Attention is currently required from: dexter.
Hello dexter,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-mgw/+/29778
to look at the new patch set (#2).
Change subject: mgcp-client: vty: Write deprecation warning using non-mgw nodes
......................................................................
mgcp-client: vty: Write deprecation warning using non-mgw nodes
Let's advise all our users to migrate to the new pooled mode, the old
VTY interface should be dropped at some point to avoid making it
overcomplex to configure MGW. There's no need to maintain the same set
of commands under 2 different places.
Change-Id: I95f717a0fcd3c4ca622e3989baa28fac1f7ec1ca
---
M src/libosmo-mgcp-client/mgcp_client_vty.c
1 file changed, 7 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/78/29778/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29778
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I95f717a0fcd3c4ca622e3989baa28fac1f7ec1ca
Gerrit-Change-Number: 29778
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: newpatchset
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29778 )
Change subject: mgcp-client: vty: Write deprecation warning using non-mgw nodes
......................................................................
mgcp-client: vty: Write deprecation warning using non-mgw nodes
Let's advise all our users to migrate to the new pooled mode, the old
VTY interface should be dropped at some point to avoid making it
overcomplex to configure MGW. There's no need to maintain the same set
of commands under 2 different places.
Change-Id: I95f717a0fcd3c4ca622e3989baa28fac1f7ec1ca
---
M src/libosmo-mgcp-client/mgcp_client_vty.c
1 file changed, 7 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/78/29778/1
diff --git a/src/libosmo-mgcp-client/mgcp_client_vty.c b/src/libosmo-mgcp-client/mgcp_client_vty.c
index da017f6..f0606d6 100644
--- a/src/libosmo-mgcp-client/mgcp_client_vty.c
+++ b/src/libosmo-mgcp-client/mgcp_client_vty.c
@@ -52,8 +52,13 @@
{
if (global_mgcp_client_pool && vty->node == global_mgcp_client_pool->vty_node->node)
return vty->index;
- else
- return global_mgcp_client_conf;
+
+ /* Global single MGCP config, deprecated: */
+ vty_out(vty, "%% MGCP commands outside of 'mgw' nodes are depreacted."
+ "You should consider reading User Manual and migrating to 'mgw' node.%s",
+ VTY_NEWLINE);
+
+ return global_mgcp_client_conf;
}
DEFUN(cfg_mgw_local_ip, cfg_mgw_local_ip_cmd,
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29778
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I95f717a0fcd3c4ca622e3989baa28fac1f7ec1ca
Gerrit-Change-Number: 29778
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newchange
Attention is currently required from: pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29772 )
Change subject: contrib/jenkins.sh: run …rebuild.sh from workspace
......................................................................
Patch Set 1:
(1 comment)
File contrib/jenkins.sh:
https://gerrit.osmocom.org/c/osmo-ci/+/29772/comment/c89a72c1_bac4a927
PS1, Line 7: clone_repo() {
> did you think about using pushd+popd?
yes. IMHO it makes it more complicated since depending if the git repository exists already or not, we would need to pushd once or twice.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29772
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I998c0d47ee5ce6f9978d1a6c9e195d5ce40e4e85
Gerrit-Change-Number: 29772
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 17 Oct 2022 14:01:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29740 )
Change subject: ansible/setup-simtest: pre-install pysim depends
......................................................................
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29740
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I1e9ddb93f05108146a219bd28cf1e9332764bf8e
Gerrit-Change-Number: 29740
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 17 Oct 2022 13:34:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29777 )
Change subject: Clear SCTP tx queue upon SCTP RESTART notification
......................................................................
Clear SCTP tx queue upon SCTP RESTART notification
Depends: libosmo-netif.git Change-Id Iecb0a4bc281647673d2930d1f1586a2df231af52
Related: SYS#6113
Change-Id: I60adf35e5b5713d38c4584615e059875dcb74bd7
---
M TODO-RELEASE
M src/osmo-hnbgw/hnbgw.c
2 files changed, 7 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/77/29777/1
diff --git a/TODO-RELEASE b/TODO-RELEASE
index d0852fc..fbce417 100644
--- a/TODO-RELEASE
+++ b/TODO-RELEASE
@@ -7,3 +7,4 @@
# If any interfaces have been added since the last public release: c:r:a + 1.
# If any interfaces have been removed or changed since the last public release: c:r:0.
#library what description / commit summary line
+libosmo-netif >1.2.0 new APIs osmo_stream_{cli,srv}_clear_tx_queue()
\ No newline at end of file
diff --git a/src/osmo-hnbgw/hnbgw.c b/src/osmo-hnbgw/hnbgw.c
index 38d33eb..ce5e5e4 100644
--- a/src/osmo-hnbgw/hnbgw.c
+++ b/src/osmo-hnbgw/hnbgw.c
@@ -269,6 +269,12 @@
case SCTP_RESTART:
LOGHNB(hnb, DMAIN, LOGL_NOTICE, "HNB SCTP conn RESTARTed, marking as HNBAP-unregistered\n");
hnb->hnb_registered = false;
+ /* The tx queue may be quite full after an SCTP RESTART: (SYS#6113)
+ * The link may have been flaky (a possible reason for the peer restarting the conn) and
+ * hence the kernel socket Tx queue may be full (no ACKs coming back) and our own userspace
+ * queue may contain plenty of oldish messages to be sent. Since the HNB will re-register after
+ * this, we simply drop all those old messages: */
+ osmo_stream_srv_clear_tx_queue(conn);
break;
}
break;
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29777
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I60adf35e5b5713d38c4584615e059875dcb74bd7
Gerrit-Change-Number: 29777
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newchange