October 2022 - gerrit-log - lists.osmocom.org

Change in libosmocore[master]: logging.h: Allocate DLM2PA and DLM2UA for libosmo-sigtran

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29766 ) Change subject: logging.h: Allocate DLM2PA and DLM2UA for libosmo-sigtran ...................................................................... logging.h: Allocate DLM2PA and DLM2UA for libosmo-sigtran Change-Id: I106b7586bfe8ee03c052b6f8b33da4c466e05abd --- M TODO-RELEASE M include/osmocom/core/logging.h 2 files changed, 5 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/TODO-RELEASE b/TODO-RELEASE index 436d417..6ac8db8 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -7,4 +7,5 @@ # If any interfaces have been added since the last public release: c:r:a + 1. # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line -libosmocore new API osmo_sockaddr_is_any() \ No newline at end of file +libosmocore new API osmo_sockaddr_is_any() +libosmocore ABI breakage OSMO_NUM_DLIB change affecting internal_cat[] diff --git a/include/osmocom/core/logging.h b/include/osmocom/core/logging.h index f1304f5..5ae38c7 100644 --- a/include/osmocom/core/logging.h +++ b/include/osmocom/core/logging.h @@ -152,7 +152,9 @@ #define DLIUUP -24 /*!< Osmocom IuUP layer */ #define DLPFCP -25 /*!< Osmocom Packet Forwarding Control Protocol */ #define DLCSN1 -26 /*!< CSN.1 (Concrete Syntax Notation 1) codec */ -#define OSMO_NUM_DLIB 26 /*!< Number of logging sub-systems in libraries */ +#define DLM2PA -27 /*!< Osmocom M2PA (libosmo-sigtran) */ +#define DLM2UA -28 /*!< Reserved for future Osmocom M2UA (libosmo-sigtran) */ +#define OSMO_NUM_DLIB 28 /*!< Number of logging sub-systems in libraries */ /* Colors that can be used in log_info_cat.color */ #define OSMO_LOGCOLOR_NORMAL NULL -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29766 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I106b7586bfe8ee03c052b6f8b33da4c466e05abd Gerrit-Change-Number: 29766 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 8 months

1
0
0 0

Change in libosmocore[master]: allocate VTY port number 4270 for osmo-isdntap

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29765 ) Change subject: allocate VTY port number 4270 for osmo-isdntap ...................................................................... allocate VTY port number 4270 for osmo-isdntap osmo-isdntap is a ISDN protocol + call tracing utility currently under development, see https://gitea.osmocom.org/retronetworking/osmo-isdntap Change-Id: I25ca4565e326ee9b0b32eeabc4a76756e2fde4ac --- M include/osmocom/vty/ports.h 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/include/osmocom/vty/ports.h b/include/osmocom/vty/ports.h index d3b1d7a..bc00128 100644 --- a/include/osmocom/vty/ports.h +++ b/include/osmocom/vty/ports.h @@ -38,6 +38,7 @@ #define OSMO_VTY_PORT_CBC 4264 #define OSMO_VTY_PORT_UECUPS 4268 #define OSMO_VTY_PORT_E1D 4269 +#define OSMO_VTY_PORT_ISDNTAP 4270 #define OSMO_VTY_PORT_SMLC 4271 /* 4272 used by control interface */ #define OSMO_VTY_PORT_HNODEB 4273 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29765 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I25ca4565e326ee9b0b32eeabc4a76756e2fde4ac Gerrit-Change-Number: 29765 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 8 months

1
0
0 0

Change in libosmocore[master]: logging.h: Allocate DLM2PA and DLM2UA for libosmo-sigtran

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29766 ) Change subject: logging.h: Allocate DLM2PA and DLM2UA for libosmo-sigtran ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29766 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I106b7586bfe8ee03c052b6f8b33da4c466e05abd Gerrit-Change-Number: 29766 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Oct 2022 12:09:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in libosmocore[master]: allocate VTY port number 4270 for osmo-isdntap

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29765 ) Change subject: allocate VTY port number 4270 for osmo-isdntap ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29765 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I25ca4565e326ee9b0b32eeabc4a76756e2fde4ac Gerrit-Change-Number: 29765 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Oct 2022 12:09:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-gsm-manuals[master]: port_numbers.adoc: Allocate VTY port number for osmo-isdntap

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/29767 ) Change subject: port_numbers.adoc: Allocate VTY port number for osmo-isdntap ...................................................................... port_numbers.adoc: Allocate VTY port number for osmo-isdntap osmo-isdntap is an ISDN protocol + call tracing utility currently under development, see https://gitea.osmocom.org/retronetworking/osmo-isdntap Change-Id: I3c5d681ba086ed7cf7fdb0408465a433000c799c --- M common/chapters/port_numbers.adoc 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/common/chapters/port_numbers.adoc b/common/chapters/port_numbers.adoc index a3198f7..16b9ce3 100644 --- a/common/chapters/port_numbers.adoc +++ b/common/chapters/port_numbers.adoc @@ -51,6 +51,7 @@ |TCP|4268|telnet (VTY)|osmo-uecups |SCTP|4268|UECUPS|osmo-uecups |TCP|4269|telnet (VTY)|osmo-e1d +|TCP|4270|telnet (VTY)|osmo-isdntap |TCP|4271|telnet (VTY)|osmo-smlc |TCP|4272|Control Interface|osmo-smlc |TCP|4273|telnet (VTY)|osmo-hnodeb -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/29767 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I3c5d681ba086ed7cf7fdb0408465a433000c799c Gerrit-Change-Number: 29767 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 8 months

1
0
0 0

Change in osmo-gsm-manuals[master]: port_numbers.adoc: Allocate VTY port number for osmo-isdntap

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/29767 ) Change subject: port_numbers.adoc: Allocate VTY port number for osmo-isdntap ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/29767 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I3c5d681ba086ed7cf7fdb0408465a433000c799c Gerrit-Change-Number: 29767 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Oct 2022 12:08:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in libsmpp34[master]: Add #define for default SMPP port 2775

by pespin

Attention is currently required from: msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libsmpp34/+/29771 ) Change subject: Add #define for default SMPP port 2775 ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libsmpp34/+/29771 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Change-Id: I2fcc15ac60b7b6501c9cb1afd0fe6d66d4b76f5f Gerrit-Change-Number: 29771 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Oct 2022 12:05:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in libosmo-netif[master]: stream: Introduce APIs osmo_stream_{cli,srv}_clear_tx_queue()

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29776 ) Change subject: stream: Introduce APIs osmo_stream_{cli,srv}_clear_tx_queue() ...................................................................... stream: Introduce APIs osmo_stream_{cli,srv}_clear_tx_queue() Related: SYS#6113 Change-Id: Iecb0a4bc281647673d2930d1f1586a2df231af52 --- M TODO-RELEASE M include/osmocom/netif/stream.h M src/stream.c 3 files changed, 22 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/76/29776/1 diff --git a/TODO-RELEASE b/TODO-RELEASE index e7fab50..5629a9c 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -9,3 +9,4 @@ #library what description / commit summary line libosmo-netif osmux new osmux_xfrm_output_* APIs libosmo-netif osmux new osmux_xfrm_input_* APIs +libosmo-netif stream new APIs osmo_stream_{cli,srv}_clear_tx_queue() \ No newline at end of file diff --git a/include/osmocom/netif/stream.h b/include/osmocom/netif/stream.h index 793e578..ce8f1d2 100644 --- a/include/osmocom/netif/stream.h +++ b/include/osmocom/netif/stream.h @@ -56,6 +56,8 @@ void osmo_stream_srv_send(struct osmo_stream_srv *conn, struct msgb *msg); int osmo_stream_srv_recv(struct osmo_stream_srv *conn, struct msgb *msg); +void osmo_stream_srv_clear_tx_queue(struct osmo_stream_srv *conn); + /*! \brief Osmocom Stream Client: Single client connection */ struct osmo_stream_cli; @@ -91,4 +93,6 @@ void osmo_stream_cli_send(struct osmo_stream_cli *cli, struct msgb *msg); int osmo_stream_cli_recv(struct osmo_stream_cli *cli, struct msgb *msg); +void osmo_stream_cli_clear_tx_queue(struct osmo_stream_cli *cli); + /*! @} */ diff --git a/src/stream.c b/src/stream.c index 12e32eb..0086588 100644 --- a/src/stream.c +++ b/src/stream.c @@ -905,6 +905,15 @@ return ret; } +void osmo_stream_cli_clear_tx_queue(struct osmo_stream_cli *cli) +{ + msgb_queue_free(&cli->tx_queue); + /* If in state 'connecting', keep WRITE flag up to receive + * socket connection signal and then transition to STATE_CONNECTED: */ + if (cli->state == STREAM_CLI_STATE_CONNECTED) + osmo_fd_write_disable(&cli->ofd); +} + /* * Server side. */ @@ -1591,4 +1600,12 @@ return ret; } +void osmo_stream_srv_clear_tx_queue(struct osmo_stream_srv *conn) +{ + msgb_queue_free(&conn->tx_queue); + osmo_fd_write_disable(&conn->ofd); + if (conn->flags & OSMO_STREAM_SRV_F_FLUSH_DESTROY) + osmo_stream_srv_destroy(conn); +} + /*! @} */ -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29776 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Iecb0a4bc281647673d2930d1f1586a2df231af52 Gerrit-Change-Number: 29776 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

Change in libosmo-netif[master]: cosmetic: stream: Fix parameter name

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29775 ) Change subject: cosmetic: stream: Fix parameter name ...................................................................... cosmetic: stream: Fix parameter name The param is already "cli" in the .c file. Change-Id: I7e1e9902a39655e57e28d38a222bca850dd7de0e --- M include/osmocom/netif/stream.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/75/29775/1 diff --git a/include/osmocom/netif/stream.h b/include/osmocom/netif/stream.h index 489fc5d..793e578 100644 --- a/include/osmocom/netif/stream.h +++ b/include/osmocom/netif/stream.h @@ -89,6 +89,6 @@ void osmo_stream_cli_close(struct osmo_stream_cli *cli); void osmo_stream_cli_send(struct osmo_stream_cli *cli, struct msgb *msg); -int osmo_stream_cli_recv(struct osmo_stream_cli *conn, struct msgb *msg); +int osmo_stream_cli_recv(struct osmo_stream_cli *cli, struct msgb *msg); /*! @} */ -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29775 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I7e1e9902a39655e57e28d38a222bca850dd7de0e Gerrit-Change-Number: 29775 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

Change in libsmpp34[master]: Add #define for default SMPP port 2775

by msuraev

msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libsmpp34/+/29771 ) Change subject: Add #define for default SMPP port 2775 ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/libsmpp34/+/29771 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Change-Id: I2fcc15ac60b7b6501c9cb1afd0fe6d66d4b76f5f Gerrit-Change-Number: 29771 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Mon, 17 Oct 2022 11:10:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

2025

2024

2023

2022

gerrit-log October 2022