October 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ci[master]: ansible/setup-simtest: pre-install pysim depends

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29740 ) Change subject: ansible/setup-simtest: pre-install pysim depends ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29740 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I1e9ddb93f05108146a219bd28cf1e9332764bf8e Gerrit-Change-Number: 29740 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Oct 2022 09:36:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-ci[master]: ansible/setup-simtest: pre-install pysim depends

by osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29740 ) Change subject: ansible/setup-simtest: pre-install pysim depends ...................................................................... Patch Set 2: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29740 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I1e9ddb93f05108146a219bd28cf1e9332764bf8e Gerrit-Change-Number: 29740 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Mon, 17 Oct 2022 09:34:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in docker-playground[master]: debian-buster-jenkins: skip llvm for arch !x86_64

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/29768 ) Change subject: debian-buster-jenkins: skip llvm for arch !x86_64 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29768 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ie5a851d8c4e808ced09b20d7478679bf1ecc1cbb Gerrit-Change-Number: 29768 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Oct 2022 09:23:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in docker-playground[master]: debian-buster-jenkins: skip llvm for arch !x86_64

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/29768 ) Change subject: debian-buster-jenkins: skip llvm for arch !x86_64 ...................................................................... debian-buster-jenkins: skip llvm for arch !x86_64 The pre-built LLVM toolchain we are downloading is built for x86_64, so this fails on other architectures. Related: OS#5260 Change-Id: Ie5a851d8c4e808ced09b20d7478679bf1ecc1cbb --- M debian-buster-jenkins/Dockerfile 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/68/29768/1 diff --git a/debian-buster-jenkins/Dockerfile b/debian-buster-jenkins/Dockerfile index 1439065..01a383e 100644 --- a/debian-buster-jenkins/Dockerfile +++ b/debian-buster-jenkins/Dockerfile @@ -128,6 +128,7 @@ xsltproc RUN set -x && \ + [ "$(arch)" = "x86_64" ] || exit 0; \ wget -q https://github.com/ARM-software/LLVM-embedded-toolchain-for-Arm/releases/do… && \ tar -xf LLVMEmbeddedToolchainForArm-${LLVM_VERSION}-linux.tar.gz && \ rm LLVMEmbeddedToolchainForArm-${LLVM_VERSION}-linux.tar.gz && \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29768 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ie5a851d8c4e808ced09b20d7478679bf1ecc1cbb Gerrit-Change-Number: 29768 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

Change in osmo-pcu[master]: Use GSM48_MT_RR_IMM_ASS instead of hardcoded 0x3f value

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/29757 ) Change subject: Use GSM48_MT_RR_IMM_ASS instead of hardcoded 0x3f value ...................................................................... Use GSM48_MT_RR_IMM_ASS instead of hardcoded 0x3f value Change-Id: Id966cbab403763d006bd5e59757c5bf57402bf9d --- M src/encoding.cpp M src/pcu_l1_if.cpp M tests/types/TypesTest.cpp 3 files changed, 7 insertions(+), 7 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved osmith: Looks good to me, but someone else must approve msuraev: Looks good to me, but someone else must approve diff --git a/src/encoding.cpp b/src/encoding.cpp index c24d187..67defec 100644 --- a/src/encoding.cpp +++ b/src/encoding.cpp @@ -447,7 +447,7 @@ bitvec_write_field(dest, &wp, 0x0, 4); // Skip Indicator bitvec_write_field(dest, &wp, 0x6, 4); // Protocol Discriminator - bitvec_write_field(dest, &wp, 0x3F, 8); // Immediate Assignment Message Type + bitvec_write_field(dest, &wp, GSM48_MT_RR_IMM_ASS, 8); // Immediate Assignment Message Type // 10.5.2.25b Dedicated mode or TBF bitvec_write_field(dest, &wp, 0x0, 1); // spare diff --git a/src/pcu_l1_if.cpp b/src/pcu_l1_if.cpp index 67e4de5..f964b78 100644 --- a/src/pcu_l1_if.cpp +++ b/src/pcu_l1_if.cpp @@ -510,7 +510,7 @@ switch (data_cnf->sapi) { case PCU_IF_SAPI_PCH: - if (data_cnf->data[2] == 0x3f) + if (data_cnf->data[2] == GSM48_MT_RR_IMM_ASS) bts_rcv_imm_ass_cnf(bts, data_cnf->data, data_cnf->fn); break; default: diff --git a/tests/types/TypesTest.cpp b/tests/types/TypesTest.cpp index c497d07..90244dd 100644 --- a/tests/types/TypesTest.cpp +++ b/tests/types/TypesTest.cpp @@ -781,7 +781,7 @@ struct gprs_rlcmac_tbf *tbf = tbf_alloc_dl_tbf(bts, ms, 0, false); static uint8_t res[] = { 0x06, - 0x3f, /* Immediate Assignment Message Type */ + 0x3f, /* Immediate Assignment Message Type (GSM48_MT_RR_IMM_ASS) */ 0x30, /* §10.5.2.26 Page Mode and §10.5.2.25b Dedicated mode/TBF */ 0x0d, 0x23, 0x6d, /* §10.5.2.25a Packet Channel Description */ /* ETSI TS 44.018 §10.5.2.30 Request Reference */ @@ -806,7 +806,7 @@ GprsMs *ms = bts_alloc_ms(bts, 1, 0); struct gprs_rlcmac_tbf *tbf = tbf_alloc_ul_tbf(bts, ms, 0, false); static uint8_t res[] = { 0x06, - 0x3f, /* Immediate Assignment Message Type */ + 0x3f, /* Immediate Assignment Message Type (GSM48_MT_RR_IMM_ASS) */ 0x10, /* §10.5.2.26 Page Mode and §10.5.2.25b Dedicated mode/TBF */ 0x0d, 0x23, 0x6d, /* §10.5.2.25a Packet Channel Description */ /* ETSI TS 44.018 §10.5.2.30 Request Reference */ @@ -824,7 +824,7 @@ void test_immediate_assign_ul0s() { static uint8_t res[] = { 0x06, - 0x3f, /* Immediate Assignment Message Type */ + 0x3f, /* Immediate Assignment Message Type (GSM48_MT_RR_IMM_ASS) */ 0x10, /* §10.5.2.26 Page Mode and §10.5.2.25b Dedicated mode/TBF */ 0x0d, 0x23, 0x6d, /* §10.5.2.25a Packet Channel Description */ /* ETSI TS 44.018 §10.5.2.30 Request Reference */ @@ -848,7 +848,7 @@ GprsMs *ms = bts_alloc_ms(bts, 1, 1); struct gprs_rlcmac_tbf *tbf = tbf_alloc_ul_tbf(bts, ms, 0, false); static uint8_t res[] = { 0x06, - 0x3f, /* Immediate Assignment Message Type */ + 0x3f, /* Immediate Assignment Message Type (GSM48_MT_RR_IMM_ASS) */ 0x10, /* §10.5.2.26 Page Mode and §10.5.2.25b Dedicated mode/TBF */ 0x0d, 0x23, 0x6d, /* §10.5.2.25a Packet Channel Description */ /* ETSI TS 44.018 §10.5.2.30 Request Reference */ @@ -866,7 +866,7 @@ void test_immediate_assign_ul1m() { static uint8_t res[] = { 0x06, - 0x3f, /* Immediate Assignment Message Type */ + 0x3f, /* Immediate Assignment Message Type (GSM48_MT_RR_IMM_ASS) */ 0x10, /* §10.5.2.26 Page Mode and §10.5.2.25b Dedicated mode/TBF */ 0x0d, 0x23, 0x6d, /* §10.5.2.25a Packet Channel Description */ /* ETSI TS 44.018 §10.5.2.30 Request Reference */ 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/29757 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Id966cbab403763d006bd5e59757c5bf57402bf9d Gerrit-Change-Number: 29757 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 8 months

1
0
0 0

Change in osmo-pcu[master]: Clarify use RR imm_ass msg fields

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/29759 ) Change subject: Clarify use RR imm_ass msg fields ...................................................................... Clarify use RR imm_ass msg fields Change-Id: I814c7d4c1bce3f56852cfb1c7aa69b41588cb245 --- M src/bts.cpp 1 file changed, 7 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved msuraev: Looks good to me, but someone else must approve diff --git a/src/bts.cpp b/src/bts.cpp index 06948d8..646dc76 100644 --- a/src/bts.cpp +++ b/src/bts.cpp @@ -667,12 +667,17 @@ int bts_rcv_imm_ass_cnf(struct gprs_rlcmac_bts *bts, const uint8_t *data, uint32_t fn) { struct gprs_rlcmac_dl_tbf *dl_tbf = NULL; + const struct gsm48_imm_ass *imm_ass = (struct gsm48_imm_ass *)data; uint8_t plen; uint32_t tlli; GprsMs *ms; - /* move to IA Rest Octets */ - plen = data[0] >> 2; + /* Move to IA Rest Octets: TS 44.018 9.1.18 "The L2 pseudo length of + * this message is the sum of lengths of all information elements + * present in the message except the IA Rest Octets and L2 Pseudo Length + * information elements." */ + /* TS 44.018 10.5.2.19 l2_plen byte lowest 2 bits are '01'B */ + plen = imm_ass->l2_plen >> 2; data += 1 + plen; if ((*data & 0xf0) != 0xd0) { 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/29759 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I814c7d4c1bce3f56852cfb1c7aa69b41588cb245 Gerrit-Change-Number: 29759 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 8 months

1
0
0 0

Change in osmo-pcu[master]: cosmetic: Add missing spacing between params

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/29755 ) Change subject: cosmetic: Add missing spacing between params ...................................................................... cosmetic: Add missing spacing between params Change-Id: I45666ed52d15871b83aaca1d7cb3e521800751c2 --- M src/encoding.cpp 1 file changed, 13 insertions(+), 13 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/src/encoding.cpp b/src/encoding.cpp index f552111..c24d187 100644 --- a/src/encoding.cpp +++ b/src/encoding.cpp @@ -445,17 +445,17 @@ int plen; int rc; - bitvec_write_field(dest, &wp,0x0,4); // Skip Indicator - bitvec_write_field(dest, &wp,0x6,4); // Protocol Discriminator - bitvec_write_field(dest, &wp,0x3F,8); // Immediate Assignment Message Type + bitvec_write_field(dest, &wp, 0x0, 4); // Skip Indicator + bitvec_write_field(dest, &wp, 0x6, 4); // Protocol Discriminator + bitvec_write_field(dest, &wp, 0x3F, 8); // Immediate Assignment Message Type // 10.5.2.25b Dedicated mode or TBF - bitvec_write_field(dest, &wp,0x0,1); // spare - bitvec_write_field(dest, &wp,0x0,1); // TMA : Two-message assignment: No meaning - bitvec_write_field(dest, &wp,downlink,1); // Downlink : Downlink assignment to mobile in packet idle mode - bitvec_write_field(dest, &wp,0x1,1); // T/D : TBF or dedicated mode: this message assigns a Temporary Block Flow (TBF). + bitvec_write_field(dest, &wp, 0x0, 1); // spare + bitvec_write_field(dest, &wp, 0x0, 1); // TMA : Two-message assignment: No meaning + bitvec_write_field(dest, &wp, downlink, 1); // Downlink : Downlink assignment to mobile in packet idle mode + bitvec_write_field(dest, &wp, 0x1, 1); // T/D : TBF or dedicated mode: this message assigns a Temporary Block Flow (TBF). - bitvec_write_field(dest, &wp,0x0,4); // Page Mode + bitvec_write_field(dest, &wp, 0x0, 4); // Page Mode // GSM 04.08 10.5.2.25a Packet Channel Description bitvec_write_field(dest, &wp, 0x01, 5); // Channel type @@ -480,13 +480,13 @@ bitvec_write_field(dest, &wp, ra, 8); /* RACH value */ } - bitvec_write_field(dest, &wp,(ref_fn / (26 * 51)) % 32,5); // T1' - bitvec_write_field(dest, &wp,ref_fn % 51,6); // T3 - bitvec_write_field(dest, &wp,ref_fn % 26,5); // T2 + bitvec_write_field(dest, &wp, (ref_fn / (26 * 51)) % 32, 5); // T1' + bitvec_write_field(dest, &wp, ref_fn % 51, 6); // T3 + bitvec_write_field(dest, &wp, ref_fn % 26, 5); // T2 // 10.5.2.40 Timing Advance - bitvec_write_field(dest, &wp,0x0,2); // spare - bitvec_write_field(dest, &wp,ta,6); // Timing Advance value + bitvec_write_field(dest, &wp, 0x0, 2); // spare + bitvec_write_field(dest, &wp, ta, 6); // Timing Advance value /* 10.5.2.21 Mobile Allocation */ if (pdch->fh.enabled) { -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/29755 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I45666ed52d15871b83aaca1d7cb3e521800751c2 Gerrit-Change-Number: 29755 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 8 months

1
0
0 0

Change in osmo-gsm-manuals[master]: port_numbers.adoc: Allocate VTY port number for osmo-isdntap

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/29767 ) Change subject: port_numbers.adoc: Allocate VTY port number for osmo-isdntap ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/29767 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I3c5d681ba086ed7cf7fdb0408465a433000c799c Gerrit-Change-Number: 29767 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 17 Oct 2022 09:03:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in libosmocore[master]: logging.h: Allocate DLM2PA and DLM2UA for libosmo-sigtran

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29766 ) Change subject: logging.h: Allocate DLM2PA and DLM2UA for libosmo-sigtran ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29766 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I106b7586bfe8ee03c052b6f8b33da4c466e05abd Gerrit-Change-Number: 29766 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 17 Oct 2022 09:03:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in libosmocore[master]: allocate VTY port number 4270 for osmo-isdntap

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29765 ) Change subject: allocate VTY port number 4270 for osmo-isdntap ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29765 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I25ca4565e326ee9b0b32eeabc4a76756e2fde4ac Gerrit-Change-Number: 29765 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 17 Oct 2022 09:02:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

2025

2024

2023

2022

gerrit-log October 2022