Attention is currently required from: fixeria, msuraev.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29761 )
Change subject: msgb: introduce realloc functions
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
Patchset:
PS2:
I think the main point of a realloc API is to avoid allocating a new chunk and having to copy over all the memory in the old chunk unless it's really unneeded.
So I think msgb_copy() should be kept as it was, and msgb_realloc in any case implemented with "man realloc" API.
The API you are proposing there is more actually "msgb_copy_new_length()" or something similar, not a realloc function.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29761
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I36d4c16241d19f0f73c325be4d0e0bdef6813615
Gerrit-Change-Number: 29761
Gerrit-PatchSet: 2
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 17 Oct 2022 09:01:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o…
Package network:osmocom:nightly/osmo-sgsn failed to build in Raspbian_10/armv7l
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-sgsn
Last lines of build log:
[ 929s] [464/484] installing python-apt-1.8.4.3
[ 930s] [465/484] installing graphviz-2.40.1-6+deb10u1
[ 931s] [466/484] installing adwaita-icon-theme-3.30.1-1
[ 945s] update-alternatives: using /usr/share/icons/Adwaita/cursor.theme to provide /usr/share/icons/default/index.theme (x-cursor-theme) in auto mode
[ 945s] [467/484] installing texlive-bibtex-extra-2018.20190227-2
[ 977s] [468/484] installing texlive-latex-recommended-2018.20190227-2
[ 986s] [469/484] installing tipa-2:1.3-20
[ 988s] Regenerating '/var/lib/texmf/fmtutil.cnf-DEBIAN'... done.
[ 988s] Regenerating '/var/lib/texmf/fmtutil.cnf-TEXLIVEDIST'... done.
[ 988s] update-fmtutil has updated the following file(s):
[ 988s] /var/lib/texmf/fmtutil.cnf-DEBIAN
[ 988s] /var/lib/texmf/fmtutil.cnf-TEXLIVEDIST
[ 988s] If you want to activate the changes in the above file(s),
[ 988s] you should run fmtutil-sys or fmtutil.
[ 988s] [470/484] installing texlive-extra-utils-2018.20190227-2
[ 1000s] dpkg-deb (subprocess): decompressing archive member: lzma error: compressed data is corrupt
[ 1000s] dpkg-deb: error: <decompress> subprocess returned error exit status 2
[ 1000s] dpkg: error processing archive .init_b_cache/texlive-extra-utils.deb (--install):
[ 1000s] cannot copy extracted data for './usr/share/texlive/texmf-dist/scripts/latex2nemeth/latex2nemeth-v1.0.1.jar' to '/usr/share/texlive/texmf-dist/scripts/latex2nemeth/latex2nemeth-v1.0.1.jar.dpkg-new': unexpected end of file or stream
[ 1000s] Errors were encountered while processing:
[ 1000s] .init_b_cache/texlive-extra-utils.deb
[ 1000s] exit ...
[ 1000s] ### VM INTERACTION START ###
[ 1002s] [ 786.408530] sysrq: SysRq : Power Off
[ 1002s] [ 786.410330] reboot: Power down
[ 1002s] ### VM INTERACTION END ###
[ 1002s]
[ 1002s] armbuild02 failed "build osmo-sgsn_1.9.0.9.b4349.202210170053.dsc" at Mon Oct 17 04:41:12 UTC 2022.
[ 1002s]
--
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)
Attention is currently required from: osmith, neels, dexter.
Hello osmith, Jenkins Builder, neels, laforge, fixeria, dexter,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-bsc/+/29751
to look at the new patch set (#5).
Change subject: Introduce support for MGW-pinning per BTS
......................................................................
Introduce support for MGW-pinning per BTS
This feature allows pinning each BTS to a specific MGW from the
configured pool. The pinning can be soft or hard (strict). If strict
pinning is not set, the configured MGW is selected with priority, but
other MGWs can still be selected during each call setup if the
preferred MGW is found not available at that time, hence avoiding denial
of service for the entire BTS if that MGW goes down.
If strict mode is selected, the call will be refused if the configured
preferred MGW is not available at the time the call is set up.
It is useful to use this feature when Osmux is configured between
the BTS and the BSC and an MGW pool is in use. This way the BSC is
capable of grouping all the calls of a BTS towards one MGW, hence taking
advantage of the Osmux trunking optimizations to reduce link data usage
(AMR payload of several concurrent calls ending up sharing the same
underlaying UPD packet).
Furthermore, this allows the operator to intelligently spread load over
the MGW pool in order to avoid ending up with more than 256 concurrent
Osmux circuits on any of the co-located MGWs in the pool (maximum supported
at the moment).
Related: SYS#5987
Depends: osmo-mgw.git 5d8b5b093595e1203e288c3175c163c0994b1102
Change-Id: I9a7a5af72795faed0d12d9d73b59951b6a0e9c7d
---
M TODO-RELEASE
M doc/manuals/chapters/mgwpool.adoc
M include/osmocom/bsc/bts.h
M src/osmo-bsc/bsc_subscr_conn_fsm.c
M src/osmo-bsc/bts.c
M src/osmo-bsc/bts_vty.c
6 files changed, 153 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/51/29751/5
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29751
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I9a7a5af72795faed0d12d9d73b59951b6a0e9c7d
Gerrit-Change-Number: 29751
Gerrit-PatchSet: 5
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: newpatchset