October 2022 - gerrit-log - lists.osmocom.org

Change in osmocom-bb[master]: mobile: check return value of gsm_arfcn2band_rc()

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/29660 ) Change subject: mobile: check return value of gsm_arfcn2band_rc() ...................................................................... mobile: check return value of gsm_arfcn2band_rc() Change-Id: Ia5bc9f8bf4aa3ea7374c67e329db22612bb350ca Fixes: CID#282374, CID#282375, CID#282376 --- M src/host/layer23/src/mobile/gsm322.c M src/host/layer23/src/mobile/gsm48_rr.c 2 files changed, 13 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve msuraev: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/host/layer23/src/mobile/gsm322.c b/src/host/layer23/src/mobile/gsm322.c index ea760b5..d288596 100644 --- a/src/host/layer23/src/mobile/gsm322.c +++ b/src/host/layer23/src/mobile/gsm322.c @@ -4203,7 +4203,10 @@ nb->prio_low = 1; /* get C1 & C2 */ - gsm_arfcn2band_rc(nb->arfcn, &band); + if (gsm_arfcn2band_rc(nb->arfcn, &band) != 0) { + LOGP(DNB, LOGL_ERROR, "gsm_arfcn2band_rc() failed\n"); + goto cont; + } class = class_of_band(ms, band); nb->c1 = calculate_c1(DNB, nb->rla_c_dbm, s->rxlev_acc_min_db, ms_pwr_dbm(band, s->ms_txpwr_max_cch), @@ -4703,7 +4706,11 @@ enum gsm_band band; int class; - gsm_arfcn2band_rc(cs->arfcn, &band); + if (gsm_arfcn2band_rc(cs->arfcn, &band) != 0) { + LOGP(DNB, LOGL_ERROR, "gsm_arfcn2band_rc() failed\n"); + return -EINVAL; + } + class = class_of_band(cs->ms, band); /* calculate the RAL_C of serving cell */ diff --git a/src/host/layer23/src/mobile/gsm48_rr.c b/src/host/layer23/src/mobile/gsm48_rr.c index 48c70f1..be9a7e1 100644 --- a/src/host/layer23/src/mobile/gsm48_rr.c +++ b/src/host/layer23/src/mobile/gsm48_rr.c @@ -1516,7 +1516,10 @@ uint8_t tx_power; enum gsm_band band; - gsm_arfcn2band_rc(cs->arfcn, &band); + if (gsm_arfcn2band_rc(cs->arfcn, &band) != 0) { + LOGP(DRR, LOGL_ERROR, "gsm_arfcn2band_rc() failed\n"); + return -EINVAL; + } /* already assigned */ if (rr->wait_assign == 2) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/29660 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia5bc9f8bf4aa3ea7374c67e329db22612bb350ca Gerrit-Change-Number: 29660 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 8 months

1
0
0 0

Change in osmocom-bb[master]: mobile: check return value of gsm_arfcn2band_rc()

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/29660 ) Change subject: mobile: check return value of gsm_arfcn2band_rc() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/29660 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia5bc9f8bf4aa3ea7374c67e329db22612bb350ca Gerrit-Change-Number: 29660 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 15 Oct 2022 06:40:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-pcu[master]: Clarify use RR imm_ass msg fields

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/29759 ) Change subject: Clarify use RR imm_ass msg fields ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/29759 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I814c7d4c1bce3f56852cfb1c7aa69b41588cb245 Gerrit-Change-Number: 29759 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 15 Oct 2022 06:39:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-pcu[master]: Use GSM48_MT_RR_IMM_ASS instead of hardcoded 0x3f value

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/29757 ) Change subject: Use GSM48_MT_RR_IMM_ASS instead of hardcoded 0x3f value ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/29757 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Id966cbab403763d006bd5e59757c5bf57402bf9d Gerrit-Change-Number: 29757 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 15 Oct 2022 06:39:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-pcu[master]: cosmetic: Add missing spacing between params

by fixeria

Attention is currently required from: pespin, msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/29755 ) Change subject: cosmetic: Add missing spacing between params ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File src/encoding.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/29755/comment/8bd3ea49_6eccbf4f PS1, Line 483: bitvec_write_field(dest, &wp,(ref_fn / (26 * 51)) % 32, 5); // T1' > Why not add space aftr &wp while at it? Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/29755 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I45666ed52d15871b83aaca1d7cb3e521800751c2 Gerrit-Change-Number: 29755 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Sat, 15 Oct 2022 06:38:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Build failure of network:osmocom:nightly/osmo-cbc in Raspbian_11/armv7l

by OBS Notification

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o… Package network:osmocom:nightly/osmo-cbc failed to build in Raspbian_11/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-cbc Last lines of build log: [ 547s] Processing triggers for libgdk-pixbuf-2.0-0:armhf (2.42.2+dfsg-1+deb11u1) ... [ 547s] Processing triggers for mailcap (3.69) ... [ 547s] Processing triggers for fontconfig (2.13.1-4.2) ... [ 547s] Errors were encountered while processing: [ 547s] tex-common [ 547s] first configure attempt failed, trying again... [ 547s] Setting up tex-common (6.16) ... [ 548s] Running mktexlsr. This may take some time... done. [ 551s] Running updmap-sys. This may take some time... done. [ 551s] Running mktexlsr /var/lib/texmf ... done. [ 551s] Building format(s) --all. [ 649s] This may take some time... [ 649s] fmtutil failed. Output has been stored in [ 649s] /tmp/fmtutil.XlaKWjHA [ 649s] Please include this file if you report a bug. [ 649s] [ 649s] dpkg: error processing package tex-common (--configure): [ 649s] installed tex-common package post-installation script subprocess returned error exit status 1 [ 649s] Errors were encountered while processing: [ 649s] tex-common [ 649s] ### VM INTERACTION START ### [ 649s] Failed to write wtmp record, ignoring: Read-only file system [ 649s] Failed to write utmp record: Read-only file system [ 649s] Powering off. [ 649s] [ 607.172164] reboot: Power down [ 650s] ### VM INTERACTION END ### [ 650s] [ 650s] armbuild02 failed "build osmo-cbc_0.4.0.4.6e64.202210150053.dsc" at Sat Oct 15 02:32:03 UTC 2022. [ 650s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)

2 years, 8 months

1
0
0 0

Change in osmo-pcu[master]: cosmetic: Add missing spacing between params

by pespin

Attention is currently required from: pespin. Hello osmith, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/29755 to look at the new patch set (#2). Change subject: cosmetic: Add missing spacing between params ...................................................................... cosmetic: Add missing spacing between params Change-Id: I45666ed52d15871b83aaca1d7cb3e521800751c2 --- M src/encoding.cpp 1 file changed, 13 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/55/29755/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/29755 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I45666ed52d15871b83aaca1d7cb3e521800751c2 Gerrit-Change-Number: 29755 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 8 months

1
0
0 0

Change in osmocom-bb[master]: mobile: check return value of gsm_arfcn2band_rc()

by msuraev

Attention is currently required from: fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/29660 ) Change subject: mobile: check return value of gsm_arfcn2band_rc() ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/host/layer23/src/mobile/gsm322.c: https://gerrit.osmocom.org/c/osmocom-bb/+/29660/comment/9373d952_b670b7ee PS1, Line 4206: if (gsm_arfcn2band_rc(nb->arfcn, &band) != 0) { I think we usually check those as (.. < 0) since negative return indicates error. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/29660 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia5bc9f8bf4aa3ea7374c67e329db22612bb350ca Gerrit-Change-Number: 29660 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Oct 2022 20:13:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-bsc[master]: abis_rsl: show full request reference in log

by fixeria

Attention is currently required from: pespin, lynxis lazus, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29703 ) Change subject: abis_rsl: show full request reference in log ...................................................................... Patch Set 3: (1 comment) File src/osmo-bsc/abis_rsl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29703/comment/75841b8b_f8dc2473 PS1, Line 1915: LOG_BTS(bts, DRSL, LOGL_INFO, "CHAN RQD: reason: %s (ra=0x%02x, t1=%d, t3=%d, t2=%d, neci=0x%02x, chreq_reason=0x%02x)\n", > ... wireshark won't always do the conversion Time to improve Wireshark! https://gitlab.com/wireshark/wireshark/-/merge_requests/8519 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29703 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I78499b49ae176b736e384e193fadc0bdd669dffa Gerrit-Change-Number: 29703 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Oct 2022 20:07:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-pcu[master]: cosmetic: Add missing spacing between params

by msuraev

Attention is currently required from: pespin. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/29755 ) Change subject: cosmetic: Add missing spacing between params ...................................................................... Patch Set 1: (1 comment) File src/encoding.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/29755/comment/ae9d2eca_326be88a PS1, Line 483: bitvec_write_field(dest, &wp,(ref_fn / (26 * 51)) % 32, 5); // T1' Why not add space aftr &wp while at it? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/29755 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I45666ed52d15871b83aaca1d7cb3e521800751c2 Gerrit-Change-Number: 29755 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Oct 2022 20:06:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

2025

2024

2023

2022

gerrit-log October 2022