October 2022 - gerrit-log - lists.osmocom.org

Change in libosmocore[master]: msgb: expand copy test

by pespin

Attention is currently required from: msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29760 ) Change subject: msgb: expand copy test ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29760 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I695c40e9350f608049111e81907fa6a5f48bb199 Gerrit-Change-Number: 29760 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Oct 2022 10:24:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in libosmocore[master]: msgb: introduce extended copy functions

by pespin

Attention is currently required from: fixeria, msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29761 ) Change subject: msgb: introduce extended copy functions ...................................................................... Patch Set 3: (1 comment) File include/osmocom/core/msgb.h: https://gerrit.osmocom.org/c/libosmocore/+/29761/comment/103eb02d_b8a14f73 PS3, Line 73: extern struct msgb *msgb_copy_ext(const struct msgb *msg, uint16_t new_len, const char *name); what about msgb_copy_resize()? looks more descriptive. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29761 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I36d4c16241d19f0f73c325be4d0e0bdef6813615 Gerrit-Change-Number: 29761 Gerrit-PatchSet: 3 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Oct 2022 10:24:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in libosmo-netif[master]: stream: Improve logging of SCTP_PEER_ADDR_CHANGE notification

by Jenkins Builder

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29769 ) Change subject: stream: Improve logging of SCTP_PEER_ADDR_CHANGE notification ...................................................................... Patch Set 1: (1 comment) File src/sctp.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-198): https://gerrit.osmocom.org/c/libosmo-netif/+/29769/comment/6f7cb4cf_c4301680 PS1, Line 51: }; adding a line without newline at end of file -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29769 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ieebc6e623874b4770ec7cd8b934244ffecaa089d Gerrit-Change-Number: 29769 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Mon, 17 Oct 2022 10:23:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in libosmo-netif[master]: stream: Improve logging of SCTP_PEER_ADDR_CHANGE notification

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29769 ) Change subject: stream: Improve logging of SCTP_PEER_ADDR_CHANGE notification ...................................................................... stream: Improve logging of SCTP_PEER_ADDR_CHANGE notification Related: SYS#6113 Change-Id: Ieebc6e623874b4770ec7cd8b934244ffecaa089d --- M include/osmocom/netif/sctp.h M src/sctp.c M src/stream.c 3 files changed, 45 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/69/29769/1 diff --git a/include/osmocom/netif/sctp.h b/include/osmocom/netif/sctp.h index 2b2e072..0b64824 100644 --- a/include/osmocom/netif/sctp.h +++ b/include/osmocom/netif/sctp.h @@ -7,7 +7,17 @@ static inline const char *osmo_sctp_assoc_chg_str(enum sctp_sac_state val) { return get_value_string(osmo_sctp_assoc_chg_strs, val); } +enum sctp_spc_state; +extern const struct value_string osmo_sctp_paddr_chg_strs[]; +static inline const char *osmo_sctp_paddr_chg_str(enum sctp_spc_state val) +{ return get_value_string(osmo_sctp_paddr_chg_strs, val); } + enum sctp_sn_type; extern const struct value_string osmo_sctp_sn_type_strs[]; static inline const char *osmo_sctp_sn_type_str(enum sctp_sn_type val) { return get_value_string(osmo_sctp_sn_type_strs, val); } + +enum sctp_sn_error; +extern const struct value_string osmo_sctp_sn_error_strs[]; +static inline const char *osmo_sctp_sn_error_str(enum sctp_sn_error val) +{ return get_value_string(osmo_sctp_sn_error_strs, val); } diff --git a/src/sctp.c b/src/sctp.c index c24e0f7..5441fe1 100644 --- a/src/sctp.c +++ b/src/sctp.c @@ -10,6 +10,17 @@ { 0, NULL } }; +const struct value_string osmo_sctp_paddr_chg_strs[] = { + { SCTP_ADDR_AVAILABLE, "ADDR_AVAILABLE" }, + { SCTP_ADDR_UNREACHABLE, "ADDR_UNREACHABLE" }, + { SCTP_ADDR_REMOVED, "ADDR_REMOVED" }, + { SCTP_ADDR_ADDED, "ADDR_ADDED" }, + { SCTP_ADDR_MADE_PRIM, "ADDR_MADE_PRIM" }, + { SCTP_ADDR_CONFIRMED, "ADDR_CONFIRMED" }, + { SCTP_ADDR_POTENTIALLY_FAILED, "ADDR_POTENTIALLY_FAILED" }, + { 0, NULL } +}; + const struct value_string osmo_sctp_sn_type_strs[] = { { SCTP_ASSOC_CHANGE, "ASSOC_CHANGE" }, { SCTP_PEER_ADDR_CHANGE, "PEER_ADDR_CHANGE" }, @@ -26,3 +37,15 @@ #endif { 0, NULL } }; + + +const struct value_string osmo_sctp_sn_error_strs[] = { + { SCTP_FAILED_THRESHOLD, "FAILED_THRESHOLD" }, + { SCTP_RECEIVED_SACK, "RECEIVED_SACK" }, + { SCTP_HEARTBEAT_SUCCESS, "HEARTBEAT_SUCCESS" }, + { SCTP_RESPONSE_TO_USER_REQ, "RESPONSE_TO_USER_REQ" }, + { SCTP_INTERNAL_ERROR, "INTERNAL_ERROR" }, + { SCTP_SHUTDOWN_GUARD_EXPIRES, "SHUTDOWN_GUARD_EXPIRES" }, + { SCTP_PEER_FAULTY, "PEER_FAULTY" }, + { 0, NULL } +}; \ No newline at end of file diff --git a/src/stream.c b/src/stream.c index 7b41ce1..12e32eb 100644 --- a/src/stream.c +++ b/src/stream.c @@ -49,6 +49,8 @@ #include <netinet/sctp.h> #endif +#include <osmocom/netif/sctp.h> + #define LOGSCLI(cli, level, fmt, args...) \ LOGP(DLINP, level, "[%s] %s(): " fmt, get_value_string(stream_cli_state_names, (cli)->state), __func__, ## args) @@ -1508,7 +1510,16 @@ LOGP(DLINP, LOGL_DEBUG, "===> SEND FAILED\n"); break; case SCTP_PEER_ADDR_CHANGE: - LOGP(DLINP, LOGL_DEBUG, "===> PEER ADDR CHANGE\n"); + { + char addr_str[INET6_ADDRSTRLEN + 10]; + struct sockaddr_storage sa = notif->sn_paddr_change.spc_aaddr; + osmo_sockaddr_to_str_buf(addr_str, sizeof(addr_str), + (const struct osmo_sockaddr *)&sa); + LOGP(DLINP, LOGL_DEBUG, "===> PEER ADDR CHANGE: %s %s err=%s\n", + addr_str, osmo_sctp_paddr_chg_str(notif->sn_paddr_change.spc_state), + (notif->sn_paddr_change.spc_state == SCTP_ADDR_UNREACHABLE) ? + osmo_sctp_sn_error_str(notif->sn_paddr_change.spc_error) : "None"); + } break; case SCTP_SHUTDOWN_EVENT: LOGP(DLINP, LOGL_DEBUG, "===> SHUTDOWN EVT\n"); -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29769 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ieebc6e623874b4770ec7cd8b934244ffecaa089d Gerrit-Change-Number: 29769 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

Change in libosmocore[master]: msgb: expand copy test

by msuraev

Attention is currently required from: pespin. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29760 ) Change subject: msgb: expand copy test ...................................................................... Patch Set 2: (1 comment) File tests/msgb/msgb_test.c: https://gerrit.osmocom.org/c/libosmocore/+/29760/comment/c2512f28_62d187bb PS1, Line 164: OSMO_ASSERT(msg->tail - msg->l4h == msg2->tail - msg2->l4h); > Perhaps it wasn't there when the test was written? Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29760 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I695c40e9350f608049111e81907fa6a5f48bb199 Gerrit-Change-Number: 29760 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Oct 2022 10:10:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in libosmocore[master]: msgb: expand copy test

by msuraev

Attention is currently required from: pespin. Hello Jenkins Builder, pespin, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/29760 to look at the new patch set (#2). Change subject: msgb: expand copy test ...................................................................... msgb: expand copy test * use proper Lx comparison functions * use msgb_l4len() * check test invariant * print destination properly Change-Id: I695c40e9350f608049111e81907fa6a5f48bb199 --- M tests/msgb/msgb_test.c 1 file changed, 16 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/60/29760/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29760 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I695c40e9350f608049111e81907fa6a5f48bb199 Gerrit-Change-Number: 29760 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 8 months

1
0
0 0

Change in libosmocore[master]: msgb: introduce extended copy functions

by msuraev

Attention is currently required from: fixeria, msuraev. Hello Jenkins Builder, pespin, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/29761 to look at the new patch set (#3). Change subject: msgb: introduce extended copy functions ...................................................................... msgb: introduce extended copy functions Those are similar to existing *msgb_alloc*() functions but allows to change the size of destination msgb provided it fits the data from source msgb. Change-Id: I36d4c16241d19f0f73c325be4d0e0bdef6813615 --- M include/osmocom/core/msgb.h M src/msgb.c 2 files changed, 46 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/61/29761/3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29761 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I36d4c16241d19f0f73c325be4d0e0bdef6813615 Gerrit-Change-Number: 29761 Gerrit-PatchSet: 3 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 8 months

1
0
0 0

Change in libosmocore[master]: msgb: expand copy test

by msuraev

Attention is currently required from: pespin. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29760 ) Change subject: msgb: expand copy test ...................................................................... Patch Set 1: (1 comment) File tests/msgb/msgb_test.c: https://gerrit.osmocom.org/c/libosmocore/+/29760/comment/f82b0113_0394ecd3 PS1, Line 164: OSMO_ASSERT(msg->tail - msg->l4h == msg2->tail - msg2->l4h); > we don't have msgb_l4len()? Perhaps it wasn't there when the test was written? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29760 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I695c40e9350f608049111e81907fa6a5f48bb199 Gerrit-Change-Number: 29760 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Oct 2022 10:08:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in docker-playground[master]: debian-buster-jenkins: skip llvm for arch !x86_64

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/29768 ) Change subject: debian-buster-jenkins: skip llvm for arch !x86_64 ...................................................................... debian-buster-jenkins: skip llvm for arch !x86_64 The pre-built LLVM toolchain we are downloading is built for x86_64, so this fails on other architectures. Related: OS#5260 Change-Id: Ie5a851d8c4e808ced09b20d7478679bf1ecc1cbb --- M debian-buster-jenkins/Dockerfile 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/debian-buster-jenkins/Dockerfile b/debian-buster-jenkins/Dockerfile index 1439065..01a383e 100644 --- a/debian-buster-jenkins/Dockerfile +++ b/debian-buster-jenkins/Dockerfile @@ -128,6 +128,7 @@ xsltproc RUN set -x && \ + [ "$(arch)" = "x86_64" ] || exit 0; \ wget -q https://github.com/ARM-software/LLVM-embedded-toolchain-for-Arm/releases/do… && \ tar -xf LLVMEmbeddedToolchainForArm-${LLVM_VERSION}-linux.tar.gz && \ rm LLVMEmbeddedToolchainForArm-${LLVM_VERSION}-linux.tar.gz && \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29768 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ie5a851d8c4e808ced09b20d7478679bf1ecc1cbb Gerrit-Change-Number: 29768 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 8 months

1
0
0 0

Change in docker-playground[master]: debian-buster-jenkins: skip llvm for arch !x86_64

by osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/29768 ) Change subject: debian-buster-jenkins: skip llvm for arch !x86_64 ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: this is trivial and fixes a failing jenkins job, merging now -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29768 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ie5a851d8c4e808ced09b20d7478679bf1ecc1cbb Gerrit-Change-Number: 29768 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Oct 2022 09:36:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

2025

2024

2023

2022

gerrit-log October 2022