October 2022 - gerrit-log - lists.osmocom.org

Change in libsmpp34[master]: cosmetic: make linter happy

by pespin

Attention is currently required from: msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libsmpp34/+/29770 ) Change subject: cosmetic: make linter happy ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libsmpp34/+/29770 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Change-Id: I772e6d7db38d830dfbee651bcd6e8ed24f07ca0b Gerrit-Change-Number: 29770 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Oct 2022 11:10:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in libsmpp34[master]: cosmetic: make linter happy

by msuraev

Attention is currently required from: msuraev. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libsmpp34/+/29770 ) Change subject: cosmetic: make linter happy ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/libsmpp34/+/29770 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Change-Id: I772e6d7db38d830dfbee651bcd6e8ed24f07ca0b Gerrit-Change-Number: 29770 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Oct 2022 11:09:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in libosmo-netif[master]: stream: Improve logging of SCTP_PEER_ADDR_CHANGE notification

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29769 ) Change subject: stream: Improve logging of SCTP_PEER_ADDR_CHANGE notification ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29769 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ieebc6e623874b4770ec7cd8b934244ffecaa089d Gerrit-Change-Number: 29769 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Oct 2022 11:02:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-ci[master]: jobs/update-osmo-ci-on-slaves: set wipe-workspace

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29773 ) Change subject: jobs/update-osmo-ci-on-slaves: set wipe-workspace ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29773 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I5626c4728ebd7f6b693484c7801963985832398d Gerrit-Change-Number: 29773 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Oct 2022 11:01:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-ci[master]: contrib/jenkins.sh: run …rebuild.sh from workspace

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29772 ) Change subject: contrib/jenkins.sh: run …rebuild.sh from workspace ...................................................................... Patch Set 1: (1 comment) File contrib/jenkins.sh: https://gerrit.osmocom.org/c/osmo-ci/+/29772/comment/072d65b5_ecaccadb PS1, Line 7: clone_repo() { did you think about using pushd+popd? -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29772 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I998c0d47ee5ce6f9978d1a6c9e195d5ce40e4e85 Gerrit-Change-Number: 29772 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Oct 2022 11:01:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-ci[master]: contrib/jenkins.sh: run …rebuild.sh from workspace

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29772 ) Change subject: contrib/jenkins.sh: run …rebuild.sh from workspace ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29772 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I998c0d47ee5ce6f9978d1a6c9e195d5ce40e4e85 Gerrit-Change-Number: 29772 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Oct 2022 11:00:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-ci[master]: jobs/update-osmo-ci-on-slaves: set wipe-workspace

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/29773 ) Change subject: jobs/update-osmo-ci-on-slaves: set wipe-workspace ...................................................................... jobs/update-osmo-ci-on-slaves: set wipe-workspace Wipe the workspace before running the job, so the _docker_playground clone gets recreated (and e.g. doesn't have the old clone url). Change-Id: I5626c4728ebd7f6b693484c7801963985832398d --- M jobs/update-osmo-ci-on-slaves.yml 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/73/29773/1 diff --git a/jobs/update-osmo-ci-on-slaves.yml b/jobs/update-osmo-ci-on-slaves.yml index 41181cd..39afb46 100644 --- a/jobs/update-osmo-ci-on-slaves.yml +++ b/jobs/update-osmo-ci-on-slaves.yml @@ -30,6 +30,7 @@ skip-tag: true branches: - 'origin/master' + wipe-workspace: true triggers: - pollscm: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29773 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I5626c4728ebd7f6b693484c7801963985832398d Gerrit-Change-Number: 29773 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

Change in osmo-ci[master]: contrib/jenkins.sh: set-url for existing clones

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/29774 ) Change subject: contrib/jenkins.sh: set-url for existing clones ...................................................................... contrib/jenkins.sh: set-url for existing clones Make sure that the recent change from git.osmocom.org -> gerrit.osmocom.org for git clone urls is applied to the existing clones as well. Change-Id: I3d9c193bf353ecff0ee8bb4c507de59139fc0925 --- M contrib/jenkins.sh 1 file changed, 12 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/74/29774/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 6512af9..96becc7 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -5,7 +5,18 @@ # Clone repository to ~/, or update existing # $1: name of osmocom project clone_repo() { - cd ~/"$1" || (cd ~/ && git clone https://gerrit.osmocom.org/"$1" && cd ~/"$1") + local project="$1" + local url="https://gerrit.osmocom.org/$project" + + if [ -d ~/"$project" ]; then + cd ~/"$project" + git remote set-url origin "$url" + else + cd ~ + git clone "$url" + cd "$project" + fi + git rev-parse HEAD git status -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29774 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I3d9c193bf353ecff0ee8bb4c507de59139fc0925 Gerrit-Change-Number: 29774 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

Change in osmo-ci[master]: contrib/jenkins.sh: run …rebuild.sh from workspace

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/29772 ) Change subject: contrib/jenkins.sh: run …rebuild.sh from workspace ...................................................................... contrib/jenkins.sh: run …rebuild.sh from workspace After cloning a repository, go back into the workspace directory. Run scripts/osmo-ci-docker-rebuild.sh from there, instead of the version cloned into ~/osmo-ci. This is the behavior one would expect. Without this patch, a _docker_playground temporary git clone gets created/used in ~/osmo-ci, although it would make much more sense to have it in the workspace dir. Change-Id: I998c0d47ee5ce6f9978d1a6c9e195d5ce40e4e85 --- M contrib/jenkins.sh 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/72/29772/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 300d38c..6512af9 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -1,5 +1,6 @@ #!/bin/sh set -e -x +WORKSPACE_DIR="$(realpath "$(dirname "$0")/..")" # Clone repository to ~/, or update existing # $1: name of osmocom project @@ -12,12 +13,13 @@ git rev-parse HEAD git status + + cd "$WORKSPACE_DIR" } clone_repo osmo-ci clone_repo osmo-gsm-manuals if [ `uname` = "Linux" ] && [ "x${OSMO_CI_NO_DOCKER}" != "x1" ]; then - cd ~/osmo-ci scripts/osmo-ci-docker-rebuild.sh fi -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29772 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I998c0d47ee5ce6f9978d1a6c9e195d5ce40e4e85 Gerrit-Change-Number: 29772 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

Change in libosmo-netif[master]: stream: Improve logging of SCTP_PEER_ADDR_CHANGE notification

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/29769 to look at the new patch set (#2). Change subject: stream: Improve logging of SCTP_PEER_ADDR_CHANGE notification ...................................................................... stream: Improve logging of SCTP_PEER_ADDR_CHANGE notification Related: SYS#6113 Change-Id: Ieebc6e623874b4770ec7cd8b934244ffecaa089d --- M include/osmocom/netif/sctp.h M src/sctp.c M src/stream.c 3 files changed, 47 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/69/29769/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29769 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ieebc6e623874b4770ec7cd8b934244ffecaa089d Gerrit-Change-Number: 29769 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 8 months

1
0
0 0

2025

2024

2023

2022

gerrit-log October 2022