October 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: Add BTS ramping to prevent mass configuration of BTS at the same time

by fixeria

Attention is currently required from: lynxis lazus. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29788 ) Change subject: Add BTS ramping to prevent mass configuration of BTS at the same time ...................................................................... Patch Set 1: (4 comments) File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/6d6d0f6e_cbba83fd PS1, Line 1284: "allow-bts-configuration <0-65535>", Unfortunately we have a mix of two different command styles: a) 'COMMAND <0-255>' and b) 'bts <0-255> COMMAND'. Personally I find b) more logical and suggest to use it for the new command. For example, see bts_resend_sysinfo_cmd. https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/c50b2ece_d3427ec3 PS1, Line 1284: 65535 Not sure if OML allows to address more than 256 BTS instances, but ok. https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/0007d035_73d8e375 PS1, Line 3087: bts ramp limit I suggest to rework this command as follows: bts-ramp # "Configure BTS ramping parameters\n" limit <0-999> # "Limit number of BTS\n" "Number of BTS\n" window <0-999> # "Time window\n" "Time window (in seconds)\n" File src/osmo-bsc/nm_bts_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/a165e573_e4a541bc PS1, Line 92: struct gsm_bts *bts, weird [mis]alignment -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29788 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id56dde6d58f3d0d20352f6c306598d2cccc6345d Gerrit-Change-Number: 29788 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 18 Oct 2022 09:31:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-msc[master]: SMPP: use default port from libsmpp34

by msuraev

Attention is currently required from: fixeria, msuraev. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28865 ) Change subject: SMPP: use default port from libsmpp34 ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28865 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I2140ed57e64f17fb79130014eaf88f58b62d7a00 Gerrit-Change-Number: 28865 Gerrit-PatchSet: 9 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Oct 2022 09:17:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-bsc[master]: gsm_data.h: replace white spaces with tabs

by fixeria

Attention is currently required from: lynxis lazus. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29787 ) Change subject: gsm_data.h: replace white spaces with tabs ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29787 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I78604117ab50f92f0dcec040a85499f106757f48 Gerrit-Change-Number: 29787 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 18 Oct 2022 09:04:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-bsc[master]: bts_ipaccess_nanobts: remove unused assignment

by fixeria

Attention is currently required from: lynxis lazus. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29786 ) Change subject: bts_ipaccess_nanobts: remove unused assignment ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29786 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I811f7c596de42eff250b1882a9e2e7cdece6259d Gerrit-Change-Number: 29786 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 18 Oct 2022 09:04:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-bsc[master]: bsc_vty: training_sequence_code: add missing doc string

by fixeria

Attention is currently required from: pespin, lynxis lazus. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29785 ) Change subject: bsc_vty: training_sequence_code: add missing doc string ...................................................................... Patch Set 1: Code-Review-2 (1 comment) File src/osmo-bsc/bts_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29785/comment/44d0a7c3_8f096d6b PS1, Line 305: "Set the Training Sequence Code (TSC) of this BTS\n" > This looks wrong to me. […] Indeed, we have two items in the command vector and two docstrings. No need for 3rd docstring. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29785 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib16e8537e252f6462ef1a90f5eb80572db4b96bb Gerrit-Change-Number: 29785 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 18 Oct 2022 09:04:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-bsc[master]: gsm_data.h: replace white spaces with tabs

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29787 ) Change subject: gsm_data.h: replace white spaces with tabs ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29787 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I78604117ab50f92f0dcec040a85499f106757f48 Gerrit-Change-Number: 29787 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 18 Oct 2022 08:56:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-bsc[master]: bts_ipaccess_nanobts: remove unused assignment

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29786 ) Change subject: bts_ipaccess_nanobts: remove unused assignment ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29786 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I811f7c596de42eff250b1882a9e2e7cdece6259d Gerrit-Change-Number: 29786 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 18 Oct 2022 08:56:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-bsc[master]: bsc_vty: training_sequence_code: add missing doc string

by pespin

Attention is currently required from: fixeria, lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29785 ) Change subject: bsc_vty: training_sequence_code: add missing doc string ...................................................................... Patch Set 1: Code-Review-1 (1 comment) File src/osmo-bsc/bts_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29785/comment/d15c191d_b485b009 PS1, Line 305: "Set the Training Sequence Code (TSC) of this BTS\n" This looks wrong to me. The previous one is correct, since there's 2 args, and there should be 2 strings/lines -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29785 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib16e8537e252f6462ef1a90f5eb80572db4b96bb Gerrit-Change-Number: 29785 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 18 Oct 2022 08:55:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-bsc[master]: bts_ipaccess_nanobts: remove unused assignment

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29786 ) Change subject: bts_ipaccess_nanobts: remove unused assignment ...................................................................... bts_ipaccess_nanobts: remove unused assignment Change-Id: I811f7c596de42eff250b1882a9e2e7cdece6259d --- M src/osmo-bsc/bts_ipaccess_nanobts.c 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/86/29786/1 diff --git a/src/osmo-bsc/bts_ipaccess_nanobts.c b/src/osmo-bsc/bts_ipaccess_nanobts.c index c4df29e..624aabc 100644 --- a/src/osmo-bsc/bts_ipaccess_nanobts.c +++ b/src/osmo-bsc/bts_ipaccess_nanobts.c @@ -168,7 +168,6 @@ break; case NM_OC_CHANNEL: ts = obj; - trx = ts->trx; osmo_fsm_inst_dispatch(ts->mo.fi, NM_EV_STATE_CHG_REP, nsd); break; case NM_OC_RADIO_CARRIER: -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29786 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I811f7c596de42eff250b1882a9e2e7cdece6259d Gerrit-Change-Number: 29786 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

Change in osmo-bsc[master]: gsm_data.h: replace white spaces with tabs

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29787 ) Change subject: gsm_data.h: replace white spaces with tabs ...................................................................... gsm_data.h: replace white spaces with tabs Change-Id: I78604117ab50f92f0dcec040a85499f106757f48 --- M include/osmocom/bsc/gsm_data.h 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/87/29787/1 diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h index 37d7947..481eae4 100644 --- a/include/osmocom/bsc/gsm_data.h +++ b/include/osmocom/bsc/gsm_data.h @@ -872,10 +872,10 @@ struct llist_head bts_list; struct llist_head bts_rejected; - /* BTS-based counters when we can't find the actual BTS - * e.g. when conn->lchan is NULL */ - struct rate_ctr_group *bts_unknown_ctrs; - struct osmo_stat_item_group *bts_unknown_statg; + /* BTS-based counters when we can't find the actual BTS + * e.g. when conn->lchan is NULL */ + struct rate_ctr_group *bts_unknown_ctrs; + struct osmo_stat_item_group *bts_unknown_statg; /* see gsm_network_T_defs */ struct osmo_tdef *T_defs; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29787 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I78604117ab50f92f0dcec040a85499f106757f48 Gerrit-Change-Number: 29787 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

2025

2024

2023

2022

gerrit-log October 2022