January 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bsc-nat[master]: Add bsc_nat fsm

by osmith

Attention is currently required from: osmith, neels. Hello neels, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662 to look at the new patch set (#7). Change subject: Add bsc_nat fsm ...................................................................... Add bsc_nat fsm Create the initial FSM that starts and stops two SS7 instances (one for CN, one for RAN), and binds an sccp user to each. Related: OS#2545 Depends: libosmocore 0066f1bdcb328e7ffc846b4746e3e1d02afe4be8 Change-Id: I7d52fa649c397582b18a1a7dcc40bb407f3b2c97 --- M doc/examples/osmo-bsc-nat/osmo-bsc-nat.cfg M include/osmocom/bsc_nat/Makefile.am M include/osmocom/bsc_nat/bsc_nat.h A include/osmocom/bsc_nat/bsc_nat_fsm.h M src/osmo-bsc-nat/Makefile.am M src/osmo-bsc-nat/bsc_nat.c A src/osmo-bsc-nat/bsc_nat_fsm.c M src/osmo-bsc-nat/main.c M src/osmo-bsc-nat/vty.c 9 files changed, 327 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc-nat refs/changes/62/26662/7 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I7d52fa649c397582b18a1a7dcc40bb407f3b2c97 Gerrit-Change-Number: 26662 Gerrit-PatchSet: 7 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 5 months

1
0
0 0

Change in dahdi-linux[master]: vpmadt032: Create .o.cmd file for the shipped object file.

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/26970 ) Change subject: vpmadt032: Create .o.cmd file for the shipped object file. ...................................................................... vpmadt032: Create .o.cmd file for the shipped object file. Kernel version 5.8, in commit "modpost: use read_text_file() and get_line() for reading text files" [1] made it an error if the .o.cmd file is missing. However, this file is not generated for shipped .o files. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?… Signed-off-by: Shaun Ruffell <sruffell(a)sruffell.net> Change-Id: I06d201bcd07b35cb41c8c4a8467bcad6471c431a --- M drivers/dahdi/Kbuild 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved; Verified diff --git a/drivers/dahdi/Kbuild b/drivers/dahdi/Kbuild index 958e070..6a90fee 100644 --- a/drivers/dahdi/Kbuild +++ b/drivers/dahdi/Kbuild @@ -133,6 +133,7 @@ ifneq ($(DAHDI_ARCH),) ifneq ($(wildcard $(src)/vpmadt032_loader/vpmadt032_$(DAHDI_ARCH).o_shipped),) + $(shell touch $(KBUILD_EXTMOD)/vpmadt032_loader/.vpmadt032_$(DAHDI_ARCH).o.cmd) VPMADT032_LOADER_PRESENT=yes dahdi_vpmadt032_loader-objs += vpmadt032_loader/vpmadt032_$(DAHDI_ARCH).o obj-$(DAHDI_BUILD_ALL)$(CONFIG_DAHDI_VPMADT032_LOADER) += dahdi_vpmadt032_loader.o -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/26970 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I06d201bcd07b35cb41c8c4a8467bcad6471c431a Gerrit-Change-Number: 26970 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years, 5 months

1
0
0 0

Change in dahdi-linux[master]: vpmadt032: Create .o.cmd file for the shipped object file.

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/26970 ) Change subject: vpmadt032: Create .o.cmd file for the shipped object file. ...................................................................... Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/26970 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I06d201bcd07b35cb41c8c4a8467bcad6471c431a Gerrit-Change-Number: 26970 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sun, 23 Jan 2022 15:40:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in dahdi-linux[master]: vpmadt032: Create .o.cmd file for the shipped object file.

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/dahdi-linux/+/26970 ) Change subject: vpmadt032: Create .o.cmd file for the shipped object file. ...................................................................... vpmadt032: Create .o.cmd file for the shipped object file. Kernel version 5.8, in commit "modpost: use read_text_file() and get_line() for reading text files" [1] made it an error if the .o.cmd file is missing. However, this file is not generated for shipped .o files. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?… Signed-off-by: Shaun Ruffell <sruffell(a)sruffell.net> Change-Id: I06d201bcd07b35cb41c8c4a8467bcad6471c431a --- M drivers/dahdi/Kbuild 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/dahdi-linux refs/changes/70/26970/1 diff --git a/drivers/dahdi/Kbuild b/drivers/dahdi/Kbuild index 958e070..6a90fee 100644 --- a/drivers/dahdi/Kbuild +++ b/drivers/dahdi/Kbuild @@ -133,6 +133,7 @@ ifneq ($(DAHDI_ARCH),) ifneq ($(wildcard $(src)/vpmadt032_loader/vpmadt032_$(DAHDI_ARCH).o_shipped),) + $(shell touch $(KBUILD_EXTMOD)/vpmadt032_loader/.vpmadt032_$(DAHDI_ARCH).o.cmd) VPMADT032_LOADER_PRESENT=yes dahdi_vpmadt032_loader-objs += vpmadt032_loader/vpmadt032_$(DAHDI_ARCH).o obj-$(DAHDI_BUILD_ALL)$(CONFIG_DAHDI_VPMADT032_LOADER) += dahdi_vpmadt032_loader.o -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/26970 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I06d201bcd07b35cb41c8c4a8467bcad6471c431a Gerrit-Change-Number: 26970 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 years, 5 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: logp("start") also for handler_mode := false

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26969 ) Change subject: bsc: logp("start") also for handler_mode := false ...................................................................... bsc: logp("start") also for handler_mode := false Change-Id: I4421a674055cd7013d21c52e9de6e369d1a72b6b --- M bsc/BSC_Tests.ttcn 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index fe6d1b2..634e629 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -1227,6 +1227,9 @@ for (var integer i := 0; i < nr_bts; i := i+1) { f_init_bts(i, handler_mode); } + + /* Emit a marker to appear in the SUT's own logging output */ + f_logp(BSCVTY, testcasename() & "() start"); } function f_init_bts(integer bts_idx := 0, boolean handler_mode := false) @@ -3704,8 +3707,6 @@ function f_start_handler_run(MSC_ConnHdlr vc_conn, void_fn fn, template (omit) TestHdlrParams pars := omit) runs on test_CT return MSC_ConnHdlr { var charstring id := testcasename(); - /* Emit a marker to appear in the SUT's own logging output */ - f_logp(BSCVTY, id & "() start"); vc_conn.start(f_handler_init(fn, id, pars)); return vc_conn; } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26969 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4421a674055cd7013d21c52e9de6e369d1a72b6b Gerrit-Change-Number: 26969 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years, 5 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: logp("start") also for handler_mode := false

by laforge

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26969 ) Change subject: bsc: logp("start") also for handler_mode := false ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26969 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4421a674055cd7013d21c52e9de6e369d1a72b6b Gerrit-Change-Number: 26969 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Sun, 23 Jan 2022 10:29:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Build failure of network:osmocom:nightly/osmo-gbproxy in openSUSE_Factory_ARM/armv7l

by OBS Notification

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o… Package network:osmocom:nightly/osmo-gbproxy failed to build in openSUSE_Factory_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-gbproxy Last lines of build log: [ 41s] [145/162] cumulate libosmogsm-devel-1.6.0.47.1d1a.202201230026-1.1 [ 41s] [146/162] cumulate libosmovty-devel-1.6.0.47.1d1a.202201230026-1.1 [ 41s] [147/162] cumulate libtool-2.4.6-8.20 [ 41s] [148/162] cumulate libutempter0-1.2.0-3.12 [ 41s] [149/162] cumulate libosmoctrl0-1.6.0.47.1d1a.202201230026-1.1 [ 41s] [150/162] cumulate libosmogb12-1.6.0.47.1d1a.202201230026-1.1 [ 41s] [151/162] cumulate post-build-checks-84.87+git20210304.df696a0-1.2 [ 41s] [152/162] cumulate pam-1.5.2-5.3 [ 41s] [153/162] cumulate gcc11-11.2.1+git1173-1.3 [ 41s] [154/162] cumulate gcc-11-4.3 [ 41s] [155/162] cumulate libopenssl-1_1-devel-1.1.1m-1.3 [ 41s] [156/162] cumulate libosmoctrl-devel-1.6.0.47.1d1a.202201230026-1.1 [ 41s] [157/162] cumulate libosmogb-devel-1.6.0.47.1d1a.202201230026-1.1 [ 41s] [158/162] cumulate pam_unix-1.5.2-5.3 [ 41s] [159/162] cumulate shadow-4.11.1-1.1 [ 41s] [160/162] cumulate util-linux-2.37.2-2.3 [ 41s] [161/162] cumulate gcc-PIE-11-4.3 [ 41s] [162/162] cumulate rpm-build-4.17.0-2.4 [ 41s] now installing cumulated packages [ 41s] error: .init_b_cache/bash-sh.rpm: signature region trailer: BAD, tag 0 type 0 offset 0 count 0 [ 41s] error: .init_b_cache/bash-sh.rpm cannot be installed [ 41s] exit ... [ 41s] ### VM INTERACTION START ### [ 44s] [ 8.722662][ T391] sysrq: Power Off [ 44s] [ 8.723214][ T208] reboot: Power down [ 44s] ### VM INTERACTION END ### [ 44s] [ 44s] obs-arm-10 failed "build osmo-gbproxy.spec" at Sun Jan 23 00:36:14 UTC 2022. [ 44s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)

3 years, 5 months

1
0
0 0

Change in libosmocore[master]: ports.h: add osmo-pfcp-tool ports

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26607 ) Change subject: ports.h: add osmo-pfcp-tool ports ...................................................................... ports.h: add osmo-pfcp-tool ports Related: SYS#5599 Change-Id: I8a5f437d934b9bda11ea593b50bd18c7d5d71ce9 --- M include/osmocom/ctrl/ports.h M include/osmocom/vty/ports.h 2 files changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified neels: Looks good to me, approved pespin: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve diff --git a/include/osmocom/ctrl/ports.h b/include/osmocom/ctrl/ports.h index d287940..b4bceef 100644 --- a/include/osmocom/ctrl/ports.h +++ b/include/osmocom/ctrl/ports.h @@ -32,4 +32,6 @@ #define OSMO_CTRL_PORT_HNODEB 4274 /* 4275: OSMO_VTY_PORT_UPF */ #define OSMO_CTRL_PORT_UPF 4276 +/* 4277: OSMO_VTY_PORT_PFCP_TOOL */ +#define OSMO_CTRL_PORT_PFCP_TOOL 4278 /* When adding/changing port numbers, keep docs and wiki in sync. See above. */ diff --git a/include/osmocom/vty/ports.h b/include/osmocom/vty/ports.h index 75ff86f..d3b1d7a 100644 --- a/include/osmocom/vty/ports.h +++ b/include/osmocom/vty/ports.h @@ -44,4 +44,6 @@ /* 4274 used by control interface */ #define OSMO_VTY_PORT_UPF 4275 /* 4276: OSMO_CTRL_PORT_UPF */ +#define OSMO_VTY_PORT_PFCP_TOOL 4277 +/* 4278: OSMO_CTRL_PORT_UPF */ /* When adding/changing port numbers, keep docs and wiki in sync. See above. */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26607 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8a5f437d934b9bda11ea593b50bd18c7d5d71ce9 Gerrit-Change-Number: 26607 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 5 months

1
0
0 0

Change in libosmocore[master]: ports.h: add osmo-pfcp-tool ports

by neels

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26607 ) Change subject: ports.h: add osmo-pfcp-tool ports ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26607 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8a5f437d934b9bda11ea593b50bd18c7d5d71ce9 Gerrit-Change-Number: 26607 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 23 Jan 2022 00:25:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: f_perform_clear: ack all DLCX and RSL REL REQ

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26620 ) Change subject: bsc: f_perform_clear: ack all DLCX and RSL REL REQ ...................................................................... bsc: f_perform_clear: ack all DLCX and RSL REL REQ ACK any MGCP DLCX or RLL REL REQ during f_perform_clear(), which makes it more universally applicable to invoke at the end of a test. Related: OS#5337 Change-Id: Ie5b77c266a5d8f47edd187c474df281a799a81de --- M bsc/BSC_Tests.ttcn 1 file changed, 20 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index d68cba2..34d3d03 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -7791,9 +7791,27 @@ } } +private altstep as_mgcp_ack_all_dlcx() runs on MSC_ConnHdlr { + var MgcpCommand mgcp_cmd; + [] MGCP.receive(tr_DLCX(?)) -> value mgcp_cmd { + MGCP.send(ts_DLCX_ACK2(mgcp_cmd.line.trans_id)); + repeat; + } +} + +private altstep as_rsl_ack_all_rel_req() runs on MSC_ConnHdlr { + var RslLinkId main_dcch := valueof(ts_RslLinkID_DCCH(0)); + [] RSL.receive(tr_RSL_REL_REQ(g_chan_nr, ?)) { + RSL.send(ts_RSL_REL_CONF(g_chan_nr, main_dcch)); + repeat; + } +} + friend function f_perform_clear(RSL_DCHAN_PT rsl_pt := RSL, RSLEM_PROC_PT rsl_proc_pt := RSL_PROC, template PDU_ML3_NW_MS exp_rr_rel_tmpl := tr_RRM_RR_RELEASE) runs on MSC_ConnHdlr { + var default ack_dlcx := activate(as_mgcp_ack_all_dlcx()); + var default ack_rel_req := activate(as_rsl_ack_all_rel_req()); f_logp(BSCVTY, "MSC instructs BSC to clear channel"); BSSAP.send(ts_BSSMAP_ClearCommand(0)); interleave { @@ -7814,6 +7832,8 @@ f_rslem_unregister(0, g_chan_nr, PT := rsl_proc_pt); } } + deactivate(ack_dlcx); + deactivate(ack_rel_req); } private function f_perform_compl_l3(RSL_DCHAN_PT rsl_pt, RSLEM_PROC_PT rsl_proc_pt, null-- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26620 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie5b77c266a5d8f47edd187c474df281a799a81de Gerrit-Change-Number: 26620 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2022