lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

January 2022

  • 3 participants
  • 781 discussions
Change in osmo-ttcn3-hacks[master]: bsc: make perform_clear() work when VTY is not initialized
by neels 22 Jan '22

22 Jan '22
Attention is currently required from: laforge, fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26617 ) Change subject: bsc: make perform_clear() work when VTY is not initialized ...................................................................... Patch Set 1: (1 comment) File bsc/BSC_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26617/comment/97c11097_7ee3… PS1, Line 1069: if (g_vty_initialized) { > good idea! I would have done that, but f_logp() is not on MSC_ConnHdlr and hence doesn't know g_* variables. Is there a way to find out from the state of the TELNETasp_PT whether it is connected? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26617 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8116075f32937bd06ba14b426010bf6fec2ef402 Gerrit-Change-Number: 26617 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 22 Jan 2022 22:56:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment
1 0
0 0
Change in libosmocore[master]: add osmo_sockaddr_to_str_c(), osmo_sockaddr_to_str_buf2()
by neels 22 Jan '22

22 Jan '22
Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26608 ) Change subject: add osmo_sockaddr_to_str_c(), osmo_sockaddr_to_str_buf2() ...................................................................... Patch Set 2: (6 comments) Patchset: PS2: the function was defined to return null for short buf. The new version is better, it returns a truncated string and the would-be-required length. File src/socket.c: https://gerrit.osmocom.org/c/libosmocore/+/26608/comment/6efb1de2_9815eff3 PS1, Line 1827: /*! string-format a given osmo_sockaddr address into a user-supplied buffer. > I think you are changing how this function used to worked here, and imho it's unexpected. […] Previously, the function would return NULL in case of errors, just in a specific corner case it didn't. Read the API doc: "or NULL if too short". The C test shows this. File tests/socket/socket_test.c: https://gerrit.osmocom.org/c/libosmocore/+/26608/comment/4d53c597_41a7e44d PS2, Line 350: OSMO_ASSERT(!strncmp("[::1]:4", result, sizeof(buf))); here for some reason, even though the port number should be 42, the function failed to return NULL. https://gerrit.osmocom.org/c/libosmocore/+/26608/comment/7d6b93bc_a59aebae PS2, Line 350: OSMO_ASSERT(result == NULL); Now this corner case is fixed. https://gerrit.osmocom.org/c/libosmocore/+/26608/comment/877da413_f3e9b34f PS2, Line 357: OSMO_ASSERT(result == NULL); here and https://gerrit.osmocom.org/c/libosmocore/+/26608/comment/5c7fc121_72005a9d PS2, Line 363: OSMO_ASSERT(result == NULL); here it was always verified to return NULL for a short buffer -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26608 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I12771bf8a021e6785217b1faad03c09ec1cfef0e Gerrit-Change-Number: 26608 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 22 Jan 2022 22:46:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment
1 0
0 0
Change in osmo-bsc[master]: fix two comments in chan_counts.h
by neels 22 Jan '22

22 Jan '22
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26966 ) Change subject: fix two comments in chan_counts.h ...................................................................... fix two comments in chan_counts.h An earlier patch version had that typedef, the merged version switched to the struct containing the array. Change-Id: Id8ca7b298436feb98f4a563ad3cdea510b9362b0 --- M include/osmocom/bsc/chan_counts.h 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: neels: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/bsc/chan_counts.h b/include/osmocom/bsc/chan_counts.h index 9f73bc4..31a1adc 100644 --- a/include/osmocom/bsc/chan_counts.h +++ b/include/osmocom/bsc/chan_counts.h @@ -4,7 +4,7 @@ struct gsm_bts; struct gsm_bts_trx; -/* First array index to typedef chan_counts_arr. */ +/* First array index to chan_counts.val. */ enum chan_counts_dim1 { CHAN_COUNTS1_ALL = 0, CHAN_COUNTS1_STATIC = 1, @@ -12,7 +12,7 @@ _CHAN_COUNTS1_NUM }; -/* Second array index to typedef chan_counts_arr. */ +/* Second array index to chan_counts.val. */ enum chan_counts_dim2 { /* The maximum possible nr of lchans of this type. Counts all dynamic timeslots as if they are fully available * for this type, regardless of the current pchan mode. (For CHAN_COUNTS1_STATIC, of course no dyn TS are counted -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26966 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id8ca7b298436feb98f4a563ad3cdea510b9362b0 Gerrit-Change-Number: 26966 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged
1 0
0 0
Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Emulation: implement direct mode of operation
by laforge 22 Jan '22

22 Jan '22
Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26521 ) Change subject: library/DIAMETER_Emulation: implement direct mode of operation ...................................................................... Patch Set 5: Code-Review+1 (1 comment) Patchset: PS5: not sure if we call this "direct" or "raw" in other emulation components? Might be worth verifying we align with others naming-wise -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26521 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I52e22ac70cc85be5b0436b68c77356aabc4f05e1 Gerrit-Change-Number: 26521 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 22 Jan 2022 13:00:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
Change in pysim[master]: cosmetic: Use EF.FDN instead of EF_FDN in ts_51_011.py
by laforge 22 Jan '22

22 Jan '22
laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/26963 ) Change subject: cosmetic: Use EF.FDN instead of EF_FDN in ts_51_011.py ...................................................................... cosmetic: Use EF.FDN instead of EF_FDN in ts_51_011.py All the files have '.' as separator in their names so far, let's avoid any inconsistencies Change-Id: Icabb892408a40ea37c7ebeb7db545b383aa01d99 --- M pySim/ts_51_011.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/ts_51_011.py b/pySim/ts_51_011.py index 847ed98..0f7e737 100644 --- a/pySim/ts_51_011.py +++ b/pySim/ts_51_011.py @@ -434,7 +434,7 @@ super().__init__(fid=fid, name=name, desc=desc) files = [ EF_ADN(), - EF_ADN(fid='6f3b', name='EF_FDN', desc='Fixed dialling numbers'), + EF_ADN(fid='6f3b', name='EF.FDN', desc='Fixed dialling numbers'), EF_SMS(), LinFixedEF(fid='6f3d', name='EF.CCP', desc='Capability Configuration Parameters', rec_len={14,14}), LinFixedEF(fid='6f4f', name='EF.ECCP', desc='Extended Capability Configuration Parameters', rec_len={15,32}), -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26963 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icabb892408a40ea37c7ebeb7db545b383aa01d99 Gerrit-Change-Number: 26963 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged
1 0
0 0
Change in pysim[master]: pySim-shell: alphabetically sort name of files in 'dir' command
by laforge 22 Jan '22

22 Jan '22
laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/26964 ) Change subject: pySim-shell: alphabetically sort name of files in 'dir' command ...................................................................... pySim-shell: alphabetically sort name of files in 'dir' command Change-Id: Id136909884d3c0eaa2416c6c488a6c4b7ed48119 --- M pySim/filesystem.py 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/filesystem.py b/pySim/filesystem.py index 32688db..3e9d52e 100644 --- a/pySim/filesystem.py +++ b/pySim/filesystem.py @@ -172,7 +172,9 @@ list containing all selectable names. """ sels = self.get_selectables(flags) - return list(sels.keys()) + sel_keys = list(sels.keys()) + sel_keys.sort() + return sel_keys def decode_select_response(self, data_hex:str): """Decode the response to a SELECT command. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26964 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id136909884d3c0eaa2416c6c488a6c4b7ed48119 Gerrit-Change-Number: 26964 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged
1 0
0 0
Change in pysim[master]: ts_102_221: decode/encode EF.PL
by laforge 22 Jan '22

22 Jan '22
laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/26965 ) Change subject: ts_102_221: decode/encode EF.PL ...................................................................... ts_102_221: decode/encode EF.PL pySIM-shell (MF/EF.PL)> read_binary_decoded [ "en", null, null, null, null ] Change-Id: I4e879ef34acee461adb8137a6315d064370b1b10 --- M pySim/ts_102_221.py 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/ts_102_221.py b/pySim/ts_102_221.py index f145d19..7cc3025 100644 --- a/pySim/ts_102_221.py +++ b/pySim/ts_102_221.py @@ -503,6 +503,17 @@ class EF_PL(TransRecEF): def __init__(self, fid='2f05', sfid=0x05, name='EF.PL', desc='Preferred Languages'): super().__init__(fid, sfid=sfid, name=name, desc=desc, rec_len=2, size={2,None}) + def _decode_record_bin(self, bin_data): + if bin_data == b'\xff\xff': + return None + else: + return bin_data.decode('ascii') + def _encode_record_bin(self, in_json): + if in_json is None: + return b'\xff\xff' + else: + return in_json.encode('ascii') + # TS 102 221 Section 13.4 class EF_ARR(LinFixedEF): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26965 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4e879ef34acee461adb8137a6315d064370b1b10 Gerrit-Change-Number: 26965 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged
1 0
0 0
Change in pysim[master]: ts_31_102: Add support for EF.ECC (emergency call codes)
by laforge 22 Jan '22

22 Jan '22
laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/26962 ) Change subject: ts_31_102: Add support for EF.ECC (emergency call codes) ...................................................................... ts_31_102: Add support for EF.ECC (emergency call codes) decoded output will look like this: [ { "call_code": "911", "service_category": { "police": false, "ambulance": false, "fire_brigade": false, "marine_guard": false, "mountain_rescue": false, "manual_ecall": false, "automatic_ecall": false }, "alpha_id": "911" }, { "call_code": "112", "service_category": { "police": false, "ambulance": false, "fire_brigade": false, "marine_guard": false, "mountain_rescue": false, "manual_ecall": false, "automatic_ecall": false }, "alpha_id": "112" }, null, null, null ] Change-Id: If8b4972af4f5be1707446d335cfc6e729c973abb --- M pySim/ts_31_102.py 1 file changed, 26 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/ts_31_102.py b/pySim/ts_31_102.py index 647a4d7..c96bf09 100644 --- a/pySim/ts_31_102.py +++ b/pySim/ts_31_102.py @@ -558,9 +558,35 @@ # TS 31.103 Section 4.2.7 - *not* the same as DF.GSM/EF.ECC! class EF_ECC(LinFixedEF): + cc_construct = Rpad(BcdAdapter(Rpad(Bytes(3))), pattern='f') + category_construct = FlagsEnum(Byte, police=1, ambulance=2, fire_brigade=3, marine_guard=4, + mountain_rescue=5, manual_ecall=6, automatic_ecall=7) + alpha_construct = GsmStringAdapter(Rpad(GreedyBytes)) def __init__(self, fid='6fb7', sfid=0x01, name='EF.ECC', desc='Emergency Call Codes'): super().__init__(fid, sfid=sfid, name=name, desc=desc, rec_len={4,20}) + def _decode_record_bin(self, in_bin): + # mandatory parts + code = in_bin[:3] + if code == b'\xff\xff\xff': + return None + svc_category = in_bin[-1:] + ret = {'call_code': parse_construct(EF_ECC.cc_construct, code), + 'service_category': parse_construct(EF_ECC.category_construct, svc_category) } + # optional alpha identifier + if len(in_bin) > 4: + alpha_id = in_bin[3:-1] + ret['alpha_id'] = parse_construct(EF_ECC.alpha_construct, alpha_id) + return ret + def _encode_record_bin(self, in_json): + if in_json is None: + return b'\xff\xff\xff\xff' + code = EF_ECC.cc_construct.build(in_json['call_code']) + svc_category = EF_ECC.category_construct.build(in_json['category']) + alpha_id = EF_ECC.alpha_construct.build(in_json['alpha_id']) + # FIXME: alpha_id needs padding up to 'record_length - 4' + return code + alpha_id + svc_category + # TS 31.102 Section 4.2.17 class EF_LOCI(TransparentEF): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26962 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If8b4972af4f5be1707446d335cfc6e729c973abb Gerrit-Change-Number: 26962 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged
1 0
0 0
Change in pysim[master]: ts_102_221: decode/encode EF.PL
by laforge 22 Jan '22

22 Jan '22
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26965 ) Change subject: ts_102_221: decode/encode EF.PL ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26965 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4e879ef34acee461adb8137a6315d064370b1b10 Gerrit-Change-Number: 26965 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sat, 22 Jan 2022 12:59:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
Change in pysim[master]: pySim-shell: alphabetically sort name of files in 'dir' command
by laforge 22 Jan '22

22 Jan '22
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26964 ) Change subject: pySim-shell: alphabetically sort name of files in 'dir' command ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26964 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id136909884d3c0eaa2416c6c488a6c4b7ed48119 Gerrit-Change-Number: 26964 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sat, 22 Jan 2022 12:58:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 30
  • 31
  • 32
  • 33
  • 34
  • 35
  • 36
  • ...
  • 79
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.