January 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Emulation: implement direct mode of operation

by pespin

Attention is currently required from: laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26521 ) Change subject: library/DIAMETER_Emulation: implement direct mode of operation ...................................................................... Patch Set 4: (1 comment) File library/DIAMETER_Emulation.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26521/comment/0492dacc_aff8… PS4, Line 357: [] DIAMETER.receive(tr_DIAMETER_RecvFrom_R(?)) -> value mrf { please add "not ops.direct" here or similar, for readers to understand either of the alt steps is expected based on configuration. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26521 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I52e22ac70cc85be5b0436b68c77356aabc4f05e1 Gerrit-Change-Number: 26521 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Jan 2022 16:09:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in osmo-bsc[master]: fix two comments in chan_counts.h

by neels

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26966 ) Change subject: fix two comments in chan_counts.h ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: trivial -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26966 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id8ca7b298436feb98f4a563ad3cdea510b9362b0 Gerrit-Change-Number: 26966 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Fri, 21 Jan 2022 15:54:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in osmo-bsc[master]: fix two comments in chan_counts.h

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26966 ) Change subject: fix two comments in chan_counts.h ...................................................................... fix two comments in chan_counts.h An earlier patch version had that typedef, the merged version switched to the struct containing the array. Change-Id: Id8ca7b298436feb98f4a563ad3cdea510b9362b0 --- M include/osmocom/bsc/chan_counts.h 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/66/26966/1 diff --git a/include/osmocom/bsc/chan_counts.h b/include/osmocom/bsc/chan_counts.h index 9f73bc4..31a1adc 100644 --- a/include/osmocom/bsc/chan_counts.h +++ b/include/osmocom/bsc/chan_counts.h @@ -4,7 +4,7 @@ struct gsm_bts; struct gsm_bts_trx; -/* First array index to typedef chan_counts_arr. */ +/* First array index to chan_counts.val. */ enum chan_counts_dim1 { CHAN_COUNTS1_ALL = 0, CHAN_COUNTS1_STATIC = 1, @@ -12,7 +12,7 @@ _CHAN_COUNTS1_NUM }; -/* Second array index to typedef chan_counts_arr. */ +/* Second array index to chan_counts.val. */ enum chan_counts_dim2 { /* The maximum possible nr of lchans of this type. Counts all dynamic timeslots as if they are fully available * for this type, regardless of the current pchan mode. (For CHAN_COUNTS1_STATIC, of course no dyn TS are counted -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26966 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id8ca7b298436feb98f4a563ad3cdea510b9362b0 Gerrit-Change-Number: 26966 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 5 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Emulation: implement direct mode of operation

by fixeria

Attention is currently required from: laforge, pespin. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26521 to look at the new patch set (#4). Change subject: library/DIAMETER_Emulation: implement direct mode of operation ...................................................................... library/DIAMETER_Emulation: implement direct mode of operation This patch implements a new mode of operation, which allows to have direct communication between the emulation component and the other component connected via the 'DIAMETER_UNIT' port. This eliminates the need to have dedicated components for each IMSI, what is not necessarily needed in some specific cases. Change-Id: I52e22ac70cc85be5b0436b68c77356aabc4f05e1 Related: SYS#5602 --- M library/DIAMETER_Emulation.ttcn M mme/MME_Tests.ttcn M pgw/PGW_Tests.ttcn 3 files changed, 21 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/21/26521/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26521 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I52e22ac70cc85be5b0436b68c77356aabc4f05e1 Gerrit-Change-Number: 26521 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 5 months

1
0
0 0

Change in osmo-bsc-nat[master]: Add bsc_nat fsm

by pespin

Attention is currently required from: osmith, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662 ) Change subject: Add bsc_nat fsm ...................................................................... Patch Set 5: (2 comments) File include/osmocom/bsc_nat/bsc_nat_fsm.h: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662/comment/25a5d941_7a701e1b PS5, Line 22: void bsc_nat_fsm_start(struct bsc_nat *bsc_nat); The API is a bit weird, because you return fi in bsc_nat_fsm_alloc, which is then assigned externally to bsc_nat->fi, and then in these other functions you pass bsc_nat and do bsc_nat->fi from it. File src/osmo-bsc-nat/bsc_nat_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662/comment/845a1a19_3b5c8a6c PS5, Line 136: static void st_stopped_on_enter(struct osmo_fsm_inst *fi, uint32_t prev_state) Please put the on_enter function above the event one. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I7d52fa649c397582b18a1a7dcc40bb407f3b2c97 Gerrit-Change-Number: 26662 Gerrit-PatchSet: 5 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Jan 2022 15:38:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Emulation: implement direct mode of operation

by fixeria

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26521 ) Change subject: library/DIAMETER_Emulation: implement direct mode of operation ...................................................................... Patch Set 2: (1 comment) This change is ready for review. File library/DIAMETER_Emulation.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26521/comment/647e67de_501c… PS1, Line 342: [ops.direct] DIAMETER_UNIT.receive(PDU_DIAMETER:?) -> value msg { > so if direct is false, what do we do with those messages? I don't see any other DIAMETER_UNIT. […] If 'direct' is false, then the emulation component behaves as usual: looks up a dedicated component in its internal table and sends the PDU over DIAMETER_CLIENT port. If true, no lookup is performed and all messages are getting sent over DIAMETER_UNIT port regardless of the IMSI. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26521 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I52e22ac70cc85be5b0436b68c77356aabc4f05e1 Gerrit-Change-Number: 26521 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Jan 2022 15:37:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in osmo-bsc-nat[master]: Add bsc_nat fsm

by osmith

Attention is currently required from: neels, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662 ) Change subject: Add bsc_nat fsm ...................................................................... Patch Set 5: (9 comments) Patchset: PS5: Thanks for the detailed review, updated. File include/osmocom/bsc_nat/bsc_nat_fsm.h: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662/comment/8b63849b_0bba3e23 PS4, Line 21: enum bsc_nat_fsm_states { > (usually the state enum can live in the foo_fsm. […] Done https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662/comment/a90c2712_7a6e96fd PS4, Line 33: extern struct osmo_fsm bsc_nat_fsm; > (no need to declare the fsm in the .h, it can be static in the .c file. […] Done https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662/comment/f5560898_43a60a2b PS4, Line 35: void bsc_nat_start(struct bsc_nat *bsc_nat); > does this do the same as BSC_NAT_FSM_EV_START? Then maybe the events enum can also move to the . […] Done File src/osmo-bsc-nat/bsc_nat_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662/comment/47801b12_3e07cc73 PS4, Line 34: #define X(s) (1 << (s)) > There's tons of FSMs where X() is used. keeping X() https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662/comment/cd103293_e7785c1d PS4, Line 142: osmo_fsm_inst_state_chg(fi, BSC_NAT_FSM_ST_STOPPED, 0, 0); > seems like ST_STOPPING is not needed: the onenter directly changes state to another state. […] Done https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662/comment/3a713cdc_f3708e26 PS4, Line 159: X(BSC_NAT_FSM_ST_STOPPING), > (let me plug here the scheme i invented and use in my FSM definitions, which allows adding and remov […] Done https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662/comment/83077a4d_41fe4fd7 PS4, Line 184: int bsc_nat_fsm_timer_cb(struct osmo_fsm_inst *fi) > seems like no timer cb is needed. […] Done File src/osmo-bsc-nat/main.c: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662/comment/7cbf2bbd_1130f83e PS4, Line 150: bsc_nat_stop(g_bsc_nat, true); > osmo_select_shutdown_request() changes the osmo select loop to only handle pending writes and no lon […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I7d52fa649c397582b18a1a7dcc40bb407f3b2c97 Gerrit-Change-Number: 26662 Gerrit-PatchSet: 5 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Jan 2022 15:09:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in osmo-bsc-nat[master]: Add bsc_nat fsm

by osmith

Hello laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662 to look at the new patch set (#5). Change subject: Add bsc_nat fsm ...................................................................... Add bsc_nat fsm Create the initial FSM that starts and stops two SS7 instances (one for CN, one for RAN), and binds an sccp user to each. Related: OS#2545 Depends: libosmocore 0066f1bdcb328e7ffc846b4746e3e1d02afe4be8 Change-Id: I7d52fa649c397582b18a1a7dcc40bb407f3b2c97 --- M doc/examples/osmo-bsc-nat/osmo-bsc-nat.cfg M include/osmocom/bsc_nat/Makefile.am M include/osmocom/bsc_nat/bsc_nat.h A include/osmocom/bsc_nat/bsc_nat_fsm.h M src/osmo-bsc-nat/Makefile.am M src/osmo-bsc-nat/bsc_nat.c A src/osmo-bsc-nat/bsc_nat_fsm.c M src/osmo-bsc-nat/main.c M src/osmo-bsc-nat/vty.c 9 files changed, 324 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc-nat refs/changes/62/26662/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I7d52fa649c397582b18a1a7dcc40bb407f3b2c97 Gerrit-Change-Number: 26662 Gerrit-PatchSet: 5 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 5 months

1
0
0 0

Change in pysim[master]: ts_102_221: decode/encode EF.PL

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/26965 ) Change subject: ts_102_221: decode/encode EF.PL ...................................................................... ts_102_221: decode/encode EF.PL pySIM-shell (MF/EF.PL)> read_binary_decoded [ "en", null, null, null, null ] Change-Id: I4e879ef34acee461adb8137a6315d064370b1b10 --- M pySim/ts_102_221.py 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/65/26965/1 diff --git a/pySim/ts_102_221.py b/pySim/ts_102_221.py index f145d19..7cc3025 100644 --- a/pySim/ts_102_221.py +++ b/pySim/ts_102_221.py @@ -503,6 +503,17 @@ class EF_PL(TransRecEF): def __init__(self, fid='2f05', sfid=0x05, name='EF.PL', desc='Preferred Languages'): super().__init__(fid, sfid=sfid, name=name, desc=desc, rec_len=2, size={2,None}) + def _decode_record_bin(self, bin_data): + if bin_data == b'\xff\xff': + return None + else: + return bin_data.decode('ascii') + def _encode_record_bin(self, in_json): + if in_json is None: + return b'\xff\xff' + else: + return in_json.encode('ascii') + # TS 102 221 Section 13.4 class EF_ARR(LinFixedEF): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26965 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4e879ef34acee461adb8137a6315d064370b1b10 Gerrit-Change-Number: 26965 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 years, 5 months

1
0
0 0

Change in pysim[master]: pySim-shell: alphabetically sort name of files in 'dir' command

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/26964 ) Change subject: pySim-shell: alphabetically sort name of files in 'dir' command ...................................................................... pySim-shell: alphabetically sort name of files in 'dir' command Change-Id: Id136909884d3c0eaa2416c6c488a6c4b7ed48119 --- M pySim/filesystem.py 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/64/26964/1 diff --git a/pySim/filesystem.py b/pySim/filesystem.py index 32688db..3e9d52e 100644 --- a/pySim/filesystem.py +++ b/pySim/filesystem.py @@ -172,7 +172,9 @@ list containing all selectable names. """ sels = self.get_selectables(flags) - return list(sels.keys()) + sel_keys = list(sels.keys()) + sel_keys.sort() + return sel_keys def decode_select_response(self, data_hex:str): """Decode the response to a SELECT command. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26964 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id136909884d3c0eaa2416c6c488a6c4b7ed48119 Gerrit-Change-Number: 26964 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 years, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2022