laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26963 )
Change subject: cosmetic: Use EF.FDN instead of EF_FDN in ts_51_011.py
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/26963
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Icabb892408a40ea37c7ebeb7db545b383aa01d99
Gerrit-Change-Number: 26963
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Sat, 22 Jan 2022 12:58:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/26968 )
Change subject: icE1usb: Use USB_CTRL_SET_TIMEOUT (5s) instead of hand-coded 1s
......................................................................
Patch Set 2: Verified+1 Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/26968
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: dahdi-linux
Gerrit-Branch: master
Gerrit-Change-Id: I7b7c1a2b13f61372e839e34a376e66c91190bdb3
Gerrit-Change-Number: 26968
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Sat, 22 Jan 2022 12:57:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: tnt.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/26967 )
Change subject: icE1usb: update ice1usb_proto.h to firmware 0.2
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
as I wrote on IRC last night, I think the GPS-DO should actually be exposed as anoter interface descriptor (with no endpoints). This would substantially simplify the DAHDI (or any Linux kernel) driver. Wondering if we should at thta point move the requests from device to interface level?
--
To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/26967
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: dahdi-linux
Gerrit-Branch: master
Gerrit-Change-Id: I1423531470a1c9165d713108fb6a87ff47ff6e29
Gerrit-Change-Number: 26967
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: tnt <tnt(a)246tNt.com>
Gerrit-Attention: tnt <tnt(a)246tNt.com>
Gerrit-Comment-Date: Sat, 22 Jan 2022 12:57:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment