January 2022 - gerrit-log - lists.osmocom.org

Change in pysim[master]: transport/serial: fix for Python 3

by Hoernchen

Hoernchen has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/26971 ) Change subject: transport/serial: fix for Python 3 ...................................................................... transport/serial: fix for Python 3 Change-Id: I21e5a7ad4f623ed30681dce1ff819679b8714c5b --- M pySim/transport/serial.py 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve Hoernchen: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/transport/serial.py b/pySim/transport/serial.py index 4f2b28f..c080926 100644 --- a/pySim/transport/serial.py +++ b/pySim/transport/serial.py @@ -184,7 +184,7 @@ def _send_apdu_raw(self, pdu): pdu = h2b(pdu) - data_len = ord(pdu[4]) # P3 + data_len = pdu[4] # P3 # Send first CLASS,INS,P1,P2,P3 self._tx_string(pdu[0:5]) @@ -195,7 +195,7 @@ # - SW1: The card can apparently proceed ... while True: b = self._rx_byte() - if b == pdu[1]: + if ord(b) == pdu[1]: break elif b != '\x60': # Ok, it 'could' be SW1 @@ -215,7 +215,7 @@ # length = [P3 - tx_data (=len(pdu)-len(hdr)) + 2 (SW1//2) ] to_recv = data_len - len(pdu) + 5 + 2 - data = '' + data = bytes(0) while (len(data) < to_recv): b = self._rx_byte() if (to_recv == 2) and (b == '\x60'): # Ignore NIL if we have no RX data (hack ?) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26971 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I21e5a7ad4f623ed30681dce1ff819679b8714c5b Gerrit-Change-Number: 26971 Gerrit-PatchSet: 1 Gerrit-Owner: steve-m <steve(a)steve-m.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years, 5 months

1
0
0 0

Change in pysim[master]: transport/serial: fix for Python 3

by Hoernchen

Attention is currently required from: steve-m. Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26971 ) Change subject: transport/serial: fix for Python 3 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26971 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I21e5a7ad4f623ed30681dce1ff819679b8714c5b Gerrit-Change-Number: 26971 Gerrit-PatchSet: 1 Gerrit-Owner: steve-m <steve(a)steve-m.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: steve-m <steve(a)steve-m.de> Gerrit-Comment-Date: Tue, 25 Jan 2022 01:01:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in libosmocore[master]: add osmo_sockaddr_to_str_c(), osmo_sockaddr_to_str_buf2()

by laforge

Attention is currently required from: neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26608 ) Change subject: add osmo_sockaddr_to_str_c(), osmo_sockaddr_to_str_buf2() ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26608 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I12771bf8a021e6785217b1faad03c09ec1cfef0e Gerrit-Change-Number: 26608 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Jan 2022 00:19:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Emulation: implement 'raw' mode of operation

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26521 ) Change subject: library/DIAMETER_Emulation: implement 'raw' mode of operation ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26521 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I52e22ac70cc85be5b0436b68c77356aabc4f05e1 Gerrit-Change-Number: 26521 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Jan 2022 00:19:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in pysim[master]: transport/serial: fix for Python 3

by laforge

Attention is currently required from: steve-m. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26971 ) Change subject: transport/serial: fix for Python 3 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26971 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I21e5a7ad4f623ed30681dce1ff819679b8714c5b Gerrit-Change-Number: 26971 Gerrit-PatchSet: 1 Gerrit-Owner: steve-m <steve(a)steve-m.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-Attention: steve-m <steve(a)steve-m.de> Gerrit-Comment-Date: Tue, 25 Jan 2022 00:18:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in pysim[master]: transport/serial: fix for Python 3

by steve-m

steve-m has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/26971 ) Change subject: transport/serial: fix for Python 3 ...................................................................... transport/serial: fix for Python 3 Change-Id: I21e5a7ad4f623ed30681dce1ff819679b8714c5b --- M pySim/transport/serial.py 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/71/26971/1 diff --git a/pySim/transport/serial.py b/pySim/transport/serial.py index 4f2b28f..c080926 100644 --- a/pySim/transport/serial.py +++ b/pySim/transport/serial.py @@ -184,7 +184,7 @@ def _send_apdu_raw(self, pdu): pdu = h2b(pdu) - data_len = ord(pdu[4]) # P3 + data_len = pdu[4] # P3 # Send first CLASS,INS,P1,P2,P3 self._tx_string(pdu[0:5]) @@ -195,7 +195,7 @@ # - SW1: The card can apparently proceed ... while True: b = self._rx_byte() - if b == pdu[1]: + if ord(b) == pdu[1]: break elif b != '\x60': # Ok, it 'could' be SW1 @@ -215,7 +215,7 @@ # length = [P3 - tx_data (=len(pdu)-len(hdr)) + 2 (SW1//2) ] to_recv = data_len - len(pdu) + 5 + 2 - data = '' + data = bytes(0) while (len(data) < to_recv): b = self._rx_byte() if (to_recv == 2) and (b == '\x60'): # Ignore NIL if we have no RX data (hack ?) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26971 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I21e5a7ad4f623ed30681dce1ff819679b8714c5b Gerrit-Change-Number: 26971 Gerrit-PatchSet: 1 Gerrit-Owner: steve-m <steve(a)steve-m.de> Gerrit-MessageType: newchange

3 years, 5 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Emulation: implement 'raw' mode of operation

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26521 ) Change subject: library/DIAMETER_Emulation: implement 'raw' mode of operation ...................................................................... Patch Set 6: (1 comment) Patchset: PS5: > I am not aware of any other emulation components allowing to disable the internal routing. […] Ok, found some examples. The header file in BSC_Tests.ttcn describes two modes of operation: handler and raw. I aligned the naming as requested. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26521 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I52e22ac70cc85be5b0436b68c77356aabc4f05e1 Gerrit-Change-Number: 26521 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 24 Jan 2022 13:35:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Emulation: implement 'raw' mode of operation

by fixeria

Attention is currently required from: laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26521 to look at the new patch set (#6). Change subject: library/DIAMETER_Emulation: implement 'raw' mode of operation ...................................................................... library/DIAMETER_Emulation: implement 'raw' mode of operation This patch implements a new mode of operation, which allows to have direct communication between the emulation component and the other component connected via the 'DIAMETER_UNIT' port. This eliminates the need to have dedicated components for each IMSI, what is not necessarily needed in some specific cases. Change-Id: I52e22ac70cc85be5b0436b68c77356aabc4f05e1 Related: SYS#5602 --- M library/DIAMETER_Emulation.ttcn M mme/MME_Tests.ttcn M pgw/PGW_Tests.ttcn 3 files changed, 22 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/21/26521/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26521 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I52e22ac70cc85be5b0436b68c77356aabc4f05e1 Gerrit-Change-Number: 26521 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

3 years, 5 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Emulation: implement direct mode of operation

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26521 ) Change subject: library/DIAMETER_Emulation: implement direct mode of operation ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: > not sure if we call this "direct" or "raw" in other emulation components? Might be worth verifying w […] I am not aware of any other emulation components allowing to disable the internal routing. If there are, for sure I will align the naming. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26521 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I52e22ac70cc85be5b0436b68c77356aabc4f05e1 Gerrit-Change-Number: 26521 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 24 Jan 2022 12:05:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in osmo-bsc-nat[master]: Add bsc_nat fsm

by osmith

Attention is currently required from: neels, laforge, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662 ) Change subject: Add bsc_nat fsm ...................................................................... Patch Set 7: (1 comment) File src/osmo-bsc-nat/bsc_nat_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662/comment/15f60c7e_7ed8ed91 PS6, Line 129: ss7_inst_free(bsc_nat->cn); > looks like we want to set the pointers to NULL here after freeing. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I7d52fa649c397582b18a1a7dcc40bb407f3b2c97 Gerrit-Change-Number: 26662 Gerrit-PatchSet: 7 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 24 Jan 2022 09:27:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2022