January 2022 - gerrit-log - lists.osmocom.org

Change in simtrace2[master]: cosmetic: contrib/simtrace.lua: more consistent formatting

by fixeria

Attention is currently required from: Hoernchen, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26977 ) Change subject: cosmetic: contrib/simtrace.lua: more consistent formatting ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26977 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: If842dd95c7244ebe33579ed104247c66682ed4d4 Gerrit-Change-Number: 26977 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 25 Jan 2022 18:53:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in simtrace2[master]: contrib/simtrace.lue: Add VID/PID of all currentl simtrace2 devices

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26976 ) Change subject: contrib/simtrace.lue: Add VID/PID of all currentl simtrace2 devices ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/simtrace2/+/26976/comment/6c32d746_99d56c6e PS1, Line 7: lue lua -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26976 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Ie425f8dbd3a02c6bdcdaeaafaf0d5b4fb351ec4d Gerrit-Change-Number: 26976 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 25 Jan 2022 18:52:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in docker-playground[master]: ttcn3-bsc-test/jenkins.sh: fix '--ulimit core=-1' set twice

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26987 ) Change subject: ttcn3-bsc-test/jenkins.sh: fix '--ulimit core=-1' set twice ...................................................................... ttcn3-bsc-test/jenkins.sh: fix '--ulimit core=-1' set twice Change-Id: I3223f8f4cc09797de44971215a94fc62ad8d263b --- M ttcn3-bsc-test/jenkins.sh 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/87/26987/1 diff --git a/ttcn3-bsc-test/jenkins.sh b/ttcn3-bsc-test/jenkins.sh index 7f05c5e..fd9046c 100755 --- a/ttcn3-bsc-test/jenkins.sh +++ b/ttcn3-bsc-test/jenkins.sh @@ -32,7 +32,6 @@ --ulimit core=-1 \ -v $VOL_BASE_DIR/stp:/data \ --name ${BUILD_TAG}-stp -d \ - --ulimit core=-1 \ $DOCKER_ARGS \ $REPO_USER/osmo-stp-$IMAGE_SUFFIX -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26987 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I3223f8f4cc09797de44971215a94fc62ad8d263b Gerrit-Change-Number: 26987 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 5 months

1
0
0 0

Change in simtrace2[master]: contrib/simtrace.lua: Don't print SIMTRACE_MSGT_ in every COL_INFO

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/26986 ) Change subject: contrib/simtrace.lua: Don't print SIMTRACE_MSGT_ in every COL_INFO ...................................................................... contrib/simtrace.lua: Don't print SIMTRACE_MSGT_ in every COL_INFO this is redundant. We care about *which* message type, and not about wasting horizontal screen real-estate. Change-Id: I98f90561b39401f1c2339f79a3cb40574bb03b2d --- M contrib/simtrace.lua 1 file changed, 16 insertions(+), 16 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/86/26986/1 diff --git a/contrib/simtrace.lua b/contrib/simtrace.lua index 0a2d0ec..eb2de80 100644 --- a/contrib/simtrace.lua +++ b/contrib/simtrace.lua @@ -13,26 +13,26 @@ [0x0001] = "SIMTRACE_CMD_BD_BOARD_INFO", -- /* SIMTRACE_MSGC_CARDEM */ -[0x0101] = "SIMTRACE_MSGT_DT_CEMU_TX_DATA", -[0x0102] = "SIMTRACE_MSGT_DT_CEMU_SET_ATR", -[0x0103] = "SIMTRACE_MSGT_BD_CEMU_STATS", -[0x0104] = "SIMTRACE_MSGT_BD_CEMU_STATUS", -[0x0105] = "SIMTRACE_MSGT_DT_CEMU_CARDINSERT", -[0x0106] = "SIMTRACE_MSGT_DO_CEMU_RX_DATA", -[0x0107] = "SIMTRACE_MSGT_DO_CEMU_PTS", -[0x0108] = "SIMTRACE_MSGT_BD_CEMU_CONFIG", +[0x0101] = "DT_CEMU_TX_DATA", +[0x0102] = "DT_CEMU_SET_ATR", +[0x0103] = "BD_CEMU_STATS", +[0x0104] = "BD_CEMU_STATUS", +[0x0105] = "DT_CEMU_CARDINSERT", +[0x0106] = "DO_CEMU_RX_DATA", +[0x0107] = "DO_CEMU_PTS", +[0x0108] = "BD_CEMU_CONFIG", -- /* SIMTRACE_MSGC_MODEM */ -[0x0201] = "SIMTRACE_MSGT_DT_MODEM_RESET", -[0x0202] = "SIMTRACE_MSGT_DT_MODEM_SIM_SELECT", -[0x0203] = "SIMTRACE_MSGT_BD_MODEM_STATUS", +[0x0201] = "DT_MODEM_RESET", +[0x0202] = "DT_MODEM_SIM_SELECT", +[0x0203] = "BD_MODEM_STATUS", -- /* SIMTRACE_MSGC_SNIFF */ -[0x0300] = "SIMTRACE_MSGT_SNIFF_CHANGE", -[0x0301] = "SIMTRACE_MSGT_SNIFF_FIDI", -[0x0302] = "SIMTRACE_MSGT_SNIFF_ATR", -[0x0304] = "SIMTRACE_MSGT_SNIFF_TPDU", -[0x0303] = "SIMTRACE_MSGT_SNIFF_PPS" +[0x0300] = "SNIFF_CHANGE", +[0x0301] = "SNIFF_FIDI", +[0x0302] = "SNIFF_ATR", +[0x0304] = "SNIFF_TPDU", +[0x0303] = "SNIFF_PPS" } local msgtype = ProtoField.uint16("usb_simtrace.msgtype", "Message Type", base.HEX_DEC, control_commands) -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26986 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I98f90561b39401f1c2339f79a3cb40574bb03b2d Gerrit-Change-Number: 26986 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 years, 5 months

1
0
0 0

Change in simtrace2[master]: contrib/simtrace.lua: print length + slot-number in decimal only

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/26984 ) Change subject: contrib/simtrace.lua: print length + slot-number in decimal only ...................................................................... contrib/simtrace.lua: print length + slot-number in decimal only Change-Id: Ia9a969b88170c49f8bb1cb0cda6918d6a894d3ba --- M contrib/simtrace.lua 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/84/26984/1 diff --git a/contrib/simtrace.lua b/contrib/simtrace.lua index d05ff0a..c5bdafb 100644 --- a/contrib/simtrace.lua +++ b/contrib/simtrace.lua @@ -36,17 +36,17 @@ } local msgtype = ProtoField.uint16("usb_simtrace.msgtype", "Message Type", base.HEX_DEC, control_commands) -local seqnr = ProtoField.uint8("usb_simtrace.seqnr", "Sequence Number", base.HEX_DEC) -local slotnr = ProtoField.uint8("usb_simtrace.slotnr", "Slot Number", base.HEX_DEC) +local seqnr = ProtoField.uint8("usb_simtrace.seqnr", "Sequence Number", base.DEC) +local slotnr = ProtoField.uint8("usb_simtrace.slotnr", "Slot Number", base.DEC) local reserved = ProtoField.uint16("usb_simtrace.reserved", "reserved", base.HEX_DEC) -local payloadlen = ProtoField.uint16("usb_simtrace.length", "length", base.HEX_DEC) +local payloadlen = ProtoField.uint16("usb_simtrace.length", "length", base.DEC) local payload = ProtoField.bytes("usb_simtrace.payload", "Data") local pb_and_rx = ProtoField.uint32("usb_simtrace.pb_and_rx", "pb_and_rx", base.HEX_DEC, NULL, 0x8) local pb_and_tx = ProtoField.uint32("usb_simtrace.pb_and_tx", "pb_and_tx", base.HEX_DEC, NULL, 0x4) local final = ProtoField.uint32("usb_simtrace.final", "final", base.HEX_DEC, NULL, 0x2) local tpdu_hdr = ProtoField.uint32("usb_simtrace.tpdu_hdr", "tpdu_hdr", base.HEX_DEC, NULL, 0x1) -local rxtxdatalen = ProtoField.uint16("usb_simtrace.rxtxdatalen", "rx/tx data length", base.HEX_DEC) +local rxtxdatalen = ProtoField.uint16("usb_simtrace.rxtxdatalen", "rx/tx data length", base.DEC) local rxtxdata = ProtoField.bytes("usb_simtrace.rxtxdata", "rx/tx (data)") local CEMU_STATUS_F_VCC_PRESENT = ProtoField.uint32("usb_simtrace.CEMU_STATUS.F_VCC_PRESENT", "VCC_PRESENT", base.HEX_DEC, NULL, 0x00000001) -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26984 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Ia9a969b88170c49f8bb1cb0cda6918d6a894d3ba Gerrit-Change-Number: 26984 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 years, 5 months

1
0
0 0

Change in simtrace2[master]: contrib/simtrace.lua: Add Flag bits + Data to COL_INFO

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/26985 ) Change subject: contrib/simtrace.lua: Add Flag bits + Data to COL_INFO ...................................................................... contrib/simtrace.lua: Add Flag bits + Data to COL_INFO this provides an esy way to understand more without looking at the detailed decode for each packet. Change-Id: I0aa3d68172022907fbe8371aaca6538df0649dfe --- M contrib/simtrace.lua 1 file changed, 24 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/85/26985/1 diff --git a/contrib/simtrace.lua b/contrib/simtrace.lua index c5bdafb..0a2d0ec 100644 --- a/contrib/simtrace.lua +++ b/contrib/simtrace.lua @@ -89,6 +89,30 @@ headerSubtree:add(rxtxdatalen, len) headerSubtree:add_le(rxtxdata, payload_data(6,len)) + local flagstr = " " + if is_pbrx().value == 1 then + flagstr = flagstr .. "R" + else + flagstr = flagstr .. "." + end + if is_pbtx().value == 1 then + flagstr = flagstr .. "T" + else + flagstr = flagstr .. "." + end + if is_final().value == 1 then + flagstr = flagstr .. "F" + else + flagstr = flagstr .. "." + end + if is_hdr().value == 1 then + flagstr = flagstr .. "H" + else + flagstr = flagstr .. "." + end + flagstr = flagstr .. " " + pinfo.cols.info:append(flagstr .. payload_data(6,len)) + -- ghetto dissection does not work due to mixed in procedure bytes --if pinfo.visited == false then -- Dissector.get("iso7816"):call(payload_data(6):tvb(), pinfo, tree) -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26985 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I0aa3d68172022907fbe8371aaca6538df0649dfe Gerrit-Change-Number: 26985 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 years, 5 months

1
0
0 0

Change in docker-playground[master]: osmo-uecups-master: add more complete osmo-uecups-daemon.cfg

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26983 ) Change subject: osmo-uecups-master: add more complete osmo-uecups-daemon.cfg ...................................................................... osmo-uecups-master: add more complete osmo-uecups-daemon.cfg Change-Id: I16e3f60485039efd3b965009608982c27511b680 Related: SYS#5602 --- M osmo-uecups-master/osmo-uecups-daemon.cfg 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/83/26983/1 diff --git a/osmo-uecups-master/osmo-uecups-daemon.cfg b/osmo-uecups-master/osmo-uecups-daemon.cfg index e69de29..9f63bb7 100644 --- a/osmo-uecups-master/osmo-uecups-daemon.cfg +++ b/osmo-uecups-master/osmo-uecups-daemon.cfg @@ -0,0 +1,15 @@ +log stderr + logging filter all 1 + logging print extended-timestamp 1 + logging print file basename last + logging print category-hex 0 + logging print category 1 + logging print level 1 + logging timestamp 1 + logging color 0 +! + logging level set-all info +line vty + bind 0.0.0.0 +uecups + local-ip 0.0.0.0 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26983 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I16e3f60485039efd3b965009608982c27511b680 Gerrit-Change-Number: 26983 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 5 months

1
0
0 0

Change in docker-playground[master]: osmo-uecups-master/Dockerfile: fix copy-pasted ARG OSMO_BSC_BRANCH

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26981 ) Change subject: osmo-uecups-master/Dockerfile: fix copy-pasted ARG OSMO_BSC_BRANCH ...................................................................... osmo-uecups-master/Dockerfile: fix copy-pasted ARG OSMO_BSC_BRANCH Change-Id: Id713ddd24b7ba674d1a2035a0b3b62b1b9d26d9e Related: SYS#5602 --- M osmo-uecups-master/Dockerfile 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/81/26981/1 diff --git a/osmo-uecups-master/Dockerfile b/osmo-uecups-master/Dockerfile index deaedc7..e8767d1 100644 --- a/osmo-uecups-master/Dockerfile +++ b/osmo-uecups-master/Dockerfile @@ -16,14 +16,14 @@ WORKDIR /tmp -ARG OSMO_BSC_BRANCH="master" +ARG OSMO_UECUPS_BRANCH="master" RUN git clone git://git.osmocom.org/osmo-uecups.git -ADD http://git.osmocom.org/osmo-uecups/patch?h=$OSMO_BSC_BRANCH /tmp/commit-osmo-uecups +ADD http://git.osmocom.org/osmo-uecups/patch?h=$OSMO_UECUPS_BRANCH /tmp/commit-osmo-uecups RUN cd osmo-uecups && \ - git fetch && git checkout $OSMO_BSC_BRANCH && \ - (git symbolic-ref -q HEAD && git reset --hard origin/$OSMO_BSC_BRANCH || exit 1); \ + git fetch && git checkout $OSMO_UECUPS_BRANCH && \ + (git symbolic-ref -q HEAD && git reset --hard origin/$OSMO_UECUPS_BRANCH || exit 1); \ git rev-parse --abbrev-ref HEAD && git rev-parse HEAD && \ autoreconf -fi && \ ./configure && \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26981 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Id713ddd24b7ba674d1a2035a0b3b62b1b9d26d9e Gerrit-Change-Number: 26981 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 5 months

1
0
0 0

Change in docker-playground[master]: osmo-uecups-master/Dockerfile: do not pass command like options

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26982 ) Change subject: osmo-uecups-master/Dockerfile: do not pass command like options ...................................................................... osmo-uecups-master/Dockerfile: do not pass command like options Change-Id: Ia9b220e4cfbc89b800fafdd153bd63d6d95799e2 Related: SYS#5602 --- M osmo-uecups-master/Dockerfile 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/82/26982/1 diff --git a/osmo-uecups-master/Dockerfile b/osmo-uecups-master/Dockerfile index e8767d1..157e7f8 100644 --- a/osmo-uecups-master/Dockerfile +++ b/osmo-uecups-master/Dockerfile @@ -36,6 +36,8 @@ RUN useradd -m --uid=1000 osmocom WORKDIR /data -CMD ["/bin/sh", "-c", "/usr/local/bin/osmo-uecups-daemon -c /data/osmo-uecups-daemon.cfg >/data/osmo-uecups-daemon.log 2>&1"] + # osmo-uecups-daemon has no command like options, it simply expects + # osmo-uecups-daemon.cfg to be present in the current directory. +CMD ["/bin/sh", "-c", "/usr/local/bin/osmo-uecups-daemon >/data/osmo-uecups-daemon.log 2>&1"] #EXPOSE -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26982 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ia9b220e4cfbc89b800fafdd153bd63d6d95799e2 Gerrit-Change-Number: 26982 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 5 months

1
0
0 0

Change in docker-playground[master]: ttcn3-pgw-test: set '--ulimit core=-1' for osmo-uecups-daemon

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26980 ) Change subject: ttcn3-pgw-test: set '--ulimit core=-1' for osmo-uecups-daemon ...................................................................... ttcn3-pgw-test: set '--ulimit core=-1' for osmo-uecups-daemon Change-Id: I16f4eefa2bb48486c139ca63f2a48346f0532a8c Related: SYS#5602 --- M ttcn3-pgw-test/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/80/26980/1 diff --git a/ttcn3-pgw-test/jenkins.sh b/ttcn3-pgw-test/jenkins.sh index ffce1d1..0f6ee5d 100755 --- a/ttcn3-pgw-test/jenkins.sh +++ b/ttcn3-pgw-test/jenkins.sh @@ -62,6 +62,7 @@ --sysctl net.ipv6.conf.all.disable_ipv6=0 \ --rm \ $(docker_network_params $SUBNET 20) \ + --ulimit core=-1 \ -v $VOL_BASE_DIR/osmo-uecups:/data \ -e "WORKDIR=/data" \ --name ${BUILD_TAG}-uecups -d \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26980 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I16f4eefa2bb48486c139ca63f2a48346f0532a8c Gerrit-Change-Number: 26980 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2022