January 2022 - gerrit-log - lists.osmocom.org

Change in docker-playground[master]: ttcn3-pgw-test: add Dockerfile, jenkins.sh and configs for open5gs

by fixeria

fixeria has uploaded a new patch set (#5) to the change originally created by laforge. ( https://gerrit.osmocom.org/c/docker-playground/+/17953 ) Change subject: ttcn3-pgw-test: add Dockerfile, jenkins.sh and configs for open5gs ...................................................................... ttcn3-pgw-test: add Dockerfile, jenkins.sh and configs for open5gs Change-Id: I69e2f5be8204cc4fd0cc0f4eb019ef1104121b60 Tweaked-By: Vadim Yanitskiy <vyanitskiy(a)sysmocom.de> Related: SYS#5602 --- A ttcn3-pgw-test/Dockerfile A ttcn3-pgw-test/Makefile A ttcn3-pgw-test/PGW_Tests.cfg A ttcn3-pgw-test/freeDiameter-smf.conf A ttcn3-pgw-test/jenkins.sh A ttcn3-pgw-test/open5gs-nrf.yaml A ttcn3-pgw-test/open5gs-smf.yaml A ttcn3-pgw-test/open5gs-upf.yaml A ttcn3-pgw-test/osmo-uecups-daemon.cfg 9 files changed, 1,318 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/53/17953/5 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/17953 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I69e2f5be8204cc4fd0cc0f4eb019ef1104121b60 Gerrit-Change-Number: 17953 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 5 months

1
0
0 0

Change in docker-playground[master]: ttcn3-pgw-test: set '--ulimit core=-1' for open5gs-{nrf,upf,smf}

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26979 ) Change subject: ttcn3-pgw-test: set '--ulimit core=-1' for open5gs-{nrf,upf,smf} ...................................................................... ttcn3-pgw-test: set '--ulimit core=-1' for open5gs-{nrf,upf,smf} Change-Id: I2da2d502f339fc4cbea8fa72414eeaeb6078dfd9 Related: SYS#5602 --- M ttcn3-pgw-test/jenkins.sh 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/79/26979/1 diff --git a/ttcn3-pgw-test/jenkins.sh b/ttcn3-pgw-test/jenkins.sh index 4a41473..ffce1d1 100755 --- a/ttcn3-pgw-test/jenkins.sh +++ b/ttcn3-pgw-test/jenkins.sh @@ -23,6 +23,7 @@ # start container with open5gs-nrfd in background docker run --rm \ $(docker_network_params $SUBNET 10) \ + --ulimit core=-1 \ -v $VOL_BASE_DIR/pgw:/data \ --name ${BUILD_TAG}-nrf -d \ $DOCKER_ARGS \ @@ -35,6 +36,7 @@ --sysctl net.ipv6.conf.all.disable_ipv6=0 \ --rm \ $(docker_network_params $SUBNET 7) \ + --ulimit core=-1 \ -v $VOL_BASE_DIR/pgw:/data \ --name ${BUILD_TAG}-upf -d \ $DOCKER_ARGS \ @@ -47,6 +49,7 @@ --sysctl net.ipv6.conf.all.disable_ipv6=0 \ --rm \ $(docker_network_params $SUBNET 4) \ + --ulimit core=-1 \ -v $VOL_BASE_DIR/pgw:/data \ --name ${BUILD_TAG}-smf -d \ $DOCKER_ARGS \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26979 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I2da2d502f339fc4cbea8fa72414eeaeb6078dfd9 Gerrit-Change-Number: 26979 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 5 months

1
0
0 0

Change in simtrace2[master]: contrib/simtrace.lue: Add VID/PID of all currentl simtrace2 devices

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/26976 ) Change subject: contrib/simtrace.lue: Add VID/PID of all currentl simtrace2 devices ...................................................................... contrib/simtrace.lue: Add VID/PID of all currentl simtrace2 devices Change-Id: Ie425f8dbd3a02c6bdcdaeaafaf0d5b4fb351ec4d --- M contrib/simtrace.lua 1 file changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/76/26976/1 diff --git a/contrib/simtrace.lua b/contrib/simtrace.lua index efae492..83bc925 100644 --- a/contrib/simtrace.lua +++ b/contrib/simtrace.lua @@ -174,8 +174,11 @@ function usb_simtrace_protocol.init() local usb_product_dissectors = DissectorTable.get("usb.product") -usb_product_dissectors:add(0x1d50616d, usb_simtrace_protocol) -usb_product_dissectors:add(0x1d50616e, usb_simtrace_protocol) +usb_product_dissectors:add(0x1d50616d, usb_simtrace_protocol) -- OCTSIMTEST +usb_product_dissectors:add(0x1d50616e, usb_simtrace_protocol) -- NGFF_CARDEM +usb_product_dissectors:add(0x1d5060e3, usb_simtrace_protocol) -- SIMTRACE2 +usb_product_dissectors:add(0x1d504004, usb_simtrace_protocol) -- QMOD +usb_product_dissectors:add(0x1d504001, usb_simtrace_protocol) -- OWHW DissectorTable.get("usb.bulk"):add(0xffff, usb_simtrace_protocol) DissectorTable.get("usb.interrupt"):add(0xffff, usb_simtrace_protocol) --concatss = ByteArray.new() -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26976 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Ie425f8dbd3a02c6bdcdaeaafaf0d5b4fb351ec4d Gerrit-Change-Number: 26976 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 years, 5 months

1
0
0 0

Change in simtrace2[master]: cosmetic: contrib/simtrace.lua: more consistent formatting

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/26977 ) Change subject: cosmetic: contrib/simtrace.lua: more consistent formatting ...................................................................... cosmetic: contrib/simtrace.lua: more consistent formatting Change-Id: If842dd95c7244ebe33579ed104247c66682ed4d4 --- M contrib/simtrace.lua 1 file changed, 11 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/77/26977/1 diff --git a/contrib/simtrace.lua b/contrib/simtrace.lua index 83bc925..09ee9e6 100644 --- a/contrib/simtrace.lua +++ b/contrib/simtrace.lua @@ -160,11 +160,11 @@ if(command == 0x0101 or command == 0x0106) then return dissect_rxtx(payload_data(),pinfo,subtree) elseif(command == 0x0104) then - return dissect_status(payload_data(),pinfo,subtree) + return dissect_status(payload_data(),pinfo,subtree) elseif(command == 0x0102) then - return dissect_atr(payload_data(),pinfo,subtree) + return dissect_atr(payload_data(),pinfo,subtree) elseif(command == 0x0201) then - return dissect_modem_reset(payload_data(),pinfo,subtree) + return dissect_modem_reset(payload_data(),pinfo,subtree) else subtree:add(payload, payload_data) end @@ -173,13 +173,12 @@ function usb_simtrace_protocol.init() -local usb_product_dissectors = DissectorTable.get("usb.product") -usb_product_dissectors:add(0x1d50616d, usb_simtrace_protocol) -- OCTSIMTEST -usb_product_dissectors:add(0x1d50616e, usb_simtrace_protocol) -- NGFF_CARDEM -usb_product_dissectors:add(0x1d5060e3, usb_simtrace_protocol) -- SIMTRACE2 -usb_product_dissectors:add(0x1d504004, usb_simtrace_protocol) -- QMOD -usb_product_dissectors:add(0x1d504001, usb_simtrace_protocol) -- OWHW -DissectorTable.get("usb.bulk"):add(0xffff, usb_simtrace_protocol) -DissectorTable.get("usb.interrupt"):add(0xffff, usb_simtrace_protocol) ---concatss = ByteArray.new() + local usb_product_dissectors = DissectorTable.get("usb.product") + usb_product_dissectors:add(0x1d50616d, usb_simtrace_protocol) -- OCTSIMTEST + usb_product_dissectors:add(0x1d50616e, usb_simtrace_protocol) -- NGFF_CARDEM + usb_product_dissectors:add(0x1d5060e3, usb_simtrace_protocol) -- SIMTRACE2 + usb_product_dissectors:add(0x1d504004, usb_simtrace_protocol) -- QMOD + usb_product_dissectors:add(0x1d504001, usb_simtrace_protocol) -- OWHW + DissectorTable.get("usb.bulk"):add(0xffff, usb_simtrace_protocol) + DissectorTable.get("usb.interrupt"):add(0xffff, usb_simtrace_protocol) end -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26977 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: If842dd95c7244ebe33579ed104247c66682ed4d4 Gerrit-Change-Number: 26977 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 years, 5 months

1
0
0 0

Change in simtrace2[master]: contrib/simtrace.lua: Add header with author/description/usage

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/26978 ) Change subject: contrib/simtrace.lua: Add header with author/description/usage ...................................................................... contrib/simtrace.lua: Add header with author/description/usage Change-Id: I56574741cd77436f9f452420677c00d8049a50cc --- M contrib/simtrace.lua 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/78/26978/1 diff --git a/contrib/simtrace.lua b/contrib/simtrace.lua index 09ee9e6..d05ff0a 100644 --- a/contrib/simtrace.lua +++ b/contrib/simtrace.lua @@ -1,3 +1,9 @@ +-- wireshark LUA dissector for the SIMtrace USB protocol +-- (C) 2021 by sysmocom - s.f.m.c. GmbH, Author: Eric Wild +-- SPDX-License-Identifier: GPL-2.0+ +-- +-- Usage: Put this into your ~/.wireshark/init.lua [or include it from there] + usb_simtrace_protocol = Proto("USB_simtrace", "USB simtrace protocol") -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26978 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I56574741cd77436f9f452420677c00d8049a50cc Gerrit-Change-Number: 26978 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 years, 5 months

1
0
0 0

Change in libosmocore[master]: logging: log to stderr when logging is not initialized

by fixeria

Attention is currently required from: laforge, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26950 ) Change subject: logging: log to stderr when logging is not initialized ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26950 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9b1b0988e02322e3e44fd4ceea3e1bc2d4df3c45 Gerrit-Change-Number: 26950 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Jan 2022 17:18:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in simtrace2[master]: host: properly zero-initialize interface match structures

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26975 ) Change subject: host: properly zero-initialize interface match structures ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26975 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I304d55b584e37d9dccb75b24057bb682f799beb2 Gerrit-Change-Number: 26975 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 25 Jan 2022 17:02:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in libosmocore[master]: logging: log to stderr when logging is not initialized

by dexter

Attention is currently required from: laforge. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26950 ) Change subject: logging: log to stderr when logging is not initialized ...................................................................... Patch Set 4: (1 comment) File src/logging.c: https://gerrit.osmocom.org/c/libosmocore/+/26950/comment/d35f54f3_374c7206 PS2, Line 315: * Check whether the logging framework is initialized (osmo_log_info exists) */ : int log_initialized(void) : { : if (!osmo_log_info) : return 0; : return 1; : } > this is a non-inline function that does nothing else but exporting the value of an (already global, […] This variable is global, but I think its not exported. I have put it as extern variable in the header file now so that I can use it directly from the macros. I also thought of doing this, but I wasn't sure if it is was a good idea to expose osmo_log_info. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26950 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9b1b0988e02322e3e44fd4ceea3e1bc2d4df3c45 Gerrit-Change-Number: 26950 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 25 Jan 2022 16:57:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in libosmocore[master]: logging: log to stderr when logging is not initialized

by dexter

Attention is currently required from: laforge. Hello osmith, Jenkins Builder, laforge, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/26950 to look at the new patch set (#4). Change subject: logging: log to stderr when logging is not initialized ...................................................................... logging: log to stderr when logging is not initialized When the logging framework is not initialized we get an error: "ERROR: osmo_log_info == NULL! You must call log_init() before using logging in ..." There are sometimes situations where some code tries to log before logging was initialied. This is a problem because the actual log line with the debug info we need is covered up by the error message from the logging framework. Lets introduce a fallback logging function that is called when the the logging framework is not available. This function can just use fprintf to output to stderr. Change-Id: I9b1b0988e02322e3e44fd4ceea3e1bc2d4df3c45 --- M include/osmocom/core/logging.h M src/logging.c 2 files changed, 27 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/50/26950/4 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26950 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9b1b0988e02322e3e44fd4ceea3e1bc2d4df3c45 Gerrit-Change-Number: 26950 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

3 years, 5 months

1
0
0 0

Change in libosmocore[master]: logging: log to stderr when logging is not initialized

by dexter

Attention is currently required from: dexter. Hello osmith, Jenkins Builder, laforge, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/26950 to look at the new patch set (#3). Change subject: logging: log to stderr when logging is not initialized ...................................................................... logging: log to stderr when logging is not initialized When the logging framework is not initialized we get an error: "ERROR: osmo_log_info == NULL! You must call log_init() before using logging in ..." There are sometimes situations where some code tries to log before logging was initialied. This is a problem because the actual log line with the debug info we need is covered up by the error message from the logging framework. Lets introduce a fallback logging function that is called when the the logging framework is not available. This function can just use fprintf to output to stderr. Change-Id: I9b1b0988e02322e3e44fd4ceea3e1bc2d4df3c45 --- M include/osmocom/core/logging.h M src/logging.c 2 files changed, 33 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/50/26950/3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26950 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9b1b0988e02322e3e44fd4ceea3e1bc2d4df3c45 Gerrit-Change-Number: 26950 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2022