osmocom-commitlog November 2017

osmocom-commitlog@lists.osmocom.org

1 participants
196 discussions

osmo-hlr.git branch master updated. 0.1.0-10-gdb5dae6

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, master has been updated via db5dae6c991f9dc69203ca96e1a21715c95eb3cc (commit) from 38f08770a3a40cc90caf2879c9ff545a3e58f714 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-hlr/commit/?id=db5dae6c991f9dc69203ca96e1a2171… commit db5dae6c991f9dc69203ca96e1a21715c95eb3cc Author: Alexander Couzens <lynxis(a)fe80.eu> Date: Thu Nov 16 01:30:56 2017 +0100 debian: install osmo-hlr.cfg to /etc/osmocom Change-Id: Ifa1094da9b286a17a5c9a1ee300ec13a4a10a9a7 ----------------------------------------------------------------------- Summary of changes: debian/osmo-hlr.install | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- UNNAMED PROJECT

7 years, 7 months

osmo-hlr.git branch master updated. 0.1.0-9-g38f0877

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, master has been updated via 38f08770a3a40cc90caf2879c9ff545a3e58f714 (commit) from aee7be901bbc91ef63449595727a5096bb65c09b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-hlr/commit/?id=38f08770a3a40cc90caf2879c9ff545… commit 38f08770a3a40cc90caf2879c9ff545a3e58f714 Author: Alexander Couzens <lynxis(a)fe80.eu> Date: Thu Nov 16 01:01:09 2017 +0100 doc: install example .cfg files to $(docdir)/examples/ Change-Id: I8671ce33b9bf28c89f767dd1b4a1463aeb275158 ----------------------------------------------------------------------- Summary of changes: Makefile.am | 1 + configure.ac | 1 + debian/osmo-hlr.install | 1 + doc/Makefile.am | 22 ++++++++++++++++++++++ 4 files changed, 25 insertions(+) create mode 100644 doc/Makefile.am hooks/post-receive -- UNNAMED PROJECT

7 years, 7 months

libosmocore.git branch laforge/vty-node-exit-cb created. 0.10.2-13-gd38126ba

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, laforge/vty-node-exit-cb has been created at d38126ba403bd73f50f903b35207143fbf12424c (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=d38126ba403bd73f50f903b35207… commit d38126ba403bd73f50f903b35207143fbf12424c Author: Harald Welte <laforge(a)gnumonks.org> Date: Fri Nov 17 14:07:52 2017 +0100 WIP: Add vty_node exit callback This way an application (or library) implementing a VTY node can register an exit call-back that is called every time the node is exit-ed, e.g. to apply any configuration changes, to verify their consistency, or the like. THIS BREAKS ABI so don't merge it without increasing LIBVER major Change-Id: I9c917955e9569d22048449763b3ac6c770b58b58 ----------------------------------------------------------------------- hooks/post-receive -- An utility library for Open Source Mobile Communications

7 years, 7 months

libosmocore.git branch master updated. 0.10.2-12-gb93f60f7

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via b93f60f7cd4bebbe6c26a456ea0b394fcafc731f (commit) from d0682108964fe7928e75e24c450637a62331ad9f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=b93f60f7cd4bebbe6c26a456ea0b… commit b93f60f7cd4bebbe6c26a456ea0b394fcafc731f Author: Harald Welte <laforge(a)gnumonks.org> Date: Fri Nov 17 11:41:34 2017 +0100 conv_acc: Our code requires SSSE3, not just SSE3 The accelerated convolutional decoder uses SSSE3 instructions such as PSIGNW (via _mm_sign_epi16) which go beyond what SSE3 offers. So let's make sure we use the right compiler flag (-mssse3) and also the right runtime check. Without this patch, we would use illegal instructions e.g. on Opteron Gen3 such as Opteron 2427, which are also used as build.opensuse.org build hosts (build31 through build36) where we wouldn't pass "make check" as a result. Change-Id: I2754164384109f2821fd98ffb48f625893f2923d Fixes: OS#2386 ----------------------------------------------------------------------- Summary of changes: configure.ac | 2 +- m4/ax_check_simd.m4 | 18 +++++++++--------- src/Makefile.am | 10 +++++----- src/conv_acc.c | 24 ++++++++++++------------ src/conv_acc_sse.c | 2 +- src/conv_acc_sse_avx.c | 2 +- 6 files changed, 29 insertions(+), 29 deletions(-) hooks/post-receive -- An utility library for Open Source Mobile Communications

7 years, 7 months

osmo-iuh.git branch master updated. 0.2.0-5-gdfc75df

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom code for Iuh interface". The branch, master has been updated via dfc75df19991954273c8b5e2eebe38f3d2503f00 (commit) from b0c650e7b03261b2d5ba5441eae528af0b7bba2f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-iuh/commit/?id=dfc75df19991954273c8b5e2eebe38f… commit dfc75df19991954273c8b5e2eebe38f3d2503f00 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Nov 16 09:47:08 2017 +0100 src/Makefile.am: drop unused COMMON_LDADD unused since change-id Ic6a645a93406670d58eb5edf5f2f2e1266168c92 "osmo-hnbgw: Avoid useless linking to libosmogsm and libsctp" Change-Id: I4241a1d84b54a77a6a6dad809f8ec921f45ba4bc ----------------------------------------------------------------------- Summary of changes: src/Makefile.am | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- Osmocom code for Iuh interface

7 years, 7 months

libosmocore.git branch neels/sanitize updated. 0.10.2-26-g467559c0

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, neels/sanitize has been updated discards a1b83e292a0f92158eb4eb76eb04e01ffe9f5f96 (commit) discards e10f427233f77e31c165bcf2742b3e47ef7410f1 (commit) discards d84d23fdeb792cfbe814b92756af1a82d2513954 (commit) discards a42a383e17f639021257f692faadfb0a8d703840 (commit) discards 83a25d7b49d5b31395e0f8fa4598f57ef2c613de (commit) discards 3f8083140af1570805d994d0d405957b64d5284a (commit) discards 6b50f8c21dc92f3fad2ea2bc62971efe08749fbf (commit) discards 865ef453152657b844be1c587f8883baa6a74b54 (commit) discards b583af90b52bcd90eb3188e7cf3031a511689e95 (commit) discards 252f1f2ca853b9498e9107dec5334ed4f4b01d38 (commit) discards f236a4cf60a6900f9282974f3d7a826e1d8775eb (commit) discards 6c891f1dada3a60edd00c94a5dd8e865c9c6c60a (commit) discards 860e1055027fcb9af9adf16017eab98cd5ca9eed (commit) discards 5984f1751cb27073a035e66680b4894e1b3e62b8 (commit) discards 8b148ab96c1663ef9f2501c7dc7942214f4ed5ab (commit) via 467559c0bde2d79d369dd6fae0676b6e6b9dfdc1 (commit) via 140ad0657e8cdcd650d5f23f917b9bc740cccec3 (commit) via d390a2cfcd30194a6d883ee55e57570b47aa0485 (commit) via c69a9f2724a3d79e061ef600ac186a93aac9d04a (commit) via d14112a98534350275b18af704267f05b20c32fa (commit) via 213e5185c321d626ea9f9b5d357b5c773fdb1eb5 (commit) via 6662784105e9cf7b6dbd0cce26e962388336d1aa (commit) via a6a0519b22ed28a90b26eb8ac9076067372fd07c (commit) via cbfdcddfa9b2cd0e8eab3a27a87d8d9e04c03dd5 (commit) via 1470b59d2031378fbdf9a70055f5a48343ae62b7 (commit) via 83b3afbf22491e8ae1e709e430326aef4bdbca68 (commit) via e311004eb40ecada318356955fd1e24e132a8649 (commit) via 3e098c78aaf81e1de92360fb99768587bcdb6929 (commit) via 0083c2433b03f47b95c1ac39c3ef6beaef051fd0 (commit) via a3584bf13467d79a681fbef8508759362e001986 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (a1b83e292a0f92158eb4eb76eb04e01ffe9f5f96) \ N -- N -- N (467559c0bde2d79d369dd6fae0676b6e6b9dfdc1) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=467559c0bde2d79d369dd6fae067… commit 467559c0bde2d79d369dd6fae0676b6e6b9dfdc1 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Fri Nov 17 00:15:44 2017 +0100 sercomm_test: sanitize: fix msgb mem leak This should fix the last current remaining sanitizer build failure in libosmocore regression tests. Helps fix sanitizer build on debian 9. Change-Id: I4d6dd7f4348675bc77d4df5a7a0ce41f12d4a043 http://cgit.osmocom.org/libosmocore/commit/?id=140ad0657e8cdcd650d5f23f917b… commit 140ad0657e8cdcd650d5f23f917b9bc740cccec3 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Nov 16 23:34:33 2017 +0100 tlv_put: guard against NULL val and 0 len For example encode_auth_info() from gsup.c calls msgb_tlv_put(msg, iei, 0, NULL) to put a tag and len with content data following later. However, this would cause a memcpy() from a NULL pointer, in tlv_put(). Allow passing NULL and len = 0 for cases like the above: If val is NULL, use memset(0) instead of memcpy(). If len is zero, do not copy nor memset anything. Hence make tlv_put() behave in a well-defined and valid way for any and all input args; no negative fallout is possible from this patch. Add proper API doc comment. Fixes a sanitizer build failure in gsup_test: ../../../../src/libosmocore/include/osmocom/gsm/tlv.h:99:2: runtime error: null pointer passed as argument 2, which is declared to never be null Helps fix sanitizer build on debian 9. Change-Id: I13dce9cd1228817890d3e81edeeb660c893c1d64 http://cgit.osmocom.org/libosmocore/commit/?id=d390a2cfcd30194a6d883ee55e57… commit d390a2cfcd30194a6d883ee55e57570b47aa0485 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Nov 16 22:31:57 2017 +0100 bssgp_fc_test: sanitize: free fc struct when done Helps fix sanitizer build on debian 9. Change-Id: I0ef95ee8185a4789f0732b9420243dda5104d181 http://cgit.osmocom.org/libosmocore/commit/?id=c69a9f2724a3d79e061ef600ac18… commit c69a9f2724a3d79e061ef600ac186a93aac9d04a Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Nov 16 22:32:36 2017 +0100 gprs_bssgp: bssgp_fc_in(): fix mem leak on queue overflow All successful and all error code paths of bssgp_fc_in() free the msgb, except the code path calling fc_enqueue() when the msg is dropped (due to queue being full, or failure to allocate). Callers could theoretically catch the -ENOSPC return value and discard the msgb. However, in other code paths, a callback's return value is returned, which is expected to free the msgb, so such callback would have to never return -ENOSPC when it freed the msgb. Much simpler semantics would be to free the msgb in every code path, no matter which kind of error occurred. Who is currently calling bssgp_fc_in and how do they handle the return value? - bssgp_fc_test.c ignores the return value (and hits a mem leak aka sanitizer build failure if the queue is full). - fc_timer_cb() ignores the return value. - bssgp_tx_dl_ud() returns the bssgp_fc_in() rc. - which is returned by a cascade of functions leading up to being returned, for example, by gprs_llgmm_reset(), which is usually called with ignored return code. At this point it is already fairly clear that bssgp_fc_in() should always free the msgb, since the callers don't seem to distinguish even between error or success, let alone between -ENOSPC or other errors. bssgp_fc_test: assert that no msgbs remain unfreed after the tests. Adjust expected results. Helps fix sanitizer build on debian 9. Change-Id: I00c62a104baeaad6a85883c380259c469aebf0df http://cgit.osmocom.org/libosmocore/commit/?id=d14112a98534350275b18af70426… commit d14112a98534350275b18af704267f05b20c32fa Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Nov 16 22:32:36 2017 +0100 bssgp_fc_test: sanitizer: free msgb context when done Print remaining msgbs when done, then free the entire tall_msgb_context. To be able to do that, call msgb_talloc_ctx_init() and use its return value. A subsequent patch will fix a known mem leak and add assertions for 0b in 1 blocks remaining in the tall_msgb_context. Helps fix sanitizer build on debian 9. Change-Id: I67d347ab2642b0bfc27b21b44231a7f3146ff641 http://cgit.osmocom.org/libosmocore/commit/?id=213e5185c321d626ea9f9b5d357b… commit 213e5185c321d626ea9f9b5d357b5c773fdb1eb5 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Nov 16 22:55:02 2017 +0100 bssgp_fc_test: clarify by outputting ok / failure messages The test fills up the queue / sends too large PDUs on purpose. Make that obvious by outputting returned errors in the expected output. Cosmetic: - fc_in()'s return value is ignored, hence don't return anything. - add comment. Change-Id: I57d6fce2515a65f6dd037e75af5397079215cb46 http://cgit.osmocom.org/libosmocore/commit/?id=6662784105e9cf7b6dbd0cce26e9… commit 6662784105e9cf7b6dbd0cce26e962388336d1aa Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Nov 16 22:29:38 2017 +0100 bssgp_fc_test: remove rounding to deciseconds Ever since this test was changed to use osmo_gettimeofday_override, the times it sees are exact every time and don't need rounding to pass the expected output. Change-Id: I4a9a5d31fc02eb55caf7ba9c141426d8115bb740 http://cgit.osmocom.org/libosmocore/commit/?id=a6a0519b22ed28a90b26eb8ac907… commit a6a0519b22ed28a90b26eb8ac9076067372fd07c Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Nov 16 18:31:57 2017 +0100 rate_ctr_group_alloc: use ctx; adjust stats_test Using the NULL context creates mem leaks that bother sanitizer builds. Allocating from the rate counter context allows cleaning up at the end of stats_test. Remove the comment concerning osmo-msc: one way to fix if the talloc becomes unexpected from this patch is to adjust the talloc expectations, another (preferred) way is to have no invalid rate counter names in osmo-msc. Change-Id: Ief9abfeb78b7706200bcc6aaa5dcb04fbeaa9b5b http://cgit.osmocom.org/libosmocore/commit/?id=cbfdcddfa9b2cd0e8eab3a27a87d… commit cbfdcddfa9b2cd0e8eab3a27a87d8d9e04c03dd5 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Nov 16 18:26:21 2017 +0100 stats_test: clarify talloc contexts Change-Id: I0eda27cd3e322fb43a825382b37185048ebcd509 http://cgit.osmocom.org/libosmocore/commit/?id=1470b59d2031378fbdf9a70055f5… commit 1470b59d2031378fbdf9a70055f5a48343ae62b7 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Nov 16 18:23:52 2017 +0100 rate_ctr: doc: explain intentional "mem leak" for mangled group names Change-Id: I35363c4c1fa0d62fd7fed40fe689487244248a3f http://cgit.osmocom.org/libosmocore/commit/?id=83b3afbf22491e8ae1e709e43032… commit 83b3afbf22491e8ae1e709e430326aef4bdbca68 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Nov 16 17:34:07 2017 +0100 gsm0808_test: sanitize: fix msgb memleak Helps fix sanitizer build on debian 9. Change-Id: I0097d63bbb4e7ee20eb4a8474f4fef32d39e625f http://cgit.osmocom.org/libosmocore/commit/?id=e311004eb40ecada318356955fd1… commit e311004eb40ecada318356955fd1e24e132a8649 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Nov 16 17:30:44 2017 +0100 gsm0408_test: sanitize: cleanup msgb Remove initial msgb talloc context creation: if we create a root ctx for msgb that all msgb are allocated in, we would in a final cleanup discard all msgbs, i.e. we would not verify that all msgb are cleaned up properly. If we create the msgb context and *don't* clean it up in the end, the sanitizer build fails because the context root is not cleaned up. Easiest is to actually allocate all msgb at NULL ctx, because then any msgb that aren't cleaned up properly would still linger, while we don't leave a root ctx that we need to clean up either. Helps fix sanitizer build on debian 9. Change-Id: I1f2d1d05c75bbf4d92787f9735083f18cdc90f6f http://cgit.osmocom.org/libosmocore/commit/?id=3e098c78aaf81e1de92360fb9976… commit 3e098c78aaf81e1de92360fb99768587bcdb6929 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Nov 16 16:25:08 2017 +0100 lapd_test: sanitize: fix msgb memleaks Helps fix sanitizer build on debian 9. Change-Id: I0add9eac7225db23bc02fc2aaee5f42258d34e25 http://cgit.osmocom.org/libosmocore/commit/?id=0083c2433b03f47b95c1ac39c3ef… commit 0083c2433b03f47b95c1ac39c3ef6beaef051fd0 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Nov 16 16:24:36 2017 +0100 abis_test: sanitize: fix msgb memleak Helps fix sanitizer build on debian 9. Change-Id: I69750d9cd2b8f30bfc6d2dfd9e62576e46989fab http://cgit.osmocom.org/libosmocore/commit/?id=a3584bf13467d79a681fbef85087… commit a3584bf13467d79a681fbef8508759362e001986 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Nov 16 16:24:04 2017 +0100 memleak: osmo_config_list_parse: getline() needs free also on error Helps fix sanitizer build on debian 9. Change-Id: Iddf0a6cc733cd81d5f6c1eb62fc079ad319db119 ----------------------------------------------------------------------- Summary of changes: hooks/post-receive -- An utility library for Open Source Mobile Communications

7 years, 7 months

libosmocore.git branch neels/sanitize updated. 0.10.2-26-ga1b83e29

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, neels/sanitize has been updated discards aa0b97fa090730e73d2b39630ca7103380078077 (commit) discards f3f44735ad0efc05b7128d8dac8ba3d28c2cf77e (commit) discards 167b3bcd7bcbc2f0d228b55068b71a2f11699bd8 (commit) discards 51bdbc4b9a2d27755d2ecd0eaabdd65e8d1ca36d (commit) discards 67f1e6e6e63c249009fb2a1173cb9e3d3f57e5d4 (commit) discards 77aa9ca1e211e6d9f20dd068af963b43c5f523b0 (commit) discards ee1e3f4892d9b483faf75a88c15c2c8ce64924ca (commit) discards ee0676a258ccc46cad6b9601e5e1f119791a8d2d (commit) discards 0d012e5e2b244d15e320af708ca9da01e60baddf (commit) discards 7edacb93eb16c328dc200bb2306087b2ab9d0594 (commit) discards 58ba554283093cfaa44135927008a8bab526264c (commit) discards 997403ea6ba40b1f5c32e19a9d1ed84d2a981b14 (commit) discards 0c8e11de8d889b2d116ccca700238a727d7b3fdf (commit) discards d250cfcb60f1e9bf21cb981ce07ef97b223ac184 (commit) discards f9781a87c6c131f6a20990986557ae4452c555f4 (commit) via a1b83e292a0f92158eb4eb76eb04e01ffe9f5f96 (commit) via e10f427233f77e31c165bcf2742b3e47ef7410f1 (commit) via d84d23fdeb792cfbe814b92756af1a82d2513954 (commit) via a42a383e17f639021257f692faadfb0a8d703840 (commit) via 83a25d7b49d5b31395e0f8fa4598f57ef2c613de (commit) via 3f8083140af1570805d994d0d405957b64d5284a (commit) via 6b50f8c21dc92f3fad2ea2bc62971efe08749fbf (commit) via 865ef453152657b844be1c587f8883baa6a74b54 (commit) via b583af90b52bcd90eb3188e7cf3031a511689e95 (commit) via 252f1f2ca853b9498e9107dec5334ed4f4b01d38 (commit) via f236a4cf60a6900f9282974f3d7a826e1d8775eb (commit) via 6c891f1dada3a60edd00c94a5dd8e865c9c6c60a (commit) via 860e1055027fcb9af9adf16017eab98cd5ca9eed (commit) via 5984f1751cb27073a035e66680b4894e1b3e62b8 (commit) via 8b148ab96c1663ef9f2501c7dc7942214f4ed5ab (commit) via d0682108964fe7928e75e24c450637a62331ad9f (commit) via c30a76b2d49265ba6b7ab9e1d684b507b3bfc5f4 (commit) via e2640ef763e1335d0eec590ceaeaa390428cfd51 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (aa0b97fa090730e73d2b39630ca7103380078077) \ N -- N -- N (a1b83e292a0f92158eb4eb76eb04e01ffe9f5f96) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=a1b83e292a0f92158eb4eb76eb04… commit a1b83e292a0f92158eb4eb76eb04e01ffe9f5f96 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Fri Nov 17 00:15:44 2017 +0100 sercomm_test: sanitizer: fix msgb mem leak This should fix the last current remaining sanitizer build failure in libosmocore regression tests. Change-Id: I4d6dd7f4348675bc77d4df5a7a0ce41f12d4a043 http://cgit.osmocom.org/libosmocore/commit/?id=e10f427233f77e31c165bcf2742b… commit e10f427233f77e31c165bcf2742b3e47ef7410f1 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Nov 16 23:34:33 2017 +0100 sanitizer: tlv_put: guard against NULL val and 0 len For example encode_auth_info() from gsup.c calls msgb_tlv_put(msg, iei, 0, NULL) to put a tag and len with content data following later. However, this would cause a memcpy() from a NULL pointer, in tlv_put(). Allow passing NULL and len = 0 for cases like the above: If val is NULL, use memset(0) instead of memcpy(). If len is zero, do not copy nor memset anything. Hence make tlv_put() behave in a well-defined and valid way for any and all input args; no negative fallout is possible from this patch. Add proper API doc comment. Fixes a sanitizer build failure in gsup_test: ../../../../src/libosmocore/include/osmocom/gsm/tlv.h:99:2: runtime error: null pointer passed as argument 2, which is declared to never be null Change-Id: I13dce9cd1228817890d3e81edeeb660c893c1d64 http://cgit.osmocom.org/libosmocore/commit/?id=d84d23fdeb792cfbe814b92756af… commit d84d23fdeb792cfbe814b92756af1a82d2513954 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Nov 16 22:31:57 2017 +0100 bssgp_fc_test: fix sanitizer build: free fc struct when done Change-Id: I0ef95ee8185a4789f0732b9420243dda5104d181 http://cgit.osmocom.org/libosmocore/commit/?id=a42a383e17f639021257f692faad… commit a42a383e17f639021257f692faadfb0a8d703840 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Nov 16 22:32:36 2017 +0100 gprs_bssgp: bssgp_fc_in(): fix mem leak on queue overflow All successful and all error code paths of bssgp_fc_in() free the msgb, except the code path calling fc_enqueue() when the msg is dropped (due to queue being full, or failure to allocate). Callers could theoretically catch the -ENOSPC return value and discard the msgb. However, in other code paths, a callback's return value is returned, which is expected to free the msgb, so such callback would have to never return -ENOSPC when it freed the msgb. Much simpler semantics would be to free the msgb in every code path, no matter which kind of error occurred. Who is currently calling bssgp_fc_in and how do they handle the return value? - bssgp_fc_test.c ignores the return value (and hits a mem leak aka sanitizer build failure if the queue is full). - fc_timer_cb() ignores the return value. - bssgp_tx_dl_ud() returns the bssgp_fc_in() rc. - which is returned by a cascade of functions leading up to being returned, for example, by gprs_llgmm_reset(), which is usually called with ignored return code. At this point it is already fairly clear that bssgp_fc_in() should always free the msgb, since the callers don't seem to distinguish even between error or success, let alone between -ENOSPC or other errors. bssgp_fc_test: assert that no msgbs remain unfreed after the tests. Adjust expected results. Helps to fix the sanitizer build of bssgp_fc_test by eliminating the mem leak. Change-Id: I00c62a104baeaad6a85883c380259c469aebf0df http://cgit.osmocom.org/libosmocore/commit/?id=83a25d7b49d5b31395e0f8fa4598… commit 83a25d7b49d5b31395e0f8fa4598f57ef2c613de Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Nov 16 22:32:36 2017 +0100 bssgp_fc_test: partly fix sanitizer build: free msgb context when done Print remaining msgbs when done, then free the entire tall_msgb_context. To be able to do that, call msgb_talloc_ctx_init() and use its return value. A subsequent patch will fix a known mem leak and add assertions for 0b in 1 blocks remaining in the tall_msgb_context. Change-Id: I67d347ab2642b0bfc27b21b44231a7f3146ff641 http://cgit.osmocom.org/libosmocore/commit/?id=3f8083140af1570805d994d0d405… commit 3f8083140af1570805d994d0d405957b64d5284a Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Nov 16 22:55:02 2017 +0100 bssgp_fc_test: clarify by outputting ok / failure messages The test fills up the queue / sends too large PDUs on purpose. Make that obvious by outputting returned errors in the expected output. Cosmetic: - fc_in()'s return value is ignored, hence don't return anything. - add comment. Change-Id: I57d6fce2515a65f6dd037e75af5397079215cb46 http://cgit.osmocom.org/libosmocore/commit/?id=6b50f8c21dc92f3fad2ea2bc6297… commit 6b50f8c21dc92f3fad2ea2bc62971efe08749fbf Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Nov 16 22:29:38 2017 +0100 bssgp_fc_test: remove rounding to deciseconds Ever since this test was changed to use osmo_gettimeofday_override, the times it sees are exact every time and don't need rounding to pass the expected output. Change-Id: I4a9a5d31fc02eb55caf7ba9c141426d8115bb740 http://cgit.osmocom.org/libosmocore/commit/?id=865ef453152657b844be1c587f88… commit 865ef453152657b844be1c587f8883baa6a74b54 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Nov 16 18:31:57 2017 +0100 rate_ctr_group_alloc: use ctx; adjust stats_test Using the NULL context creates mem leaks that bother sanitizer builds. Allocating from the rate counter context allows cleaning up at the end of stats_test. Remove the comment concerning osmo-msc: one way to fix if the talloc becomes unexpected from this patch is to adjust the talloc expectations, another (preferred) way is to have no invalid rate counter names in osmo-msc. Change-Id: Ief9abfeb78b7706200bcc6aaa5dcb04fbeaa9b5b http://cgit.osmocom.org/libosmocore/commit/?id=b583af90b52bcd90eb3188e7cf30… commit b583af90b52bcd90eb3188e7cf3031a511689e95 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Nov 16 18:26:21 2017 +0100 stats_test: clarify talloc contexts Change-Id: I0eda27cd3e322fb43a825382b37185048ebcd509 http://cgit.osmocom.org/libosmocore/commit/?id=252f1f2ca853b9498e9107dec533… commit 252f1f2ca853b9498e9107dec5334ed4f4b01d38 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Nov 16 18:23:52 2017 +0100 rate_ctr: doc: explain intentional "mem leak" for mangled group names Change-Id: I35363c4c1fa0d62fd7fed40fe689487244248a3f http://cgit.osmocom.org/libosmocore/commit/?id=f236a4cf60a6900f9282974f3d7a… commit f236a4cf60a6900f9282974f3d7a826e1d8775eb Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Nov 16 17:34:07 2017 +0100 gsm0808_test: fix memleak Change-Id: I0097d63bbb4e7ee20eb4a8474f4fef32d39e625f http://cgit.osmocom.org/libosmocore/commit/?id=6c891f1dada3a60edd00c94a5dd8… commit 6c891f1dada3a60edd00c94a5dd8e865c9c6c60a Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Nov 16 17:30:44 2017 +0100 gsm0408_test: fix sanitized build Remove initial msgb talloc context creation: if we create a root ctx for msgb that all msgb are allocated in, we would in a final cleanup discard all msgbs, i.e. we would not verify that all msgb are cleaned up properly. If we create the msgb context and *don't* clean it up in the end, the sanitizer build fails because the context root is not cleaned up. Easiest is to actually allocate all msgb at NULL ctx, because then any msgb that aren't cleaned up properly would still linger, while we don't leave a root ctx that we need to clean up either. Change-Id: I1f2d1d05c75bbf4d92787f9735083f18cdc90f6f http://cgit.osmocom.org/libosmocore/commit/?id=860e1055027fcb9af9adf16017ea… commit 860e1055027fcb9af9adf16017eab98cd5ca9eed Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Nov 16 16:25:08 2017 +0100 lapd_test: fix msgb memleaks Change-Id: I0add9eac7225db23bc02fc2aaee5f42258d34e25 http://cgit.osmocom.org/libosmocore/commit/?id=5984f1751cb27073a035e66680b4… commit 5984f1751cb27073a035e66680b4894e1b3e62b8 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Nov 16 16:24:36 2017 +0100 abis_test: test_sw_descr: fix msgb memleak Change-Id: I69750d9cd2b8f30bfc6d2dfd9e62576e46989fab http://cgit.osmocom.org/libosmocore/commit/?id=8b148ab96c1663ef9f2501c7dc79… commit 8b148ab96c1663ef9f2501c7dc7942214f4ed5ab Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Nov 16 16:24:04 2017 +0100 memleak: osmo_config_list_parse: getline() needs free also on error Change-Id: Iddf0a6cc733cd81d5f6c1eb62fc079ad319db119 ----------------------------------------------------------------------- Summary of changes: src/gsm/gsm_utils.c | 2 +- tests/Makefile.am | 1 + utils/osmo-auc-gen.c | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) hooks/post-receive -- An utility library for Open Source Mobile Communications

7 years, 7 months

libosmocore.git branch neels/sanitize created. 0.10.2-23-gaa0b97fa

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, neels/sanitize has been created at aa0b97fa090730e73d2b39630ca7103380078077 (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=aa0b97fa090730e73d2b39630ca7… commit aa0b97fa090730e73d2b39630ca7103380078077 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Fri Nov 17 00:15:44 2017 +0100 sercomm_test: sanitizer: fix msgb mem leak This should fix the last current remaining sanitizer build failure in libosmocore regression tests. Change-Id: I4d6dd7f4348675bc77d4df5a7a0ce41f12d4a043 http://cgit.osmocom.org/libosmocore/commit/?id=f3f44735ad0efc05b7128d8dac8b… commit f3f44735ad0efc05b7128d8dac8ba3d28c2cf77e Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Nov 16 23:34:33 2017 +0100 sanitizer: tlv_put: guard against NULL val and 0 len For example encode_auth_info() from gsup.c calls msgb_tlv_put(msg, iei, 0, NULL) to put a tag and len with content data following later. However, this would cause a memcpy() from a NULL pointer, in tlv_put(). Allow passing NULL and len = 0 for cases like the above: If val is NULL, use memset(0) instead of memcpy(). If len is zero, do not copy nor memset anything. Hence make tlv_put() behave in a well-defined and valid way for any and all input args; no negative fallout is possible from this patch. Add proper API doc comment. Fixes a sanitizer build failure in gsup_test: ../../../../src/libosmocore/include/osmocom/gsm/tlv.h:99:2: runtime error: null pointer passed as argument 2, which is declared to never be null Change-Id: I13dce9cd1228817890d3e81edeeb660c893c1d64 http://cgit.osmocom.org/libosmocore/commit/?id=167b3bcd7bcbc2f0d228b55068b7… commit 167b3bcd7bcbc2f0d228b55068b71a2f11699bd8 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Nov 16 22:31:57 2017 +0100 bssgp_fc_test: fix sanitizer build: free fc struct when done Change-Id: I0ef95ee8185a4789f0732b9420243dda5104d181 http://cgit.osmocom.org/libosmocore/commit/?id=51bdbc4b9a2d27755d2ecd0eaabd… commit 51bdbc4b9a2d27755d2ecd0eaabdd65e8d1ca36d Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Nov 16 22:32:36 2017 +0100 gprs_bssgp: bssgp_fc_in(): fix mem leak on queue overflow All successful and all error code paths of bssgp_fc_in() free the msgb, except the code path calling fc_enqueue() when the msg is dropped (due to queue being full, or failure to allocate). Callers could theoretically catch the -ENOSPC return value and discard the msgb. However, in other code paths, a callback's return value is returned, which is expected to free the msgb, so such callback would have to never return -ENOSPC when it freed the msgb. Much simpler semantics would be to free the msgb in every code path, no matter which kind of error occurred. Who is currently calling bssgp_fc_in and how do they handle the return value? - bssgp_fc_test.c ignores the return value (and hits a mem leak aka sanitizer build failure if the queue is full). - fc_timer_cb() ignores the return value. - bssgp_tx_dl_ud() returns the bssgp_fc_in() rc. - which is returned by a cascade of functions leading up to being returned, for example, by gprs_llgmm_reset(), which is usually called with ignored return code. At this point it is already fairly clear that bssgp_fc_in() should always free the msgb, since the callers don't seem to distinguish even between error or success, let alone between -ENOSPC or other errors. bssgp_fc_test: assert that no msgbs remain unfreed after the tests. Adjust expected results. Helps to fix the sanitizer build of bssgp_fc_test by eliminating the mem leak. Change-Id: I00c62a104baeaad6a85883c380259c469aebf0df http://cgit.osmocom.org/libosmocore/commit/?id=67f1e6e6e63c249009fb2a1173cb… commit 67f1e6e6e63c249009fb2a1173cb9e3d3f57e5d4 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Nov 16 22:32:36 2017 +0100 bssgp_fc_test: partly fix sanitizer build: free msgb context when done Print remaining msgbs when done, then free the entire tall_msgb_context. To be able to do that, call msgb_talloc_ctx_init() and use its return value. A subsequent patch will fix a known mem leak and add assertions for 0b in 1 blocks remaining in the tall_msgb_context. Change-Id: I67d347ab2642b0bfc27b21b44231a7f3146ff641 http://cgit.osmocom.org/libosmocore/commit/?id=77aa9ca1e211e6d9f20dd068af96… commit 77aa9ca1e211e6d9f20dd068af963b43c5f523b0 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Nov 16 22:55:02 2017 +0100 bssgp_fc_test: clarify by outputting ok / failure messages The test fills up the queue / sends too large PDUs on purpose. Make that obvious by outputting returned errors in the expected output. Cosmetic: - fc_in()'s return value is ignored, hence don't return anything. - add comment. Change-Id: I57d6fce2515a65f6dd037e75af5397079215cb46 http://cgit.osmocom.org/libosmocore/commit/?id=ee1e3f4892d9b483faf75a88c15c… commit ee1e3f4892d9b483faf75a88c15c2c8ce64924ca Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Nov 16 22:29:38 2017 +0100 bssgp_fc_test: remove rounding to deciseconds Ever since this test was changed to use osmo_gettimeofday_override, the times it sees are exact every time and don't need rounding to pass the expected output. Change-Id: I4a9a5d31fc02eb55caf7ba9c141426d8115bb740 http://cgit.osmocom.org/libosmocore/commit/?id=ee0676a258ccc46cad6b9601e5e1… commit ee0676a258ccc46cad6b9601e5e1f119791a8d2d Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Nov 16 18:31:57 2017 +0100 rate_ctr_group_alloc: use ctx; adjust stats_test Using the NULL context creates mem leaks that bother sanitizer builds. Allocating from the rate counter context allows cleaning up at the end of stats_test. Remove the comment concerning osmo-msc: one way to fix if the talloc becomes unexpected from this patch is to adjust the talloc expectations, another (preferred) way is to have no invalid rate counter names in osmo-msc. Change-Id: Ief9abfeb78b7706200bcc6aaa5dcb04fbeaa9b5b http://cgit.osmocom.org/libosmocore/commit/?id=0d012e5e2b244d15e320af708ca9… commit 0d012e5e2b244d15e320af708ca9da01e60baddf Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Nov 16 18:26:21 2017 +0100 stats_test: clarify talloc contexts Change-Id: I0eda27cd3e322fb43a825382b37185048ebcd509 http://cgit.osmocom.org/libosmocore/commit/?id=7edacb93eb16c328dc200bb23060… commit 7edacb93eb16c328dc200bb2306087b2ab9d0594 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Nov 16 18:23:52 2017 +0100 rate_ctr: doc: explain intentional "mem leak" for mangled group names Change-Id: I35363c4c1fa0d62fd7fed40fe689487244248a3f http://cgit.osmocom.org/libosmocore/commit/?id=58ba554283093cfaa44135927008… commit 58ba554283093cfaa44135927008a8bab526264c Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Nov 16 17:34:07 2017 +0100 gsm0808_test: fix memleak Change-Id: I0097d63bbb4e7ee20eb4a8474f4fef32d39e625f http://cgit.osmocom.org/libosmocore/commit/?id=997403ea6ba40b1f5c32e19a9d1e… commit 997403ea6ba40b1f5c32e19a9d1ed84d2a981b14 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Nov 16 17:30:44 2017 +0100 gsm0408_test: fix sanitized build Remove initial msgb talloc context creation: if we create a root ctx for msgb that all msgb are allocated in, we would in a final cleanup discard all msgbs, i.e. we would not verify that all msgb are cleaned up properly. If we create the msgb context and *don't* clean it up in the end, the sanitizer build fails because the context root is not cleaned up. Easiest is to actually allocate all msgb at NULL ctx, because then any msgb that aren't cleaned up properly would still linger, while we don't leave a root ctx that we need to clean up either. Change-Id: I1f2d1d05c75bbf4d92787f9735083f18cdc90f6f http://cgit.osmocom.org/libosmocore/commit/?id=0c8e11de8d889b2d116ccca70023… commit 0c8e11de8d889b2d116ccca700238a727d7b3fdf Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Nov 16 16:25:08 2017 +0100 lapd_test: fix msgb memleaks Change-Id: I0add9eac7225db23bc02fc2aaee5f42258d34e25 http://cgit.osmocom.org/libosmocore/commit/?id=d250cfcb60f1e9bf21cb981ce07e… commit d250cfcb60f1e9bf21cb981ce07ef97b223ac184 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Nov 16 16:24:36 2017 +0100 abis_test: test_sw_descr: fix msgb memleak Change-Id: I69750d9cd2b8f30bfc6d2dfd9e62576e46989fab http://cgit.osmocom.org/libosmocore/commit/?id=f9781a87c6c131f6a20990986557… commit f9781a87c6c131f6a20990986557ae4452c555f4 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Nov 16 16:24:04 2017 +0100 memleak: osmo_config_list_parse: getline() needs free also on error Change-Id: Iddf0a6cc733cd81d5f6c1eb62fc079ad319db119 ----------------------------------------------------------------------- hooks/post-receive -- An utility library for Open Source Mobile Communications

7 years, 7 months

libosmocore.git branch master updated. 0.10.2-11-gd0682108

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via d0682108964fe7928e75e24c450637a62331ad9f (commit) from c30a76b2d49265ba6b7ab9e1d684b507b3bfc5f4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=d0682108964fe7928e75e24c4506… commit d0682108964fe7928e75e24c450637a62331ad9f Author: Harald Welte <laforge(a)gnumonks.org> Date: Thu Nov 16 17:49:38 2017 +0100 Print /proc/cpuinfo before executing testsuite The testsuite fails on some specific build machines in the OBS build cluster. Let's try to figure out which CPU flags they have to narrow down the cause of this. Change-Id: Ib23e5bfb3c894206fad62d6cc6151583b1bb75a6 ----------------------------------------------------------------------- Summary of changes: tests/Makefile.am | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- An utility library for Open Source Mobile Communications

7 years, 7 months

libosmocore.git branch master updated. 0.10.2-10-gc30a76b2

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via c30a76b2d49265ba6b7ab9e1d684b507b3bfc5f4 (commit) from e2640ef763e1335d0eec590ceaeaa390428cfd51 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=c30a76b2d49265ba6b7ab9e1d684… commit c30a76b2d49265ba6b7ab9e1d684b507b3bfc5f4 Author: Pau Espin Pedrol <pespin(a)sysmocom.de> Date: Thu Nov 16 16:37:55 2017 +0100 utils: Fix false positive in compiler warning Fixes the warning below: warning: ‘sqn’ may be used uninitialized in this function [-Wmaybe-uninitialized] fprintf(stderr, "Requesting --sqn %"PRIu64" implies IND=%u," ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ " so no further --ind argument is allowed.\n", ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sqn, test_aud.u.umts.ind); ~~~~~~~~~~~~~~~~~~~~~~~~~ The warning is a false positive as sqn is only used in case sqn_is_set!=0, and in that code path, sqn is set. Change-Id: Ib5903db01ea6765bd6bb688e63f70925c5012f98 ----------------------------------------------------------------------- Summary of changes: utils/osmo-auc-gen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- An utility library for Open Source Mobile Communications

7 years, 7 months

← Newer
1
...
7
8
9
10
11
12
13
...
20
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

osmocom-commitlog November 2017