osmocom-commitlog November 2017

osmocom-commitlog@lists.osmocom.org

1 participants
196 discussions

libosmo-netif.git branch master updated. 0.1.1-9-gc72be77

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom network interface library". The branch, master has been updated via c72be77aa330c968f9f1d624e38141b3c2e24323 (commit) from b6e8d39417b217e9bbf396d50c3ef2a91a6c4054 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmo-netif/commit/?id=c72be77aa330c968f9f1d624e3… commit c72be77aa330c968f9f1d624e38141b3c2e24323 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Fri Nov 17 03:29:51 2017 +0100 osmo_stream_{cli,srv}_destroy: fix mem leak: empty msgb queue On destroying a client or server stream, deallocate any msgbs that are still pending in the queue. In libosmo-sccp, the ss7_test.c in test_as(), messages are queued and were, before this, left floating after the stream was destroyed, causing a sanitizer memory leak. This patch fixes the leak. Depends: Ia291832ca445d4071f0ed9a01730d945ff691cf7 (libosmocore) Change-Id: Iaad35f03e3bdfabf3ba82b16e563c0a5d1f03639 ----------------------------------------------------------------------- Summary of changes: src/stream.c | 2 ++ 1 file changed, 2 insertions(+) hooks/post-receive -- Osmocom network interface library

7 years, 7 months

libosmocore.git branch master updated. 0.10.2-27-gfe1ed398

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via fe1ed39846c6537ebfe19d22500ee2e38587c143 (commit) via e750980d6c89cf7052daa62745366a743badd384 (commit) via 85f5a2cd9c46ffd165f9244b4e219bfc03aa5e0e (commit) via cd325efae564384c74b4af6163303ddc81c7a3c1 (commit) via 0128c78ffe25196f53fbbc0884a9c4587f493224 (commit) via 9541a683780d23b260c5c0f6b9a9572a7ac16a66 (commit) via 568f8e20175a21da4e4537a2f5a4f7fedec8c6d6 (commit) from 10ee73a7b39b2867fde2a827b199f6264149c75c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=fe1ed39846c6537ebfe19d22500e… commit fe1ed39846c6537ebfe19d22500ee2e38587c143 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Fri Nov 17 00:15:44 2017 +0100 sercomm_test: sanitize: fix msgb mem leak This should fix the last current remaining sanitizer build failure in libosmocore regression tests. Helps fix sanitizer build on debian 9. Change-Id: I4d6dd7f4348675bc77d4df5a7a0ce41f12d4a043 http://cgit.osmocom.org/libosmocore/commit/?id=e750980d6c89cf7052daa6274536… commit e750980d6c89cf7052daa62745366a743badd384 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Nov 16 23:34:33 2017 +0100 tlv_put: guard against NULL val and 0 len For example encode_auth_info() from gsup.c calls msgb_tlv_put(msg, iei, 0, NULL) to put a tag and len with content data following later. However, this would cause a memcpy() from a NULL pointer, in tlv_put(). Allow passing NULL and len = 0 for cases like the above: If val is NULL, use memset(0) instead of memcpy(). If len is zero, do not copy nor memset anything. Hence make tlv_put() behave in a well-defined and valid way for any and all input args; no negative fallout is possible from this patch. Add proper API doc comment. Fixes a sanitizer build failure in gsup_test: ../../../../src/libosmocore/include/osmocom/gsm/tlv.h:99:2: runtime error: null pointer passed as argument 2, which is declared to never be null Helps fix sanitizer build on debian 9. Change-Id: I13dce9cd1228817890d3e81edeeb660c893c1d64 http://cgit.osmocom.org/libosmocore/commit/?id=85f5a2cd9c46ffd165f9244b4e21… commit 85f5a2cd9c46ffd165f9244b4e219bfc03aa5e0e Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Nov 16 22:31:57 2017 +0100 bssgp_fc_test: sanitize: free fc struct when done Helps fix sanitizer build on debian 9. Change-Id: I0ef95ee8185a4789f0732b9420243dda5104d181 http://cgit.osmocom.org/libosmocore/commit/?id=cd325efae564384c74b4af616330… commit cd325efae564384c74b4af6163303ddc81c7a3c1 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Nov 16 22:32:36 2017 +0100 gprs_bssgp: bssgp_fc_in(): fix mem leak on queue overflow All successful and all error code paths of bssgp_fc_in() free the msgb, except the code path calling fc_enqueue() when the msg is dropped (due to queue being full, or failure to allocate). Callers could theoretically catch the -ENOSPC return value and discard the msgb. However, in other code paths, a callback's return value is returned, which is expected to free the msgb, so such callback would have to never return -ENOSPC when it freed the msgb. Much simpler semantics would be to free the msgb in every code path, no matter which kind of error occurred. Who is currently calling bssgp_fc_in and how do they handle the return value? - bssgp_fc_test.c ignores the return value (and hits a mem leak aka sanitizer build failure if the queue is full). - fc_timer_cb() ignores the return value. - bssgp_tx_dl_ud() returns the bssgp_fc_in() rc. - which is returned by a cascade of functions leading up to being returned, for example, by gprs_llgmm_reset(), which is usually called with ignored return code. At this point it is already fairly clear that bssgp_fc_in() should always free the msgb, since the callers don't seem to distinguish even between error or success, let alone between -ENOSPC or other errors. bssgp_fc_test: assert that no msgbs remain unfreed after the tests. Adjust expected results. Helps fix sanitizer build on debian 9. Change-Id: I00c62a104baeaad6a85883c380259c469aebf0df http://cgit.osmocom.org/libosmocore/commit/?id=0128c78ffe25196f53fbbc0884a9… commit 0128c78ffe25196f53fbbc0884a9c4587f493224 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Nov 16 22:32:36 2017 +0100 bssgp_fc_test: sanitizer: free msgb context when done Print remaining msgbs when done, then free the entire tall_msgb_context. To be able to do that, call msgb_talloc_ctx_init() and use its return value. A subsequent patch will fix a known mem leak and add assertions for 0b in 1 blocks remaining in the tall_msgb_context. Helps fix sanitizer build on debian 9. Change-Id: I67d347ab2642b0bfc27b21b44231a7f3146ff641 http://cgit.osmocom.org/libosmocore/commit/?id=9541a683780d23b260c5c0f6b9a9… commit 9541a683780d23b260c5c0f6b9a9572a7ac16a66 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Nov 16 22:55:02 2017 +0100 bssgp_fc_test: clarify by outputting ok / failure messages The test fills up the queue / sends too large PDUs on purpose. Make that obvious by outputting returned errors in the expected output. Cosmetic: - fc_in()'s return value is ignored, hence don't return anything. - add comment. Change-Id: I57d6fce2515a65f6dd037e75af5397079215cb46 http://cgit.osmocom.org/libosmocore/commit/?id=568f8e20175a21da4e4537a2f5a4… commit 568f8e20175a21da4e4537a2f5a4f7fedec8c6d6 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Nov 16 22:29:38 2017 +0100 bssgp_fc_test: remove rounding to deciseconds Ever since this test was changed to use osmo_gettimeofday_override, the times it sees are exact every time and don't need rounding to pass the expected output. Change-Id: I4a9a5d31fc02eb55caf7ba9c141426d8115bb740 ----------------------------------------------------------------------- Summary of changes: include/osmocom/gsm/tlv.h | 15 ++++++-- src/gb/gprs_bssgp.c | 6 +++- tests/gb/bssgp_fc_test.c | 43 ++++++++++++++++------- tests/gb/bssgp_fc_tests.ok | 84 ++++++++++++++++++++++++++++++++++++++++++++ tests/sercomm/sercomm_test.c | 1 + 5 files changed, 133 insertions(+), 16 deletions(-) hooks/post-receive -- An utility library for Open Source Mobile Communications

7 years, 7 months

libosmocore.git branch master updated. 0.10.2-20-g10ee73a7

by gitosis＠osmocom.org

7 years, 7 months

libosmocore.git branch master updated. 0.10.2-19-g3fad5d78

by gitosis＠osmocom.org

7 years, 7 months

libosmo-netif.git branch master updated. 0.1.1-8-gb6e8d39

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom network interface library". The branch, master has been updated via b6e8d39417b217e9bbf396d50c3ef2a91a6c4054 (commit) from 2547e87b94223d2a90057d87aa821f3745687196 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmo-netif/commit/?id=b6e8d39417b217e9bbf396d50c… commit b6e8d39417b217e9bbf396d50c3ef2a91a6c4054 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Mon Nov 20 14:23:25 2017 +0100 gitignore: vim swp files Change-Id: I0013625df95c5600479953e6f83b848efadb525a ----------------------------------------------------------------------- Summary of changes: .gitignore | 2 ++ 1 file changed, 2 insertions(+) hooks/post-receive -- Osmocom network interface library

7 years, 7 months

osmo-pcu.git branch master updated. 0.4.0-4-g8d55563

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, master has been updated via 8d555635230033e2bfd80bd1b58ed1a50e5600a3 (commit) via 1bcfa9aacfef875f21aeb3d6b5bd393b069e4183 (commit) from bfc54b551b614815705d0711db5bdbd2fa240aec (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-pcu/commit/?id=8d555635230033e2bfd80bd1b58ed1a… commit 8d555635230033e2bfd80bd1b58ed1a50e5600a3 Author: Minh-Quang Nguyen <minh-quang.nguyen(a)nutaq.com> Date: Wed Nov 1 15:00:08 2017 -0400 PCU: display TA information in TBF stats Change-Id: I26886224c2ad6d5a29e92203635b8bf7459730a2 http://cgit.osmocom.org/osmo-pcu/commit/?id=1bcfa9aacfef875f21aeb3d6b5bd393… commit 1bcfa9aacfef875f21aeb3d6b5bd393b069e4183 Author: Minh-Quang Nguyen <minh-quang.nguyen(a)nutaq.com> Date: Wed Nov 1 14:41:37 2017 -0400 PCU: Fix TA adjustment Promblem: TA provided from L1 PH-DATA-IND is a relative amount of TA adjustment to actual TA being used for given TBF. The current TA update algorithm in PCU simply applies the relative amount of TA to given TBF but does not take into account of current TA. As a result, the PCU will request wrong TA jump for given TBF if the MS is moving away from BTS more than 2 km. Related issue: http://osmocom.org/issues/2611 Fixes: - The PCU needs increase or decrease current TA of given TBF on receiving of relative amount of TA adjustment provided by PH-DATA-IND from L1 - The PCU needs to set absolute TA of given TBF on receiving absolute TA provided by PH-RA-IND from L1. Change-Id: I65212f8203f1a35278890f51db038d689b2493d5 ----------------------------------------------------------------------- Summary of changes: src/bts.cpp | 56 +++++++++++++++++++++++++++++++----- src/bts.h | 5 ++-- src/osmo-bts-litecell15/lc15_l1_if.c | 4 +-- src/osmo-bts-sysmo/sysmo_l1_if.c | 4 +-- src/pcu_l1_if.h | 28 ++++++++++++++++++ src/pcu_vty_functions.cpp | 3 +- 6 files changed, 86 insertions(+), 14 deletions(-) hooks/post-receive -- UNNAMED PROJECT

7 years, 7 months

libosmo-sccp.git branch master updated. 0.8.1-22-g116dfb6

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "SCCP Library". The branch, master has been updated via 116dfb662158b45ff374cc91ee6bbb74aacf8b7e (commit) from 73a7435d28780b129a391002a366681c15aed2ef (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmo-sccp/commit/?id=116dfb662158b45ff374cc91ee6… commit 116dfb662158b45ff374cc91ee6bbb74aacf8b7e Author: Pau Espin Pedrol <pespin(a)sysmocom.de> Date: Fri Nov 17 14:45:52 2017 +0100 contrib/test: Fix config of local/remote ports The first port is the remote one, and the second port is the local one, according to cs7_asp_cmd doc and code. In the same config, the ports for the servers are used and for the local port in the client we don't care, that's why we use 0 there. Change-Id: I0fafd07614068a27c19bc2dfa6491b4b0c6737fb ----------------------------------------------------------------------- Summary of changes: contrib/test/osmo-stp.cfg | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- SCCP Library

7 years, 7 months

osmo-gsm-manuals.git branch master updated. 5ee9d2edfd9afb25f2c9c1b6b70e78e75fcf8807

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Manuals for Osmocom GSM components". The branch, master has been updated via 5ee9d2edfd9afb25f2c9c1b6b70e78e75fcf8807 (commit) via 58977d8796e8c8881367c7d6595c60c47f051d13 (commit) from 5625fcf76fcbb98164410177e8c8e38ec04eac8b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-gsm-manuals/commit/?id=5ee9d2edfd9afb25f2c9c1b… commit 5ee9d2edfd9afb25f2c9c1b6b70e78e75fcf8807 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Sun Nov 12 22:50:00 2017 +0100 OsmoGGSN: multiple instances: mention GTP port Change-Id: I781feeb955ace17d93206bc98d12bc423584ce32 http://cgit.osmocom.org/osmo-gsm-manuals/commit/?id=58977d8796e8c8881367c7d… commit 58977d8796e8c8881367c7d6595c60c47f051d13 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Mon Nov 13 02:46:38 2017 +0100 OsmoGGSN: more info on non-root operation / tun creation Add examples for 'ip addr add' and mention correspondence to config file, add examples for enabling masquerading and IP forwarding, place the non-root config in its own section and highlight the diffs. Add tiny hint at systemd-networkd. Change-Id: I02bd9cfa35c7f2fb338d5d92c2e968fe80574a78 ----------------------------------------------------------------------- Summary of changes: OsmoGGSN/chapters/configuration.adoc | 21 ++++++++++++++++----- OsmoGGSN/chapters/running.adoc | 9 +++++++++ 2 files changed, 25 insertions(+), 5 deletions(-) hooks/post-receive -- Manuals for Osmocom GSM components

7 years, 7 months

libosmocore.git branch master updated. 0.10.2-18-gabcd0e37

by gitosis＠osmocom.org

7 years, 7 months

osmo-gsm-manuals.git branch master updated. 5625fcf76fcbb98164410177e8c8e38ec04eac8b

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Manuals for Osmocom GSM components". The branch, master has been updated via 5625fcf76fcbb98164410177e8c8e38ec04eac8b (commit) from 5c6f783d60704d7eb09240fbc51fff0bdb05aa38 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-gsm-manuals/commit/?id=5625fcf76fcbb9816441017… commit 5625fcf76fcbb98164410177e8c8e38ec04eac8b Author: Max <msuraev(a)sysmocom.de> Date: Thu Nov 2 13:09:18 2017 +0100 Fix build with default paths If LIBOSMO_DIR is not set explicitly than ~/source/gsm/libosmocore is used which is base for MERGE_DOC which is used by vty_reference_combine.sh as it is. If the shell used by vty_reference_combine.sh does not expand ~ than the build will fail. Let's be nice and use realpath on MERGE_DOC before giving it to vty_reference_combine.sh to make sure complete path is used. Change-Id: I2edf64348502cbe498d9fd27a686c712b044c926 ----------------------------------------------------------------------- Summary of changes: build/Makefile.vty-reference.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- Manuals for Osmocom GSM components

7 years, 7 months

← Newer
1
...
4
5
6
7
8
9
10
...
20
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

osmocom-commitlog November 2017