- gerrit-log - lists.osmocom.org

Change in libgtpnl[master]: Bump version: 1.2.2.1-9fa7-dirty → 1.2.3
by pespin 28 Jun '22

28 Jun '22

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libgtpnl/+/28431 ) Change subject: Bump version: 1.2.2.1-9fa7-dirty → 1.2.3 ...................................................................... Bump version: 1.2.2.1-9fa7-dirty → 1.2.3 Change-Id: I9530d28a2deb4c31be0d1929a37e956c56f55b36 --- M debian/changelog M src/Makefile.am 2 files changed, 8 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libgtpnl refs/changes/31/28431/1 diff --git a/debian/changelog b/debian/changelog index 904301f..3a3228e 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,10 @@ +libgtpnl (1.2.3) unstable; urgency=medium + + [ Neels Hofmeyr ] + * fix some cases of rc == 0 on error + + -- Pau Espin Pedrol <pespin(a)sysmocom.de> Tue, 28 Jun 2022 16:13:45 +0200 + libgtpnl (1.2.2) unstable; urgency=medium [ Oliver Smith ] diff --git a/src/Makefile.am b/src/Makefile.am index a87c5cc..4d6910e 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -2,7 +2,7 @@ # This is _NOT_ the library release version, it's an API version. # Please read Chapter 6 "Library interface versions" of the libtool documentation before making any modification -LIBVERSION=1:1:1 +LIBVERSION=1:2:1 lib_LTLIBRARIES = libgtpnl.la -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/28431 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: I9530d28a2deb4c31be0d1929a37e956c56f55b36 Gerrit-Change-Number: 28431 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in docker-playground[master]: Use Osmocom OBS
by osmith 28 Jun '22

28 Jun '22

osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/28417 ) Change subject: Use Osmocom OBS ...................................................................... Use Osmocom OBS Related: OS#5557 Change-Id: I880f8134e4f7e6ae4125237e6b3983c04cea9ec6 --- M README.md M centos7-build/Dockerfile M centos7-obs-latest/Dockerfile M centos8-build/Dockerfile M centos8-obs-latest/Dockerfile M common/Release.key M debian-bullseye-build/Dockerfile M debian-bullseye-erlang/Dockerfile M debian-bullseye-obs-latest/Dockerfile M debian-bullseye-titan/Dockerfile M debian-buster-build/Dockerfile M debian-buster-jenkins/Dockerfile M debian-buster-simtrace2/Dockerfile M debian-jessie-osmocom/Dockerfile M debian-sid-jenkins/Dockerfile M debian-stretch-build/Dockerfile M debian-stretch-jenkins/Dockerfile M debian-stretch-obs-latest/Dockerfile M make/Makefile M osmo-ran/Dockerfile M osmo-ran/split/ran-bsc_mgw/Dockerfile M osmo-ran/split/ran-bts_pcu/Dockerfile M osmo-ran/split/ran-trx-ipc/Dockerfile M osmo-ran/split/ran-trx-uhd/Dockerfile 24 files changed, 70 insertions(+), 72 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/README.md b/README.md index 9a1889e..dd3d992 100644 --- a/README.md +++ b/README.md @@ -45,7 +45,7 @@ 2021q1-centos8: ``` -export OSMOCOM_REPO_TESTSUITE_MIRROR="http://download.opensuse.org" +export OSMOCOM_REPO_TESTSUITE_MIRROR="https://downloads.osmocom.org" export OSMOCOM_REPO_MIRROR="https://downloads.osmocom.org" export OSMOCOM_REPO_PATH="osmo-maintained" export OSMOCOM_REPO_VERSION="2021q1" @@ -75,7 +75,7 @@ The OBS repository mirror consists of `${OSMOCOM_REPO_MIRROR}/${OSMOCOM_REPO_PATH}/${OSMOCOM_REPO_VERSION}`, -e.g. `https://download.opensuse.org/repositories/network:/osmocom:/latest/`. +e.g. `https://downloads.osmocom.org/packages/osmocom:/latest/`. ### Creating kernel config fragments For the kernel tests, we are storing kernel config fragments in the git diff --git a/centos7-build/Dockerfile b/centos7-build/Dockerfile index 2e04efb..f449d42 100644 --- a/centos7-build/Dockerfile +++ b/centos7-build/Dockerfile @@ -2,8 +2,8 @@ ARG UPSTREAM_DISTRO=centos:centos7 FROM ${REGISTRY}/${UPSTREAM_DISTRO} # Arguments used after FROM must be specified again -ARG OSMOCOM_REPO_MIRROR="http://download.opensuse.org" -ARG OSMOCOM_REPO_PATH="repositories/network:/osmocom:" +ARG OSMOCOM_REPO_MIRROR="https://downloads.osmocom.org" +ARG OSMOCOM_REPO_PATH="packages/osmocom:" # Use dnf package manager instead of yum, so we can use all the dnf codepaths # that were originally written for CentOS8 in this CentOS7 image too diff --git a/centos7-obs-latest/Dockerfile b/centos7-obs-latest/Dockerfile index dfe12fc..2c06882 100644 --- a/centos7-obs-latest/Dockerfile +++ b/centos7-obs-latest/Dockerfile @@ -2,8 +2,8 @@ ARG UPSTREAM_DISTRO=centos:centos7 FROM ${REGISTRY}/${UPSTREAM_DISTRO} # Arguments used after FROM must be specified again -ARG OSMOCOM_REPO_MIRROR="http://download.opensuse.org" -ARG OSMOCOM_REPO_PATH="repositories/network:/osmocom:" +ARG OSMOCOM_REPO_MIRROR="https://downloads.osmocom.org" +ARG OSMOCOM_REPO_PATH="packages/osmocom:" ARG OSMOCOM_REPO_VERSION="latest" # Use dnf package manager instead of yum, so we can use all the dnf codepaths diff --git a/centos8-build/Dockerfile b/centos8-build/Dockerfile index 26ef819..19593c1 100644 --- a/centos8-build/Dockerfile +++ b/centos8-build/Dockerfile @@ -2,8 +2,8 @@ ARG UPSTREAM_DISTRO=almalinux:8 FROM ${REGISTRY}/${UPSTREAM_DISTRO} # Arguments used after FROM must be specified again -ARG OSMOCOM_REPO_MIRROR="http://download.opensuse.org" -ARG OSMOCOM_REPO_PATH="repositories/network:/osmocom:" +ARG OSMOCOM_REPO_MIRROR="https://downloads.osmocom.org" +ARG OSMOCOM_REPO_PATH="packages/osmocom:" # Let package metadata expire after 60 seconds instead of 48 hours RUN echo "metadata_expire=60" >> /etc/dnf/dnf.conf && cat /etc/dnf/dnf.conf diff --git a/centos8-obs-latest/Dockerfile b/centos8-obs-latest/Dockerfile index 69eeb79..ccbef81f 100644 --- a/centos8-obs-latest/Dockerfile +++ b/centos8-obs-latest/Dockerfile @@ -2,8 +2,8 @@ ARG UPSTREAM_DISTRO=almalinux:8 FROM ${REGISTRY}/${UPSTREAM_DISTRO} # Arguments used after FROM must be specified again -ARG OSMOCOM_REPO_MIRROR="http://download.opensuse.org" -ARG OSMOCOM_REPO_PATH="repositories/network:/osmocom:" +ARG OSMOCOM_REPO_MIRROR="https://downloads.osmocom.org" +ARG OSMOCOM_REPO_PATH="packages/osmocom:" ARG OSMOCOM_REPO_VERSION="latest" # Let package metadata expire after 60 seconds instead of 48 hours diff --git a/common/Release.key b/common/Release.key index 30aebe8..ecca084 100644 --- a/common/Release.key +++ b/common/Release.key @@ -1,20 +1,26 @@ -----BEGIN PGP PUBLIC KEY BLOCK----- Version: GnuPG v1.4.5 (GNU/Linux) -mQENBFJBt/wBCADAht3d/ilNuyzaXYw/QwTRvmjyoDvfXw+H/3Fvk1zlDZoiKPPc -a1wCVBINUZl7vYM2OXqbJwYa++JP2Q48xKSvC6thbRc/YLievkbcvTemf7IaREfl -CTjoYpoqXHa9kHMw1aALDm8CNU88jZmnV7v9L6hKkbYDxie+jpoj7D6B9JlxgNJ4 -5dQyRNsFGVcIl4Vplt1HyGc5Q5nQI/VgS2rlF/IOXmhRQBc4LEDdU8R2IKnkU4ee -S7TWanAigGAQhxGuCkS39/CWzc1DhLhjlNhBl/+RTPejkqJtAy00ZLps3+RqUN1Y -CU/Fsr7aRlYVGqQ/BlptwV0XQ2VVYJX2oEBBABEBAAG0MG5ldHdvcmsgT0JTIFBy -b2plY3QgPG5ldHdvcmtAYnVpbGQub3BlbnN1c2Uub3JnPokBPAQTAQIAJgUCYo5k -AwIbAwUJFGtcBwYLCQgHAwIEFQIIAwQWAgMBAh4BAheAAAoJEGLrGgkXKA3fU7YI -AKtt2TSRJ6M+vJlAGEafD0OIwbLCQ5XY9xd0ncbW2HfsIznUafgRPgTz2YN5n1iO -hGAhAQVQrm7HIqZEJBmdvUHxiOgsVYviaVAo8t2fNH5TYdK4y5fjIjzNrFtJFr3z -ImxPmu/kuIhTCzl09Xd0vtIi7wDy1J0l5Chy4DR/X+NeduyvtgpbMCv8DX3G95GH -MHpsmFaFtKY0Mbuwu+aEZ97k/I1BkmPSDYFWycqe/fGYNRHjSQjopqD2+3sNyeAg -Bs7jPDnJ8RILRz7YnxMqT69z64mgrvlPj7jX2w8jdWKzhAythbbYDKOb7rYQ9U2g -NEpwNGuOkrZYSLlna1ZXYjiIRgQTEQIABgUCUkG3/AAKCRA7MBG3a51lIzhdAJ9v -d6XPffMZRcCGgDEY5OaTn/MsCQCgrXbeZpFJgnirSrc8rRonvzYFiF4= -=wfqq +mQENBGKzE1QBCADFcM3ZzggvgxNRNNqDGWf5xIDAiK5qzFLdGes7L6F9VCHdaPy0 +RAOB5bFb/Q1tSDFNEBLtaauXKz+4iGL6qMVjZcyjzpB5w4jKN+kkrFRhjDNUv/SH +BX6d+P7v5WBGSNArNgA8D1BGzckp5a99EZ0okMJFEqIcN40PD6OGugpq5XnVV5Nk +e93fLa2Cu8vhFBcVn6CuHeEhsmuMf6NLbQRNfNNCEEUYaZn7beMYtpZ7t1djsKx5 +1xGm50OzI22FLu8lELQ9d7qMVGRG3WHYawX9BDteRybiyqxfwUHm1haWazRJtlGt +UWyzvwAb80BK1J2Nu5fbAa3w5CoEPAbUuCyrABEBAAG0JW9zbW9jb20gT0JTIFBy +b2plY3QgPG9zbW9jb21Ab3Ntb2NvbT6JAVQEEwEIAD4WIQRrKp83ktFetw1Oao+G +pzC2U3JZcwUCYrMV4wIbAwUJBB6yjwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAK +CRCGpzC2U3JZc4FRCACQQkKIrnvQ7n2u7GSmyVZa3I+oLoFXSGqaGyey5TW/nrMm +vFDKU3qliHiuNSmUY35SnAhXUsvqOYppxVRoO1MLrqUvzMOnIWqkJpf8mtjGUnsW +jyVeto7Rsjs75y2i1Hk+e7ljb/V65J3NlfrfEYWbqR9AKd53ReNXTdrQ0J05A38N +GdI4Ld/2lNISAwaBmGhqdeKsLHpQw/JERU1TApVJR1whFiIwDF1rOCg9GPnNKIk7 +yRZdK267XzztrainX/cbPILyzUZEDhYs6wQuyACyQ1YUxZIxrwVfk7PMNay8CrLH +z42B73Ne5IAj8+op/3iJafFONLm7YXiDUFN+QDYAiQEzBBMBCAAdFiEExoiYhHND +S7aVYlnqa51NyAUyjdsFAmKzE1UACgkQa51NyAUyjdvuZgf+OXmr//i7u7Gg7eWB +7e0qUsyCId9lXS8J437x3K6ciJfD7/6RSy8TFW5Nglm/uSkbyq582I8t+SoOirMD +E6cg9U/5+h5s46bAf+Kd2XS/6tLGeNLM18i4el8CP06NpFzDrsKu76uYFpyRiiHD +otBdtgxeLJ83LugGfZslF+/5cigJkAJMhAdVvGO8h85R6fba8ZSOKtMKkaQRfi76 +nhyOrJPlLuS+DLEnHwdkOFgtKnxHdjM97K+Tx0gisb6uwaWroXfSLnhP8RTLLZZy +Z+noU1Hw3c+mn4c/NYbcC/uwHYHKRzuf9gHnQ3dGgv0Z5sbeLRVo92hjGj7Ftlyd +4hmKBg== +=HxK4 -----END PGP PUBLIC KEY BLOCK----- diff --git a/debian-bullseye-build/Dockerfile b/debian-bullseye-build/Dockerfile index 3c8bf4b..b1e7cd5 100644 --- a/debian-bullseye-build/Dockerfile +++ b/debian-bullseye-build/Dockerfile @@ -2,8 +2,8 @@ ARG UPSTREAM_DISTRO=debian:bullseye FROM ${REGISTRY}/${UPSTREAM_DISTRO} # Arguments used after FROM must be specified again -ARG OSMOCOM_REPO_MIRROR="http://download.opensuse.org" -ARG OSMOCOM_REPO_PATH="repositories/network:/osmocom:" +ARG OSMOCOM_REPO_MIRROR="https://downloads.osmocom.org" +ARG OSMOCOM_REPO_PATH="packages/osmocom:" ARG OSMOCOM_REPO="$OSMOCOM_REPO_MIRROR/${OSMOCOM_REPO_PATH}/nightly/Debian_11/" RUN apt-get update && \ diff --git a/debian-bullseye-erlang/Dockerfile b/debian-bullseye-erlang/Dockerfile index 9c3d4f3..e7a584e 100644 --- a/debian-bullseye-erlang/Dockerfile +++ b/debian-bullseye-erlang/Dockerfile @@ -1,10 +1,8 @@ ARG REGISTRY=docker.io FROM ${REGISTRY}/debian:bullseye # Arguments used after FROM must be specified again -ARG OSMOCOM_REPO_MIRROR="http://download.opensuse.org" -ARG OSMOCOM_REPO_PATH="repositories/network:/osmocom:" - - +ARG OSMOCOM_REPO_MIRROR="https://downloads.osmocom.org" +ARG OSMOCOM_REPO_PATH="packages/osmocom:" ARG OSMOCOM_REPO="${OSMOCOM_REPO_MIRROR}/${OSMOCOM_REPO_PATH}/latest/Debian_11/" # install the erlang vm and rebar (2) diff --git a/debian-bullseye-obs-latest/Dockerfile b/debian-bullseye-obs-latest/Dockerfile index 6707838..16320c0 100644 --- a/debian-bullseye-obs-latest/Dockerfile +++ b/debian-bullseye-obs-latest/Dockerfile @@ -2,8 +2,8 @@ ARG UPSTREAM_DISTRO=debian:bullseye FROM ${REGISTRY}/${UPSTREAM_DISTRO} # Arguments used after FROM must be specified again -ARG OSMOCOM_REPO_MIRROR="http://download.opensuse.org" -ARG OSMOCOM_REPO_PATH="repositories/network:/osmocom:" +ARG OSMOCOM_REPO_MIRROR="https://downloads.osmocom.org" +ARG OSMOCOM_REPO_PATH="packages/osmocom:" ARG OSMOCOM_REPO="${OSMOCOM_REPO_MIRROR}/${OSMOCOM_REPO_PATH}/latest/Debian_11/" RUN apt-get update && \ diff --git a/debian-bullseye-titan/Dockerfile b/debian-bullseye-titan/Dockerfile index 576041c..68c27ee 100644 --- a/debian-bullseye-titan/Dockerfile +++ b/debian-bullseye-titan/Dockerfile @@ -2,10 +2,8 @@ ARG UPSTREAM_DISTRO=debian:bullseye FROM ${REGISTRY}/${UPSTREAM_DISTRO} # Arguments used after FROM must be specified again -ARG OSMOCOM_REPO_TESTSUITE_MIRROR="http://download.opensuse.org" - - -ARG OSMOCOM_REPO="$OSMOCOM_REPO_TESTSUITE_MIRROR/repositories/network:/osmocom:/latest/Debian_11/" +ARG OSMOCOM_REPO_TESTSUITE_MIRROR="https://downloads.osmocom.org" +ARG OSMOCOM_REPO="$OSMOCOM_REPO_TESTSUITE_MIRROR/packages/osmocom:/latest/Debian_11/" RUN apt-get update && apt-get install -y \ ca-certificates \ diff --git a/debian-buster-build/Dockerfile b/debian-buster-build/Dockerfile index 7000ca5..80e5678 100644 --- a/debian-buster-build/Dockerfile +++ b/debian-buster-build/Dockerfile @@ -2,8 +2,8 @@ ARG UPSTREAM_DISTRO=debian:buster FROM ${REGISTRY}/${UPSTREAM_DISTRO} # Arguments used after FROM must be specified again -ARG OSMOCOM_REPO_MIRROR="http://download.opensuse.org" -ARG OSMOCOM_REPO_PATH="repositories/network:/osmocom:" +ARG OSMOCOM_REPO_MIRROR="https://downloads.osmocom.org" +ARG OSMOCOM_REPO_PATH="packages/osmocom:" ARG OSMOCOM_REPO="$OSMOCOM_REPO_MIRROR/${OSMOCOM_REPO_PATH}/nightly/Debian_10/" RUN apt-get update && \ diff --git a/debian-buster-jenkins/Dockerfile b/debian-buster-jenkins/Dockerfile index 04c6c4c..5229373 100644 --- a/debian-buster-jenkins/Dockerfile +++ b/debian-buster-jenkins/Dockerfile @@ -5,8 +5,8 @@ ARG REGISTRY=docker.io FROM ${REGISTRY}/debian:${DEBIAN_VERSION} # Arguments used after FROM must be specified again -ARG OSMOCOM_REPO_MIRROR="http://download.opensuse.org" -ARG OSMOCOM_REPO_PATH="repositories/network:/osmocom:" +ARG OSMOCOM_REPO_MIRROR="https://downloads.osmocom.org" +ARG OSMOCOM_REPO_PATH="packages/osmocom:" # Make "$DEBIAN_VERSION" available after FROM # https://docs.docker.com/engine/reference/builder/#understand-how-arg-and-fr… diff --git a/debian-buster-simtrace2/Dockerfile b/debian-buster-simtrace2/Dockerfile index 71309b5..c697d16 100644 --- a/debian-buster-simtrace2/Dockerfile +++ b/debian-buster-simtrace2/Dockerfile @@ -1,10 +1,8 @@ ARG USER FROM $USER/debian-buster-build # Arguments used after FROM must be specified again -ARG OSMOCOM_REPO_MIRROR="http://download.opensuse.org" -ARG OSMOCOM_REPO_PATH="repositories/network:/osmocom:" - - +ARG OSMOCOM_REPO_MIRROR="https://downloads.osmocom.org" +ARG OSMOCOM_REPO_PATH="packages/osmocom:" ARG OSMOCOM_REPO="${OSMOCOM_REPO_MIRROR}/${OSMOCOM_REPO_PATH}/nightly/Debian_10/" COPY .common/Release.key /tmp/Release.key diff --git a/debian-jessie-osmocom/Dockerfile b/debian-jessie-osmocom/Dockerfile index 011f5aa..da0eb9b 100644 --- a/debian-jessie-osmocom/Dockerfile +++ b/debian-jessie-osmocom/Dockerfile @@ -1,10 +1,8 @@ ARG REGISTRY=docker.io FROM ${REGISTRY}/debian:jessie # Arguments used after FROM must be specified again -ARG OSMOCOM_REPO_MIRROR="http://download.opensuse.org" -ARG OSMOCOM_REPO_PATH="repositories/network:/osmocom:" - - +ARG OSMOCOM_REPO_MIRROR="https://downloads.osmocom.org" +ARG OSMOCOM_REPO_PATH="packages/osmocom:" ARG OSMOCOM_REPO="${OSMOCOM_REPO_MIRROR}/${OSMOCOM_REPO_PATH}/nightly/Debian_8.0/" COPY .common/Release.key /tmp/Release.key diff --git a/debian-sid-jenkins/Dockerfile b/debian-sid-jenkins/Dockerfile index 944e514..bb66f13 100644 --- a/debian-sid-jenkins/Dockerfile +++ b/debian-sid-jenkins/Dockerfile @@ -5,8 +5,8 @@ ARG REGISTRY=docker.io FROM ${REGISTRY}/debian:${DEBIAN_VERSION} # Arguments used after FROM must be specified again -ARG OSMOCOM_REPO_MIRROR="http://download.opensuse.org" -ARG OSMOCOM_REPO_PATH="repositories/network:/osmocom:" +ARG OSMOCOM_REPO_MIRROR="https://downloads.osmocom.org" +ARG OSMOCOM_REPO_PATH="packages/osmocom:" # Make "$DEBIAN_VERSION" available after FROM # https://docs.docker.com/engine/reference/builder/#understand-how-arg-and-fr… diff --git a/debian-stretch-build/Dockerfile b/debian-stretch-build/Dockerfile index b144e13..509e4d5 100644 --- a/debian-stretch-build/Dockerfile +++ b/debian-stretch-build/Dockerfile @@ -2,8 +2,8 @@ ARG UPSTREAM_DISTRO=debian:stretch FROM ${REGISTRY}/${UPSTREAM_DISTRO} # Arguments used after FROM must be specified again -ARG OSMOCOM_REPO_MIRROR="http://download.opensuse.org" -ARG OSMOCOM_REPO_PATH="repositories/network:/osmocom:" +ARG OSMOCOM_REPO_MIRROR="https://downloads.osmocom.org" +ARG OSMOCOM_REPO_PATH="packages/osmocom:" ARG OSMOCOM_REPO="$OSMOCOM_REPO_MIRROR/${OSMOCOM_REPO_PATH}/nightly/Debian_9.0/" RUN apt-get update && \ diff --git a/debian-stretch-jenkins/Dockerfile b/debian-stretch-jenkins/Dockerfile index d44e394..42ed09a 100644 --- a/debian-stretch-jenkins/Dockerfile +++ b/debian-stretch-jenkins/Dockerfile @@ -5,8 +5,8 @@ ARG REGISTRY=docker.io FROM ${REGISTRY}/debian:${DEBIAN_VERSION} # Arguments used after FROM must be specified again -ARG OSMOCOM_REPO_MIRROR="http://download.opensuse.org" -ARG OSMOCOM_REPO_PATH="repositories/network:/osmocom:" +ARG OSMOCOM_REPO_MIRROR="https://downloads.osmocom.org" +ARG OSMOCOM_REPO_PATH="packages/osmocom:" # Make "$DEBIAN_VERSION" available after FROM # https://docs.docker.com/engine/reference/builder/#understand-how-arg-and-fr… diff --git a/debian-stretch-obs-latest/Dockerfile b/debian-stretch-obs-latest/Dockerfile index fe3420b..ced8a7d 100644 --- a/debian-stretch-obs-latest/Dockerfile +++ b/debian-stretch-obs-latest/Dockerfile @@ -2,8 +2,8 @@ ARG UPSTREAM_DISTRO=debian:stretch FROM ${REGISTRY}/${UPSTREAM_DISTRO} # Arguments used after FROM must be specified again -ARG OSMOCOM_REPO_MIRROR="http://download.opensuse.org" -ARG OSMOCOM_REPO_PATH="repositories/network:/osmocom:" +ARG OSMOCOM_REPO_MIRROR="https://downloads.osmocom.org" +ARG OSMOCOM_REPO_PATH="packages/osmocom:" ARG OSMOCOM_REPO="${OSMOCOM_REPO_MIRROR}/${OSMOCOM_REPO_PATH}/latest/Debian_9.0/" RUN apt-get update && \ diff --git a/make/Makefile b/make/Makefile index 89310dd..d3bd727 100644 --- a/make/Makefile +++ b/make/Makefile @@ -46,15 +46,15 @@ # Full OBS repository mirror consists of: # ${OSMOCOM_REPO_MIRROR}/${OSMOCOM_REPO_PATH}/${OSMOCOM_REPO_VERSION} -# e.g. "https://download.opensuse.org/repositories/network:/osmocom:/latest/" +# e.g. "https://downloads.osmocom.org/packages/osmocom:/latest/" # # Use if down: OSMOCOM_REPO_MIRROR=http://ftp.uni-stuttgart.de/opensuse -OSMOCOM_REPO_MIRROR?=http://download.opensuse.org -OSMOCOM_REPO_PATH?=repositories/network:/osmocom: +OSMOCOM_REPO_MIRROR?=https://downloads.osmocom.org +OSMOCOM_REPO_PATH?=packages/osmocom: # Use "nightly" to use the nightly feed OSMOCOM_REPO_VERSION?=latest # Build the testsuite with the following mirror. In jenkins we always want to -# point this to http://download.opensuse.org, so the same testsuite can be +# point this to http://downloads.osmocom.org, so the same testsuite can be # used no matter which OSMOCOM_REPO_MIRROR is set. This avoids rebuilding the # testsuite when we only want to change OSMOCOM_REPO_MIRROR to build different # subjects under test, and it works even if the OSMOCOM_REPO_MIRROR only has diff --git a/osmo-ran/Dockerfile b/osmo-ran/Dockerfile index 07c8551..a0bf9b9 100644 --- a/osmo-ran/Dockerfile +++ b/osmo-ran/Dockerfile @@ -2,8 +2,8 @@ FROM $USER/systemd # Arguments used after FROM must be specified again ARG DISTRO -ARG OSMOCOM_REPO_MIRROR="http://download.opensuse.org" -ARG OSMOCOM_REPO_PATH="repositories/network:/osmocom:" +ARG OSMOCOM_REPO_MIRROR="https://downloads.osmocom.org" +ARG OSMOCOM_REPO_PATH="packages/osmocom:" ARG OSMOCOM_REPO_VERSION=latest diff --git a/osmo-ran/split/ran-bsc_mgw/Dockerfile b/osmo-ran/split/ran-bsc_mgw/Dockerfile index 03c16fe..b090d6c 100644 --- a/osmo-ran/split/ran-bsc_mgw/Dockerfile +++ b/osmo-ran/split/ran-bsc_mgw/Dockerfile @@ -2,8 +2,8 @@ FROM $USER/systemd # Arguments used after FROM must be specified again ARG DISTRO -ARG OSMOCOM_REPO_MIRROR="http://download.opensuse.org" -ARG OSMOCOM_REPO_PATH="repositories/network:/osmocom:" +ARG OSMOCOM_REPO_MIRROR="https://downloads.osmocom.org" +ARG OSMOCOM_REPO_PATH="packages/osmocom:" ARG OSMOCOM_REPO_VERSION=latest diff --git a/osmo-ran/split/ran-bts_pcu/Dockerfile b/osmo-ran/split/ran-bts_pcu/Dockerfile index 0129b75..19f68c4 100644 --- a/osmo-ran/split/ran-bts_pcu/Dockerfile +++ b/osmo-ran/split/ran-bts_pcu/Dockerfile @@ -2,8 +2,8 @@ FROM $USER/systemd # Arguments used after FROM must be specified again ARG DISTRO -ARG OSMOCOM_REPO_MIRROR="http://download.opensuse.org" -ARG OSMOCOM_REPO_PATH="repositories/network:/osmocom:" +ARG OSMOCOM_REPO_MIRROR="https://downloads.osmocom.org" +ARG OSMOCOM_REPO_PATH="packages/osmocom:" ARG OSMOCOM_REPO_VERSION=latest diff --git a/osmo-ran/split/ran-trx-ipc/Dockerfile b/osmo-ran/split/ran-trx-ipc/Dockerfile index 467adab..0cd2713 100644 --- a/osmo-ran/split/ran-trx-ipc/Dockerfile +++ b/osmo-ran/split/ran-trx-ipc/Dockerfile @@ -2,8 +2,8 @@ FROM $USER/systemd # Arguments used after FROM must be specified again ARG DISTRO -ARG OSMOCOM_REPO_MIRROR="http://download.opensuse.org" -ARG OSMOCOM_REPO_PATH="repositories/network:/osmocom:" +ARG OSMOCOM_REPO_MIRROR="https://downloads.osmocom.org" +ARG OSMOCOM_REPO_PATH="packages/osmocom:" ARG OSMOCOM_REPO_VERSION=latest diff --git a/osmo-ran/split/ran-trx-uhd/Dockerfile b/osmo-ran/split/ran-trx-uhd/Dockerfile index 3603685..75a596b 100644 --- a/osmo-ran/split/ran-trx-uhd/Dockerfile +++ b/osmo-ran/split/ran-trx-uhd/Dockerfile @@ -2,8 +2,8 @@ FROM $USER/systemd # Arguments used after FROM must be specified again ARG DISTRO -ARG OSMOCOM_REPO_MIRROR="http://download.opensuse.org" -ARG OSMOCOM_REPO_PATH="repositories/network:/osmocom:" +ARG OSMOCOM_REPO_MIRROR="https://downloads.osmocom.org" +ARG OSMOCOM_REPO_PATH="packages/osmocom:" ARG OSMOCOM_REPO_VERSION=latest -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/28417 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I880f8134e4f7e6ae4125237e6b3983c04cea9ec6 Gerrit-Change-Number: 28417 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in docker-playground[master]: Install ca-certificates before Osmocom repo
by osmith 28 Jun '22

28 Jun '22

osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/28416 ) Change subject: Install ca-certificates before Osmocom repo ...................................................................... Install ca-certificates before Osmocom repo Prepare for using https://downloads.osmocom.org/packages/ instead of http://download.opensuse.org to download packages. Install ca-certificates before attempting to use the repository, otherwise it will print a warning and not use the repository and e.g. install eclipse-titan from debian's repository instead of our repo. Fix for: W: https://downloads.osmocom.org/packages/osmocom:/latest/Debian_11/./InRelease: No system certificates available. Try installing ca-certificates. Related: OS#5557 Change-Id: Icb6764601671b6e66591f33ede6d0f822811545a --- M debian-bullseye-build/Dockerfile M debian-bullseye-erlang/Dockerfile M debian-bullseye-obs-latest/Dockerfile M debian-bullseye-titan/Dockerfile M debian-buster-build/Dockerfile M debian-buster-jenkins/Dockerfile M debian-jessie-osmocom/Dockerfile M debian-sid-jenkins/Dockerfile M debian-stretch-build/Dockerfile M debian-stretch-jenkins/Dockerfile M debian-stretch-obs-latest/Dockerfile M osmo-ran/Dockerfile M osmo-ran/split/ran-bsc_mgw/Dockerfile M osmo-ran/split/ran-bts_pcu/Dockerfile M osmo-ran/split/ran-trx-ipc/Dockerfile M osmo-ran/split/ran-trx-uhd/Dockerfile 16 files changed, 18 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/debian-bullseye-build/Dockerfile b/debian-bullseye-build/Dockerfile index baeba30..3c8bf4b 100644 --- a/debian-bullseye-build/Dockerfile +++ b/debian-bullseye-build/Dockerfile @@ -15,6 +15,7 @@ automake \ bison \ build-essential \ + ca-certificates \ cppcheck \ dahdi-source \ debhelper \ diff --git a/debian-bullseye-erlang/Dockerfile b/debian-bullseye-erlang/Dockerfile index aeff1c7..9c3d4f3 100644 --- a/debian-bullseye-erlang/Dockerfile +++ b/debian-bullseye-erlang/Dockerfile @@ -44,6 +44,7 @@ # add osmocom latest repo, should we ever require packages from there RUN apt-get update && apt-get install -y \ + ca-certificates \ gnupg COPY .common/Release.key /tmp/Release.key RUN apt-key add /tmp/Release.key && \ diff --git a/debian-bullseye-obs-latest/Dockerfile b/debian-bullseye-obs-latest/Dockerfile index fb8cd93..6707838 100644 --- a/debian-bullseye-obs-latest/Dockerfile +++ b/debian-bullseye-obs-latest/Dockerfile @@ -10,6 +10,7 @@ apt-get upgrade -y && \ apt-get install -y --no-install-recommends \ telnet \ + ca-certificates \ gnupg \ && \ apt-get clean diff --git a/debian-bullseye-titan/Dockerfile b/debian-bullseye-titan/Dockerfile index 125f02b..576041c 100644 --- a/debian-bullseye-titan/Dockerfile +++ b/debian-bullseye-titan/Dockerfile @@ -8,6 +8,7 @@ ARG OSMOCOM_REPO="$OSMOCOM_REPO_TESTSUITE_MIRROR/repositories/network:/osmocom:/latest/Debian_11/" RUN apt-get update && apt-get install -y \ + ca-certificates \ gnupg COPY .common/Release.key /tmp/Release.key diff --git a/debian-buster-build/Dockerfile b/debian-buster-build/Dockerfile index b80d881..7000ca5 100644 --- a/debian-buster-build/Dockerfile +++ b/debian-buster-build/Dockerfile @@ -15,6 +15,7 @@ automake \ bison \ build-essential \ + ca-certificates \ cppcheck \ dahdi-source \ debhelper \ diff --git a/debian-buster-jenkins/Dockerfile b/debian-buster-jenkins/Dockerfile index 6bbd389..04c6c4c 100644 --- a/debian-buster-jenkins/Dockerfile +++ b/debian-buster-jenkins/Dockerfile @@ -26,6 +26,7 @@ bc \ bison \ bzip2 \ + ca-certificates \ cmake \ coccinelle \ cppcheck \ diff --git a/debian-jessie-osmocom/Dockerfile b/debian-jessie-osmocom/Dockerfile index 08fb320..011f5aa 100644 --- a/debian-jessie-osmocom/Dockerfile +++ b/debian-jessie-osmocom/Dockerfile @@ -9,6 +9,9 @@ COPY .common/Release.key /tmp/Release.key +RUN apt-get update && apt-get install -y \ + ca-certificates + RUN apt-key add /tmp/Release.key && \ rm /tmp/Release.key && \ echo "deb " $OSMOCOM_REPO " ./" > /etc/apt/sources.list.d/osmocom-nightly.list diff --git a/debian-sid-jenkins/Dockerfile b/debian-sid-jenkins/Dockerfile index 411b640..944e514 100644 --- a/debian-sid-jenkins/Dockerfile +++ b/debian-sid-jenkins/Dockerfile @@ -26,6 +26,7 @@ bc \ bison \ bzip2 \ + ca-certificates \ cmake \ coccinelle \ cppcheck \ diff --git a/debian-stretch-build/Dockerfile b/debian-stretch-build/Dockerfile index b04eb8e..b144e13 100644 --- a/debian-stretch-build/Dockerfile +++ b/debian-stretch-build/Dockerfile @@ -15,6 +15,7 @@ automake \ bison \ build-essential \ + ca-certificates \ cppcheck \ dahdi-source \ debhelper \ diff --git a/debian-stretch-jenkins/Dockerfile b/debian-stretch-jenkins/Dockerfile index b5c36fb..d44e394 100644 --- a/debian-stretch-jenkins/Dockerfile +++ b/debian-stretch-jenkins/Dockerfile @@ -26,6 +26,7 @@ bc \ bison \ bzip2 \ + ca-certificates \ cmake \ coccinelle \ cppcheck \ diff --git a/debian-stretch-obs-latest/Dockerfile b/debian-stretch-obs-latest/Dockerfile index aaf1b43..fe3420b 100644 --- a/debian-stretch-obs-latest/Dockerfile +++ b/debian-stretch-obs-latest/Dockerfile @@ -9,6 +9,7 @@ RUN apt-get update && \ apt-get upgrade -y && \ apt-get install -y --no-install-recommends \ + ca-certificates \ telnet \ gnupg \ && \ diff --git a/osmo-ran/Dockerfile b/osmo-ran/Dockerfile index 64697c6..07c8551 100644 --- a/osmo-ran/Dockerfile +++ b/osmo-ran/Dockerfile @@ -16,6 +16,7 @@ debian*) \ apt-get update && \ apt-get install -y --no-install-recommends \ + ca-certificates \ gnupg && \ apt-key add /tmp/Release.key && \ rm /tmp/Release.key && \ diff --git a/osmo-ran/split/ran-bsc_mgw/Dockerfile b/osmo-ran/split/ran-bsc_mgw/Dockerfile index e0e3b15..03c16fe 100644 --- a/osmo-ran/split/ran-bsc_mgw/Dockerfile +++ b/osmo-ran/split/ran-bsc_mgw/Dockerfile @@ -16,6 +16,7 @@ debian*) \ apt-get update && \ apt-get install -y --no-install-recommends \ + ca-certificates \ gnupg && \ apt-key add /tmp/Release.key && \ rm /tmp/Release.key && \ diff --git a/osmo-ran/split/ran-bts_pcu/Dockerfile b/osmo-ran/split/ran-bts_pcu/Dockerfile index d8b9bcd..0129b75 100644 --- a/osmo-ran/split/ran-bts_pcu/Dockerfile +++ b/osmo-ran/split/ran-bts_pcu/Dockerfile @@ -16,6 +16,7 @@ debian*) \ apt-get update && \ apt-get install -y --no-install-recommends \ + ca-certificates \ gnupg && \ apt-key add /tmp/Release.key && \ rm /tmp/Release.key && \ diff --git a/osmo-ran/split/ran-trx-ipc/Dockerfile b/osmo-ran/split/ran-trx-ipc/Dockerfile index e273da9..467adab 100644 --- a/osmo-ran/split/ran-trx-ipc/Dockerfile +++ b/osmo-ran/split/ran-trx-ipc/Dockerfile @@ -16,6 +16,7 @@ debian*) \ apt-get update && \ apt-get install -y --no-install-recommends \ + ca-certificates \ gnupg && \ apt-key add /tmp/Release.key && \ rm /tmp/Release.key && \ diff --git a/osmo-ran/split/ran-trx-uhd/Dockerfile b/osmo-ran/split/ran-trx-uhd/Dockerfile index adc764a..3603685 100644 --- a/osmo-ran/split/ran-trx-uhd/Dockerfile +++ b/osmo-ran/split/ran-trx-uhd/Dockerfile @@ -16,6 +16,7 @@ debian*) \ apt-get update && \ apt-get install -y --no-install-recommends \ + ca-certificates \ gnupg && \ apt-key add /tmp/Release.key && \ rm /tmp/Release.key && \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/28416 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Icb6764601671b6e66591f33ede6d0f822811545a Gerrit-Change-Number: 28416 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in docker-playground[master]: Use Osmocom OBS
by osmith 28 Jun '22

28 Jun '22

Attention is currently required from: laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/28417 ) Change subject: Use Osmocom OBS ...................................................................... Patch Set 1: Code-Review+2 (2 comments) Patchset: PS1: > LGTM, but we should of course only deploy it once the nightly jenkins job is deployed, i.e. […] ACK. It's deployed and packages built today, merging now. PS1: 1+1=2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/28417 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I880f8134e4f7e6ae4125237e6b3983c04cea9ec6 Gerrit-Change-Number: 28417 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 28 Jun 2022 14:08:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

Change in libasn1c[master]: Bump version: 0.9.33.1-3bbf → 0.9.34
by pespin 28 Jun '22

28 Jun '22

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libasn1c/+/28430 ) Change subject: Bump version: 0.9.33.1-3bbf → 0.9.34 ...................................................................... Bump version: 0.9.33.1-3bbf → 0.9.34 Change-Id: Iff6d90fa291eea2dab06d21a8a91618acd622553 --- M debian/changelog 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libasn1c refs/changes/30/28430/1 diff --git a/debian/changelog b/debian/changelog index 10fa9b5..242f46a 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,10 @@ +libasn1c (0.9.34) unstable; urgency=medium + + [ Eric ] + * configure.ac: fix libtool issue with clang and sanitizer + + -- Pau Espin Pedrol <pespin(a)sysmocom.de> Tue, 28 Jun 2022 16:03:31 +0200 + libasn1c (0.9.33) unstable; urgency=medium [ Oliver Smith ] -- To view, visit https://gerrit.osmocom.org/c/libasn1c/+/28430 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libasn1c Gerrit-Branch: master Gerrit-Change-Id: Iff6d90fa291eea2dab06d21a8a91618acd622553 Gerrit-Change-Number: 28430 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-bsc[master]: ipaccess-config: check value returned by abis_nm_tlv_parse()
by fixeria 28 Jun '22

28 Jun '22

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28425 ) Change subject: ipaccess-config: check value returned by abis_nm_tlv_parse() ...................................................................... ipaccess-config: check value returned by abis_nm_tlv_parse() Change-Id: I38cd35506964efb1441555d16cea998f415e9394 Fixes: CID#272995 --- M src/ipaccess/ipaccess-config.c 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/ipaccess/ipaccess-config.c b/src/ipaccess/ipaccess-config.c index 76f10f5..1d8675e 100644 --- a/src/ipaccess/ipaccess-config.c +++ b/src/ipaccess/ipaccess-config.c @@ -286,7 +286,10 @@ unsigned int indent = 0; - abis_nm_tlv_parse(&tp, bts, foh->data, oh->length-sizeof(*foh)); + if (abis_nm_tlv_parse(&tp, bts, foh->data, oh->length-sizeof(*foh)) < 0) { + LOGPFOH(DNM, LOGL_ERROR, foh, "%s(): tlv_parse failed\n", __func__); + return -EINVAL; + } abis_nm_tlv_attr_primary_oml(&tp, &ia, &oml_port); osmo_strlcpy(oml_ip, inet_ntoa(ia), sizeof(oml_ip)); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28425 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I38cd35506964efb1441555d16cea998f415e9394 Gerrit-Change-Number: 28425 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-bsc[master]: VTY: fix wrong enum value s/ACTIVATE_FOR_VTY/ASSIGN_FOR_VTY/
by fixeria 28 Jun '22

28 Jun '22

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28419 ) Change subject: VTY: fix wrong enum value s/ACTIVATE_FOR_VTY/ASSIGN_FOR_VTY/ ...................................................................... VTY: fix wrong enum value s/ACTIVATE_FOR_VTY/ASSIGN_FOR_VTY/ Found by clang: warning: implicit conversion from enumeration type 'enum lchan_activate_for' to different enumeration type 'enum assign_for' [-Wenum-conversion] This is indeed a bug, because both enum items have different values: * ACTIVATE_FOR_VTY (from enum lchan_activate_for) is 4, * ASSIGN_FOR_VTY (from enum assign_for) is 3. Change-Id: I44544d4577833e0aed62b07d0c7c1c2821b05dd4 --- M src/osmo-bsc/bsc_vty.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c index fb03d6f..5b46e79 100644 --- a/src/osmo-bsc/bsc_vty.c +++ b/src/osmo-bsc/bsc_vty.c @@ -774,7 +774,7 @@ vty_out(vty, "Error: cannot find free lchan of type %s%s", gsm_lchant_name(from_lchan->type), VTY_NEWLINE); } - if (reassignment_request_to_lchan(ACTIVATE_FOR_VTY, from_lchan, to_lchan, -1, -1)) { + if (reassignment_request_to_lchan(ASSIGN_FOR_VTY, from_lchan, to_lchan, -1, -1)) { vty_out(vty, "Error: not allowed to start assignment for %s%s", gsm_lchan_name(from_lchan), VTY_NEWLINE); return CMD_WARNING; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28419 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I44544d4577833e0aed62b07d0c7c1c2821b05dd4 Gerrit-Change-Number: 28419 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-bsc[master]: cbsp: Avoid encoding CBSP message if link is down
by pespin 28 Jun '22

28 Jun '22

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28428 ) Change subject: cbsp: Avoid encoding CBSP message if link is down ...................................................................... cbsp: Avoid encoding CBSP message if link is down Change-Id: I25c8681d2ee987ac6ebfce42ee409926eb88301d --- M src/osmo-bsc/cbsp_link.c 1 file changed, 7 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/28/28428/1 diff --git a/src/osmo-bsc/cbsp_link.c b/src/osmo-bsc/cbsp_link.c index 39798df..d8c32ec 100644 --- a/src/osmo-bsc/cbsp_link.c +++ b/src/osmo-bsc/cbsp_link.c @@ -300,6 +300,13 @@ { struct msgb *msg; + if (!cbc->client.cli && !cbc->server.srv) { + LOGP(DCBS, LOGL_ERROR, "Discarding Tx CBSP Message Type %s, link is down\n", + get_value_string(cbsp_msg_type_names, cbsp->msg_type)); + talloc_free(cbsp); + return 0; + } + msg = osmo_cbsp_encode(cbc, cbsp); if (!msg) { LOGP(DCBS, LOGL_ERROR, "Unable to encode CBSP Message Type %s: %s\n", @@ -311,10 +318,6 @@ osmo_stream_cli_send(cbc->client.cli, msg); else if (cbc->server.srv) osmo_stream_srv_send(cbc->server.srv, msg); - else { - LOGP(DCBS, LOGL_ERROR, "Discarding CBSP Message, link is down: %s\n", msgb_hexdump(msg)); - msgb_free(msg); - } talloc_free(cbsp); return 0; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28428 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I25c8681d2ee987ac6ebfce42ee409926eb88301d Gerrit-Change-Number: 28428 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-bsc[master]: cbsp: Change log level ERROR->INFO on CBSP tx and link down
by pespin 28 Jun '22

28 Jun '22

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28429 ) Change subject: cbsp: Change log level ERROR->INFO on CBSP tx and link down ...................................................................... cbsp: Change log level ERROR->INFO on CBSP tx and link down Let's decrease the logging since it's fine simply discarding the message if the link is down. This way all code sending messages doesn't need to care about the link state. Change-Id: I64356ec6a7b3a4e11a0e66b17efab2788b1ca5cc --- M src/osmo-bsc/cbsp_link.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/29/28429/1 diff --git a/src/osmo-bsc/cbsp_link.c b/src/osmo-bsc/cbsp_link.c index d8c32ec..849b802 100644 --- a/src/osmo-bsc/cbsp_link.c +++ b/src/osmo-bsc/cbsp_link.c @@ -301,7 +301,7 @@ struct msgb *msg; if (!cbc->client.cli && !cbc->server.srv) { - LOGP(DCBS, LOGL_ERROR, "Discarding Tx CBSP Message Type %s, link is down\n", + LOGP(DCBS, LOGL_INFO, "Discarding Tx CBSP Message Type %s, link is down\n", get_value_string(cbsp_msg_type_names, cbsp->msg_type)); talloc_free(cbsp); return 0; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28429 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I64356ec6a7b3a4e11a0e66b17efab2788b1ca5cc Gerrit-Change-Number: 28429 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-gsm-manuals[master]: sigtran: Use caps in section header
by pespin 28 Jun '22

28 Jun '22

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/28427 ) Change subject: sigtran: Use caps in section header ...................................................................... sigtran: Use caps in section header Change-Id: Ie7ff0dced649a29817a5a46e37eaaaf7ee22aea6 --- M common/chapters/sigtran.adoc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/27/28427/1 diff --git a/common/chapters/sigtran.adoc b/common/chapters/sigtran.adoc index 58445bb..2cbd84c 100644 --- a/common/chapters/sigtran.adoc +++ b/common/chapters/sigtran.adoc @@ -380,7 +380,7 @@ Osmocom (libosmo-sigtran) implements both the SGP and ASP roles, but not the IPSP role. -==== traffic modes in SIGTRAN +==== Traffic Modes in SIGTRAN Whenever an AS consists of multiple ASPs, the traffic mode expresses how messages are distributed between those ASPs. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/28427 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Ie7ff0dced649a29817a5a46e37eaaaf7ee22aea6 Gerrit-Change-Number: 28427 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

2025

2024

2023

2022

gerrit-log