- gerrit-log - lists.osmocom.org

Change in docker-playground[master]: debian-stretch-jenkins: add apt-transport-https
by fixeria 28 Jun '22

28 Jun '22

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/28435 ) Change subject: debian-stretch-jenkins: add apt-transport-https ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/28435 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I9ece7ffb295d8b371a0000a91b9b6d0f7174535d Gerrit-Change-Number: 28435 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Jun 2022 15:30:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in docker-playground[master]: debian-stretch-jenkins: add apt-transport-https
by pespin 28 Jun '22

28 Jun '22

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/28435 ) Change subject: debian-stretch-jenkins: add apt-transport-https ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/28435 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I9ece7ffb295d8b371a0000a91b9b6d0f7174535d Gerrit-Change-Number: 28435 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Jun 2022 15:30:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-hlr[master]: db_auc: hexparse_stmt(): check value returned by osmo_hexparse()
by fixeria 28 Jun '22

28 Jun '22

Attention is currently required from: fixeria. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hlr/+/28424 to look at the new patch set (#2). Change subject: db_auc: hexparse_stmt(): check value returned by osmo_hexparse() ...................................................................... db_auc: hexparse_stmt(): check value returned by osmo_hexparse() Change-Id: I78bb3aff9dd57a38278bb34113ea764e0a54c439 Fixes: CID#272997 --- M src/db_auc.c 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/24/28424/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/28424 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I78bb3aff9dd57a38278bb34113ea764e0a54c439 Gerrit-Change-Number: 28424 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in docker-playground[master]: debian-stretch-jenkins: add apt-transport-https
by osmith 28 Jun '22

28 Jun '22

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/28435 ) Change subject: debian-stretch-jenkins: add apt-transport-https ...................................................................... debian-stretch-jenkins: add apt-transport-https Fix installing packages from https with debian-stretch-jenkins after we switched the packages mirror to https://downloads.osmocom.org/packages. Fix for: E: The method driver /usr/lib/apt/methods/https could not be found. Related: SYS#5557 Change-Id: I9ece7ffb295d8b371a0000a91b9b6d0f7174535d --- M debian-stretch-jenkins/Dockerfile 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/35/28435/1 diff --git a/debian-stretch-jenkins/Dockerfile b/debian-stretch-jenkins/Dockerfile index 42ed09a..03d258f 100644 --- a/debian-stretch-jenkins/Dockerfile +++ b/debian-stretch-jenkins/Dockerfile @@ -18,6 +18,7 @@ DEBIAN_FRONTEND=noninteractive apt-get update && \ DEBIAN_FRONTEND=noninteractive apt-get upgrade -y && \ DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends \ + apt-transport-https \ asciidoc \ asciidoc-dblatex \ autoconf \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/28435 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I9ece7ffb295d8b371a0000a91b9b6d0f7174535d Gerrit-Change-Number: 28435 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-gsm-manuals[master]: Bump version: 1.2.0.12-6984 → 1.3.0
by pespin 28 Jun '22

28 Jun '22

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/28434 ) Change subject: Bump version: 1.2.0.12-6984 → 1.3.0 ...................................................................... Bump version: 1.2.0.12-6984 → 1.3.0 Change-Id: I9487c26c6f1898481c25f227bc462b6867a05b70 --- M debian/changelog 1 file changed, 24 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/34/28434/1 diff --git a/debian/changelog b/debian/changelog index 8f9668b..1eff938 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,27 @@ +osmo-gsm-manuals-dev (1.3.0) unstable; urgency=medium + + [ Philipp Maier ] + * counters-overview: add documentation about socket statistics + + [ Alexander Couzens ] + * common: gb-ns2: remove empty VTY chapter + * common: gb-ns2: update ip-sns configuration example + * common: gb-ns2: correct ip.access static configuration + * common: gb-ns2: fix typo in configures + * common: gb-ns2: add chapter Gb/NS maintenance + + [ Harald Welte ] + * Add CBSP port number to default list of ports + * bibliography: Add reference to TS 48.049 (CBSP) + * glossary: add CBSP, CBC, CBS + * port_numbers: Add missing records for osmo-upf, pfcp-tool, hnodeb + + [ Pau Espin Pedrol ] + * sigtran: Remove old comment about non-implemented stuff + * sigtran: Use caps in section header + + -- Pau Espin Pedrol <pespin(a)sysmocom.de> Tue, 28 Jun 2022 17:27:15 +0200 + osmo-gsm-manuals-dev (1.2.0) unstable; urgency=medium [ Harald Welte ] -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/28434 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I9487c26c6f1898481c25f227bc462b6867a05b70 Gerrit-Change-Number: 28434 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-bsc[master]: cbsp: Change log level ERROR->INFO on CBSP tx and link down
by pespin 28 Jun '22

28 Jun '22

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28429 ) Change subject: cbsp: Change log level ERROR->INFO on CBSP tx and link down ...................................................................... Patch Set 1: (3 comments) Patchset: PS1: Yes, see pointers. File src/osmo-bsc/cbsp_link.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28429/comment/bdcb4e21_c0f100ed PS1, Line 150: LOGP(DCBS, LOGL_NOTICE, "CBSP Client connected to CBC: %s\n", cbc->client.sock_name); Here https://gerrit.osmocom.org/c/osmo-bsc/+/28429/comment/b9cc3538_44b11b4e PS1, Line 162: LOGP(DCBS, LOGL_NOTICE, "CBSP Client lost connection to %s\n", cbc->client.sock_name); And here. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28429 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I64356ec6a7b3a4e11a0e66b17efab2788b1ca5cc Gerrit-Change-Number: 28429 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 28 Jun 2022 15:20:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: cbsp: Avoid encoding CBSP message if link is down
by pespin 28 Jun '22

28 Jun '22

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28428 ) Change subject: cbsp: Avoid encoding CBSP message if link is down ...................................................................... cbsp: Avoid encoding CBSP message if link is down Change-Id: I25c8681d2ee987ac6ebfce42ee409926eb88301d --- M src/osmo-bsc/cbsp_link.c 1 file changed, 7 insertions(+), 4 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-bsc/cbsp_link.c b/src/osmo-bsc/cbsp_link.c index 39798df..d8c32ec 100644 --- a/src/osmo-bsc/cbsp_link.c +++ b/src/osmo-bsc/cbsp_link.c @@ -300,6 +300,13 @@ { struct msgb *msg; + if (!cbc->client.cli && !cbc->server.srv) { + LOGP(DCBS, LOGL_ERROR, "Discarding Tx CBSP Message Type %s, link is down\n", + get_value_string(cbsp_msg_type_names, cbsp->msg_type)); + talloc_free(cbsp); + return 0; + } + msg = osmo_cbsp_encode(cbc, cbsp); if (!msg) { LOGP(DCBS, LOGL_ERROR, "Unable to encode CBSP Message Type %s: %s\n", @@ -311,10 +318,6 @@ osmo_stream_cli_send(cbc->client.cli, msg); else if (cbc->server.srv) osmo_stream_srv_send(cbc->server.srv, msg); - else { - LOGP(DCBS, LOGL_ERROR, "Discarding CBSP Message, link is down: %s\n", msgb_hexdump(msg)); - msgb_free(msg); - } talloc_free(cbsp); return 0; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28428 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I25c8681d2ee987ac6ebfce42ee409926eb88301d Gerrit-Change-Number: 28428 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-dev[master]: tmux/ttcn3-bsc-test.sh: configure 4 TRX instances for BTS2
by fixeria 28 Jun '22

28 Jun '22

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/28432 ) Change subject: tmux/ttcn3-bsc-test.sh: configure 4 TRX instances for BTS2 ...................................................................... tmux/ttcn3-bsc-test.sh: configure 4 TRX instances for BTS2 Change-Id: I2294c788c1a7d37cb0492c8789b42d993e3f947b --- M ttcn3/tmux/ttcn3-bsc-test.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved; Verified diff --git a/ttcn3/tmux/ttcn3-bsc-test.sh b/ttcn3/tmux/ttcn3-bsc-test.sh index 0f76071..2da39f7 100755 --- a/ttcn3/tmux/ttcn3-bsc-test.sh +++ b/ttcn3/tmux/ttcn3-bsc-test.sh @@ -39,6 +39,6 @@ BTS_FEATURES="-fCCN,EGPRS,GPRS,IPv6_NSVC,PAGING_COORDINATION" tmux send-keys -t $SESSION:1.1 "$RESPAWN osmo-bts-omldummy $BTS_FEATURES 127.0.0.1 1234 1" C-m tmux send-keys -t $SESSION:1.2 "$RESPAWN osmo-bts-omldummy $BTS_FEATURES 127.0.0.1 1235 1" C-m -tmux send-keys -t $SESSION:1.3 "$RESPAWN osmo-bts-omldummy $BTS_FEATURES 127.0.0.1 1236 1" C-m +tmux send-keys -t $SESSION:1.3 "$RESPAWN osmo-bts-omldummy $BTS_FEATURES 127.0.0.1 1236 4" C-m tmux attach -t $SESSION:0 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/28432 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I2294c788c1a7d37cb0492c8789b42d993e3f947b Gerrit-Change-Number: 28432 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

Change in osmo-dev[master]: tmux/ttcn3-bsc-test.sh: configure 4 TRX instances for BTS2
by fixeria 28 Jun '22

28 Jun '22

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/28432 ) Change subject: tmux/ttcn3-bsc-test.sh: configure 4 TRX instances for BTS2 ...................................................................... Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/28432 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I2294c788c1a7d37cb0492c8789b42d993e3f947b Gerrit-Change-Number: 28432 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 28 Jun 2022 15:15:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ci[master]: install-coverity: update to 2021.12
by laforge 28 Jun '22

28 Jun '22

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28421 ) Change subject: install-coverity: update to 2021.12 ...................................................................... install-coverity: update to 2021.12 Starting in February 2022, coverity stopped to support the old 2019.03 version that we were using. Unfortunately that didn't generate any e-mail notification to the project admins so it remained undetected until now :( What sucks is that the filename states 2021.12 but then the actual directory created upon extraction is 2021.12.1, meaning our ansible rule breaks. We have to rename the tarball to 2021.12.1 before running the playbook... Closes: OS#5594 Change-Id: I950834cc2ad70979a53a563610bbc9feef1f5f20 --- M ansible/roles/install-coverity/defaults/main.yml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved; Verified diff --git a/ansible/roles/install-coverity/defaults/main.yml b/ansible/roles/install-coverity/defaults/main.yml index 6b97781..d7a8082 100644 --- a/ansible/roles/install-coverity/defaults/main.yml +++ b/ansible/roles/install-coverity/defaults/main.yml @@ -1,4 +1,4 @@ --- -coverity_version: 2019.03 +coverity_version: 2021.12.1 coverity_installer_file: "cov-analysis-linux64-{{ coverity_version }}.tar.gz" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28421 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I950834cc2ad70979a53a563610bbc9feef1f5f20 Gerrit-Change-Number: 28421 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

2025

2024

2023

2022

gerrit-log