Attention is currently required from: manawyrm.
laforge has removed a vote from this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/27280 )
Change subject: zaphfc: Port support for HFC-S cards
......................................................................
Removed Verified-1 by Jenkins Builder (1000002)
--
To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/27280
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: dahdi-linux
Gerrit-Branch: master
Gerrit-Change-Id: Ifd09d82ea2b6d6245207609da849350db45d91f6
Gerrit-Change-Number: 27280
Gerrit-PatchSet: 2
Gerrit-Owner: manawyrm <osmocom.account(a)tbspace.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: manawyrm <osmocom.account(a)tbspace.de>
Gerrit-MessageType: deleteVote
Attention is currently required from: manawyrm.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/27280 )
Change subject: zaphfc: Port support for HFC-S cards
......................................................................
Patch Set 2: Verified+1 Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/27280
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: dahdi-linux
Gerrit-Branch: master
Gerrit-Change-Id: Ifd09d82ea2b6d6245207609da849350db45d91f6
Gerrit-Change-Number: 27280
Gerrit-PatchSet: 2
Gerrit-Owner: manawyrm <osmocom.account(a)tbspace.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: manawyrm <osmocom.account(a)tbspace.de>
Gerrit-Comment-Date: Mon, 21 Feb 2022 22:17:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: manawyrm.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/dahdi-linux/+/27280
to look at the new patch set (#2).
Change subject: zaphfc: Port support for HFC-S cards
......................................................................
zaphfc: Port support for HFC-S cards
This ports the current zaphfc driver from the Debian bullseye patchset.
Change-Id: Ifd09d82ea2b6d6245207609da849350db45d91f6
---
M drivers/dahdi/Kbuild
M drivers/dahdi/Kconfig
A drivers/dahdi/zaphfc/Kbuild
A drivers/dahdi/zaphfc/base.c
A drivers/dahdi/zaphfc/fifo.c
A drivers/dahdi/zaphfc/fifo.h
A drivers/dahdi/zaphfc/zaphfc.h
7 files changed, 2,611 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/dahdi-linux refs/changes/80/27280/2
--
To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/27280
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: dahdi-linux
Gerrit-Branch: master
Gerrit-Change-Id: Ifd09d82ea2b6d6245207609da849350db45d91f6
Gerrit-Change-Number: 27280
Gerrit-PatchSet: 2
Gerrit-Owner: manawyrm <osmocom.account(a)tbspace.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: manawyrm <osmocom.account(a)tbspace.de>
Gerrit-MessageType: newpatchset
laforge has submitted this change. ( https://gerrit.osmocom.org/c/dahdi-tools/+/27275 )
Change subject: dahdi_pcap: Fix the use of the pkttype field
......................................................................
dahdi_pcap: Fix the use of the pkttype field
* pkttype is big-endian, so '3' is not valid, but htons(3)
* let's not use magic numbers but the actual #define PACKET_*
* differentiate PACKET_HOST (rx) from PACKET_OUTGOING (tx),
which makes wireshark properly show rx/tx packets, allows coloring
or filtering based on direction, etc.
Change-Id: I8c66a011a0fa0c5275bf3d5cf6b42064f02e28c0
---
M dahdi_pcap.c
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
manawyrm: Looks good to me, approved
diff --git a/dahdi_pcap.c b/dahdi_pcap.c
index 225fe78..0eadde3 100644
--- a/dahdi_pcap.c
+++ b/dahdi_pcap.c
@@ -41,6 +41,7 @@
#include <sys/ioctl.h>
#include <stdlib.h>
#include <getopt.h>
+#include <linux/if_packet.h>
#define BLOCK_SIZE 512
#define MAX_CHAN 16
@@ -161,7 +162,7 @@
hdr.caplen = res+sizeof(struct lapd_sll_hdr)-2;
hdr.len = res+sizeof(struct lapd_sll_hdr)-2;
- lapd->sll_pkttype = 3;
+ lapd->sll_pkttype = htons(is_read ? PACKET_HOST : PACKET_OUTGOING);
lapd->sll_hatype = 0;
lapd->sll_halen = htons(8);
// lapd->sll_addr = ???
--
To view, visit https://gerrit.osmocom.org/c/dahdi-tools/+/27275
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: dahdi-tools
Gerrit-Branch: master
Gerrit-Change-Id: I8c66a011a0fa0c5275bf3d5cf6b42064f02e28c0
Gerrit-Change-Number: 27275
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: manawyrm <osmocom.account(a)tbspace.de>
Gerrit-Reviewer: roox <mardnh(a)gmx.de>
Gerrit-MessageType: merged