- gerrit-log - lists.osmocom.org

Change in osmo-gsm-manuals[master]: sigtran: Remove old comment about non-implemented stuff
by pespin 28 Jun '22

28 Jun '22

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/28426 ) Change subject: sigtran: Remove old comment about non-implemented stuff ...................................................................... sigtran: Remove old comment about non-implemented stuff As supports multiple ASP with loadshare and override since a long time ago. Change-Id: I703c64a85636c2f9ebbd809e49c0dc8891cb9527 --- M common/chapters/sigtran.adoc 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/26/28426/1 diff --git a/common/chapters/sigtran.adoc b/common/chapters/sigtran.adoc index cbf513e..58445bb 100644 --- a/common/chapters/sigtran.adoc +++ b/common/chapters/sigtran.adoc @@ -254,8 +254,8 @@ protocols. An Application Server can have one or more Application Server Processes -associated with it. This functionality (currently not implemented in -Osmocom) can be used for load-balancing or fail-over scenarios. +associated with it. This functionality can be used for load-balancing or +fail-over scenarios. ===== Application Server Process (ASP) -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/28426 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I703c64a85636c2f9ebbd809e49c0dc8891cb9527 Gerrit-Change-Number: 28426 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-bsc[master]: ipaccess-config: check value returned by abis_nm_tlv_parse()
by pespin 28 Jun '22

28 Jun '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28425 ) Change subject: ipaccess-config: check value returned by abis_nm_tlv_parse() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28425 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I38cd35506964efb1441555d16cea998f415e9394 Gerrit-Change-Number: 28425 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Jun 2022 12:29:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: VTY: fix wrong enum value s/ACTIVATE_FOR_VTY/ASSIGN_FOR_VTY/
by pespin 28 Jun '22

28 Jun '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28419 ) Change subject: VTY: fix wrong enum value s/ACTIVATE_FOR_VTY/ASSIGN_FOR_VTY/ ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28419 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I44544d4577833e0aed62b07d0c7c1c2821b05dd4 Gerrit-Change-Number: 28419 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Jun 2022 12:28:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-hlr[master]: db_auc: hexparse_stmt(): check value returned by osmo_hexparse()
by pespin 28 Jun '22

28 Jun '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/28424 ) Change subject: db_auc: hexparse_stmt(): check value returned by osmo_hexparse() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/28424 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I78bb3aff9dd57a38278bb34113ea764e0a54c439 Gerrit-Change-Number: 28424 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Jun 2022 12:27:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: ipaccess-config: check value returned by abis_nm_tlv_parse()
by fixeria 28 Jun '22

28 Jun '22

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28425 ) Change subject: ipaccess-config: check value returned by abis_nm_tlv_parse() ...................................................................... ipaccess-config: check value returned by abis_nm_tlv_parse() Change-Id: I38cd35506964efb1441555d16cea998f415e9394 Fixes: CID#272995 --- M src/ipaccess/ipaccess-config.c 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/25/28425/1 diff --git a/src/ipaccess/ipaccess-config.c b/src/ipaccess/ipaccess-config.c index 76f10f5..1d8675e 100644 --- a/src/ipaccess/ipaccess-config.c +++ b/src/ipaccess/ipaccess-config.c @@ -286,7 +286,10 @@ unsigned int indent = 0; - abis_nm_tlv_parse(&tp, bts, foh->data, oh->length-sizeof(*foh)); + if (abis_nm_tlv_parse(&tp, bts, foh->data, oh->length-sizeof(*foh)) < 0) { + LOGPFOH(DNM, LOGL_ERROR, foh, "%s(): tlv_parse failed\n", __func__); + return -EINVAL; + } abis_nm_tlv_attr_primary_oml(&tp, &ia, &oml_port); osmo_strlcpy(oml_ip, inet_ntoa(ia), sizeof(oml_ip)); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28425 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I38cd35506964efb1441555d16cea998f415e9394 Gerrit-Change-Number: 28425 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-bsc[master]: VTY: fix wrong enum value s/ACTIVATE_FOR_VTY/ASSIGN_FOR_VTY/
by fixeria 28 Jun '22

28 Jun '22

Attention is currently required from: fixeria. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/28419 to look at the new patch set (#2). Change subject: VTY: fix wrong enum value s/ACTIVATE_FOR_VTY/ASSIGN_FOR_VTY/ ...................................................................... VTY: fix wrong enum value s/ACTIVATE_FOR_VTY/ASSIGN_FOR_VTY/ Found by clang: warning: implicit conversion from enumeration type 'enum lchan_activate_for' to different enumeration type 'enum assign_for' [-Wenum-conversion] This is indeed a bug, because both enum items have different values: * ACTIVATE_FOR_VTY (from enum lchan_activate_for) is 4, * ASSIGN_FOR_VTY (from enum assign_for) is 3. Change-Id: I44544d4577833e0aed62b07d0c7c1c2821b05dd4 --- M src/osmo-bsc/bsc_vty.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/19/28419/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28419 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I44544d4577833e0aed62b07d0c7c1c2821b05dd4 Gerrit-Change-Number: 28419 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in osmo-hlr[master]: db_auc: hexparse_stmt(): check value returned by osmo_hexparse()
by fixeria 28 Jun '22

28 Jun '22

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/28424 ) Change subject: db_auc: hexparse_stmt(): check value returned by osmo_hexparse() ...................................................................... Patch Set 1: (1 comment) File src/db_auc.c: https://gerrit.osmocom.org/c/osmo-hlr/+/28424/comment/4eb2956a_4689dc1d PS1, Line 99: return osmo_hexparse((void *)text, dst, dst_len) == col_len; > This is wrong, osmo_hexparse returns "number of parsed octets", not zero. Yes, this is why I am comparing returned value against col_len, not against 0. -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/28424 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I78bb3aff9dd57a38278bb34113ea764e0a54c439 Gerrit-Change-Number: 28424 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Jun 2022 11:04:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-hlr[master]: db_auc: hexparse_stmt(): check value returned by osmo_hexparse()
by pespin 28 Jun '22

28 Jun '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/28424 ) Change subject: db_auc: hexparse_stmt(): check value returned by osmo_hexparse() ...................................................................... Patch Set 1: Code-Review-1 (1 comment) File src/db_auc.c: https://gerrit.osmocom.org/c/osmo-hlr/+/28424/comment/0a485351_e219fe18 PS1, Line 99: return osmo_hexparse((void *)text, dst, dst_len) == col_len; This is wrong, osmo_hexparse returns "number of parsed octets", not zero. -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/28424 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I78bb3aff9dd57a38278bb34113ea764e0a54c439 Gerrit-Change-Number: 28424 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Jun 2022 11:01:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-pcu[master]: encoding: fix an uninitialized field in gen_freq_params()
by pespin 28 Jun '22

28 Jun '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/28423 ) Change subject: encoding: fix an uninitialized field in gen_freq_params() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/28423 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I4dd5202d1c4bd75baf0ab4f88ffefcc47272bd9c Gerrit-Change-Number: 28423 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Jun 2022 11:00:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-hlr[master]: db_auc: hexparse_stmt(): check value returned by osmo_hexparse()
by fixeria 28 Jun '22

28 Jun '22

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/28424 ) Change subject: db_auc: hexparse_stmt(): check value returned by osmo_hexparse() ...................................................................... db_auc: hexparse_stmt(): check value returned by osmo_hexparse() Change-Id: I78bb3aff9dd57a38278bb34113ea764e0a54c439 Fixes: CID#272997 --- M src/db_auc.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/24/28424/1 diff --git a/src/db_auc.c b/src/db_auc.c index 975eb2d..44733d6 100644 --- a/src/db_auc.c +++ b/src/db_auc.c @@ -95,8 +95,8 @@ LOGAUC(imsi, LOGL_ERROR, "Error reading %s\n", col_name); return -EIO; } - osmo_hexparse((void *)text, dst, dst_len); - return 0; + + return osmo_hexparse((void *)text, dst, dst_len) == col_len; } /* obtain the authentication data for a given imsi -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/28424 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I78bb3aff9dd57a38278bb34113ea764e0a54c439 Gerrit-Change-Number: 28424 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

2025

2024

2023

2022

gerrit-log