- gerrit-log - lists.osmocom.org

Change in osmo-ci[master]: install-coverity: update to 2021.12
by laforge 28 Jun '22

28 Jun '22

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/28421 to look at the new patch set (#2). Change subject: install-coverity: update to 2021.12 ...................................................................... install-coverity: update to 2021.12 Starting in February 2022, coverity stopped to support the old 2019.03 version that we were using. Unfortunately that didn't generate any e-mail notification to the project admins so it remained undetected until now :( Change-Id: I950834cc2ad70979a53a563610bbc9feef1f5f20 --- M ansible/roles/install-coverity/defaults/main.yml M ansible/roles/install-coverity/tasks/main.yml 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/21/28421/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28421 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I950834cc2ad70979a53a563610bbc9feef1f5f20 Gerrit-Change-Number: 28421 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

Change in osmo-ci[master]: install-coverity: update to 2021.12
by laforge 28 Jun '22

28 Jun '22

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/28421 ) Change subject: install-coverity: update to 2021.12 ...................................................................... install-coverity: update to 2021.12 Starting in February 2022, coverity stopped to support the old 2019.03 version that we were using. Unfortunately that didn't generate any e-mail notification to the project admins so it remained undetected until now :( Change-Id: I950834cc2ad70979a53a563610bbc9feef1f5f20 --- M ansible/roles/install-coverity/defaults/main.yml 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/21/28421/1 diff --git a/ansible/roles/install-coverity/defaults/main.yml b/ansible/roles/install-coverity/defaults/main.yml index 6b97781..b823ba6 100644 --- a/ansible/roles/install-coverity/defaults/main.yml +++ b/ansible/roles/install-coverity/defaults/main.yml @@ -1,4 +1,4 @@ --- -coverity_version: 2019.03 +coverity_version: 2021.12 coverity_installer_file: "cov-analysis-linux64-{{ coverity_version }}.tar.gz" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28421 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I950834cc2ad70979a53a563610bbc9feef1f5f20 Gerrit-Change-Number: 28421 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

Change in osmo-ci[master]: update git URLs (git -> https; gitea/gerrit)
by laforge 28 Jun '22

28 Jun '22

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/28349 to look at the new patch set (#2). Change subject: update git URLs (git -> https; gitea/gerrit) ...................................................................... update git URLs (git -> https; gitea/gerrit) Change-Id: Ia44e4127ff87a3d4d747225d3258188a0a891f1b --- M ansible/hosts M ansible/roles/gsm-tester/tasks/main.yml M ansible/roles/osmocom-workstation/tasks/git-repos.yml M contrib/jenkins.sh M coverity/prepare_source_Osmcocom.sh M jobs/coverity.yml M jobs/master-builds.yml M jobs/octsim_osmo-ccid-firmware.yml M jobs/osmo-gsm-manuals-trigger.yml M jobs/osmo-gsm-tester-builder.yml M jobs/osmo-gsm-tester-runner.yml M jobs/osmocom-build-tags-against-master.yml M jobs/osmocom-depcheck.yml M jobs/osmocom-list-commits.yml M jobs/osmocom-obs.yml M jobs/osmocom-release-tarballs.yml M jobs/registry-rebuild-upload-fpga-build.yml M jobs/registry-rebuild-upload-titan.yml M jobs/registry-triggers.yml M jobs/repo-install-test.yml M jobs/ttcn3-testsuites-kernel-git.yml M jobs/ttcn3-testsuites.yml M jobs/update-osmo-ci-on-slaves.yml M qemu-kvm/ggsn-kernel-gtp/postinst.sh M scripts/osmo-build.sh M scripts/osmo-depcheck/config.py M scripts/osmo-depcheck/dependencies.py M scripts/osmo-deps.sh M scripts/osmo-layer1-headers.sh 29 files changed, 36 insertions(+), 35 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/49/28349/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28349 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia44e4127ff87a3d4d747225d3258188a0a891f1b Gerrit-Change-Number: 28349 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

Change in osmo-ci[master]: jobs/osmocom-obs: run against obs.osmocom.org too
by pespin 28 Jun '22

28 Jun '22

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28415 ) Change subject: jobs/osmocom-obs: run against obs.osmocom.org too ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28415 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib271e16e93ebc58ed1ecb0ea881e1f1370e40928 Gerrit-Change-Number: 28415 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Jun 2022 09:12:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: lchan_select: implement dynamic selection mode for assignment
by laforge 28 Jun '22

28 Jun '22

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28328 ) Change subject: lchan_select: implement dynamic selection mode for assignment ...................................................................... Patch Set 5: Code-Review+1 (1 comment) File src/osmo-bsc/lchan_select.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28328/comment/3b7a517e_0cdb6a94 PS2, Line 231: qsort(&trx_list[0], bts->num_trx, sizeof(trx), &qsort_func); > I though about having a separate function for dynamic mode, but then it would be 80% identical to th […] I can find arguments in favor of both ways, I don't see a clear advantage of either over the other. So in the interest of not dragging this on any loger, I'd be in favor of merging it as-is -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28328 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1b7a0d706976b73cc5c30a8714b830811addfe8d Gerrit-Change-Number: 28328 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Jun 2022 09:11:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: lchan_select: prepare a list of timeslots once, iterate over it
by laforge 28 Jun '22

28 Jun '22

Attention is currently required from: neels, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28326 ) Change subject: lchan_select: prepare a list of timeslots once, iterate over it ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28326 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7ccc56856bfd40fd7c63b7437736de60c2b516ff Gerrit-Change-Number: 28326 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Jun 2022 09:09:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in docker-playground[master]: Use Osmocom OBS
by laforge 28 Jun '22

28 Jun '22

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/28417 ) Change subject: Use Osmocom OBS ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: LGTM, but we should of course only deploy it once the nightly jenkins job is deployed, i.e. once the nightly packages on obs.osmocom.org are actually updated every night. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/28417 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I880f8134e4f7e6ae4125237e6b3983c04cea9ec6 Gerrit-Change-Number: 28417 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Jun 2022 09:07:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ci[master]: jobs/osmocom-obs: run against obs.osmocom.org too
by laforge 28 Jun '22

28 Jun '22

Attention is currently required from: osmith, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28415 ) Change subject: jobs/osmocom-obs: run against obs.osmocom.org too ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I'd prefer any of the other possibilities you suggest. […] I didn't even think of the use of an alias. I think it's an interesting hack, and we can live with it. Remember, it is only temporary anyway. After some months of keeping both we will stop working with public OBS at all.. So at that point the alias could be removed again and we can update the .oscrc to always use the obs.osmocom.org? -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28415 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib271e16e93ebc58ed1ecb0ea881e1f1370e40928 Gerrit-Change-Number: 28415 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Jun 2022 08:34:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: VTY: fix wrong enum value s/ACTIVATE_FOR_VTY/ASSIGN_FOR_VTY/
by laforge 28 Jun '22

28 Jun '22

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28419 ) Change subject: VTY: fix wrong enum value s/ACTIVATE_FOR_VTY/ASSIGN_FOR_VTY/ ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28419 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I44544d4577833e0aed62b07d0c7c1c2821b05dd4 Gerrit-Change-Number: 28419 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Jun 2022 08:32:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ttcn3-hacks[master]: library/MGCP_Templates: add send template ts_MgcpResp_Err
by laforge 28 Jun '22

28 Jun '22

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28418 ) Change subject: library/MGCP_Templates: add send template ts_MgcpResp_Err ...................................................................... library/MGCP_Templates: add send template ts_MgcpResp_Err Change-Id: Ib0462228cece29952c91b4d18ebe2d89fed70c03 Related: OS#5572 --- M library/MGCP_Templates.ttcn 1 file changed, 14 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/library/MGCP_Templates.ttcn b/library/MGCP_Templates.ttcn index 2fd9b18..e5a05bc 100644 --- a/library/MGCP_Templates.ttcn +++ b/library/MGCP_Templates.ttcn @@ -64,7 +64,20 @@ /* osmo-bsc_mgcp implements L/C/M/X only, osmo-mgw adds 'I' */ /* SDP: osmo-bsc_mgcp implements Tx of v,o,s,c,t,m,a */ - template MgcpResponse tr_MgcpResp_Err(template MgcpResponseCode code) := { + template (value) MgcpResponse + ts_MgcpResp_Err(template (value) MgcpTransId trans_id, + template (value) MgcpResponseCode code, + template (value) charstring string := "FAIL") := { + line := { + code := code, + trans_id := trans_id, + string := string + }, + params := {}, + sdp := omit + } + template MgcpResponse + tr_MgcpResp_Err(template (present) MgcpResponseCode code) := { line := { code := code, trans_id := ?, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28418 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib0462228cece29952c91b4d18ebe2d89fed70c03 Gerrit-Change-Number: 28418 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

2025

2024

2023

2022

gerrit-log