- gerrit-log - lists.osmocom.org

Change in osmo-bsc-nat[master]: bsc_nat_fsm: split sccp_sap_verify_called_addr out

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27257 ) Change subject: bsc_nat_fsm: split sccp_sap_verify_called_addr out ...................................................................... bsc_nat_fsm: split sccp_sap_verify_called_addr out Make sccp_sap_up a bit shorter before extending it to forward not only connection-less messages, but also connection-oriented messages. While at it, change my_addr to called_addr. my_addr is ambiguous, the bsc-nat has one in CN and one in RAN. Related: SYS#5560 Change-Id: Id9bfbf38a61ef66a4246f752ef487d8a09fea173 --- M src/osmo-bsc-nat/bsc_nat_fsm.c 1 file changed, 18 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc-nat refs/changes/57/27257/1 diff --git a/src/osmo-bsc-nat/bsc_nat_fsm.c b/src/osmo-bsc-nat/bsc_nat_fsm.c index e5767b1..b3d061e 100644 --- a/src/osmo-bsc-nat/bsc_nat_fsm.c +++ b/src/osmo-bsc-nat/bsc_nat_fsm.c @@ -69,14 +69,29 @@ return g_bsc_nat->cn; } +/* For connection-less messages, verify that the called address is the locally + * configured address. */ +static int sccp_sap_verify_called_addr(struct bsc_nat_ss7_inst *src, struct osmo_sccp_addr *called_addr, + struct osmo_sccp_addr *peer_addr) +{ + char buf[255]; + + if (osmo_sccp_addr_ri_cmp(&src->local_sccp_addr, called_addr) == 0) + return 0; + + osmo_sccp_addr_to_str_buf(buf, sizeof(buf), NULL, called_addr); + LOG_SCCP(src, peer_addr, LOGL_ERROR, "Called address %s is not the locally configured" + " address %s\n", buf, osmo_sccp_inst_addr_name(NULL, &src->local_sccp_addr)); + + return -1; +} + static int sccp_sap_up(struct osmo_prim_hdr *oph, void *scu) { struct bsc_nat_ss7_inst *src = osmo_sccp_user_get_priv(scu); struct bsc_nat_ss7_inst *dest = ss7_inst_dest(src); struct osmo_scu_prim *prim = (struct osmo_scu_prim *) oph; - struct osmo_sccp_addr *my_addr; struct osmo_sccp_addr *peer_addr; - char buf[255]; int rc = -1; switch (OSMO_PRIM_HDR(oph)) { @@ -98,16 +113,11 @@ case OSMO_PRIM(OSMO_SCU_PRIM_N_UNITDATA, PRIM_OP_INDICATION): /* connection-less data received */ - my_addr = &prim->u.unitdata.called_addr; peer_addr = &prim->u.unitdata.calling_addr; LOG_SCCP(src, peer_addr, LOGL_DEBUG, "%s(%s)\n", __func__, osmo_scu_prim_name(oph)); - if (osmo_sccp_addr_ri_cmp(&src->local_sccp_addr, my_addr)) { - osmo_sccp_addr_to_str_buf(buf, sizeof(buf), NULL, my_addr); - LOG_SCCP(src, peer_addr, LOGL_ERROR, "Called address %s is not the locally configured" - " address %s\n", buf, osmo_sccp_inst_addr_name(NULL, &src->local_sccp_addr)); + if (sccp_sap_verify_called_addr(src, &prim->u.unitdata.called_addr, peer_addr) < 0) goto error; - } /* Figure out called party in dest. TODO: build and use a * mapping of peer_addr + conn_id <--> dest_ss7. For now, this -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27257 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: Id9bfbf38a61ef66a4246f752ef487d8a09fea173 Gerrit-Change-Number: 27257 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 4 months

1
0
0 0

Change in osmo-bsc-nat[master]: bsc_nat_fsm: rename vars to peer_addr_{in,out}

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27258 ) Change subject: bsc_nat_fsm: rename vars to peer_addr_{in,out} ...................................................................... bsc_nat_fsm: rename vars to peer_addr_{in,out} Only in connection-less messages, the called party address is always the address of the receiving peer. Prepare for connection-oriented messages by renaming: dest_called -> peer_addr_out peer_addr -> peer_addr_in Related: SYS#5560 Change-Id: Ib58a4e8eb8beca23cb9f11c46576f8b17bb66f3c --- M src/osmo-bsc-nat/bsc_nat_fsm.c 1 file changed, 21 insertions(+), 21 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc-nat refs/changes/58/27258/1 diff --git a/src/osmo-bsc-nat/bsc_nat_fsm.c b/src/osmo-bsc-nat/bsc_nat_fsm.c index b3d061e..f91845d 100644 --- a/src/osmo-bsc-nat/bsc_nat_fsm.c +++ b/src/osmo-bsc-nat/bsc_nat_fsm.c @@ -39,12 +39,12 @@ static char log_buf[255]; -#define LOG_SCCP(ss7_inst, peer_addr, level, fmt, args...) do { \ - if (peer_addr) \ - osmo_sccp_addr_to_str_buf(log_buf, sizeof(log_buf), NULL, peer_addr); \ +#define LOG_SCCP(ss7_inst, peer_addr_in, level, fmt, args...) do { \ + if (peer_addr_in) \ + osmo_sccp_addr_to_str_buf(log_buf, sizeof(log_buf), NULL, peer_addr_in); \ LOGP(DMAIN, level, "(%s%s%s) " fmt, \ - peer_addr ? log_buf : "", \ - peer_addr ? " from " : "", \ + peer_addr_in ? log_buf : "", \ + peer_addr_in ? " from " : "", \ ss7_inst == g_bsc_nat->ran ? "RAN" : "CN", \ ## args); \ } while (0) @@ -72,7 +72,7 @@ /* For connection-less messages, verify that the called address is the locally * configured address. */ static int sccp_sap_verify_called_addr(struct bsc_nat_ss7_inst *src, struct osmo_sccp_addr *called_addr, - struct osmo_sccp_addr *peer_addr) + struct osmo_sccp_addr *peer_addr_in) { char buf[255]; @@ -80,7 +80,7 @@ return 0; osmo_sccp_addr_to_str_buf(buf, sizeof(buf), NULL, called_addr); - LOG_SCCP(src, peer_addr, LOGL_ERROR, "Called address %s is not the locally configured" + LOG_SCCP(src, peer_addr_in, LOGL_ERROR, "Called address %s is not the locally configured" " address %s\n", buf, osmo_sccp_inst_addr_name(NULL, &src->local_sccp_addr)); return -1; @@ -91,14 +91,15 @@ struct bsc_nat_ss7_inst *src = osmo_sccp_user_get_priv(scu); struct bsc_nat_ss7_inst *dest = ss7_inst_dest(src); struct osmo_scu_prim *prim = (struct osmo_scu_prim *) oph; - struct osmo_sccp_addr *peer_addr; + struct osmo_sccp_addr *peer_addr_in; + struct osmo_sccp_addr peer_addr_out; int rc = -1; switch (OSMO_PRIM_HDR(oph)) { case OSMO_PRIM(OSMO_SCU_PRIM_N_CONNECT, PRIM_OP_INDICATION): /* indication of new inbound connection request */ - peer_addr = &prim->u.connect.calling_addr; - LOG_SCCP(src, peer_addr, LOGL_DEBUG, "%s(%s)\n", __func__, osmo_scu_prim_name(oph)); + peer_addr_in = &prim->u.connect.calling_addr; + LOG_SCCP(src, peer_addr_in, LOGL_DEBUG, "%s(%s)\n", __func__, osmo_scu_prim_name(oph)); break; case OSMO_PRIM(OSMO_SCU_PRIM_N_DATA, PRIM_OP_INDICATION): @@ -113,10 +114,10 @@ case OSMO_PRIM(OSMO_SCU_PRIM_N_UNITDATA, PRIM_OP_INDICATION): /* connection-less data received */ - peer_addr = &prim->u.unitdata.calling_addr; - LOG_SCCP(src, peer_addr, LOGL_DEBUG, "%s(%s)\n", __func__, osmo_scu_prim_name(oph)); + peer_addr_in = &prim->u.unitdata.calling_addr; + LOG_SCCP(src, peer_addr_in, LOGL_DEBUG, "%s(%s)\n", __func__, osmo_scu_prim_name(oph)); - if (sccp_sap_verify_called_addr(src, &prim->u.unitdata.called_addr, peer_addr) < 0) + if (sccp_sap_verify_called_addr(src, &prim->u.unitdata.called_addr, peer_addr_in) < 0) goto error; /* Figure out called party in dest. TODO: build and use a @@ -124,31 +125,30 @@ * is simplified by assuming there is only one MSC, one BSC. */ struct osmo_ss7_instance *dest_ss7; - struct osmo_sccp_addr dest_called; dest_ss7 = osmo_ss7_instance_find(dest->ss7_id); OSMO_ASSERT(dest_ss7); if (src == g_bsc_nat->ran) { - if (osmo_sccp_addr_by_name_local(&dest_called, "msc", dest_ss7) < 0) { - LOG_SCCP(src, peer_addr, LOGL_ERROR, "Could not find MSC in address book\n"); + if (osmo_sccp_addr_by_name_local(&peer_addr_out, "msc", dest_ss7) < 0) { + LOG_SCCP(src, peer_addr_in, LOGL_ERROR, "Could not find MSC in address book\n"); goto error; } } else { - if (osmo_sccp_addr_by_name_local(&dest_called, "bsc", dest_ss7) < 0) { - LOG_SCCP(src, peer_addr, LOGL_ERROR, "Could not find BSC in address book\n"); + if (osmo_sccp_addr_by_name_local(&peer_addr_out, "bsc", dest_ss7) < 0) { + LOG_SCCP(src, peer_addr_in, LOGL_ERROR, "Could not find BSC in address book\n"); goto error; } } - LOG_SCCP(src, peer_addr, LOGL_NOTICE, "Forwarding to %s in %s\n", - osmo_sccp_inst_addr_name(NULL, &dest_called), + LOG_SCCP(src, peer_addr_in, LOGL_NOTICE, "Forwarding to %s in %s\n", + osmo_sccp_inst_addr_name(NULL, &peer_addr_out), dest == g_bsc_nat->ran ? "RAN" : "CN"); /* oph->msg stores oph and unitdata msg. Move oph->msg->data to * unitdata msg and send it again. */ msgb_pull_to_l2(oph->msg); - osmo_sccp_tx_unitdata(dest->scu, &dest->local_sccp_addr, &dest_called, oph->msg->data, + osmo_sccp_tx_unitdata(dest->scu, &dest->local_sccp_addr, &peer_addr_out, oph->msg->data, msgb_length(oph->msg)); rc = 0; break; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27258 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: Ib58a4e8eb8beca23cb9f11c46576f8b17bb66f3c Gerrit-Change-Number: 27258 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 4 months

1
0
0 0

Change in osmo-bsc-nat[master]: bsc_nat_fsm: fix SSN of OsmoBSCNAT-CN

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27255 ) Change subject: bsc_nat_fsm: fix SSN of OsmoBSCNAT-CN ...................................................................... bsc_nat_fsm: fix SSN of OsmoBSCNAT-CN Related: SYS#5560 Change-Id: Ic0e64e002bccf1115cc53566bdab9d84dc680b03 --- M src/osmo-bsc-nat/bsc_nat_fsm.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc-nat refs/changes/55/27255/1 diff --git a/src/osmo-bsc-nat/bsc_nat_fsm.c b/src/osmo-bsc-nat/bsc_nat_fsm.c index 403097a..b24581a 100644 --- a/src/osmo-bsc-nat/bsc_nat_fsm.c +++ b/src/osmo-bsc-nat/bsc_nat_fsm.c @@ -199,7 +199,7 @@ { struct bsc_nat *bsc_nat = (struct bsc_nat *)fi->priv; - if (ss7_inst_init(bsc_nat->cn, "OsmoBSCNAT-CN", DEFAULT_PC_CN, OSMO_SCCP_SSN_RANAP) < 0) { + if (ss7_inst_init(bsc_nat->cn, "OsmoBSCNAT-CN", DEFAULT_PC_CN, OSMO_SCCP_SSN_BSSAP) < 0) { osmo_fsm_inst_state_chg(fi, BSC_NAT_FSM_ST_STOPPED, 0, 0); return; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27255 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: Ic0e64e002bccf1115cc53566bdab9d84dc680b03 Gerrit-Change-Number: 27255 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 4 months

1
0
0 0

Change in osmo-ci[master]: lint: checkpatch: ignore MISSING_SPACE

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/27253 ) Change subject: lint: checkpatch: ignore MISSING_SPACE ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27253 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib6be7744418530ae3ddbf373e67d1d7f25a60508 Gerrit-Change-Number: 27253 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 18 Feb 2022 13:28:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-ci[master]: allow to terminate value_string[] with '{0}'

by fixeria

Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/27254 ) Change subject: allow to terminate value_string[] with '{0}' ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27254 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id2f5ba897ec83f34f8d3c4425353c0baf309bb6d Gerrit-Change-Number: 27254 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 18 Feb 2022 13:28:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-ci[master]: allow to terminate value_string[] with '{0}'

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/27254 ) Change subject: allow to terminate value_string[] with '{0}' ...................................................................... allow to terminate value_string[] with '{0}' For a long time I was using '{}' to indicate a nulled out struct. But apparently '{0}' is the favored way to write that. Let's allow using this notation to terminate a value_string[]. Change-Id: Id2f5ba897ec83f34f8d3c4425353c0baf309bb6d --- M scripts/verify_value_string_arrays_are_terminated.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/54/27254/1 diff --git a/scripts/verify_value_string_arrays_are_terminated.py b/scripts/verify_value_string_arrays_are_terminated.py index f6dc545..abeff4d 100755 --- a/scripts/verify_value_string_arrays_are_terminated.py +++ b/scripts/verify_value_string_arrays_are_terminated.py @@ -19,7 +19,7 @@ re.MULTILINE | re.DOTALL) members = r'(\.(value|str)\s*=\s*)?' -terminator_re = re.compile('{}|{\s*' + members + '(0|NULL)\s*,' +terminator_re = re.compile('{\s*}|{\s*0\s*}|{\s*' + members + '(0|NULL)\s*,' '\s*' + members + '(0|NULL)\s*}') errors_found = 0 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27254 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id2f5ba897ec83f34f8d3c4425353c0baf309bb6d Gerrit-Change-Number: 27254 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 4 months

1
0
0 0

Change in osmo-ci[master]: lint: checkpatch: ignore MISSING_SPACE

by daniel

Attention is currently required from: osmith. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/27253 ) Change subject: lint: checkpatch: ignore MISSING_SPACE ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27253 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib6be7744418530ae3ddbf373e67d1d7f25a60508 Gerrit-Change-Number: 27253 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 18 Feb 2022 13:26:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-upf[master]: libosmo-tlv: add auto dec/enc to/from structs

by neels

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/27218 ) Change subject: libosmo-tlv: add auto dec/enc to/from structs ...................................................................... Patch Set 1: (2 comments) File include/osmocom/tlv/tlv_dec_enc.h: https://gerrit.osmocom.org/c/osmo-upf/+/27218/comment/4aad041b_9ceb7109 PS1, Line 60: OSMO_TLV_NESTED_IES_ORDERED_SAME = 0, > This is not really clear. […] ok, will clarify https://gerrit.osmocom.org/c/osmo-upf/+/27218/comment/28fbe195_fec47fb6 PS1, Line 135: * In this example, the nested IEs decode/encode to different goo sub structs depending on the tag value. > goo? the table game? well, we often use foo, bar, baz, but i also like to use foo, goo, moo etc. Because "fubar" has military connotation and is pretty vulgar, too. I know World Of Goo as a computer game. is there a table game? I only know the absolutely magnificent and stunning board game Go, is it even a game. -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/27218 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I65de793105882a452124ee58adb0e58469e6e796 Gerrit-Change-Number: 27218 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 18 Feb 2022 13:19:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-ci[master]: lint: checkpatch: ignore MISSING_SPACE

by osmith

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/27253 to look at the new patch set (#2). Change subject: lint: checkpatch: ignore MISSING_SPACE ...................................................................... lint: checkpatch: ignore MISSING_SPACE Don't require breaking strings at spaces. This is not useful for strings of hex characters, e.g.: { 123, "ffffffffffffffffffffffffffffffffffffffff" "ffffffffffffffffffffffffffffffffffffffff" "ffffffffffffffffffffffffffffffffffffffff" Change-Id: Ib6be7744418530ae3ddbf373e67d1d7f25a60508 --- M lint/checkpatch/checkpatch_osmo.sh 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/53/27253/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27253 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib6be7744418530ae3ddbf373e67d1d7f25a60508 Gerrit-Change-Number: 27253 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

3 years, 4 months

1
0
0 0

Change in osmo-ci[master]: lint: checkpatch: ignore MISSING_SPACE

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/27253 ) Change subject: lint: checkpatch: ignore MISSING_SPACE ...................................................................... lint: checkpatch: ignore MISSING_SPACE Don't require breaking strings at spaces. This is not useful for strings of hex characters, e.g.: { 123, "ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff" "ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff" "ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff" Change-Id: Ib6be7744418530ae3ddbf373e67d1d7f25a60508 --- M lint/checkpatch/checkpatch_osmo.sh 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/53/27253/1 diff --git a/lint/checkpatch/checkpatch_osmo.sh b/lint/checkpatch/checkpatch_osmo.sh index 93b601b..faf0fca 100755 --- a/lint/checkpatch/checkpatch_osmo.sh +++ b/lint/checkpatch/checkpatch_osmo.sh @@ -64,6 +64,7 @@ # * LINE_CONTINUATIONS: false positives # * LINE_SPACING: we don't always put a blank line after declarations # * LONG_LINE*: should be 120 chars, but exceptions are done often so don't fail here +# * MISSING_SPACE: warns about breaking strings at space characters, not useful for long strings of hex chars # * PREFER_DEFINED_ATTRIBUTE_MACRO: macros like __packed not defined in libosmocore # * PREFER_FALLTHROUGH: pseudo keyword macro "fallthrough" is not defined in libosmocore # * REPEATED_WORD: false positives in doxygen descriptions (e.g. '\param[in] data Data passed through...') @@ -103,6 +104,7 @@ --ignore LONG_LINE \ --ignore LONG_LINE_COMMENT \ --ignore LONG_LINE_STRING \ + --ignore MISSING_SPACE \ --ignore PREFER_DEFINED_ATTRIBUTE_MACRO \ --ignore PREFER_FALLTHROUGH \ --ignore REPEATED_WORD \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27253 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib6be7744418530ae3ddbf373e67d1d7f25a60508 Gerrit-Change-Number: 27253 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log