laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/27208 )
Change subject: docs/legcay.txt: Point to pySim-shell as replacement
......................................................................
docs/legcay.txt: Point to pySim-shell as replacement
Change-Id: I9ca6b9d8c35e23be2ec8752107bb7d1e4f6f9bc1
---
M docs/legacy.rst
1 file changed, 8 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, approved
diff --git a/docs/legacy.rst b/docs/legacy.rst
index ec3ddfc..d93358f 100644
--- a/docs/legacy.rst
+++ b/docs/legacy.rst
@@ -4,6 +4,9 @@
*legacy tools* are the classic ``pySim-prog`` and ``pySim-read`` programs that
existed long before ``pySim-shell``.
+These days, you should primarily use ``pySim-shell`` instead of these
+legacy tools.
+
pySim-prog
----------
@@ -45,6 +48,11 @@
``pySim-read`` allows you to read some data from a SIM card. It will only some files
of the card, and will only read files accessible to a normal user (without any special authentication)
+These days, you should use the ``export`` command of ``pySim-shell``
+instead. It performs a much more comprehensive export of all of the
+[standard] files that can be found on the card. To get a human-readable
+decode instead of the raw hex export, you can use ``export --json``.
+
Specifically, pySim-read will dump the following:
* MF
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/27208
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I9ca6b9d8c35e23be2ec8752107bb7d1e4f6f9bc1
Gerrit-Change-Number: 27208
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: merged
laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/27209 )
Change subject: pySim-shell: export: Add FCP template to export
......................................................................
pySim-shell: export: Add FCP template to export
The FCP template provides us a lot of context, like the permissions of
a given file. Let's make it part of the 'export' output, both in raw
and in decoded form.
Change-Id: I05f17bbebd7a9b3535204b821900851a5f66e88f
Closes: OS#5457
---
M pySim-shell.py
M pySim/filesystem.py
2 files changed, 6 insertions(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/pySim-shell.py b/pySim-shell.py
index 12f35fd..ad76ba0 100755
--- a/pySim-shell.py
+++ b/pySim-shell.py
@@ -532,6 +532,8 @@
structure = self._cmd.rs.selected_file_structure()
self._cmd.poutput("# structure: %s" % str(structure))
+ self._cmd.poutput("# RAW FCP Template: %s" % str(self._cmd.rs.selected_file_fcp_hex))
+ self._cmd.poutput("# Decoded FCP Template: %s" % str(self._cmd.rs.selected_file_fcp))
for f in df_path_list:
self._cmd.poutput("select " + str(f))
diff --git a/pySim/filesystem.py b/pySim/filesystem.py
index 8303a4b..f8b86c5 100644
--- a/pySim/filesystem.py
+++ b/pySim/filesystem.py
@@ -1221,6 +1221,8 @@
self.card = card
self.selected_file = self.mf # type: CardDF
self.profile = profile
+ self.selected_file_fcp = None
+ self.selected_file_fcp_hex = None
# make sure the class and selection control bytes, which are specified
# by the card profile are used
@@ -1464,7 +1466,8 @@
select_resp = f.decode_select_response(data)
else:
select_resp = self.probe_file(name, cmd_app)
- # store the decoded FCP for later reference
+ # store the raw + decoded FCP for later reference
+ self.selected_file_fcp_hex = data
self.selected_file_fcp = select_resp
self._select_post(cmd_app)
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/27209
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I05f17bbebd7a9b3535204b821900851a5f66e88f
Gerrit-Change-Number: 27209
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: merged
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/27237 )
Change subject: doc: Improve documentation in various places
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/27237
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ib88bb7d12faaac7d149ee1f6379bc128b83bbdd5
Gerrit-Change-Number: 27237
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Fri, 18 Feb 2022 11:56:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment