- gerrit-log - lists.osmocom.org

Change in osmo-ttcn3-hacks[master]: bsc: Call f_shutdown_helper() in BSC_Tests_CBSP tests
by fixeria 23 Jun '22

23 Jun '22

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28406 ) Change subject: bsc: Call f_shutdown_helper() in BSC_Tests_CBSP tests ...................................................................... Patch Set 2: (1 comment) File bsc/BSC_Tests_CBSP.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28406/comment/68c6bbde_b780… PS2, Line 15: import from BSC_Tests all; > Some further differences: […] As I said, this is an unrelated change. I am against mixing up questionable changes into the real fixes and merging everything together. If you insist on doing reordering, then please propose it in a separate change and also update the other friend modules (like BTS_Tests_VAMOS and BTS_Tests_SMSCB) to avoid the inconsistency. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28406 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5ddce5cfcbfb057b4559a5d5a710d218bae1d8fe Gerrit-Change-Number: 28406 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 Jun 2022 11:28:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-ttcn3-hacks[master]: bsc: Call f_shutdown_helper() in BSC_Tests_CBSP tests
by pespin 23 Jun '22

23 Jun '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28406 ) Change subject: bsc: Call f_shutdown_helper() in BSC_Tests_CBSP tests ...................................................................... Patch Set 2: (1 comment) File bsc/BSC_Tests_CBSP.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28406/comment/abb12624_d126… PS2, Line 15: import from BSC_Tests all; > I am still not convinced why it makes sense, sorry. We're simply using some API from BSC_Tests. […] Some further differences: - It's in the same directory - BSC_Tests is a friend of us please let's avoid waisting time on this kind of stuff. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28406 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5ddce5cfcbfb057b4559a5d5a710d218bae1d8fe Gerrit-Change-Number: 28406 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 Jun 2022 11:10:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-ttcn3-hacks[master]: bsc: Call f_shutdown_helper() in BSC_Tests_CBSP tests
by fixeria 23 Jun '22

23 Jun '22

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28406 ) Change subject: bsc: Call f_shutdown_helper() in BSC_Tests_CBSP tests ...................................................................... Patch Set 2: Code-Review-1 (1 comment) File bsc/BSC_Tests_CBSP.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28406/comment/19761fbc_7d39… PS2, Line 15: import from BSC_Tests all; > I changed it here on purpose since it's somehow a special case, since we are basically extending fro […] I am still not convinced why it makes sense, sorry. We're simply using some API from BSC_Tests. Just like we use API from the other modules, there is nothing special about that. This patch is about adding f_shutdown_helper() to address sporadic failures, and regardless of my opinion on reordering imports this is an unrelated change. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28406 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5ddce5cfcbfb057b4559a5d5a710d218bae1d8fe Gerrit-Change-Number: 28406 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 Jun 2022 11:08:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-ttcn3-hacks[master]: bsc: Call f_shutdown_helper() in BSC_Tests_CBSP tests
by pespin 23 Jun '22

23 Jun '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28406 ) Change subject: bsc: Call f_shutdown_helper() in BSC_Tests_CBSP tests ...................................................................... Patch Set 2: (1 comment) File bsc/BSC_Tests_CBSP.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28406/comment/46e28a97_0a6f… PS2, Line 15: import from BSC_Tests all; > This line should be kept where it was, I see no reason to move it here. I changed it here on purpose since it's somehow a special case, since we are basically extending from that testsuite. Hence why I put it before/after and not in the middle of the other dependencies. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28406 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5ddce5cfcbfb057b4559a5d5a710d218bae1d8fe Gerrit-Change-Number: 28406 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 Jun 2022 10:59:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-ttcn3-hacks[master]: cbc: Introduce f_shutdown_helper() and call it in every test
by fixeria 23 Jun '22

23 Jun '22

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28407 ) Change subject: cbc: Introduce f_shutdown_helper() and call it in every test ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28407 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I95e6f8a5a5c35d35662950e1105bdb17d2ca00de Gerrit-Change-Number: 28407 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 Jun 2022 10:58:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ttcn3-hacks[master]: bsc: Call f_shutdown_helper() in BSC_Tests_CBSP tests
by fixeria 23 Jun '22

23 Jun '22

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28406 ) Change subject: bsc: Call f_shutdown_helper() in BSC_Tests_CBSP tests ...................................................................... Patch Set 2: (2 comments) File bsc/BSC_Tests_CBSP.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28406/comment/55bb4104_ed82… PS1, Line 15: friend module BSC_Tests; > By saying that BSC_Tests is a friend module, you basically allow BSC_Tests to import 'friendly' stuf […] Done File bsc/BSC_Tests_CBSP.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28406/comment/17a52c4a_7851… PS2, Line 15: import from BSC_Tests all; This line should be kept where it was, I see no reason to move it here. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28406 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5ddce5cfcbfb057b4559a5d5a710d218bae1d8fe Gerrit-Change-Number: 28406 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 Jun 2022 10:58:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-ttcn3-hacks[master]: cbc: Introduce f_shutdown_helper() and call it in every test
by pespin 23 Jun '22

23 Jun '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28407 ) Change subject: cbc: Introduce f_shutdown_helper() and call it in every test ...................................................................... Patch Set 2: (1 comment) File cbc/CBC_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28407/comment/00275425_0d60… PS1, Line 135: private function f_shutdown_helper() runs on test_CT { > I think you could avoid adding a new function here by using Misc_Helpers. […] I think it's fine having this one here so that we can extend it later with testsuite specific stuff. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28407 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I95e6f8a5a5c35d35662950e1105bdb17d2ca00de Gerrit-Change-Number: 28407 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 Jun 2022 10:58:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-ttcn3-hacks[master]: cbc: Introduce f_shutdown_helper() and call it in every test
by fixeria 23 Jun '22

23 Jun '22

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28407 ) Change subject: cbc: Introduce f_shutdown_helper() and call it in every test ...................................................................... Patch Set 2: (1 comment) File cbc/CBC_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28407/comment/db30fa97_36a4… PS1, Line 135: private function f_shutdown_helper() runs on test_CT { I think you could avoid adding a new function here by using Misc_Helpers.f_shutdown(), which basically does the same. BSC_Tests has its own f_shutdown_helper() because it also checks some talloc stuff... -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28407 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I95e6f8a5a5c35d35662950e1105bdb17d2ca00de Gerrit-Change-Number: 28407 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 Jun 2022 10:57:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-ttcn3-hacks[master]: bsc: Call f_shutdown_helper() in BSC_Tests_CBSP tests
by pespin 23 Jun '22

23 Jun '22

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28406 to look at the new patch set (#2). Change subject: bsc: Call f_shutdown_helper() in BSC_Tests_CBSP tests ...................................................................... bsc: Call f_shutdown_helper() in BSC_Tests_CBSP tests This should avoid some sporadic failure sptted during tear down. Change-Id: I5ddce5cfcbfb057b4559a5d5a710d218bae1d8fe --- M bsc/BSC_Tests.ttcn M bsc/BSC_Tests_CBSP.ttcn 2 files changed, 34 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/06/28406/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28406 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5ddce5cfcbfb057b4559a5d5a710d218bae1d8fe Gerrit-Change-Number: 28406 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in osmo-ttcn3-hacks[master]: bsc: Call f_shutdown_helper() in BSC_Tests_CBSP tests
by fixeria 23 Jun '22

23 Jun '22

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28406 ) Change subject: bsc: Call f_shutdown_helper() in BSC_Tests_CBSP tests ...................................................................... Patch Set 1: (1 comment) File bsc/BSC_Tests_CBSP.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28406/comment/40c4103d_4373… PS1, Line 15: friend module BSC_Tests; By saying that BSC_Tests is a friend module, you basically allow BSC_Tests to import 'friendly' stuff from BSC_Tests_CBSP. However, I see no friend definitions in this module at all, so I don't think this is needed. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28406 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5ddce5cfcbfb057b4559a5d5a710d218bae1d8fe Gerrit-Change-Number: 28406 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 Jun 2022 10:54:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

2025

2024

2023

2022

gerrit-log