- gerrit-log - lists.osmocom.org

Change in osmo-pcu[master]: encoding: fix an uninitialized field in gen_freq_params()
by fixeria 28 Jun '22

28 Jun '22

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/28423 ) Change subject: encoding: fix an uninitialized field in gen_freq_params() ...................................................................... encoding: fix an uninitialized field in gen_freq_params() This is not critical, given that we set 'ElementsOf_RFL_NUMBER' to 0. But still, let's ensure that all fields are initialized. Change-Id: I4dd5202d1c4bd75baf0ab4f88ffefcc47272bd9c Fixes: CID#272999 --- M src/encoding.cpp 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/23/28423/1 diff --git a/src/encoding.cpp b/src/encoding.cpp index 4737137..2c13e46 100644 --- a/src/encoding.cpp +++ b/src/encoding.cpp @@ -573,6 +573,7 @@ fh_params.MAIO = pdch->fh.maio; fh_params.GPRS_Mobile_Allocation.HSN = pdch->fh.hsn; fh_params.GPRS_Mobile_Allocation.ElementsOf_RFL_NUMBER = 0; + fh_params.GPRS_Mobile_Allocation.RFL_NUMBER = { 0 }; /* Mobile Allocation bitmap */ fh_params.GPRS_Mobile_Allocation.UnionType = 0; /* MA bitmap */ -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/28423 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I4dd5202d1c4bd75baf0ab4f88ffefcc47272bd9c Gerrit-Change-Number: 28423 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-ci[master]: coverity: add osmo-bsc-nat
by osmith 28 Jun '22

28 Jun '22

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28422 ) Change subject: coverity: add osmo-bsc-nat ...................................................................... coverity: add osmo-bsc-nat Fixes: OS#5596 Change-Id: Id7cf497ea15c3ccdf76c047c6a67f17fac94e0dd --- M coverity/build_Osmocom.sh M coverity/prepare_source_Osmcocom.sh 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/coverity/build_Osmocom.sh b/coverity/build_Osmocom.sh index 6a8cf59..a7f8cdd 100755 --- a/coverity/build_Osmocom.sh +++ b/coverity/build_Osmocom.sh @@ -100,6 +100,7 @@ build_default osmo-cbc build_default osmo-hnodeb build_default osmo-hnbgw +build_default osmo-bsc-nat # GMR build_default libosmo-dsp diff --git a/coverity/prepare_source_Osmcocom.sh b/coverity/prepare_source_Osmcocom.sh index 3b0d4d5..ab8b2bd 100755 --- a/coverity/prepare_source_Osmcocom.sh +++ b/coverity/prepare_source_Osmcocom.sh @@ -34,6 +34,7 @@ simtrace2 \ osmo-hnodeb \ osmo-hnbgw \ + osmo-bsc-nat \ ; do if [ -d $proj ]; then -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28422 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id7cf497ea15c3ccdf76c047c6a67f17fac94e0dd Gerrit-Change-Number: 28422 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-ci[master]: coverity: add osmo-bsc-nat
by fixeria 28 Jun '22

28 Jun '22

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28422 ) Change subject: coverity: add osmo-bsc-nat ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28422 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id7cf497ea15c3ccdf76c047c6a67f17fac94e0dd Gerrit-Change-Number: 28422 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Jun 2022 10:35:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ci[master]: coverity: add osmo-bsc-nat
by pespin 28 Jun '22

28 Jun '22

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28422 ) Change subject: coverity: add osmo-bsc-nat ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28422 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id7cf497ea15c3ccdf76c047c6a67f17fac94e0dd Gerrit-Change-Number: 28422 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Jun 2022 10:33:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ci[master]: coverity: add osmo-bsc-nat
by osmith 28 Jun '22

28 Jun '22

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/28422 ) Change subject: coverity: add osmo-bsc-nat ...................................................................... coverity: add osmo-bsc-nat Fixes: OS#5596 Change-Id: Id7cf497ea15c3ccdf76c047c6a67f17fac94e0dd --- M coverity/build_Osmocom.sh M coverity/prepare_source_Osmcocom.sh 2 files changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/22/28422/1 diff --git a/coverity/build_Osmocom.sh b/coverity/build_Osmocom.sh index 6a8cf59..a7f8cdd 100755 --- a/coverity/build_Osmocom.sh +++ b/coverity/build_Osmocom.sh @@ -100,6 +100,7 @@ build_default osmo-cbc build_default osmo-hnodeb build_default osmo-hnbgw +build_default osmo-bsc-nat # GMR build_default libosmo-dsp diff --git a/coverity/prepare_source_Osmcocom.sh b/coverity/prepare_source_Osmcocom.sh index 3b0d4d5..ab8b2bd 100755 --- a/coverity/prepare_source_Osmcocom.sh +++ b/coverity/prepare_source_Osmcocom.sh @@ -34,6 +34,7 @@ simtrace2 \ osmo-hnodeb \ osmo-hnbgw \ + osmo-bsc-nat \ ; do if [ -d $proj ]; then -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28422 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id7cf497ea15c3ccdf76c047c6a67f17fac94e0dd Gerrit-Change-Number: 28422 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-ci[master]: update git URLs (git -> https; gitea/gerrit)
by pespin 28 Jun '22

28 Jun '22

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28349 ) Change subject: update git URLs (git -> https; gitea/gerrit) ...................................................................... Patch Set 2: Code-Review-1 (1 comment) File ansible/hosts: https://gerrit.osmocom.org/c/osmo-ci/+/28349/comment/2c2eae1d_a707e515 PS2, Line 27: #epyc1-obsworker1 ansible_host=2a02:8106:13:1e34:581e:abff:fe43:da45 obs_worker_instances=2 obs_worker_jobs=4 obs_vm_type=emulator:armv7l this looks non-related? -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28349 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia44e4127ff87a3d4d747225d3258188a0a891f1b Gerrit-Change-Number: 28349 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 28 Jun 2022 10:10:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ci[master]: jobs/osmocom-obs: run against obs.osmocom.org too
by osmith 28 Jun '22

28 Jun '22

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28415 ) Change subject: jobs/osmocom-obs: run against obs.osmocom.org too ...................................................................... jobs/osmocom-obs: run against obs.osmocom.org too Split the OBS related jenkins jobs into two, one that uploads to the new obs.osmocom.org and one that uploads to build.opensuse.org. Set an alias for "osc" that sets the right server, and set the expand_aliases shopt so the bash scripts that source common-obs.sh will not ignore the alias. Related: OS#5557 Change-Id: Ib271e16e93ebc58ed1ecb0ea881e1f1370e40928 --- M jobs/osmocom-obs.yml M scripts/common-obs.sh 2 files changed, 22 insertions(+), 9 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/jobs/osmocom-obs.yml b/jobs/osmocom-obs.yml index 3b8b1d8..cfd3bff 100644 --- a/jobs/osmocom-obs.yml +++ b/jobs/osmocom-obs.yml @@ -2,23 +2,24 @@ - project: name: Osmocom_OBS jobs: - - Osmocom_OBS_{type} + - Osmocom_OBS_{type}_{server} type: - nightly - latest # - next (disabled: OS#5322) + server: + - build.opensuse.org: + proj: "network:osmocom" + - obs.osmocom.org: + proj: "osmocom" - job-template: - name: 'Osmocom_OBS_{type}' + name: 'Osmocom_OBS_{type}_{server}' project-type: freestyle defaults: global description: | - <ul> - <li><a href="https://build.opensuse.org/project/show/network:osmocom:{type}">osmocom:{type} home page</a> - <li><a href="https://build.opensuse.org/project/monitor/network:osmocom:{type}">osmocom:{type} build monitor</a> - <li><a href="https://osmocom.org/projects/cellular-infrastructure/wiki/Binary_Packages">Wiki: binary packages</a> - </ul> - (Generated by job-builder) + See <a href="https://osmocom.org/projects/cellular-infrastructure/wiki/Binary_Packages">Wiki: binary packages</a> + for more information. node: obs parameters: - string: @@ -27,7 +28,9 @@ default: 'refs/remotes/origin/master' builders: - shell: | - export PROJ=network:osmocom:{type} + export PROJ={proj}:{type} + export OBS_SERVER={server} + ./scripts/osmocom-{type}-packages.sh scm: - git: diff --git a/scripts/common-obs.sh b/scripts/common-obs.sh index 91d54c9..4de2c55 100644 --- a/scripts/common-obs.sh +++ b/scripts/common-obs.sh @@ -29,6 +29,16 @@ exit 1 fi +if [ -z "$OBS_SERVER" ]; then + echo "OBS_SERVER environment variable is not set" + exit 1 +fi + +# Related configuration sections are in .oscrc (OS#5557) +echo "Using OBS server: $OBS_SERVER" +shopt -s expand_aliases +alias osc="osc -A '$OBS_SERVER'" + # Add dependency to all (sub)packages in debian/control and commit the change. # $1: path to debian/control file # $2: package name (e.g. "libosmocore") -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28415 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib271e16e93ebc58ed1ecb0ea881e1f1370e40928 Gerrit-Change-Number: 28415 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-ci[master]: jobs/osmocom-obs: run against obs.osmocom.org too
by osmith 28 Jun '22

28 Jun '22

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28415 ) Change subject: jobs/osmocom-obs: run against obs.osmocom.org too ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28415 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib271e16e93ebc58ed1ecb0ea881e1f1370e40928 Gerrit-Change-Number: 28415 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Jun 2022 09:59:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ci[master]: install-coverity: update to 2021.12
by laforge 28 Jun '22

28 Jun '22

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/28421 to look at the new patch set (#4). Change subject: install-coverity: update to 2021.12 ...................................................................... install-coverity: update to 2021.12 Starting in February 2022, coverity stopped to support the old 2019.03 version that we were using. Unfortunately that didn't generate any e-mail notification to the project admins so it remained undetected until now :( What sucks is that the filename states 2021.12 but then the actual directory created upon extraction is 2021.12.1, meaning our ansible rule breaks. We have to rename the tarball to 2021.12.1 before running the playbook... Closes: OS#5594 Change-Id: I950834cc2ad70979a53a563610bbc9feef1f5f20 --- M ansible/roles/install-coverity/defaults/main.yml 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/21/28421/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28421 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I950834cc2ad70979a53a563610bbc9feef1f5f20 Gerrit-Change-Number: 28421 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

Change in osmo-ci[master]: install-coverity: update to 2021.12
by laforge 28 Jun '22

28 Jun '22

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/28421 to look at the new patch set (#3). Change subject: install-coverity: update to 2021.12 ...................................................................... install-coverity: update to 2021.12 Starting in February 2022, coverity stopped to support the old 2019.03 version that we were using. Unfortunately that didn't generate any e-mail notification to the project admins so it remained undetected until now :( What sucks is that the filename states 2021.12 but then the actual directory created upon extraction is 2021.12.1, meaning our ansible rule breaks. We have to rename the tarball to 2021.12.1 before running the playbook... Change-Id: I950834cc2ad70979a53a563610bbc9feef1f5f20 --- M ansible/roles/install-coverity/defaults/main.yml 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/21/28421/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28421 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I950834cc2ad70979a53a563610bbc9feef1f5f20 Gerrit-Change-Number: 28421 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

2025

2024

2023

2022

gerrit-log