Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/28424 ) Change subject: db_auc: hexparse_stmt(): check value returned by osmo_hexparse() ...................................................................... Patch Set 1: (1 comment) File src/db_auc.c: https://gerrit.osmocom.org/c/osmo-hlr/+/28424/comment/4eb2956a_4689dc1d PS1, Line 99: return osmo_hexparse((void *)text, dst, dst_len) == col_len;

This is wrong, osmo_hexparse returns "number of parsed octets", not zero. Yes, this is why I am comparing returned value against col_len, not against 0.

-- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/28424 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I78bb3aff9dd57a38278bb34113ea764e0a54c439 Gerrit-Change-Number: 28424 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Tue, 28 Jun 2022 11:04:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment