Attention is currently required from: fixeria.
Hello Jenkins Builder, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-pcu/+/28423
to look at the new patch set (#2).
Change subject: encoding: fix an uninitialized field in gen_freq_params()
......................................................................
encoding: fix an uninitialized field in gen_freq_params()
This is not critical, given that we set 'ElementsOf_RFL_NUMBER' to 0.
But still, let's ensure that all fields are initialized.
Change-Id: I4dd5202d1c4bd75baf0ab4f88ffefcc47272bd9c
Fixes: CID#272999
---
M src/encoding.cpp
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/23/28423/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/28423
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I4dd5202d1c4bd75baf0ab4f88ffefcc47272bd9c
Gerrit-Change-Number: 28423
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/28424 )
Change subject: db_auc: hexparse_stmt(): check value returned by osmo_hexparse()
......................................................................
Patch Set 2:
(1 comment)
File src/db_auc.c:
https://gerrit.osmocom.org/c/osmo-hlr/+/28424/comment/14e91faa_e6aab318
PS1, Line 99: return osmo_hexparse((void *)text, dst, dst_len) == col_len;
> Yes, this is why I am comparing returned value against col_len, not against 0.
We should still be returning 0, not 1. Fixed.
--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/28424
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I78bb3aff9dd57a38278bb34113ea764e0a54c439
Gerrit-Change-Number: 28424
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 28 Jun 2022 15:32:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/28424 )
Change subject: db_auc: hexparse_stmt(): check value returned by osmo_hexparse()
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/28424
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I78bb3aff9dd57a38278bb34113ea764e0a54c439
Gerrit-Change-Number: 28424
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 28 Jun 2022 15:31:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment