- gerrit-log - lists.osmocom.org

[XS] Change in osmo-ttcn3-hacks[master]: SGSN_Tests: remove unused variable d
by neels 14 Aug '24

14 Aug '24

Attention is currently required from: lynxis lazus. neels has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37811?usp=email ) Change subject: SGSN_Tests: remove unused variable d ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37811?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I611e4444dfc9443584397e5523e7612ee5b00af4 Gerrit-Change-Number: 37811 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 14 Aug 2024 00:41:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: SGSN_Tests_NS: NS related tests: use the shutdown helper
by neels 14 Aug '24

14 Aug '24

Attention is currently required from: lynxis lazus. neels has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37812?usp=email ) Change subject: SGSN_Tests_NS: NS related tests: use the shutdown helper ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37812?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I08eee0d11ae04276ca1ad8fd58ebb93dd6d0066f Gerrit-Change-Number: 37812 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 14 Aug 2024 00:41:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: SGSN_Tests_NS: TC_NS_connect_alive: set missing verdict
by neels 14 Aug '24

14 Aug '24

Attention is currently required from: lynxis lazus. neels has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37813?usp=email ) Change subject: SGSN_Tests_NS: TC_NS_connect_alive: set missing verdict ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37813?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I03574bc17a10d9098dcd25d73007ec5525c42c18 Gerrit-Change-Number: 37813 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 14 Aug 2024 00:41:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in ...osmo-s1gw[master]: erab_fsm: include Network Instance IE in PDRs and FARs
by neels 14 Aug '24

14 Aug '24

Attention is currently required from: fixeria, laforge. neels has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37795?usp=email ) Change subject: erab_fsm: include Network Instance IE in PDRs and FARs ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37795?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I4dbe8e0b1d14eed5fdb3f9f3f2543c44fd543d22 Gerrit-Change-Number: 37795 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Aug 2024 00:39:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in ...osmo-s1gw[master]: erab_fsm: implement handling of GTP-U address
by neels 14 Aug '24

14 Aug '24

Attention is currently required from: fixeria. neels has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37804?usp=email ) Change subject: erab_fsm: implement handling of GTP-U address ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/erab_fsm.erl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37804/comment/198fb2d1_c2c6… : PS2, Line 99: %% @param TA TEID and bind address indicated by the MME. btw often a TEID + IP address is called an F-TEID, a fully qualified TEID. it's a short name useful for coding -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37804?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ifdc492c41266d07d0e951dcdcc1e4ba74da0b13b Gerrit-Change-Number: 37804 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Aug 2024 00:37:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in ...osmo-s1gw[master]: erab_fsm: fix message flow misconceptions
by neels 14 Aug '24

14 Aug '24

Attention is currently required from: fixeria. neels has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37803?usp=email ) Change subject: erab_fsm: fix message flow misconceptions ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37803?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ie6f65516fd5621acf002de97eeeb2b9b0b4fae4a Gerrit-Change-Number: 37803 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Aug 2024 00:31:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: SGSN_Tests: add paging a whole routing area with multiple cells
by lynxis lazus 13 Aug '24

13 Aug '24

Attention is currently required from: fixeria, laforge. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37796?usp=email ) Change subject: SGSN_Tests: add paging a whole routing area with multiple cells ...................................................................... Patch Set 2: (1 comment) File sgsn/SGSN_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37796/comment/4911ae28_4d93… : PS1, Line 2575: var default d; > same here Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37796?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I88dc95669d57278a96e05ec84f934ebf70b319e5 Gerrit-Change-Number: 37796 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Aug 2024 18:57:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: SGSN_Tests: remove unused variable d
by lynxis lazus 13 Aug '24

13 Aug '24

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37811?usp=email ) Change subject: SGSN_Tests: remove unused variable d ...................................................................... SGSN_Tests: remove unused variable d Change-Id: I611e4444dfc9443584397e5523e7612ee5b00af4 --- M sgsn/SGSN_Tests.ttcn 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/11/37811/1 diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn index 1d38d65..cbf50dd 100644 --- a/sgsn/SGSN_Tests.ttcn +++ b/sgsn/SGSN_Tests.ttcn @@ -2572,7 +2572,6 @@ /* wait for T3314 expiration and check that PS PAGING is created on DL PDU */ private function f_TC_paging_ps(charstring id) runs on BSSGP_ConnHdlr { var PdpActPars apars := valueof(t_PdpActPars(mp_ggsn_ip)); - var default d; /* first perform regular attach */ f_TC_attach(id); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37811?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I611e4444dfc9443584397e5523e7612ee5b00af4 Gerrit-Change-Number: 37811 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: SGSN_Tests_NS: NS related tests: use the shutdown helper
by lynxis lazus 13 Aug '24

13 Aug '24

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37812?usp=email ) Change subject: SGSN_Tests_NS: NS related tests: use the shutdown helper ...................................................................... SGSN_Tests_NS: NS related tests: use the shutdown helper Currently the test case TC_SNS_config_sgsn() is failing because of a dynamic test error after succeeding. Use the Misc_Helpers.f_shutdown() to prevent this. Change-Id: I08eee0d11ae04276ca1ad8fd58ebb93dd6d0066f --- M sgsn/SGSN_Tests_NS.ttcn 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/12/37812/1 diff --git a/sgsn/SGSN_Tests_NS.ttcn b/sgsn/SGSN_Tests_NS.ttcn index e5d012f..ed21d5f 100644 --- a/sgsn/SGSN_Tests_NS.ttcn +++ b/sgsn/SGSN_Tests_NS.ttcn @@ -13,6 +13,7 @@ import from Osmocom_Types all; import from Osmocom_Gb_Types all; import from Osmocom_VTY_Functions all; +import from Misc_Helpers all; import from NS_Types all; import from RAW_NS all; import from SGSN_Tests all; @@ -29,6 +30,7 @@ f_sleep(1.0); f_clean_ns_codec(); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); } testcase TC_NS_connect_alive() runs on RAW_Test_CT { @@ -45,6 +47,7 @@ f_sleep(1.0); f_clean_ns_codec(); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); } /* perform outgoing SNS-SIZE procedure */ @@ -55,6 +58,7 @@ f_outgoing_sns_size(); setverdict(pass); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); } /* outgoing SNS-SIZE procedure with more BSS side IPs than SGSN can handle */ @@ -65,6 +69,7 @@ f_outgoing_sns_size(cause := NS_CAUSE_INVALID_NR_OF_NSVCS, num_ip := 100); setverdict(pass); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); } /* perform outgoing SNS-CONFIG procedure (for BSS) */ @@ -76,6 +81,7 @@ f_outgoing_sns_size(); f_outgoing_sns_config(); setverdict(pass); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); } /* perform incoming SNS-CONFIG procedure (for SGSN) */ @@ -88,6 +94,7 @@ f_outgoing_sns_config(); f_incoming_sns_config(); setverdict(pass); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); } /* perform full SNS handshake and then outbound NS-ALIVE */ @@ -101,6 +108,7 @@ f_incoming_sns_config(); f_outgoing_ns_alive(); setverdict(pass); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); } control { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37812?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I08eee0d11ae04276ca1ad8fd58ebb93dd6d0066f Gerrit-Change-Number: 37812 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: SGSN_Tests_NS: TC_NS_connect_alive: set missing verdict
by lynxis lazus 13 Aug '24

13 Aug '24

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37813?usp=email ) Change subject: SGSN_Tests_NS: TC_NS_connect_alive: set missing verdict ...................................................................... SGSN_Tests_NS: TC_NS_connect_alive: set missing verdict Change-Id: I03574bc17a10d9098dcd25d73007ec5525c42c18 --- M sgsn/SGSN_Tests_NS.ttcn 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/13/37813/1 diff --git a/sgsn/SGSN_Tests_NS.ttcn b/sgsn/SGSN_Tests_NS.ttcn index ed21d5f..e1bc4a7 100644 --- a/sgsn/SGSN_Tests_NS.ttcn +++ b/sgsn/SGSN_Tests_NS.ttcn @@ -47,6 +47,7 @@ f_sleep(1.0); f_clean_ns_codec(); + setverdict(pass); Misc_Helpers.f_shutdown(__BFILE__, __LINE__); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37813?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I03574bc17a10d9098dcd25d73007ec5525c42c18 Gerrit-Change-Number: 37813 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

2026

2025

2024

2023

2022

gerrit-log