dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37819?usp=email )
Change subject: WIP: Testsuite for pySim-shell with real cards
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I am currently working on a testsuite for pySim-shell in python. This is currently work in progress but comments and suggestions are welcome already.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/37819?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ieae1330767a6e55e62437f5f988a0d33b727b5de
Gerrit-Change-Number: 37819
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Thu, 15 Aug 2024 07:59:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Jenkins Builder has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37819?usp=email )
Change subject: WIP: Testsuite for pySim-shell with real cards
......................................................................
Patch Set 1:
(2 comments)
File tests/pySim-shell_test/README.txt:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17725):
https://gerrit.osmocom.org/c/pysim/+/37819/comment/2535b2d8_ad1b9141?usp=em… :
PS1, Line 6: Run a specfic test (e.g. export_fs) with:
'specfic' may be misspelled - perhaps 'specific'?
File tests/pySim-shell_test/utils.py:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17725):
https://gerrit.osmocom.org/c/pysim/+/37819/comment/00f66755_76c39d7c?usp=em… :
PS1, Line 71: the executed testcase and ensures that the requred card are present. The API user should call this method at
'requred' may be misspelled - perhaps 'required'?
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/37819?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ieae1330767a6e55e62437f5f988a0d33b727b5de
Gerrit-Change-Number: 37819
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Thu, 15 Aug 2024 07:57:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/37819?usp=email )
Change subject: WIP: Testsuite for pySim-shell with real cards
......................................................................
WIP: Testsuite for pySim-shell with real cards
Related: OS#6531
Change-Id: Ieae1330767a6e55e62437f5f988a0d33b727b5de
---
A tests/pySim-shell_test/README.txt
A tests/pySim-shell_test/__init__.py
A tests/pySim-shell_test/card_data.csv
A tests/pySim-shell_test/config.toml
A tests/pySim-shell_test/export_adf_ara_m/__init__.py
A tests/pySim-shell_test/export_adf_ara_m/adf_ara-m.cfg.ok
A tests/pySim-shell_test/export_adf_ara_m/adf_ara-m.script.ok
A tests/pySim-shell_test/export_adf_ara_m/adf_ara-m_empty.cfg.ok
A tests/pySim-shell_test/export_adf_ara_m/test.py
A tests/pySim-shell_test/export_adf_ara_m/test.script
A tests/pySim-shell_test/export_fs/__init__.py
A tests/pySim-shell_test/export_fs/export.script.ok
A tests/pySim-shell_test/export_fs/test.py
A tests/pySim-shell_test/export_fs/test.script
A tests/pySim-shell_test/fsdump/__init__.py
A tests/pySim-shell_test/fsdump/export.script.ok
A tests/pySim-shell_test/fsdump/fsdump.json.ok
A tests/pySim-shell_test/fsdump/test.py
A tests/pySim-shell_test/fsdump/test.script
A tests/pySim-shell_test/navigate_fs/__init__.py
A tests/pySim-shell_test/navigate_fs/checkpoints.ok
A tests/pySim-shell_test/navigate_fs/test.py
A tests/pySim-shell_test/navigate_fs/test.script
A tests/pySim-shell_test/utils.py
A tests/pySim-shell_test/verify_adm/__init__.py
A tests/pySim-shell_test/verify_adm/ef_sim_auth_key.ok
A tests/pySim-shell_test/verify_adm/test.py
A tests/pySim-shell_test/verify_adm/test_cmdline.script
A tests/pySim-shell_test/verify_adm/test_csv.script
A tests/pySim-shell_test/verify_adm/test_direct.script.template
30 files changed, 25,106 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/19/37819/1
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/37819?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ieae1330767a6e55e62437f5f988a0d33b727b5de
Gerrit-Change-Number: 37819
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/37818?usp=email )
Change subject: core/socket.c: Provide more context when printing error message
......................................................................
core/socket.c: Provide more context when printing error message
Let's include the AF, SOCKTYPE and PROTO numbers when logging an error
like "unable to create socket: Address family not supported by protocol"
Change-Id: I91b05d0520b5432ca301cf6fd34468c2f4ac9b72
Related: SYS#7047
---
M src/core/socket.c
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/18/37818/1
diff --git a/src/core/socket.c b/src/core/socket.c
index 80a9d0e..97708a7 100644
--- a/src/core/socket.c
+++ b/src/core/socket.c
@@ -172,8 +172,8 @@
sfd = socket(rp->ai_family, rp->ai_socktype, rp->ai_protocol);
if (sfd == -1) {
- LOGP(DLGLOBAL, LOGL_ERROR,
- "unable to create socket: %s\n", strerror(errno));
+ LOGP(DLGLOBAL, LOGL_ERROR, "unable to create socket(%d, %d, %d): %s\n",
+ rp->ai_family, rp->ai_socktype, rp->ai_protocol, strerror(errno));
return sfd;
}
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37818?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I91b05d0520b5432ca301cf6fd34468c2f4ac9b72
Gerrit-Change-Number: 37818
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Attention is currently required from: fixeria, neels.
laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37795?usp=email )
Change subject: erab_fsm: include Network Instance IE in PDRs and FARs
......................................................................
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37795?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I4dbe8e0b1d14eed5fdb3f9f3f2543c44fd543d22
Gerrit-Change-Number: 37795
Gerrit-PatchSet: 5
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 14 Aug 2024 11:28:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/37816?usp=email )
Change subject: (Do not merge) CI test
......................................................................
(Do not merge) CI test
Change-Id: Idd0d5b64644f98a8c195bcafb6ff2aed9109eb11
---
A test
1 file changed, 0 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/16/37816/1
diff --git a/test b/test
new file mode 100644
index 0000000..e69de29
--- /dev/null
+++ b/test
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37816?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: libosmocore
Gerrit-Branch: osmith/wip
Gerrit-Change-Id: Idd0d5b64644f98a8c195bcafb6ff2aed9109eb11
Gerrit-Change-Number: 37816
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>