- gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: SGSN_Tests: add paging a whole routing area with multiple cells
by lynxis lazus 13 Aug '24

13 Aug '24

Attention is currently required from: fixeria, laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37796?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: SGSN_Tests: add paging a whole routing area with multiple cells ...................................................................... SGSN_Tests: add paging a whole routing area with multiple cells 1. Attach + PDP Request 2. Wait for UE to be in Standby 3. Transmit to GTP Userdata 4. See the Paging on 2 BVCIs within the Routing Area Change-Id: I88dc95669d57278a96e05ec84f934ebf70b319e5 --- M sgsn/SGSN_Tests.ttcn 1 file changed, 50 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/96/37796/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37796?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I88dc95669d57278a96e05ec84f934ebf70b319e5 Gerrit-Change-Number: 37796 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-sgsn[master]: build: do not link against libosmo-abis
by fixeria 13 Aug '24

13 Aug '24

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37793?usp=email ) Change subject: build: do not link against libosmo-abis ...................................................................... build: do not link against libosmo-abis We use 'struct ipa_client_conn' from libosmo-abis: src/sgsn/sgsn_vty.c:56:#include <osmocom/abis/ipa.h> but do not call any of its API directly, so linking against it is not necessary. Remove it from $LDADD, but keep in $CFLAGS. Change-Id: I11168a7b25942d6c70566441fb0a1d26c3ae5c43 Related: OS#6535 --- M src/sgsn/Makefile.am M tests/sgsn/Makefile.am M tests/sndcp_xid/Makefile.am M tests/xid/Makefile.am 4 files changed, 0 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/src/sgsn/Makefile.am b/src/sgsn/Makefile.am index 93b9fa0..487dead 100644 --- a/src/sgsn/Makefile.am +++ b/src/sgsn/Makefile.am @@ -79,7 +79,6 @@ $(top_builddir)/src/gprs/gprs_utils.o \ $(top_builddir)/src/gprs/sgsn_ares.o \ $(OSMO_LIBS) \ - $(LIBOSMOABIS_LIBS) \ $(LIBOSMOGSUPCLIENT_LIBS) \ $(LIBCARES_LIBS) \ $(LIBGTP_LIBS) \ diff --git a/tests/sgsn/Makefile.am b/tests/sgsn/Makefile.am index c6c1f4a..9cffdfd 100644 --- a/tests/sgsn/Makefile.am +++ b/tests/sgsn/Makefile.am @@ -84,7 +84,6 @@ $(top_builddir)/src/gprs/gprs_llc_parse.o \ $(top_builddir)/src/gprs/crc24.o \ $(top_builddir)/src/gprs/sgsn_ares.o \ - $(LIBOSMOABIS_LIBS) \ $(LIBOSMOCORE_LIBS) \ $(LIBOSMOCTRL_LIBS) \ $(LIBOSMOGSM_LIBS) \ diff --git a/tests/sndcp_xid/Makefile.am b/tests/sndcp_xid/Makefile.am index c4702b8..08bd27f 100644 --- a/tests/sndcp_xid/Makefile.am +++ b/tests/sndcp_xid/Makefile.am @@ -10,7 +10,6 @@ sndcp_xid_test_LDADD = \ $(top_builddir)/src/sgsn/gprs_sndcp_xid.o \ - $(LIBOSMOABIS_LIBS) \ $(LIBOSMOCORE_LIBS) \ $(LIBOSMOGSM_LIBS) \ $(LIBOSMOGB_LIBS) \ diff --git a/tests/xid/Makefile.am b/tests/xid/Makefile.am index d3a260b..284e392 100644 --- a/tests/xid/Makefile.am +++ b/tests/xid/Makefile.am @@ -27,7 +27,6 @@ xid_test_LDADD = \ $(top_builddir)/src/sgsn/gprs_llc_xid.o \ - $(LIBOSMOABIS_LIBS) \ $(LIBOSMOCORE_LIBS) \ $(LIBOSMOGSM_LIBS) \ $(LIBOSMOGB_LIBS) \ -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37793?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I11168a7b25942d6c70566441fb0a1d26c3ae5c43 Gerrit-Change-Number: 37793 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-sgsn[master]: build: remove indirect libosmo-netif dependency
by fixeria 13 Aug '24

13 Aug '24

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37792?usp=email ) Change subject: build: remove indirect libosmo-netif dependency ...................................................................... build: remove indirect libosmo-netif dependency Neither we include its headers nor call any of its functions. It's actually a dependency of libosmo-sccp, which is required for '--enable-iu', so keep it in contrib/jenkins.sh. Change-Id: Ia3395fd335d3a693c314b29b8e92968eef55da9a Related: OS#6535 --- M configure.ac M contrib/jenkins.sh M debian/control 3 files changed, 1 insertion(+), 3 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/configure.ac b/configure.ac index 7e318aa..5286d2e 100644 --- a/configure.ac +++ b/configure.ac @@ -44,7 +44,6 @@ PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.10.0) PKG_CHECK_MODULES(LIBOSMOGB, libosmogb >= 1.10.0) PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 1.6.0) -PKG_CHECK_MODULES(LIBOSMONETIF, libosmo-netif >= 1.5.0) PKG_CHECK_MODULES(LIBOSMOGSUPCLIENT, libosmo-gsup-client >= 1.8.0) PKG_CHECK_MODULES(LIBGTP, libgtp >= 1.12.0) diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 321beef..8db3a70 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -33,11 +33,11 @@ export PATH="$inst/bin:$PATH" osmo-build-dep.sh libosmo-abis -osmo-build-dep.sh libosmo-netif osmo-build-dep.sh osmo-ggsn osmo-build-dep.sh osmo-hlr if [ "x$IU" = "x--enable-iu" ]; then + osmo-build-dep.sh libosmo-netif osmo-build-dep.sh libosmo-sccp osmo-build-dep.sh libasn1c #osmo-build-dep.sh asn1c aper-prefix # only needed for make regen in osmo-iuh diff --git a/debian/control b/debian/control index c9c224b..a5c0c6e 100644 --- a/debian/control +++ b/debian/control @@ -14,7 +14,6 @@ libgtp-dev (>= 1.12.0), libosmocore-dev (>= 1.10.0), libosmo-abis-dev (>= 1.6.0), - libosmo-netif-dev (>= 1.5.0), libosmo-gsup-client-dev (>= 1.8.0), libasn1c-dev (>= 0.9.30), libosmo-ranap-dev (>= 1.6.0), -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37792?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ia3395fd335d3a693c314b29b8e92968eef55da9a Gerrit-Change-Number: 37792 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-sgsn[master]: build: remove indirect libosmo-netif dependency
by osmith 13 Aug '24

13 Aug '24

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37792?usp=email ) Change subject: build: remove indirect libosmo-netif dependency ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37792?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ia3395fd335d3a693c314b29b8e92968eef55da9a Gerrit-Change-Number: 37792 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Aug 2024 15:19:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-sgsn[master]: build: do not link against libosmo-abis
by osmith 13 Aug '24

13 Aug '24

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37793?usp=email ) Change subject: build: do not link against libosmo-abis ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37793?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I11168a7b25942d6c70566441fb0a1d26c3ae5c43 Gerrit-Change-Number: 37793 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Aug 2024 15:19:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmocore[master]: After writing VTY config, run sync() in a different thread
by Hoernchen 13 Aug '24

13 Aug '24

Attention is currently required from: jolly, laforge. Hoernchen has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/37798?usp=email ) Change subject: After writing VTY config, run sync() in a different thread ...................................................................... Patch Set 5: (1 comment) Patchset: PS2: > To avoid the delay problems, we don't want any write to delay the process. […] one gsm frame is 577us, so stalling a ms-sdr setup for "just 1 ms" while processing bursts is not a good idea, and that is why the non-libosmocore parts have a thread pool. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37798?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3cb2ee68b2e4c730f96522208c4abf00d0f49a44 Gerrit-Change-Number: 37798 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: Hoernchen <ewild(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 13 Aug 2024 11:40:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de> Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[M] Change in libosmocore[master]: After writing VTY config, run sync() in a different thread
by fixeria 13 Aug '24

13 Aug '24

Attention is currently required from: jolly, laforge. fixeria has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/37798?usp=email ) Change subject: After writing VTY config, run sync() in a different thread ...................................................................... Patch Set 5: (1 comment) File src/vty/command.c: https://gerrit.osmocom.org/c/libosmocore/+/37798/comment/a6e4483c_880eccf5?… : PS3, Line 3380: char *sync_config; > I am getting a bit lazy about that. […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37798?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3cb2ee68b2e4c730f96522208c4abf00d0f49a44 Gerrit-Change-Number: 37798 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: Hoernchen <ewild(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 13 Aug 2024 11:05:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in libosmocore[master]: After writing VTY config, run sync() in a different thread
by jolly 13 Aug '24

13 Aug '24

Attention is currently required from: fixeria, jolly, laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/37798?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: After writing VTY config, run sync() in a different thread ...................................................................... After writing VTY config, run sync() in a different thread Running sync() after writing VTY config causes the process to stop for a fraction of a second. This may result in delayed processing that causes buffer underruns, overflows and delay. After writing VTY configuration to the config file, a new thread is created. This thread runs the sync() command. Once it returns, the thread will signal through a pipe to the main thread that the sync process is complete. The main process will then output the completion message as logging message. Related: OS#6438 Change-Id: I3cb2ee68b2e4c730f96522208c4abf00d0f49a44 --- M src/vty/command.c 1 file changed, 116 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/98/37798/5 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37798?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3cb2ee68b2e4c730f96522208c4abf00d0f49a44 Gerrit-Change-Number: 37798 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: Hoernchen <ewild(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in libosmocore[master]: After writing VTY config, run sync() in a different thread
by jolly 13 Aug '24

13 Aug '24

Attention is currently required from: fixeria, laforge. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/37798?usp=email ) Change subject: After writing VTY config, run sync() in a different thread ...................................................................... Patch Set 4: (1 comment) File src/vty/command.c: https://gerrit.osmocom.org/c/libosmocore/+/37798/comment/1a0ab1d5_82ec15a3?… : PS3, Line 3380: char *sync_config; > why not `static`? I am getting a bit lazy about that. Since I am using -Wmissing-prototypes in all of my makefiles, I let the compiler detect that. Maybe we should do that with osmocom projects too. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37798?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3cb2ee68b2e4c730f96522208c4abf00d0f49a44 Gerrit-Change-Number: 37798 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: Hoernchen <ewild(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Aug 2024 11:02:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in libosmocore[master]: After writing VTY config, run sync() in a different thread
by fixeria 13 Aug '24

13 Aug '24

Attention is currently required from: jolly, laforge. fixeria has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/37798?usp=email ) Change subject: After writing VTY config, run sync() in a different thread ...................................................................... Patch Set 3: (1 comment) File src/vty/command.c: https://gerrit.osmocom.org/c/libosmocore/+/37798/comment/61c884f0_2ece1f1e?… : PS3, Line 3380: char *sync_config; why not `static`? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37798?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3cb2ee68b2e4c730f96522208c4abf00d0f49a44 Gerrit-Change-Number: 37798 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: Hoernchen <ewild(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 13 Aug 2024 10:59:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

2026

2025

2024

2023

2022

gerrit-log