- gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: tests: move pySim-prog test and its data into a sub directory
by dexter 15 Aug '24

15 Aug '24

Attention is currently required from: dexter. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/37823?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: tests: move pySim-prog test and its data into a sub directory ...................................................................... tests: move pySim-prog test and its data into a sub directory We currently have the shell script that performs the test in the tests directory and the related data in pysim-testdata directory. This is confusing, let's have evrything in a dedicated sub directory Change-Id: Ic995a7f600d164fc0be3c2eb8255dbe043429bea Related: OS#6531 --- M contrib/jenkins.sh R tests/pySim-prog_test/Fairwaves-SIM.data R tests/pySim-prog_test/Fairwaves-SIM.ok R tests/pySim-prog_test/Wavemobile-SIM.data R tests/pySim-prog_test/Wavemobile-SIM.ok R tests/pySim-prog_test/fakemagicsim.data R tests/pySim-prog_test/fakemagicsim.ok R tests/pySim-prog_test/pySim-prog_test.sh R tests/pySim-prog_test/sysmoISIM-SJA2.data R tests/pySim-prog_test/sysmoISIM-SJA2.ok R tests/pySim-prog_test/sysmoUSIM-SJS1.data R tests/pySim-prog_test/sysmoUSIM-SJS1.ok R tests/pySim-prog_test/sysmosim-gr1.data R tests/pySim-prog_test/sysmosim-gr1.ok 14 files changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/23/37823/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37823?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic995a7f600d164fc0be3c2eb8255dbe043429bea Gerrit-Change-Number: 37823 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in pysim[master]: tests: move pySim-prog test and its data into a sub directory
by Jenkins Builder 15 Aug '24

15 Aug '24

Jenkins Builder has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37823?usp=email ) Change subject: tests: move pySim-prog test and its data into a sub directory ...................................................................... Patch Set 1: (1 comment) File tests/pySim-prog_test/pySim-prog_test.sh: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17730): https://gerrit.osmocom.org/c/pysim/+/37823/comment/1df925fe_4d7b8c82?usp=em… : PS1, Line 23: # All pathes relative to the location of this script 'pathes' may be misspelled - perhaps 'paths'? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37823?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic995a7f600d164fc0be3c2eb8255dbe043429bea Gerrit-Change-Number: 37823 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 15 Aug 2024 10:53:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in pysim[master]: tests: move pySim-prog test and its data into a sub directory
by dexter 15 Aug '24

15 Aug '24

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/37823?usp=email ) Change subject: tests: move pySim-prog test and its data into a sub directory ...................................................................... tests: move pySim-prog test and its data into a sub directory We currently have the shell script that performs the test in the tests directory and the related data in pysim-testdata directory. This is confusing, let's have evrything in a dedicated sub directory Change-Id: Ic995a7f600d164fc0be3c2eb8255dbe043429bea Related: OS#6531 --- M contrib/jenkins.sh R tests/pySim-prog_test/Fairwaves-SIM.data R tests/pySim-prog_test/Fairwaves-SIM.ok R tests/pySim-prog_test/Wavemobile-SIM.data R tests/pySim-prog_test/Wavemobile-SIM.ok R tests/pySim-prog_test/fakemagicsim.data R tests/pySim-prog_test/fakemagicsim.ok R tests/pySim-prog_test/pySim-prog_test.sh R tests/pySim-prog_test/sysmoISIM-SJA2.data R tests/pySim-prog_test/sysmoISIM-SJA2.ok R tests/pySim-prog_test/sysmoUSIM-SJS1.data R tests/pySim-prog_test/sysmoUSIM-SJS1.ok R tests/pySim-prog_test/sysmosim-gr1.data R tests/pySim-prog_test/sysmosim-gr1.ok 14 files changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/23/37823/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index f0b4d23..abbf352 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -28,9 +28,7 @@ python -m unittest discover -v -s tests/unittests # Run the test with physical cards - cd pysim-testdata - ../tests/pySim-prog_test.sh - cd .. + tests/pySim-prog_test/pySim-prog_test.sh # Run pySim-trace test tests/pySim-trace_test/pySim-trace_test.sh diff --git a/pysim-testdata/Fairwaves-SIM.data b/tests/pySim-prog_test/Fairwaves-SIM.data similarity index 100% rename from pysim-testdata/Fairwaves-SIM.data rename to tests/pySim-prog_test/Fairwaves-SIM.data diff --git a/pysim-testdata/Fairwaves-SIM.ok b/tests/pySim-prog_test/Fairwaves-SIM.ok similarity index 100% rename from pysim-testdata/Fairwaves-SIM.ok rename to tests/pySim-prog_test/Fairwaves-SIM.ok diff --git a/pysim-testdata/Wavemobile-SIM.data b/tests/pySim-prog_test/Wavemobile-SIM.data similarity index 100% rename from pysim-testdata/Wavemobile-SIM.data rename to tests/pySim-prog_test/Wavemobile-SIM.data diff --git a/pysim-testdata/Wavemobile-SIM.ok b/tests/pySim-prog_test/Wavemobile-SIM.ok similarity index 100% rename from pysim-testdata/Wavemobile-SIM.ok rename to tests/pySim-prog_test/Wavemobile-SIM.ok diff --git a/pysim-testdata/fakemagicsim.data b/tests/pySim-prog_test/fakemagicsim.data similarity index 100% rename from pysim-testdata/fakemagicsim.data rename to tests/pySim-prog_test/fakemagicsim.data diff --git a/pysim-testdata/fakemagicsim.ok b/tests/pySim-prog_test/fakemagicsim.ok similarity index 100% rename from pysim-testdata/fakemagicsim.ok rename to tests/pySim-prog_test/fakemagicsim.ok diff --git a/tests/pySim-prog_test.sh b/tests/pySim-prog_test/pySim-prog_test.sh similarity index 97% rename from tests/pySim-prog_test.sh rename to tests/pySim-prog_test/pySim-prog_test.sh index 28d9777..0de80a3 100755 --- a/tests/pySim-prog_test.sh +++ b/tests/pySim-prog_test/pySim-prog_test.sh @@ -20,13 +20,15 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see <http://www.gnu.org/licenses/>. -PYSIM_PROG=../pySim-prog.py -PYSIM_READ=../pySim-read.py +# All pathes relative to the location of this script +PYSIM_PROG=../../pySim-prog.py +PYSIM_READ=../../pySim-read.py TEMPFILE=temp.tmp PYTHON=python3 export PYSIM_INTEGRATION_TEST=1 set -e +cd "$(dirname "$0")" echo "pySim-prog_test - a test program to test pySim-prog.py" echo "======================================================" diff --git a/pysim-testdata/sysmoISIM-SJA2.data b/tests/pySim-prog_test/sysmoISIM-SJA2.data similarity index 100% rename from pysim-testdata/sysmoISIM-SJA2.data rename to tests/pySim-prog_test/sysmoISIM-SJA2.data diff --git a/pysim-testdata/sysmoISIM-SJA2.ok b/tests/pySim-prog_test/sysmoISIM-SJA2.ok similarity index 100% rename from pysim-testdata/sysmoISIM-SJA2.ok rename to tests/pySim-prog_test/sysmoISIM-SJA2.ok diff --git a/pysim-testdata/sysmoUSIM-SJS1.data b/tests/pySim-prog_test/sysmoUSIM-SJS1.data similarity index 100% rename from pysim-testdata/sysmoUSIM-SJS1.data rename to tests/pySim-prog_test/sysmoUSIM-SJS1.data diff --git a/pysim-testdata/sysmoUSIM-SJS1.ok b/tests/pySim-prog_test/sysmoUSIM-SJS1.ok similarity index 100% rename from pysim-testdata/sysmoUSIM-SJS1.ok rename to tests/pySim-prog_test/sysmoUSIM-SJS1.ok diff --git a/pysim-testdata/sysmosim-gr1.data b/tests/pySim-prog_test/sysmosim-gr1.data similarity index 100% rename from pysim-testdata/sysmosim-gr1.data rename to tests/pySim-prog_test/sysmosim-gr1.data diff --git a/pysim-testdata/sysmosim-gr1.ok b/tests/pySim-prog_test/sysmosim-gr1.ok similarity index 100% rename from pysim-testdata/sysmosim-gr1.ok rename to tests/pySim-prog_test/sysmosim-gr1.ok -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37823?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic995a7f600d164fc0be3c2eb8255dbe043429bea Gerrit-Change-Number: 37823 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: tests: move unittests into a sub directory
by dexter 15 Aug '24

15 Aug '24

Attention is currently required from: dexter. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/37821?usp=email to look at the new patch set (#3). Change subject: tests: move unittests into a sub directory ...................................................................... tests: move unittests into a sub directory We currently mix the unit-tests with the shell script based integration tests. Let's put them into a dedicated sub directory. Related: OS#6531 Change-Id: I0978c5353d0d479a050bbb6e7ae5a63db5e08d24 --- M contrib/jenkins.sh R tests/unittests/test_apdu.py R tests/unittests/test_construct.py R tests/unittests/test_esim.py R tests/unittests/test_esim_bsp.py R tests/unittests/test_esim_saip.py R tests/unittests/test_euicc.py R tests/unittests/test_files.py R tests/unittests/test_globalplatform.py R tests/unittests/test_ota.py R tests/unittests/test_sms.py R tests/unittests/test_tlv.py R tests/unittests/test_tlvs.py R tests/unittests/test_utils.py 14 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/21/37821/3 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37821?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0978c5353d0d479a050bbb6e7ae5a63db5e08d24 Gerrit-Change-Number: 37821 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: tests: move pySim-trace test and its data into a sub directory
by dexter 15 Aug '24

15 Aug '24

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/37822?usp=email ) Change subject: tests: move pySim-trace test and its data into a sub directory ...................................................................... tests: move pySim-trace test and its data into a sub directory We currently have the test data for pySim-trace in pysim-testdata. This means we mix the test data with the data from our original pySim integration tests. This is very confusing. Let's put the test data and the testcase for pySim-trace into a dedicated sub directory. Change-Id: I565b4268a05c1a1334b5e7d3fbcd9ef2ef0f0c4c Related: OS#6531 --- M contrib/jenkins.sh R tests/pySim-trace_test/pySim-trace_test.sh R tests/pySim-trace_test/pySim-trace_test_gsmtap.pcapng R tests/pySim-trace_test/pySim-trace_test_gsmtap.pcapng.ok 4 files changed, 6 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/22/37822/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 473a8a5..f0b4d23 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -30,7 +30,10 @@ # Run the test with physical cards cd pysim-testdata ../tests/pySim-prog_test.sh - ../tests/pySim-trace_test.sh + cd .. + + # Run pySim-trace test + tests/pySim-trace_test/pySim-trace_test.sh ;; "distcheck") virtualenv -p python3 venv --system-site-packages diff --git a/tests/pySim-trace_test.sh b/tests/pySim-trace_test/pySim-trace_test.sh similarity index 95% rename from tests/pySim-trace_test.sh rename to tests/pySim-trace_test/pySim-trace_test.sh index 3e200c3..ec23ad3 100755 --- a/tests/pySim-trace_test.sh +++ b/tests/pySim-trace_test/pySim-trace_test.sh @@ -20,8 +20,8 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see <http://www.gnu.org/licenses/>. -PYSIM_TRACE=../pySim-trace.py -GSMTAP_TRACE=pySim-trace_test_gsmtap.pcapng +PYSIM_TRACE=./pySim-trace.py +GSMTAP_TRACE=./tests/pySim-trace_test/pySim-trace_test_gsmtap.pcapng TEMPFILE=temp.tmp export PYSIM_INTEGRATION_TEST=1 diff --git a/pysim-testdata/pySim-trace_test_gsmtap.pcapng b/tests/pySim-trace_test/pySim-trace_test_gsmtap.pcapng similarity index 100% rename from pysim-testdata/pySim-trace_test_gsmtap.pcapng rename to tests/pySim-trace_test/pySim-trace_test_gsmtap.pcapng Binary files differ diff --git a/pysim-testdata/pySim-trace_test_gsmtap.pcapng.ok b/tests/pySim-trace_test/pySim-trace_test_gsmtap.pcapng.ok similarity index 100% rename from pysim-testdata/pySim-trace_test_gsmtap.pcapng.ok rename to tests/pySim-trace_test/pySim-trace_test_gsmtap.pcapng.ok -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37822?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I565b4268a05c1a1334b5e7d3fbcd9ef2ef0f0c4c Gerrit-Change-Number: 37822 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: tests: move unittests into sub directory
by dexter 15 Aug '24

15 Aug '24

Attention is currently required from: dexter. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/37821?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: tests: move unittests into sub directory ...................................................................... tests: move unittests into sub directory We currently mix the unit-tests with the shell script based integration tests. Let's put them into a dedicated sub directory. Related: OS#6531 Change-Id: I0978c5353d0d479a050bbb6e7ae5a63db5e08d24 --- M contrib/jenkins.sh R tests/unittests/test_apdu.py R tests/unittests/test_construct.py R tests/unittests/test_esim.py R tests/unittests/test_esim_bsp.py R tests/unittests/test_esim_saip.py R tests/unittests/test_euicc.py R tests/unittests/test_files.py R tests/unittests/test_globalplatform.py R tests/unittests/test_ota.py R tests/unittests/test_sms.py R tests/unittests/test_tlv.py R tests/unittests/test_tlvs.py R tests/unittests/test_utils.py 14 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/21/37821/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37821?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0978c5353d0d479a050bbb6e7ae5a63db5e08d24 Gerrit-Change-Number: 37821 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: tests: move unittests into sub directory
by dexter 15 Aug '24

15 Aug '24

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/37821?usp=email ) Change subject: tests: move unittests into sub directory ...................................................................... tests: move unittests into sub directory We currently mix the unit-tests with the shell script based integration tests. Let's put them into a dedicated sub directory. Related: OS#6531 Change-Id: I0978c5353d0d479a050bbb6e7ae5a63db5e08d24 --- M contrib/jenkins.sh R tests/unittests/test_apdu.py R tests/unittests/test_construct.py R tests/unittests/test_esim.py R tests/unittests/test_esim_bsp.py R tests/unittests/test_esim_saip.py R tests/unittests/test_euicc.py R tests/unittests/test_files.py R tests/unittests/test_globalplatform.py R tests/unittests/test_ota.py R tests/unittests/test_sms.py R tests/unittests/test_tlv.py R tests/unittests/test_tlvs.py R tests/unittests/test_utils.py 14 files changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/21/37821/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index a35241d..c42d3fe 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -25,7 +25,7 @@ pip install pyshark # Execute automatically discovered unit tests first - python -m unittest discover -v -s tests/ + python -m unittest discover -v -s tests/unittests # Run the test with physical cards cd pysim-testdata diff --git a/tests/test_apdu.py b/tests/unittests/test_apdu.py similarity index 100% rename from tests/test_apdu.py rename to tests/unittests/test_apdu.py diff --git a/tests/test_construct.py b/tests/unittests/test_construct.py similarity index 100% rename from tests/test_construct.py rename to tests/unittests/test_construct.py diff --git a/tests/test_esim.py b/tests/unittests/test_esim.py similarity index 100% rename from tests/test_esim.py rename to tests/unittests/test_esim.py diff --git a/tests/test_esim_bsp.py b/tests/unittests/test_esim_bsp.py similarity index 100% rename from tests/test_esim_bsp.py rename to tests/unittests/test_esim_bsp.py diff --git a/tests/test_esim_saip.py b/tests/unittests/test_esim_saip.py similarity index 100% rename from tests/test_esim_saip.py rename to tests/unittests/test_esim_saip.py diff --git a/tests/test_euicc.py b/tests/unittests/test_euicc.py similarity index 100% rename from tests/test_euicc.py rename to tests/unittests/test_euicc.py diff --git a/tests/test_files.py b/tests/unittests/test_files.py similarity index 100% rename from tests/test_files.py rename to tests/unittests/test_files.py diff --git a/tests/test_globalplatform.py b/tests/unittests/test_globalplatform.py similarity index 100% rename from tests/test_globalplatform.py rename to tests/unittests/test_globalplatform.py diff --git a/tests/test_ota.py b/tests/unittests/test_ota.py similarity index 100% rename from tests/test_ota.py rename to tests/unittests/test_ota.py diff --git a/tests/test_sms.py b/tests/unittests/test_sms.py similarity index 100% rename from tests/test_sms.py rename to tests/unittests/test_sms.py diff --git a/tests/test_tlv.py b/tests/unittests/test_tlv.py similarity index 100% rename from tests/test_tlv.py rename to tests/unittests/test_tlv.py diff --git a/tests/test_tlvs.py b/tests/unittests/test_tlvs.py similarity index 100% rename from tests/test_tlvs.py rename to tests/unittests/test_tlvs.py diff --git a/tests/test_utils.py b/tests/unittests/test_utils.py similarity index 100% rename from tests/test_utils.py rename to tests/unittests/test_utils.py -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37821?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0978c5353d0d479a050bbb6e7ae5a63db5e08d24 Gerrit-Change-Number: 37821 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in libosmo-netif[master]: stream_test: don't check if uint8_t is negative
by laforge 15 Aug '24

15 Aug '24

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/37820?usp=email ) Change subject: stream_test: don't check if uint8_t is negative ...................................................................... stream_test: don't check if uint8_t is negative Change-Id: Ic4fac424dcd06c3e235e7bd64c934eb446edb906 Closes: CID#323030 --- M tests/stream/stream_test.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/20/37820/1 diff --git a/tests/stream/stream_test.c b/tests/stream/stream_test.c index 67f7429..f2f1d4f 100644 --- a/tests/stream/stream_test.c +++ b/tests/stream/stream_test.c @@ -516,7 +516,7 @@ } LOGCLI(osc, "Received message from stream (payload len = %" PRIu16 ")\n", msgb_length(msg)); - if (ipac_msg_type < 0 || 5 < ipac_msg_type) { + if (5 < ipac_msg_type) { fprintf(stderr, "Received unexpected IPAC message type %"PRIu8"\n", ipac_msg_type); msgb_free(msg); return -ENOMSG; -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/37820?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ic4fac424dcd06c3e235e7bd64c934eb446edb906 Gerrit-Change-Number: 37820 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

1 0

[XL] Change in pysim[master]: WIP: Testsuite for pySim-shell with real cards
by laforge 15 Aug '24

15 Aug '24

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37819?usp=email ) Change subject: WIP: Testsuite for pySim-shell with real cards ...................................................................... Patch Set 1: (4 comments) File tests/pySim-shell_test/config.toml: https://gerrit.osmocom.org/c/pysim/+/37819/comment/f89777ec_447b4a11?usp=em… : PS1, Line 2: {name = "sysmoISIM-SJA5", atr = "3B9F96801F878031E073FE211B674A357530350259C4", adm = "46369345"}, > I am not happy with the adm in config.toml and card_cata.csv. […] card_data.csv is looked up by ICCID. So if you have ICCID + ADM in the CSV, pySim-shell can resolve it by the ICCID of the card. File tests/pySim-shell_test/export_adf_ara_m/test.script: https://gerrit.osmocom.org/c/pysim/+/37819/comment/273f8698_2efa1c8a?usp=em… : PS1, Line 26: sysmoUSIM it is unsupported in bertrand martel's ARA-M applet. As the sysmoEUICC1 is not using that applet, but a built-in one of the CardOS, that constrant doesn't apply there. File tests/pySim-shell_test/export_fs/export.script.ok: https://gerrit.osmocom.org/c/pysim/+/37819/comment/f43ff457_2b898c5a?usp=em… : PS1, Line 7: # there's a non-zero chance that the comment section here will change over time, especially even including the decoded FCP template. For the test, the only thing that matters is the actual non-comment commands generated by the export. Maybe we should pipe the output through a grep that drops all comment lines starting with '#'? This way any future change to the comment section would not require lots of modification to the .ok file. File tests/pySim-shell_test/export_fs/test.py: https://gerrit.osmocom.org/c/pysim/+/37819/comment/ca3c4841_45acf5b8?usp=em… : PS1, Line 35: aram_store_ref_ar_do ah, ok. you already have ignore-regexes. MAybe simply ignore all comments here? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37819?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ieae1330767a6e55e62437f5f988a0d33b727b5de Gerrit-Change-Number: 37819 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Aug 2024 08:54:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[XL] Change in pysim[master]: WIP: Testsuite for pySim-shell with real cards
by dexter 15 Aug '24

15 Aug '24

dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37819?usp=email ) Change subject: WIP: Testsuite for pySim-shell with real cards ...................................................................... Patch Set 1: (1 comment) File tests/pySim-shell_test/config.toml: https://gerrit.osmocom.org/c/pysim/+/37819/comment/5824ffc2_5f4cf926?usp=em… : PS1, Line 2: {name = "sysmoISIM-SJA5", atr = "3B9F96801F878031E073FE211B674A357530350259C4", adm = "46369345"}, I am not happy with the adm in config.toml and card_cata.csv. Maybe we should parse the ADM from card_data.csv? But then we have to put some key here to connect the entries. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37819?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ieae1330767a6e55e62437f5f988a0d33b727b5de Gerrit-Change-Number: 37819 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Thu, 15 Aug 2024 08:08:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

2026

2025

2024

2023

2022

gerrit-log