Attention is currently required from: dexter.

laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37819?usp=email )

Change subject: WIP: Testsuite for pySim-shell with real cards ......................................................................

Patch Set 1:

(4 comments)

File tests/pySim-shell_test/config.toml:

https://gerrit.osmocom.org/c/pysim/+/37819/comment/f89777ec_447b4a11?usp=ema... : PS1, Line 2: {name = "sysmoISIM-SJA5", atr = "3B9F96801F878031E073FE211B674A357530350259C4", adm = "46369345"},

I am not happy with the adm in config.toml and card_cata.csv. […]

card_data.csv is looked up by ICCID. So if you have ICCID + ADM in the CSV, pySim-shell can resolve it by the ICCID of the card.

File tests/pySim-shell_test/export_adf_ara_m/test.script:

https://gerrit.osmocom.org/c/pysim/+/37819/comment/273f8698_2efa1c8a?usp=ema... : PS1, Line 26: sysmoUSIM it is unsupported in bertrand martel's ARA-M applet. As the sysmoEUICC1 is not using that applet, but a built-in one of the CardOS, that constrant doesn't apply there.

File tests/pySim-shell_test/export_fs/export.script.ok:

https://gerrit.osmocom.org/c/pysim/+/37819/comment/f43ff457_2b898c5a?usp=ema... : PS1, Line 7: # there's a non-zero chance that the comment section here will change over time, especially even including the decoded FCP template.

For the test, the only thing that matters is the actual non-comment commands generated by the export. Maybe we should pipe the output through a grep that drops all comment lines starting with '#'? This way any future change to the comment section would not require lots of modification to the .ok file.

File tests/pySim-shell_test/export_fs/test.py:

https://gerrit.osmocom.org/c/pysim/+/37819/comment/ca3c4841_45acf5b8?usp=ema... : PS1, Line 35: aram_store_ref_ar_do ah, ok. you already have ignore-regexes. MAybe simply ignore all comments here?