- gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: SGSN: BSSGP_ConnHdlr: GMM Service Request: add support to expect auth...
by lynxis lazus 25 Nov '24

25 Nov '24

Attention is currently required from: fixeria, laforge, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396?usp=email ) Change subject: SGSN: BSSGP_ConnHdlr: GMM Service Request: add support to expect authentication ...................................................................... Patch Set 5: (1 comment) File sgsn/BSSGP_ConnHdlr.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396/comment/d59f58a3_d295… : PS4, Line 358: as_gmm_auth > I don't want to block here, but yet I find this problematic. […] as_gmm_auth() is using f_gmm_auth_as() to not duplicate code. f_gmm_auth_as() is a private function and not exported. It is not a 3rd api. as_gmm_auth() vs f_gmm_auth(): f_gmm_auth: - requires an authentication if it is global enabled - forces + requires the order of - SAI Req - SAI Resp - Auth Req - Auth Resp - CommonId (if Iu enabled) - out of order: answer as_mm_identity() requests as_gmm_auth(): - ignores the order of requests - answers SAI Req (if enabled) - answers GMM Auth Req The old (or latest) SGSN won't do auth for many steps, even I think it should be mandatory here, while the new SGSN will handle it much better and do an Auth Req. To handle both gracefully (and I think) it doesn't matter for the testcase PDP Request time out, if an auth happened or not, just do it. While for other test case, e.g. Attach Request, it matters much more. I don't see how you can migrate all users to f_gmm_auth and I think adding order to the alt step, makes it much unreadable (not 100% sure if it is even possible, because we would use global state here). -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9ed08160bf5413e3a30d6e90eb947d4d799e1058 Gerrit-Change-Number: 38396 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Nov 2024 18:55:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[M] Change in osmo-ttcn3-hacks[master]: SGSN: BSSGP_ConnHdlr: GMM Service Request: add support to expect auth...
by fixeria 25 Nov '24

25 Nov '24

Attention is currently required from: laforge, lynxis lazus, pespin. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396?usp=email ) Change subject: SGSN: BSSGP_ConnHdlr: GMM Service Request: add support to expect authentication ...................................................................... Patch Set 5: Code-Review-1 (2 comments) File sgsn/BSSGP_ConnHdlr.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396/comment/a8c18fa5_bb94… : PS4, Line 358: as_gmm_auth I don't want to block here, but yet I find this problematic. We end up having two APIs with nearly the same name doing nearly the same thing, though having some difference in their behavior that is not documented anywhere. Oh, it's actually three APIs: `f_gmm_auth_as()`, `as_gmm_auth()`, and `f_gmm_auth()`... But my concern is more about `as_gmm_auth()` vs `f_gmm_auth()`. Imagine someone writing a new testcase and trying to use this API. Which one to use? The difference is not obvious unless you compare the two closely. What would it take to make `as_gmm_auth` more flexible and migrate the users of `f_gmm_auth()` to it? If this is hard and requires a lot of effort, please at least add a comment explaining the difference and probably a TODO for future migration? > [...] also it fails if you don't have an auth [...] > f_gmm_auth() requires to have an auth. it can also not used in alt steps. I don't understand what you mean here. Looking at the code, I see a big conditional block checking `g_pars.net.expect_auth` and skipping the entire function if it's `false` (actually sleep()ing for one second to catch GMM ID REQ). https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396/comment/d102bfc2_8d84… : PS4, Line 363: Ignoring autn for now > Done Ah, I see now: `f_gmm_auth()` does not check the AUTN in the GMM PDU either. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9ed08160bf5413e3a30d6e90eb947d4d799e1058 Gerrit-Change-Number: 38396 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 25 Nov 2024 18:33:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[M] Change in osmo-ttcn3-hacks[master]: SGSN: BSSGP_ConnHdlr: f_gmm_attach(): allow the SGSN to request the IMEI
by fixeria 25 Nov '24

25 Nov '24

Attention is currently required from: lynxis lazus, pespin. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38398?usp=email ) Change subject: SGSN: BSSGP_ConnHdlr: f_gmm_attach(): allow the SGSN to request the IMEI ...................................................................... Patch Set 7: (1 comment) Patchset: PS7: Other than unused stuff, it looks good to me. Feel free to apply CR+2 once this is resolved. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38398?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id49c9e6ef7517a6a831315ac1f9915c50b88beb6 Gerrit-Change-Number: 38398 Gerrit-PatchSet: 7 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 25 Nov 2024 17:59:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmo-ttcn3-hacks[master]: SGSN: BSSGP_ConnHdlr: f_gmm_attach(): allow the SGSN to request the IMEI
by fixeria 25 Nov '24

25 Nov '24

Attention is currently required from: lynxis lazus, pespin. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38398?usp=email ) Change subject: SGSN: BSSGP_ConnHdlr: f_gmm_attach(): allow the SGSN to request the IMEI ...................................................................... Patch Set 7: Code-Review-1 (2 comments) File sgsn/BSSGP_ConnHdlr.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38398/comment/0c695825_0114… : PS7, Line 254: boolean allow_imsi := true, boolean allow_imei := true unused args https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38398/comment/cf7a2db1_a682… : PS7, Line 269: var MobileIdentityLV mi; unused var -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38398?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id49c9e6ef7517a6a831315ac1f9915c50b88beb6 Gerrit-Change-Number: 38398 Gerrit-PatchSet: 7 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 25 Nov 2024 17:57:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: ts_31_102: fix testcase for EF_ePDGSelection
by dexter 25 Nov '24

25 Nov '24

dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38941?usp=email ) Change subject: ts_31_102: fix testcase for EF_ePDGSelection ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: Unfortunately this fix has a chicken-egg problem. The code looks correct to me. I even verified one of the testcases with pen and paper. Everything should be correct. However, the the build failure we see is in the pysim repository and I have fixed the testcases there now (see https://gerrit.osmocom.org/c/pysim/+/38941). The problem is that this of course only works with the fixed version of pyosmocom and the fixed version of pyosmocom only works with the fixed pysim. My suggestion would be to remove the pysim test from jenkins.sh as this creates some kind of a circular dependency. I have inserted a patch before this one that does that, we can discuss about this in that patch then (see https://gerrit.osmocom.org/c/python/pyosmocom/+/38942) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38941?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I96fd4c13c8e58ef33ddf9e3124617b1b59b9b2c1 Gerrit-Change-Number: 38941 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Nov 2024 17:46:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in ...pyosmocom[master]: Fixing 3-digit MNC PlmnAdapter encoding & decoding, and related tests.
by dexter 25 Nov '24

25 Nov '24

Attention is currently required from: JPM, fixeria, laforge. dexter has posted comments on this change by JPM. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38687?usp=email ) Change subject: Fixing 3-digit MNC PlmnAdapter encoding & decoding, and related tests. ...................................................................... Patch Set 7: (1 comment) Patchset: PS6: Unfortunately this fix has a chicken-egg problem. The code looks correct to me. I even verified one of the testcases with pen and paper. Everything should be correct. However, the the build failure we see is in the pysim repository and I have fixed the testcases there now (see https://gerrit.osmocom.org/c/pysim/+/38941). The problem is that this of course only works with the fixed version of pyosmocom and the fixed version of pyosmocom only works with the fixed pysim. My suggestion would be to remove the pysim test from jenkins.sh as this creates some kind of a circular dependency. I can take care of this, if the reviewers are ok with that. -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38687?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I3811b227d629bd4e051a480c9622967e31f8a376 Gerrit-Change-Number: 38687 Gerrit-PatchSet: 7 Gerrit-Owner: JPM <jean-pierre.marcotte.1(a)ens.etsmtl.ca> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: JPM <jean-pierre.marcotte.1(a)ens.etsmtl.ca> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Nov 2024 17:39:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in ...pyosmocom[master]: contrib: remove pysim job from jenkins.sh
by dexter 25 Nov '24

25 Nov '24

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38942?usp=email ) Change subject: contrib: remove pysim job from jenkins.sh ...................................................................... contrib: remove pysim job from jenkins.sh The "pysim" job in jenkins.sh has the purpose to check if a change in pyosmocom breaks some functionality in pysim. However, this check has a high risk of creating some kind of circular dependency (chicken-egg problem) between pyosmocom and pysim. The problem occurs when a fix/change in pyosmocom affects the unittests-output of pysim. Then the pysim job will always fail and it is also impossible to submit a complementary fix for pysim as well, since it will always build against the non-fixed pyosmocom library. So, let's remove the pysim job. In case we break functionality in pysim, we will notice it through the nightly builds of pysim and we can take action against the problem like we do it with all other osmocom projects. Related: OS#6598 Change-Id: I5c625229bbfe3944521d3d835b74f20941d3922d --- M contrib/jenkins.sh 1 file changed, 0 insertions(+), 24 deletions(-) git pull ssh://gerrit.osmocom.org:29418/python/pyosmocom refs/changes/42/38942/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index e5f8147..78c7fb2 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -48,30 +48,6 @@ make -C "docs" publish publish-html fi ;; -"pysim") - # Run the pysim tests with pyosmocom from this tree (OS#6570) - virtualenv -p python3 venv --system-site-packages - . venv/bin/activate - pip install . --force-reinstall - deactivate - - # Clone pysim and remove pyosmocom from requirements.txt, we want to - # use the version that was just installed into the venv instead - rm -rf pysim - git clone https://gerrit.osmocom.org/pysim --depth=1 --branch=master - cd pysim - sed -i '/^pyosmocom>=.*/d' requirements.txt - if grep -q pyosmocom requirements.txt; then - cat requirements.txt - set +x - echo "ERROR: failed to remove pyosmocom from pysim's requirements.txt" - exit 1 - fi - - # Let pysim enter the same venv and run the tests - ln -s ../venv . - SKIP_CLEAN_WORKSPACE=1 JOB_TYPE="test" contrib/jenkins.sh - ;; *) set +x echo "ERROR: JOB_TYPE has unexpected value '$JOB_TYPE'." -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38942?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I5c625229bbfe3944521d3d835b74f20941d3922d Gerrit-Change-Number: 38942 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in ...pyosmocom[master]: Fixing 3-digit MNC PlmnAdapter encoding & decoding, and related tests.
by dexter 25 Nov '24

25 Nov '24

Attention is currently required from: JPM, fixeria, laforge. dexter has uploaded a new patch set (#6) to the change originally created by JPM. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38687?usp=email ) The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+2 by fixeria Change subject: Fixing 3-digit MNC PlmnAdapter encoding & decoding, and related tests. ...................................................................... Fixing 3-digit MNC PlmnAdapter encoding & decoding, and related tests. Related: pysim.git Ib2b586cb570dbe74a617c45c0fca276b08bb075e Change-Id: I3811b227d629bd4e051a480c9622967e31f8a376 Depends: pysim.git: I3811b227d629bd4e051a480c9622967e31f8a376 Related: OS#6598 --- M src/osmocom/construct.py M tests/test_construct.py 2 files changed, 19 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/python/pyosmocom refs/changes/87/38687/6 -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38687?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I3811b227d629bd4e051a480c9622967e31f8a376 Gerrit-Change-Number: 38687 Gerrit-PatchSet: 6 Gerrit-Owner: JPM <jean-pierre.marcotte.1(a)ens.etsmtl.ca> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: JPM <jean-pierre.marcotte.1(a)ens.etsmtl.ca> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: ts_31_102: fix testcase for EF_ePDGSelection
by dexter 25 Nov '24

25 Nov '24

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/38941?usp=email ) Change subject: ts_31_102: fix testcase for EF_ePDGSelection ...................................................................... ts_31_102: fix testcase for EF_ePDGSelection the testcase EF_ePDGSelection has a wrong testvector in the plmn field. This test vector is accepted because there is a complementary error in pyosmocom. However, the root problem got fixed (see depends), which means that the test vector of EF_ePDGSelection now needs to be updated. Depends: pyosmocom.git: I3811b227d629bd4e051a480c9622967e31f8a376 Change-Id: I96fd4c13c8e58ef33ddf9e3124617b1b59b9b2c1 Related: OS#6598 --- M pySim/ts_31_102.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/41/38941/1 diff --git a/pySim/ts_31_102.py b/pySim/ts_31_102.py index 636cf37..20aa08f 100644 --- a/pySim/ts_31_102.py +++ b/pySim/ts_31_102.py @@ -875,7 +875,7 @@ class EF_ePDGSelection(TransparentEF): _test_de_encode = [ ( '800600f110000100', {'e_pdg_selection': [{'plmn': '001-01', 'epdg_priority': 1, 'epdg_fqdn_format': 'operator_identified' }] }), - ( '800600011000a001', {'e_pdg_selection': [{'plmn': '001-001', 'epdg_priority': 160, 'epdg_fqdn_format': 'location_based' }] }), + ( '800600011000a001', {'e_pdg_selection': [{'plmn': '001-010', 'epdg_priority': 160, 'epdg_fqdn_format': 'location_based' }] }), ] class ePDGSelection(BER_TLV_IE, tag=0x80): _construct = GreedyRange(Struct('plmn'/PlmnAdapter(Bytes(3)), -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38941?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I96fd4c13c8e58ef33ddf9e3124617b1b59b9b2c1 Gerrit-Change-Number: 38941 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[M] Change in libosmo-netif[master]: stream_cli: Support destroy object within user callback
by daniel 25 Nov '24

25 Nov '24

Attention is currently required from: fixeria, laforge, osmith, pespin. daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/38911?usp=email ) Change subject: stream_cli: Support destroy object within user callback ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/38911?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I952938474fa2780bf3c906cbdffb2d024b03c1b7 Gerrit-Change-Number: 38911 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Nov 2024 16:43:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log