Attention is currently required from: fixeria, laforge, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396?usp=email ) Change subject: SGSN: BSSGP_ConnHdlr: GMM Service Request: add support to expect authentication ...................................................................... Patch Set 5: (1 comment) File sgsn/BSSGP_ConnHdlr.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396/comment/d59f58a3_d2952... : PS4, Line 358: as_gmm_auth

I don't want to block here, but yet I find this problematic. […] as_gmm_auth() is using f_gmm_auth_as() to not duplicate code. f_gmm_auth_as() is a private function and not exported. It is not a 3rd api.

as_gmm_auth() vs f_gmm_auth(): f_gmm_auth: - requires an authentication if it is global enabled - forces + requires the order of - SAI Req - SAI Resp - Auth Req - Auth Resp - CommonId (if Iu enabled) - out of order: answer as_mm_identity() requests as_gmm_auth(): - ignores the order of requests - answers SAI Req (if enabled) - answers GMM Auth Req The old (or latest) SGSN won't do auth for many steps, even I think it should be mandatory here, while the new SGSN will handle it much better and do an Auth Req. To handle both gracefully (and I think) it doesn't matter for the testcase PDP Request time out, if an auth happened or not, just do it. While for other test case, e.g. Attach Request, it matters much more. I don't see how you can migrate all users to f_gmm_auth and I think adding order to the alt step, makes it much unreadable (not 100% sure if it is even possible, because we would use global state here). -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9ed08160bf5413e3a30d6e90eb947d4d799e1058 Gerrit-Change-Number: 38396 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Mon, 25 Nov 2024 18:55:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge@osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis@fe80.eu>