Attention is currently required from: laforge, lynxis lazus, pespin. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396?usp=email ) Change subject: SGSN: BSSGP_ConnHdlr: GMM Service Request: add support to expect authentication ...................................................................... Patch Set 5: Code-Review-1 (2 comments) File sgsn/BSSGP_ConnHdlr.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396/comment/a8c18fa5_bb94c... : PS4, Line 358: as_gmm_auth I don't want to block here, but yet I find this problematic. We end up having two APIs with nearly the same name doing nearly the same thing, though having some difference in their behavior that is not documented anywhere. Oh, it's actually three APIs: `f_gmm_auth_as()`, `as_gmm_auth()`, and `f_gmm_auth()`... But my concern is more about `as_gmm_auth()` vs `f_gmm_auth()`. Imagine someone writing a new testcase and trying to use this API. Which one to use? The difference is not obvious unless you compare the two closely. What would it take to make `as_gmm_auth` more flexible and migrate the users of `f_gmm_auth()` to it? If this is hard and requires a lot of effort, please at least add a comment explaining the difference and probably a TODO for future migration?

[...] also it fails if you don't have an auth [...] f_gmm_auth() requires to have an auth. it can also not used in alt steps.

I don't understand what you mean here. Looking at the code, I see a big conditional block checking `g_pars.net.expect_auth` and skipping the entire function if it's `false` (actually sleep()ing for one second to catch GMM ID REQ). https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396/comment/d102bfc2_8d843... : PS4, Line 363: Ignoring autn for now

Done Ah, I see now: `f_gmm_auth()` does not check the AUTN in the GMM PDU either.

-- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9ed08160bf5413e3a30d6e90eb947d4d799e1058 Gerrit-Change-Number: 38396 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis@fe80.eu> Gerrit-Comment-Date: Mon, 25 Nov 2024 18:33:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge@osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis@fe80.eu>