- gerrit-log - lists.osmocom.org

[XS] Change in osmo-sgsn[master]: gmm: Fix reject small size RAU request
by lynxis lazus 25 Nov '24

25 Nov '24

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/38940?usp=email ) Change subject: gmm: Fix reject small size RAU request ...................................................................... gmm: Fix reject small size RAU request A RAU Request can actually be 14 bytes long: """ GSM A-I/F DTAP - Routing Area Update Request Protocol Discriminator: GPRS mobility management messages (8) .... 1000 = Protocol discriminator: GPRS mobility management messages (0x8) 0000 .... = Skip Indicator: No indication of selected PLMN (0) DTAP GPRS Mobility Management Message Type: Routing Area Update Request (0x08) Update Type .... 0... = Follow-on request pending: False .... .000 = Update type: RA updating (0) Ciphering Key Sequence Number 0... .... = Spare bit(s): 0 .111 .... = key sequence: No key is available (MS to network) (7) Routing Area Identification - Old routing area identification - RAI: 262-42-13135-0 Routing area identification: 262-42-13135-0 Mobile Country Code (MCC): Germany (262) Mobile Network Code (MNC): Vodafone GmbH (42) Location Area Code (LAC): 0x334f (13135) Routing Area Code (RAC): 0x00 (0) MS Radio Access Capability Length: 4 MS RA capability 1 0001 .... = Access Technology Type: GSM E --note that GSM E covers GSM P (1) .... 0001 111. .... = Length in bits: 0x0f (15) ...0 01.. RF Power Capability, GMSK Power Class: Not specified (1) A5 Bits: Same values apply for parameters as in the immediately preceding Access capabilities field within this IE (0) .... ...1 = Controlled early Classmark Sending: Implemented 0... .... = Pseudo Synchronisation: Not Present .0.. .... = Voice Group Call Service: no VGCS capability or no notifications wanted ..0. .... = Voice Broadcast Service: no VBS capability or no notifications wanted ...1 .... = Multislot capability struct: Present HSCSD multislot class: Bits are not available (0) GPRS multislot class: Bits are not available (0) SMS_VALUE (Switch-Measure-Switch): Bits are not available (0) ECSD multislot class: Bits are not available (0) EGPRS multislot class: Bits are not available (0) DTM GPRS Multi Slot Class: Bits are not available (0) """ Change-Id: I49210a04b16e6e2fc9d799b99c2fa415f28ddbba Change-Id: I7fbe0ecbc6bb0797188af0d73fff0052bcc32e39 --- M src/sgsn/gprs_gmm_util.c 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/40/38940/1 diff --git a/src/sgsn/gprs_gmm_util.c b/src/sgsn/gprs_gmm_util.c index 4a59c37..4f61669 100644 --- a/src/sgsn/gprs_gmm_util.c +++ b/src/sgsn/gprs_gmm_util.c @@ -79,8 +79,9 @@ memset(rau_req, 0, sizeof(struct gprs_gmm_ra_upd_req)); - /* all mandatory fields + variable length MS Radio Cap (min value) */ - if (msgb_l3len(msg) < 16) + /* all mandatory fields + variable length MS Radio Cap (min value) would be 15 bytes. + * But even short radio capabilities we should handle with 14 bytes */ + if (msgb_l3len(msg) < 14) return GMM_CAUSE_PROTO_ERR_UNSPEC; gh = (struct gsm48_hdr *) msgb_gmmh(msg); -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/38940?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I7fbe0ecbc6bb0797188af0d73fff0052bcc32e39 Gerrit-Change-Number: 38940 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: osmo_io: Increase default queue max_length from 32 to 1024
by pespin 25 Nov '24

25 Nov '24

Attention is currently required from: daniel, fixeria, jolly, laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/38886?usp=email ) Change subject: osmo_io: Increase default queue max_length from 32 to 1024 ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: > I'm not sure that's great either. […] Yeah that's why I thought 1024 is a good compromise between both situations. Will merge soon if there's no one opposing explicitly to it. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38886?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I92d5369af523f6297d45d4b534bb0f349ae74485 Gerrit-Change-Number: 38886 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Nov 2024 16:21:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-sgsn[master]: gmm: Fix reject small size RAU request
by lynxis lazus 25 Nov '24

25 Nov '24

Attention is currently required from: daniel, pespin. lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/38834?usp=email ) The change is no longer submittable: Code-Review is unsatisfied now. Change subject: gmm: Fix reject small size RAU request ...................................................................... Patch Set 1: -Code-Review -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/38834?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I49210a04b16e6e2fc9d799b99c2fa415f28ddbba Gerrit-Change-Number: 38834 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Nov 2024 16:18:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-sgsn[master]: gmm: Fix reject small size RAU request
by lynxis lazus 25 Nov '24

25 Nov '24

Attention is currently required from: daniel, pespin. lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/38834?usp=email ) Change subject: gmm: Fix reject small size RAU request ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: The spec says 15 bytes minimum (at least since r99). But we can also deal with 14 bytes. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/38834?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I49210a04b16e6e2fc9d799b99c2fa415f28ddbba Gerrit-Change-Number: 38834 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Nov 2024 16:18:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: osmo_io: Increase default queue max_length from 32 to 1024
by laforge 25 Nov '24

25 Nov '24

Attention is currently required from: daniel, fixeria, jolly, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/38886?usp=email ) Change subject: osmo_io: Increase default queue max_length from 32 to 1024 ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: > iofd_txqueue_enqueue() returns -ENOSPC. […] I'm not sure that's great either. It's wrong for an application to try to push millions of messages to a write queue without ever going through osmo_select_main and give the queue a chance to drain itself. I agree for situations like Abis 32 is too little. But 2 billion (or more in 64bit) clearly is too many... -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38886?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I92d5369af523f6297d45d4b534bb0f349ae74485 Gerrit-Change-Number: 38886 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Nov 2024 16:17:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-netif[master]: stream_cli: Rename private functions
by pespin 25 Nov '24

25 Nov '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/38924?usp=email ) Change subject: stream_cli: Rename private functions ...................................................................... stream_cli: Rename private functions Remove the osmo_ prefix to easily spot they are private. Change-Id: Iaa94ede577df78fab7a1db9a1e9a43901133c102 --- M src/stream_cli.c 1 file changed, 9 insertions(+), 9 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/stream_cli.c b/src/stream_cli.c index c9c9e19..b7ca9fd 100644 --- a/src/stream_cli.c +++ b/src/stream_cli.c @@ -161,7 +161,7 @@ cli->state == STREAM_CLI_STATE_CONNECTED; } -static void osmo_stream_cli_close_iofd(struct osmo_stream_cli *cli) +static void stream_cli_close_iofd(struct osmo_stream_cli *cli) { if (!cli->iofd) return; @@ -170,7 +170,7 @@ cli->iofd = NULL; } -static void osmo_stream_cli_close_ofd(struct osmo_stream_cli *cli) +static void stream_cli_close_ofd(struct osmo_stream_cli *cli) { if (cli->ofd.fd == -1) return; @@ -198,10 +198,10 @@ switch (cli->mode) { case OSMO_STREAM_MODE_OSMO_FD: - osmo_stream_cli_close_ofd(cli); + stream_cli_close_ofd(cli); break; case OSMO_STREAM_MODE_OSMO_IO: - osmo_stream_cli_close_iofd(cli); + stream_cli_close_iofd(cli); break; default: OSMO_ASSERT(false); @@ -249,7 +249,7 @@ return cli->iofd; } -static void osmo_stream_cli_read(struct osmo_stream_cli *cli) +static void stream_cli_read(struct osmo_stream_cli *cli) { LOGSCLI(cli, LOGL_DEBUG, "message received\n"); @@ -257,7 +257,7 @@ cli->read_cb(cli); } -static int osmo_stream_cli_write(struct osmo_stream_cli *cli) +static int stream_cli_write(struct osmo_stream_cli *cli) { #ifdef HAVE_LIBSCTP struct sctp_sndrcvinfo sinfo; @@ -409,11 +409,11 @@ case STREAM_CLI_STATE_CONNECTED: if (what & OSMO_FD_READ) { LOGSCLI(cli, LOGL_DEBUG, "connected read\n"); - osmo_stream_cli_read(cli); + stream_cli_read(cli); } if (what & OSMO_FD_WRITE) { LOGSCLI(cli, LOGL_DEBUG, "connected write\n"); - osmo_stream_cli_write(cli); + stream_cli_write(cli); } break; default: @@ -1097,7 +1097,7 @@ break; case OSMO_STREAM_MODE_OSMO_IO: /* Be sure that previous osmo_io instance is freed before creating a new one. */ - osmo_stream_cli_close_iofd(cli); + stream_cli_close_iofd(cli); #ifdef HAVE_LIBSCTP if (cli->proto == IPPROTO_SCTP) { cli->iofd = osmo_iofd_setup(cli, fd, cli->name, OSMO_IO_FD_MODE_RECVMSG_SENDMSG, -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/38924?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Iaa94ede577df78fab7a1db9a1e9a43901133c102 Gerrit-Change-Number: 38924 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: gsmtap: Increase txqueue max_length from 64 to 1024
by laforge 25 Nov '24

25 Nov '24

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/38887?usp=email ) Change subject: gsmtap: Increase txqueue max_length from 64 to 1024 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38887?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie737e1d060ea3ee48631604bbae1b8b84cf787b9 Gerrit-Change-Number: 38887 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Nov 2024 16:15:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-abis[master]: e1_input: Store new msg in llist before calling driver->want_write()
by pespin 25 Nov '24

25 Nov '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38904?usp=email ) Change subject: e1_input: Store new msg in llist before calling driver->want_write() ...................................................................... e1_input: Store new msg in llist before calling driver->want_write() This is needed for drivers handling the message synchronously during want_write() op. Until now this was not needed because probably all drivers are relying on poll based write to tx the message, which meant using the msg happened in a delayed form, asynchronously. Once we move the ipaccess driver to use libosmo-netif's stream, we'll need the msg to be available in the upper layer llist when want_write() is called, because at that time it will pop it from that llist and submit it to the lower layer stream tx_queue. Change-Id: I2b4e7bed502964fe03e3dabaeed668713b4baa7a --- M src/e1_input.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/e1_input.c b/src/e1_input.c index d4e9e88..145fccf 100644 --- a/src/e1_input.c +++ b/src/e1_input.c @@ -307,12 +307,12 @@ return -EINVAL; } e1i_ts = sign_link->ts; + msgb_enqueue(&sign_link->tx_list, msg); if (!osmo_timer_pending(&e1i_ts->sign.tx_timer)) { /* notify the driver we have something to write */ e1inp_driver = sign_link->ts->line->driver; e1inp_driver->want_write(e1i_ts); } - msgb_enqueue(&sign_link->tx_list, msg); /* we only need to write a 'Fake LAPD' packet here, if the * underlying driver hides LAPD from us. If we use the -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38904?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I2b4e7bed502964fe03e3dabaeed668713b4baa7a Gerrit-Change-Number: 38904 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: SGSN: f_TC_attach_timeout_after_pdp_act: allow authentication
by laforge 25 Nov '24

25 Nov '24

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38399?usp=email ) Change subject: SGSN: f_TC_attach_timeout_after_pdp_act: allow authentication ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38399?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I11c628ecebbe7c4c1b2c28e63133a33cfc171e12 Gerrit-Change-Number: 38399 Gerrit-PatchSet: 7 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 25 Nov 2024 16:13:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: SGSN: f_TC_attach_timeout_after_pdp_act: allow authentication
by laforge 25 Nov '24

25 Nov '24

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38399?usp=email ) Change subject: SGSN: f_TC_attach_timeout_after_pdp_act: allow authentication ...................................................................... Patch Set 7: (2 comments) Patchset: PS2: > Like in the other patch, I'm not a fan of widening the expectations of our test cases. […] Done Patchset: PS5: > IMHO: as long we don't enable auth + integrity on the LLC and check explicit for it, this is bad beh […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38399?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I11c628ecebbe7c4c1b2c28e63133a33cfc171e12 Gerrit-Change-Number: 38399 Gerrit-PatchSet: 7 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 25 Nov 2024 16:13:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

2026

2025

2024

2023

2022

gerrit-log