- gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: hnbgw: Introduce test TC_{cs,ps}_rua_dt_during_sccp_wait_cc

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40184?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: hnbgw: Introduce test TC_{cs,ps}_rua_dt_during_sccp_wait_cc ...................................................................... hnbgw: Introduce test TC_{cs,ps}_rua_dt_during_sccp_wait_cc Related: SYS#7453 Change-Id: I97767db5560edf951202c876726d0c52b5b5b49f --- M hnbgw/HNBGW_Tests.ttcn M hnbgw/expected-results.xml 2 files changed, 55 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/84/40184/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40184?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I97767db5560edf951202c876726d0c52b5b5b49f Gerrit-Change-Number: 40184 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

2 months, 1 week

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: hnbgw: Introduce test TC_{cs,ps}_rua_dt_during_sccp_wait_cc

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40184?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: hnbgw: Introduce test TC_{cs,ps}_rua_dt_during_sccp_wait_cc ...................................................................... hnbgw: Introduce test TC_{cs,ps}_rua_dt_during_sccp_wait_cc Related: SYS#7453 Change-Id: I97767db5560edf951202c876726d0c52b5b5b49f --- M hnbgw/HNBGW_Tests.ttcn M hnbgw/expected-results.xml 2 files changed, 50 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/84/40184/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40184?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I97767db5560edf951202c876726d0c52b5b5b49f Gerrit-Change-Number: 40184 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

2 months, 1 week

1
0
0 0

[S] Change in osmo-hnbgw[master]: context_map_sccp: Queue RUA->SCCP RANAP msgs while in SCCP WAIT_CC state

by pespin

Attention is currently required from: laforge, pespin. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40176?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: context_map_sccp: Queue RUA->SCCP RANAP msgs while in SCCP WAIT_CC state ...................................................................... context_map_sccp: Queue RUA->SCCP RANAP msgs while in SCCP WAIT_CC state HNB transmits the first RANAP PDU over a RUA Connect msg, which creates the session without need for any confirmation from HNBGW. As a result, HNB is allowed to transmit more RANAP PDUs after that. On the other side HNBGW, SCCP conn establishment towards CN consists of a CREQ msg and then wait until CC (or CREF) is received. HNBGW is unable to transmit any more data during that time, only the one appended to the CREQ SCCP msg. If the RAN transmits any more RANAP PDU over RUA while SCCP side is still waiting for CC, we were discarding the message. Instead, queue it and transmit it once finally the CC is received from the peer. Related: SYS#7453 Change-Id: I307ded905901421f8228fab720b3989a2f94412b --- M include/osmocom/hnbgw/context_map.h M src/osmo-hnbgw/context_map_sccp.c 2 files changed, 33 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/76/40176/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40176?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I307ded905901421f8228fab720b3989a2f94412b Gerrit-Change-Number: 40176 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

2 months, 1 week

1
0
0 0

[S] Change in osmo-hnbgw[master]: context_map_sccp: Queue RUA->SCCP RANAP msgs while in SCCP WAIT_CC state

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40176?usp=email ) Change subject: context_map_sccp: Queue RUA->SCCP RANAP msgs while in SCCP WAIT_CC state ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File src/osmo-hnbgw/context_map_sccp.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/40176/comment/edc698b9_9ae6586d?u… : PS3, Line 202: static struct msgb *wait_cc_tx_msg_list_dequeue(struct hnbgw_context_map *map) minor cosmetics: no empty line between functions. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40176?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I307ded905901421f8228fab720b3989a2f94412b Gerrit-Change-Number: 40176 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Apr 2025 17:49:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

2 months, 1 week

1
0
0 0

[S] Change in osmo-hnbgw[master]: context_map_sccp: Queue RUA->SCCP RANAP msgs while in SCCP WAIT_CC state

by pespin

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40176?usp=email ) Change subject: context_map_sccp: Queue RUA->SCCP RANAP msgs while in SCCP WAIT_CC state ...................................................................... Patch Set 3: (1 comment) This change is ready for review. Patchset: PS3: Tested successfuly here: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40184 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40176?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I307ded905901421f8228fab720b3989a2f94412b Gerrit-Change-Number: 40176 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Wed, 30 Apr 2025 15:10:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

2 months, 1 week

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Introduce test TC_{cs,ps}_rua_dt_during_sccp_wait_cc

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40184?usp=email ) Change subject: hnbgw: Introduce test TC_{cs,ps}_rua_dt_during_sccp_wait_cc ...................................................................... hnbgw: Introduce test TC_{cs,ps}_rua_dt_during_sccp_wait_cc Related: SYS#7453 Change-Id: I97767db5560edf951202c876726d0c52b5b5b49f --- M hnbgw/HNBGW_Tests.ttcn M hnbgw/expected-results.xml 2 files changed, 46 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/84/40184/1 diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index 28b41d2..743898b 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -1567,6 +1567,47 @@ f_shutdown_helper(); } +/* scenario: HNB transmits a RUA DirectTransfer after having transmitted a RUA Connect + * (with RANAP payload) and conn is still being established on SCCP side (HNBGW sent CR, + * waiting for CC from CN). */ +private function f_tc_rua_dt_during_sccp_wait_cc(charstring id) runs on ConnHdlr { + /* HNB->MSC: InitialUE */ + var RANAP_PDU tx_ranap_pdu := f_build_initial_ue(g_pars); + f_iuh2iu_connect(tx_ranap_pdu); + + /* CREQ was received at CN, now HNB decides to retransmit the RANAP PDU (ie. L3/DTAP retrans timeout). + * We expect HNBGW to queue the msg until the SCCP conn is confirmed. */ + RUA.send(tx_ranap_pdu); + + /* Let some time for RUA DirectTransfer to reach the HNBGW: */ + f_sleep(1.0); + + /* Now tx SCCP CC from CN to HNBGW: */ + BSSAP.send(ts_MSC_CONN_PRIM_CONNECT_RES); + + /* now that SCCP conn is connected, HNBGW should forward the previously queued RANAP PDU: */ + f_bssap_expect(tx_ranap_pdu); + f_sleep(1.0); // FIXME: Can probably be dropped. +} +private function f_TC_rua_dt_during_sccp_wait_cc(boolean is_ps) runs on test_CT { + var ConnHdlr vc_conn; + g_num_hnbs := 1; + /* Instruct RAN_Emulation to avoid accepting the conn, we'll trigger an + * SCCP CC by sending a N-CONNECT RESP primitive in ConnHdlr. */ + g_ran_ops.ranap_connect_ind_auto_res := false; + f_init(); + + vc_conn := f_start_handler_with_pars(refers(f_tc_rua_dt_during_sccp_wait_cc), f_TestHdlrParams(6, is_ps)); + vc_conn.done; + + f_shutdown_helper(); +} +testcase TC_cs_rua_dt_during_sccp_wait_cc() runs on test_CT { + f_TC_rua_dt_during_sccp_wait_cc(false); +}testcase TC_ps_rua_dt_during_sccp_wait_cc() runs on test_CT { + f_TC_rua_dt_during_sccp_wait_cc(true); +} + friend function f_tc_ps_rab_assignment(charstring id) runs on ConnHdlr { var RANAP_PDU tx; @@ -1578,7 +1619,6 @@ f_cn_iu_release_procedure(pfcp_teardown := g_pars.pfcp_pars.pfcp_enabled); } - testcase TC_ps_rab_assignment() runs on test_CT { var ConnHdlr vc_conn; g_num_hnbs := 1; @@ -2603,6 +2643,8 @@ execute(TC_cs_rua_disconnect_during_sccp_cr_cc()); execute(TC_cs_iu_release_req_rua_disconnect()); execute(TC_ps_iu_release_req_rua_disconnect()); + execute(TC_cs_rua_dt_during_sccp_wait_cc()); + execute(TC_ps_rua_dt_during_sccp_wait_cc()); execute(TC_ps_rab_assignment()); execute(TC_ps_rab_assignment_concurrent()); diff --git a/hnbgw/expected-results.xml b/hnbgw/expected-results.xml index 3fca542..3777715 100644 --- a/hnbgw/expected-results.xml +++ b/hnbgw/expected-results.xml @@ -1,5 +1,5 @@ <?xml version="1.0"?> -<testsuite name='Titan' tests='58' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> +<testsuite name='Titan' tests='60' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> <testcase classname='HNBGW_Tests' name='TC_hnb_register' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_hnb_register_duplicate' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_hnb_register_duplicate_reuse_sctp_assoc' time='MASKED'/> @@ -29,6 +29,8 @@ <testcase classname='HNBGW_Tests' name='TC_cs_rua_disconnect_during_sccp_cr_cc' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_cs_iu_release_req_rua_disconnect' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_ps_iu_release_req_rua_disconnect' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_cs_rua_dt_during_sccp_wait_cc' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_ps_rua_dt_during_sccp_wait_cc' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_ps_rab_assignment' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_ps_rab_assignment_concurrent' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_mscpool_L3Compl_on_1_cnlink' time='MASKED'/> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40184?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I97767db5560edf951202c876726d0c52b5b5b49f Gerrit-Change-Number: 40184 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

2 months, 1 week

1
0
0 0

[XS] Change in osmo-ci[master]: jobs/gerrit: add osmo-rp2040-firmware

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/40183?usp=email ) Change subject: jobs/gerrit: add osmo-rp2040-firmware ...................................................................... jobs/gerrit: add osmo-rp2040-firmware Related: OS#6784 Change-Id: I12eb91af7e1d296a0f1447313a3449425e473669 --- M jobs/gerrit-verifications.yml 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml index 4176d26..7d90799 100644 --- a/jobs/gerrit-verifications.yml +++ b/jobs/gerrit-verifications.yml @@ -95,6 +95,7 @@ docker_img_erlang: '$USER/debian-bookworm-erlang' docker_img_android: 'registry.osmocom.org/osmocom-build/debian-bookworm-android' docker_img_aram_applet: 'registry.osmocom.org/osmocom-build/debian-bookworm-aram-applet' + docker_img_rp2040: 'registry.osmocom.org/osmocom-build/debian-bookworm-rp2040' timeout_cmd: '/usr/bin/timeout 30m' cmd: '{docker_run_ccache} {docker_img} {timeout_cmd} /build/contrib/jenkins.sh' gerrit_url: 'ssh://jenkins@gerrit.osmocom.org:29418' @@ -423,6 +424,14 @@ pipeline_binpkgs: "debian:10 debian:12" - osmo-remsim + + - osmo-rp2040-firmware: + pipeline_binpkgs: "" + cmd: | + docker pull {docker_img_rp2040} + {docker_run} \ + {docker_img_rp2040} {timeout_cmd} contrib/jenkins.sh + - simtrace2 - osmo-opencm3-projects: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40183?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I12eb91af7e1d296a0f1447313a3449425e473669 Gerrit-Change-Number: 40183 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

2 months, 1 week

1
0
0 0

[XS] Change in osmo-ci[master]: jobs/registry-rebuild-upload: add rp2040

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/40182?usp=email ) Change subject: jobs/registry-rebuild-upload: add rp2040 ...................................................................... jobs/registry-rebuild-upload: add rp2040 Related: OS#6784 Change-Id: I8c407162d4ef6f16270e07483151ddb3b67f17f3 --- M jobs/registry-rebuild-upload.yml 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/jobs/registry-rebuild-upload.yml b/jobs/registry-rebuild-upload.yml index 87becf0..21d1335 100644 --- a/jobs/registry-rebuild-upload.yml +++ b/jobs/registry-rebuild-upload.yml @@ -7,6 +7,8 @@ image: "debian-bookworm-android" - registry-rebuild-upload-aram-applet: image: "debian-bookworm-aram-applet" + - registry-rebuild-upload-rp2040: + image: "debian-bookworm-rp2040" - job-template: name: '{job-name}' -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40182?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I8c407162d4ef6f16270e07483151ddb3b67f17f3 Gerrit-Change-Number: 40182 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

2 months, 1 week

1
0
0 0

[XS] Change in osmo-rp2040-firmware[master]: CMakeLists.txt: set project: osmo-rp2040-firmware

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-rp2040-firmware/+/40180?usp=email ) Change subject: CMakeLists.txt: set project: osmo-rp2040-firmware ...................................................................... CMakeLists.txt: set project: osmo-rp2040-firmware Change-Id: I4afdfa9293401171a559b807a2288d83ce3a6a26 --- M CMakeLists.txt 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/CMakeLists.txt b/CMakeLists.txt index d64396a..cb0f06f 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -4,7 +4,7 @@ # note: this must happen before project() include(pico_sdk_import.cmake) -project(my_project) +project(osmo-rp2040-firmware) # initialize the Raspberry Pi Pico SDK pico_sdk_init() -- To view, visit https://gerrit.osmocom.org/c/osmo-rp2040-firmware/+/40180?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-rp2040-firmware Gerrit-Branch: master Gerrit-Change-Id: I4afdfa9293401171a559b807a2288d83ce3a6a26 Gerrit-Change-Number: 40180 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

2 months, 1 week

1
0
0 0

[XS] Change in osmo-rp2040-firmware[master]: contrib/jenkins: new script

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-rp2040-firmware/+/40178?usp=email ) Change subject: contrib/jenkins: new script ...................................................................... contrib/jenkins: new script Add a script for building the project in jenkins. Related: OS#6784 Change-Id: Iaa39e3b1a9baf9d598c328231281da7c89c5dd41 --- M .gitignore A contrib/jenkins.sh 2 files changed, 7 insertions(+), 0 deletions(-) Approvals: osmith: Verified laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/.gitignore b/.gitignore index ff549be..d047853 100644 --- a/.gitignore +++ b/.gitignore @@ -7,3 +7,4 @@ *.hex CMakeFiles Makefile +build diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh new file mode 100755 index 0000000..702eea3 --- /dev/null +++ b/contrib/jenkins.sh @@ -0,0 +1,6 @@ +#!/bin/sh -ex + +mkdir build +cd build +cmake .. +make -j$(nproc) -- To view, visit https://gerrit.osmocom.org/c/osmo-rp2040-firmware/+/40178?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-rp2040-firmware Gerrit-Branch: master Gerrit-Change-Id: Iaa39e3b1a9baf9d598c328231281da7c89c5dd41 Gerrit-Change-Number: 40178 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

2 months, 1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log