- gerrit-log - lists.osmocom.org

[S] Change in osmo-trx[master]: fix(threads): centralize portable strerror handling
by pespin 25 Feb '26

25 Feb '26

Attention is currently required from: pespin. pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42199?usp=email ) Change subject: fix(threads): centralize portable strerror handling ...................................................................... Patch Set 2: (1 comment) File CommonLibs/Utils.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/42199/comment/a56f14db_9f90bb2b?usp… : PS2, Line 36: So now you are adding a function which is not used anywhere?I'd rather drop the c++ one and simply use this one. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42199?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I642aff8a9f98823e117c4debd19384ddf5975039 Gerrit-Change-Number: 42199 Gerrit-PatchSet: 2 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Feb 2026 16:39:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in libosmocore[master]: fix --disable-log-macros
by Hoernchen 25 Feb '26

25 Feb '26

Attention is currently required from: Hoernchen, laforge, pespin. Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/libosmocore/+/42203?usp=email ) Change subject: fix --disable-log-macros ...................................................................... Patch Set 2: (1 comment) File configure.ac: https://gerrit.osmocom.org/c/libosmocore/+/42203/comment/07c3446a_54260180?… : PS1, Line 511: if test x"$log_macros" == x"yes" > Oh no, now it's as broken as before... My first attempt is actually the only sane way to do it unless you want to somehow "invert" the yes/no strings. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42203?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I809ab2f61e72428ba21061055296eb83d6d710ab Gerrit-Change-Number: 42203 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Feb 2026 16:37:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ccid-firmware[master]: ccid_device: Reject XfrBlock with zero-length data
by dexter 25 Feb '26

25 Feb '26

Attention is currently required from: Hoernchen, jolly, laforge, lynxis lazus. dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42192?usp=email ) Change subject: ccid_device: Reject XfrBlock with zero-length data ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Ah indeed, 4 bytes is only possible for an APDU but not a TPDU. See ETSI TS 102 221 Section 7.3.1.1. […] Yes, that is correct. I would assume that CCID sees only TPDUs, so if there is something below 5 bytes, it should be indeed rejected. -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42192?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I65df88477e4b1c03dc20a8d41e5cbd1c9f363ba8 Gerrit-Change-Number: 42192 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 25 Feb 2026 16:37:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[M] Change in osmo-bts[master]: RTP: make ortp optional at compile time
by falconia 25 Feb '26

25 Feb '26

Attention is currently required from: pespin. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/42197?usp=email ) Change subject: RTP: make ortp optional at compile time ...................................................................... Patch Set 3: (1 comment) File contrib/Makefile.am: https://gerrit.osmocom.org/c/osmo-bts/+/42197/comment/c683255b_30384d8f?usp… : PS3, Line 4: SUBDIRS += ber > we'll probably have to port stuff under ber/ to use the abs_rtp stuff you added before dropping ortp […] I already added this ticket: https://osmocom.org/issues/6963 And I argue that it should be ported directly to twrtp, without even going through rtp_abst layer which is highly specific to osmo-bts guts, while that rtp_ber program is a very different animal. Again, let's discuss this issue in that ticket rather than here. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42197?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ib171bd42a65117457319befee2615e0c36c8d9e1 Gerrit-Change-Number: 42197 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Feb 2026 16:37:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-bts[master]: RTP: add vty option for ortp vs twrtp selection
by fixeria 25 Feb '26

25 Feb '26

Attention is currently required from: falconia, laforge. fixeria has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/42167?usp=email ) Change subject: RTP: add vty option for ortp vs twrtp selection ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42167?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iff4e3a399250c16ba8fe4cb12e4e22f4c6b346ec Gerrit-Change-Number: 42167 Gerrit-PatchSet: 6 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 25 Feb 2026 16:37:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-trx[master]: fix(threads): centralize portable strerror handling
by Timur Davydov 25 Feb '26

25 Feb '26

Attention is currently required from: pespin. Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42199?usp=email ) Change subject: fix(threads): centralize portable strerror handling ...................................................................... Patch Set 2: (2 comments) File CommonLibs/Threads.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/42199/comment/83120942_26201f44?usp… : PS1, Line 58: char *err_str = NULL; > wrong indentation Fixed https://gerrit.osmocom.org/c/osmo-trx/+/42199/comment/448b737d_ea687898?usp… : PS1, Line 59: #if defined(__GLIBC__) && defined(_GNU_SOURCE) > Can we move all this into a helper function above so it can be reused? […] I’ve moved this into Utils as a reusable strerror_buf() helper and added a C++ wrapper strerror_str() based on std::error_code. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42199?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I642aff8a9f98823e117c4debd19384ddf5975039 Gerrit-Change-Number: 42199 Gerrit-PatchSet: 2 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Feb 2026 16:37:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: fix --disable-log-macros
by Hoernchen 25 Feb '26

25 Feb '26

Attention is currently required from: laforge, pespin. Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/libosmocore/+/42203?usp=email ) Change subject: fix --disable-log-macros ...................................................................... Patch Set 2: (1 comment) File configure.ac: https://gerrit.osmocom.org/c/libosmocore/+/42203/comment/d23856c0_4120c408?… : PS1, Line 511: if test x"$log_macros" == x"yes" > But the problem is that we "enable" the flag by disabling and ENABLE_LIBOSMOCORE_NO_LOGGING_DEFAULT […] Oh no, now it's as broken as before... -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42203?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I809ab2f61e72428ba21061055296eb83d6d710ab Gerrit-Change-Number: 42203 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Feb 2026 16:36:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: fix --disable-log-macros
by Hoernchen 25 Feb '26

25 Feb '26

Attention is currently required from: laforge, pespin. Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/libosmocore/+/42203?usp=email ) Change subject: fix --disable-log-macros ...................................................................... Patch Set 2: (1 comment) File configure.ac: https://gerrit.osmocom.org/c/libosmocore/+/42203/comment/55ee2e76_e2a69f72?… : PS1, Line 511: if test x"$log_macros" == x"yes" > The problem is not the $enableval above, which I think is fine. […] But the problem is that we "enable" the flag by disabling and ENABLE_LIBOSMOCORE_NO_LOGGING_DEFAULT is obviously "no" by default... this is precisely why it is broken. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42203?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I809ab2f61e72428ba21061055296eb83d6d710ab Gerrit-Change-Number: 42203 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Feb 2026 16:34:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: fix --disable-log-macros
by Hoernchen 25 Feb '26

25 Feb '26

Attention is currently required from: Hoernchen, laforge, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/42203?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review-1 by pespin, Verified+1 by Jenkins Builder Change subject: fix --disable-log-macros ...................................................................... fix --disable-log-macros Before 9197c1ac, the AC_ARG_ENABLE(log_macros, ...) action was hardcoded to [log_macros="yes"], so *any* use of the flag --enable-log-macros or --disable-log-macros would set log_macros="yes" -> AC_DEFINE([LIBOSMOCORE_NO_LOGGING]). The commit changed this to the standard [log_macros=$enableval], but broke the conditional test, so - AC_ARG_ENABLE sets $enableval to "no" for --disable-* flags -> log_macros is now "no" -> test fails -> LIBOSMOCORE_NO_LOGGING is never defined... The opposite of what it should do... Change-Id: I809ab2f61e72428ba21061055296eb83d6d710ab --- M configure.ac 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/03/42203/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42203?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I809ab2f61e72428ba21061055296eb83d6d710ab Gerrit-Change-Number: 42203 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-trx[master]: fix(threads): centralize portable strerror handling
by Timur Davydov 25 Feb '26

25 Feb '26

Attention is currently required from: Timur Davydov. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/42199?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: fix(threads): centralize portable strerror handling ...................................................................... fix(threads): centralize portable strerror handling - Move strerror_r portability logic to Utils - Add strerror_buf() helper - Add strerror_str() wrapper using std::error_code - Simplify thread error logging in Threads.cpp Change-Id: I642aff8a9f98823e117c4debd19384ddf5975039 --- M CommonLibs/Threads.cpp M CommonLibs/Utils.cpp M CommonLibs/Utils.h 3 files changed, 27 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/99/42199/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42199?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I642aff8a9f98823e117c4debd19384ddf5975039 Gerrit-Change-Number: 42199 Gerrit-PatchSet: 2 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>

1 0

2026

2025

2024

2023

2022

gerrit-log