- gerrit-log - lists.osmocom.org

[S] Change in libosmocore[master]: core: fix config.h
by Hoernchen 25 Feb '26

25 Feb '26

Attention is currently required from: fixeria, laforge, pespin. Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/libosmocore/+/42205?usp=email ) Change subject: core: fix config.h ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > I think you have a point here. […] ..but just hoping people don't just use HAVE_XX and don't include config.h is not really a fix either? The FW build can check if the logging is defined, btw, and if it is, break. Or we could enforce including config.h everywhere by adding a check... See https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42208 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42205?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic2cf52a3b60f43a2f5d3fe01c41a41f6fd9a8000 Gerrit-Change-Number: 42205 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Feb 2026 19:27:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-ccid-firmware[master]: ensure libosmocore logging is properly disabled for builds
by Hoernchen 25 Feb '26

25 Feb '26

Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42208?usp=email ) Change subject: ensure libosmocore logging is properly disabled for builds ...................................................................... ensure libosmocore logging is properly disabled for builds Change-Id: I169a059d8daff0a3993318a4ea3ab7adcb05fee3 --- M sysmoOCTSIM/gcc/Makefile 1 file changed, 8 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/08/42208/1 diff --git a/sysmoOCTSIM/gcc/Makefile b/sysmoOCTSIM/gcc/Makefile index 0f2a909..461b313 100644 --- a/sysmoOCTSIM/gcc/Makefile +++ b/sysmoOCTSIM/gcc/Makefile @@ -164,7 +164,7 @@ vpath %.S ../ # All Target -all: $(SUB_DIRS) elf bin ihex eep lss +all: $(SUB_DIRS) elf bin ihex eep lss check-no-logging elf: $(OUTPUT_FILE_NAME).elf sysmoOCTSIM.elf bin: $(OUTPUT_FILE_NAME).bin sysmoOCTSIM.bin @@ -246,5 +246,12 @@ $(OUTPUT_FILE_NAME).lss $(OUTPUT_FILE_NAME).eep $(OUTPUT_FILE_NAME).map \ $(OUTPUT_FILE_NAME).srec +check-no-logging: $(OUTPUT_FILE_PATH) + @if $(NM) $< | grep -q ' T logp2'; then \ + echo "FAIL: logging symbols linked into release ELF (libosmocore --disable-log-macros missing/broken?)"; \ + $(NM) $< | grep ' T $logp2\|osmo_vlogp\|log_check_level\|logp_stub$'; \ + exit 1; \ + fi + mrproper: clean rm -f *.o *.d *.a *.elf *.bin *.ihex *.eep *.lss *.map *.srec -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42208?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I169a059d8daff0a3993318a4ea3ab7adcb05fee3 Gerrit-Change-Number: 42208 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>

1 0

[S] Change in osmo-trx[master]: fix(threads): centralize portable strerror handling
by Timur Davydov 25 Feb '26

25 Feb '26

Attention is currently required from: pespin. Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42199?usp=email ) Change subject: fix(threads): centralize portable strerror handling ...................................................................... Patch Set 3: (1 comment) File CommonLibs/Utils.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/42199/comment/74111118_5e7b1342?usp… : PS2, Line 36: > So now you are adding a function which is not used anywhere?I'd rather drop the c++ one and simply u […] Yes, agreed. I dropped the C++ wrapper and kept only the C helper `strerror_buf()`. I also found a few remaining direct `strerror_r()` calls in `trx_rate_ctr.cpp` and `IPCDevice.cpp` — do you want me to switch those to `strerror_buf()` as well to keep error handling consistent across the codebase? -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42199?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I642aff8a9f98823e117c4debd19384ddf5975039 Gerrit-Change-Number: 42199 Gerrit-PatchSet: 3 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Feb 2026 19:20:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-trx[master]: fix(threads): centralize portable strerror handling
by Timur Davydov 25 Feb '26

25 Feb '26

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/42199?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: fix(threads): centralize portable strerror handling ...................................................................... fix(threads): centralize portable strerror handling - Move strerror_r portability logic to Utils - Add strerror_buf() helper - Simplify thread error logging in Threads.cpp Change-Id: I642aff8a9f98823e117c4debd19384ddf5975039 --- M CommonLibs/Threads.cpp M CommonLibs/Utils.cpp M CommonLibs/Utils.h 3 files changed, 22 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/99/42199/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42199?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I642aff8a9f98823e117c4debd19384ddf5975039 Gerrit-Change-Number: 42199 Gerrit-PatchSet: 3 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: fix --disable-log-macros
by Hoernchen 25 Feb '26

25 Feb '26

Attention is currently required from: fixeria, laforge, pespin. Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/libosmocore/+/42203?usp=email ) Change subject: fix --disable-log-macros ...................................................................... Patch Set 4: (1 comment) File configure.ac: https://gerrit.osmocom.org/c/libosmocore/+/42203/comment/8ffe2824_5babf8c8?… : PS3, Line 511: if > @pespin@sysmocom.de is correct here: it's the if-statement that needs to be fixed. […] x -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42203?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I809ab2f61e72428ba21061055296eb83d6d710ab Gerrit-Change-Number: 42203 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Feb 2026 19:03:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: tcap: Avoid updating trans_track if AS doesn't have tcap-routing enabled
by laforge 25 Feb '26

25 Feb '26

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42207?usp=email ) Change subject: tcap: Avoid updating trans_track if AS doesn't have tcap-routing enabled ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42207?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I0106df80f6c186b184bada8f06d38d0d54cce735 Gerrit-Change-Number: 42207 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Feb 2026 18:12:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: hnbgw: Introduce test TC_pfcp_heartbeat_recovery_timestamp
by pespin 25 Feb '26

25 Feb '26

Attention is currently required from: fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42132?usp=email ) Change subject: hnbgw: Introduce test TC_pfcp_heartbeat_recovery_timestamp ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42132?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3f8098d7a34666961437fecc5100422a5e7436a4 Gerrit-Change-Number: 42132 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Feb 2026 18:03:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: hnbgw: introduce test TC_pfcp_heartbeat_timeout
by pespin 25 Feb '26

25 Feb '26

Attention is currently required from: fixeria, neels. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42121?usp=email ) Change subject: hnbgw: introduce test TC_pfcp_heartbeat_timeout ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42121?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1e0b50bc19e1fa1240274baea1e7fedd1265ffcb Gerrit-Change-Number: 42121 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Feb 2026 18:03:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: tcap: Avoid updating trans_track if AS doesn't have tcap-routing enabled
by pespin 25 Feb '26

25 Feb '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42207?usp=email ) Change subject: tcap: Avoid updating trans_track if AS doesn't have tcap-routing enabled ...................................................................... tcap: Avoid updating trans_track if AS doesn't have tcap-routing enabled Change-Id: I0106df80f6c186b184bada8f06d38d0d54cce735 --- M src/ipa.c 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/07/42207/1 diff --git a/src/ipa.c b/src/ipa.c index 29dc5c0..2f48167 100644 --- a/src/ipa.c +++ b/src/ipa.c @@ -309,8 +309,10 @@ /* Third, patch this into the SCCP message and create M3UA message in XUA structure */ data_hdr.si = MTP_SI_SCCP; #ifdef WITH_TCAP_LOADSHARING - /* update TCAP Transaction Tracking (Rx) */ - tcap_as_rx_sccp_asp(as, asp, opc, dpc, msg); + if (as->cfg.loadshare.tcap.enabled) { + /* update TCAP Transaction Tracking (Rx) */ + tcap_as_rx_sccp_asp(as, asp, opc, dpc, msg); + } #endif /* WITH_TCAP_LOADSHARING */ if (as->cfg.pc_override.sccp_mode == OSMO_SS7_PATCH_BOTH) { struct msgb *msg_patched = patch_sccp_with_pc(asp, msg, opc, dpc); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42207?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I0106df80f6c186b184bada8f06d38d0d54cce735 Gerrit-Change-Number: 42207 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: hnbgw: Introduce test TC_pfcp_heartbeat_recovery_timestamp
by laforge 25 Feb '26

25 Feb '26

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42132?usp=email ) Change subject: hnbgw: Introduce test TC_pfcp_heartbeat_recovery_timestamp ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42132?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3f8098d7a34666961437fecc5100422a5e7436a4 Gerrit-Change-Number: 42132 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Feb 2026 17:49:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log