- gerrit-log - lists.osmocom.org

[XS] Change in libosmocore[master]: VTY: Initialize fields of struct cmd_element in order of declaration

by Jenkins Builder

Jenkins Builder has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40188?usp=email ) Change subject: VTY: Initialize fields of struct cmd_element in order of declaration ...................................................................... Patch Set 1: (2 comments) File include/osmocom/vty/command.h: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmocore/+/40188/comment/734989de_dfb2fea4?… : PS1, Line 222: .attr = attrs, \ please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmocore/+/40188/comment/eb8dc9ca_6522f903?… : PS1, Line 233: .attr = attrs, \ please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40188?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ifaa31980f149f9c1f1a9b28f318a4850f6855472 Gerrit-Change-Number: 40188 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 01 May 2025 15:54:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

2 months, 1 week

1
0
0 0

[XS] Change in libosmocore[master]: VTY: Initialize fields of struct cmd_element in order of declaration

by jolly

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/40188?usp=email ) Change subject: VTY: Initialize fields of struct cmd_element in order of declaration ...................................................................... VTY: Initialize fields of struct cmd_element in order of declaration gpp requires designated initialisers to be initialized in the order their fields were declared. With this patch it is possible to include VTY's command.h within C++ code. Change-Id: Ifaa31980f149f9c1f1a9b28f318a4850f6855472 --- M include/osmocom/vty/command.h 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/88/40188/1 diff --git a/include/osmocom/vty/command.h b/include/osmocom/vty/command.h index 61b5881..667e9ab 100644 --- a/include/osmocom/vty/command.h +++ b/include/osmocom/vty/command.h @@ -218,8 +218,8 @@ .string = cmdstr, \ .func = funcname, \ .doc = helpstr, \ - .attr = attrs, \ .daemon = dnum, \ + .attr = attrs, \ }; /* global (non static) cmd_element */ @@ -229,8 +229,8 @@ .string = cmdstr, \ .func = funcname, \ .doc = helpstr, \ - .attr = attrs, \ .daemon = dnum, \ + .attr = attrs, \ }; #define DEFUN_CMD_ELEMENT_ATTR_USRATTR(funcname, cmdname, cmdstr, helpstr, attrs, usrattrs) \ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40188?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ifaa31980f149f9c1f1a9b28f318a4850f6855472 Gerrit-Change-Number: 40188 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu>

2 months, 1 week

1
0
0 0

[S] Change in libosmocore[master]: vty: cosmetic: fix code formatting

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/40186?usp=email ) Change subject: vty: cosmetic: fix code formatting ...................................................................... vty: cosmetic: fix code formatting Change-Id: I746b72dc79b6ebf2e3cb18274118f3ca9ead312a --- M src/vty/command.c 1 file changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/86/40186/1 diff --git a/src/vty/command.c b/src/vty/command.c index 8f87e7d..8594290 100644 --- a/src/vty/command.c +++ b/src/vty/command.c @@ -3555,13 +3555,13 @@ config_write_cmd, "write", "Write running configuration to memory, network, or terminal\n") - ALIAS(config_write_file, +ALIAS(config_write_file, config_write_memory_cmd, "write memory", "Write running configuration to memory, network, or terminal\n" "Write configuration to the file (same as write file)\n") - ALIAS(config_write_file, +ALIAS(config_write_file, copy_runningconfig_startupconfig_cmd, "copy running-config startup-config", "Copy configuration\n" @@ -3569,7 +3569,7 @@ "Copy running config to startup config (same as write file)\n") /* Write current configuration into the terminal. */ - DEFUN(config_write_terminal, +DEFUN(config_write_terminal, config_write_terminal_cmd, "write terminal", "Write running configuration to memory, network, or terminal\n" @@ -3606,7 +3606,7 @@ "show running-config", SHOW_STR "running configuration\n") /* Write startup configuration into the terminal. */ - DEFUN(show_startup_config, +DEFUN(show_startup_config, show_startup_config_cmd, "show startup-config", SHOW_STR "Contentes of startup configuration\n") { @@ -3722,7 +3722,7 @@ "The UNENCRYPTED (cleartext) line password\n") /* VTY enable password set. */ - DEFUN(config_enable_password, enable_password_cmd, +DEFUN(config_enable_password, enable_password_cmd, "enable password (8|) WORD", "Modify enable password parameters\n" "Assign the privileged level password\n" @@ -3785,7 +3785,7 @@ "The UNENCRYPTED (cleartext) 'enable' password\n") /* VTY enable password delete. */ - DEFUN(no_config_enable_password, no_enable_password_cmd, +DEFUN(no_config_enable_password, no_enable_password_cmd, "no enable password", NO_STR "Modify enable password parameters\n" -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40186?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I746b72dc79b6ebf2e3cb18274118f3ca9ead312a Gerrit-Change-Number: 40186 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

2 months, 1 week

1
0
0 0

[S] Change in libosmocore[master]: vty: remove broken 'show startup-config' command

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/40187?usp=email ) Change subject: vty: remove broken 'show startup-config' command ...................................................................... vty: remove broken 'show startup-config' command Saving the current configuration by doing 'write file [FILE]' breaks the 'show startup-config' command. If write succeeds, this command will be showing contents of the new (potentially modified) file. If write fails, this command will yield nothing. Change-Id: If0b4a79052c060cad963e6458b29000a979f95ba Fixes: OS#6440 --- M src/vty/command.c 1 file changed, 0 insertions(+), 31 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/87/40187/1 diff --git a/src/vty/command.c b/src/vty/command.c index 8594290..0292ef1 100644 --- a/src/vty/command.c +++ b/src/vty/command.c @@ -3605,36 +3605,6 @@ show_running_config_cmd, "show running-config", SHOW_STR "running configuration\n") -/* Write startup configuration into the terminal. */ -DEFUN(show_startup_config, - show_startup_config_cmd, - "show startup-config", SHOW_STR "Contentes of startup configuration\n") -{ - char buf[BUFSIZ]; - FILE *confp; - - confp = fopen(host.config, "r"); - if (confp == NULL) { - vty_out(vty, "Can't open configuration file [%s]%s", - host.config, VTY_NEWLINE); - return CMD_WARNING; - } - - while (fgets(buf, BUFSIZ, confp)) { - char *cp = buf; - - while (*cp != '\r' && *cp != '\n' && *cp != '\0') - cp++; - *cp = '\0'; - - vty_out(vty, "%s%s", buf, VTY_NEWLINE); - } - - fclose(confp); - - return CMD_SUCCESS; -} - /* Hostname configuration */ DEFUN(config_hostname, hostname_cmd, @@ -4447,7 +4417,6 @@ install_lib_element(ENABLE_NODE, &copy_runningconfig_startupconfig_cmd); install_lib_element(ENABLE_NODE, &shutdown_cmd); } - install_lib_element(ENABLE_NODE, &show_startup_config_cmd); install_lib_element(ENABLE_NODE, &show_version_cmd); install_lib_element(ENABLE_NODE, &show_online_help_cmd); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40187?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If0b4a79052c060cad963e6458b29000a979f95ba Gerrit-Change-Number: 40187 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

2 months, 1 week

1
0
0 0

[S] Change in osmo-hnbgw[master]: context_map_sccp: Queue RUA->SCCP RANAP msgs while in SCCP WAIT_CC state

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40176?usp=email ) Change subject: context_map_sccp: Queue RUA->SCCP RANAP msgs while in SCCP WAIT_CC state ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40176?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I307ded905901421f8228fab720b3989a2f94412b Gerrit-Change-Number: 40176 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 May 2025 10:34:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 months, 1 week

1
0
0 0

[XS] Change in pysim[master]: jenkins.sh: workaround for 'usage: build.py' in docs

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/40185?usp=email ) Change subject: jenkins.sh: workaround for 'usage: build.py' in docs ...................................................................... jenkins.sh: workaround for 'usage: build.py' in docs Recent versions of cmd2 have changed how the 'prog' attribute is automatically set for ArgumentParser instances. As a result, we are now seeing an unexpected 'build.py' artifact appearing in the generated documentation. Let's use an older release of cmd2, which retains the old expected behavior. Use it specifically for building documentation. Change-Id: Ifbad35adc5e9d3141acfd024d7dee2a25f1cb62e Related: https://github.com/python-cmd2/cmd2/issues/1414 Related: OS#6776 --- M contrib/jenkins.sh 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index de1d9f8..63087f0 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -82,6 +82,10 @@ pip install -r requirements.txt + # XXX: workaround for https://github.com/python-cmd2/cmd2/issues/1414 + # 2.4.3 was the last stable release not affected by this bug (OS#6776) + pip install cmd2==2.4.3 + rm -rf docs/_build make -C "docs" html latexpdf -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40185?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ifbad35adc5e9d3141acfd024d7dee2a25f1cb62e Gerrit-Change-Number: 40185 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

2 months, 1 week

1
0
0 0

[XS] Change in pysim[master]: jenkins.sh: workaround for 'usage: build.py' in docs

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/40185?usp=email ) Change subject: jenkins.sh: workaround for 'usage: build.py' in docs ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40185?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ifbad35adc5e9d3141acfd024d7dee2a25f1cb62e Gerrit-Change-Number: 40185 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Apr 2025 20:21:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 months, 1 week

1
0
0 0

[XS] Change in pysim[master]: jenkins.sh: workaround for 'usage: build.py' in docs

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/40185?usp=email ) Change subject: jenkins.sh: workaround for 'usage: build.py' in docs ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40185?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ifbad35adc5e9d3141acfd024d7dee2a25f1cb62e Gerrit-Change-Number: 40185 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Apr 2025 20:21:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 months, 1 week

1
0
0 0

[XS] Change in pysim[master]: jenkins.sh: workaround for 'usage: build.py' in docs

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/40185?usp=email ) Change subject: jenkins.sh: workaround for 'usage: build.py' in docs ...................................................................... jenkins.sh: workaround for 'usage: build.py' in docs Recent versions of cmd2 have changed how the 'prog' attribute is automatically set for ArgumentParser instances. As a result, we are now seeing an unexpected 'build.py' artifact appearing in the generated documentation. Let's use an older release of cmd2, which retains the old expected behavior. Use it specifically for building documentation. Change-Id: Ifbad35adc5e9d3141acfd024d7dee2a25f1cb62e Related: https://github.com/python-cmd2/cmd2/issues/1414 Related: OS#6776 --- M contrib/jenkins.sh 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/85/40185/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index de1d9f8..63087f0 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -82,6 +82,10 @@ pip install -r requirements.txt + # XXX: workaround for https://github.com/python-cmd2/cmd2/issues/1414 + # 2.4.3 was the last stable release not affected by this bug (OS#6776) + pip install cmd2==2.4.3 + rm -rf docs/_build make -C "docs" html latexpdf -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40185?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ifbad35adc5e9d3141acfd024d7dee2a25f1cb62e Gerrit-Change-Number: 40185 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

2 months, 1 week

1
0
0 0

[S] Change in osmo-hnbgw[master]: context_map_sccp: Queue RUA->SCCP RANAP msgs while in SCCP WAIT_CC state

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40176?usp=email ) Change subject: context_map_sccp: Queue RUA->SCCP RANAP msgs while in SCCP WAIT_CC state ...................................................................... Patch Set 4: (1 comment) File src/osmo-hnbgw/context_map_sccp.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/40176/comment/6658a488_be23cba9?u… : PS3, Line 202: static struct msgb *wait_cc_tx_msg_list_dequeue(struct hnbgw_context_map *map) > minor cosmetics: no empty line between functions. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40176?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I307ded905901421f8228fab720b3989a2f94412b Gerrit-Change-Number: 40176 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 30 Apr 2025 19:29:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

2 months, 1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log