- gerrit-log - lists.osmocom.org

[XS] Change in libosmo-sigtran[master]: sccp_scoc.c: assert value of sua_addr_parse()

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40298?usp=email ) Change subject: sccp_scoc.c: assert value of sua_addr_parse() ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: > also, we have 13 instances of invoking sua_addr_parse without checking the return value, by far the […] If you "git pull origin master" you will see I already handled all of them (most with return paths isntad of asserts) except this 3 in this patch which I somehow oversaw at the time. PS1: > should we assert if the SCCP user hands us incorrect data? I would hope we're not venturing into op […] No, this 3 asserts I'm adding AFAIU are in paths where we control the data being used, it's not the rx path when receiving from a peer, but us generating the messages or addr comming from conn object. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40298?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I008ee6f9024247c14d986a2baba061cc12bf68ec Gerrit-Change-Number: 40298 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 15 May 2025 12:48:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 month, 2 weeks

1
0
0 0

[S] Change in ...osmo-epdg[master]: s2b: add PDN type to the create session request

by lynxis lazus

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37903?usp=email ) Change subject: s2b: add PDN type to the create session request ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: This seems to be supseeded by https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40277 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37903?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I52c9b2db38489404dbe2aac907089a0a6414c9b0 Gerrit-Change-Number: 37903 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Thu, 15 May 2025 11:37:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 month, 2 weeks

1
0
0 0

[S] Change in ...osmo-epdg[master]: s2b: add PDN type to the create session request

by lynxis lazus

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37903?usp=email ) Change subject: s2b: add PDN type to the create session request ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37903?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I52c9b2db38489404dbe2aac907089a0a6414c9b0 Gerrit-Change-Number: 37903 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Thu, 15 May 2025 11:37:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 month, 2 weeks

1
0
0 0

[XS] Change in ...osmo-epdg[master]: s2b: add logline on terminating module

by lynxis lazus

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37902?usp=email ) Change subject: s2b: add logline on terminating module ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37902?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I7a3665b0a77ac86bed448a18cf224e2f6954ba73 Gerrit-Change-Number: 37902 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Thu, 15 May 2025 11:37:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 month, 2 weeks

1
0
0 0

[XS] Change in ...osmo-epdg[master]: s2b: when socket opening fails, stop the S2b module

by lynxis lazus

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37901?usp=email ) Change subject: s2b: when socket opening fails, stop the S2b module ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37901?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I49a6a1ec0c938aa70444c19c0b7b644f2e42f1fd Gerrit-Change-Number: 37901 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Thu, 15 May 2025 11:37:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 month, 2 weeks

1
0
0 0

[XS] Change in ...osmo-epdg[master]: s2b: set correct instance values for Bearers

by lynxis lazus

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37899?usp=email ) Change subject: s2b: set correct instance values for Bearers ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37899?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Ibce4a2e44a3bb0d7e1d86953a94929242d45a3dd Gerrit-Change-Number: 37899 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Thu, 15 May 2025 11:36:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 month, 2 weeks

1
0
0 0

[S] Change in ...osmo-epdg[master]: s2b: answer echo requests

by lynxis lazus

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37900?usp=email ) Change subject: s2b: answer echo requests ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37900?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I3c470bd89b9811ba269b53eb400ffc21db4fba3a Gerrit-Change-Number: 37900 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Thu, 15 May 2025 11:35:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 month, 2 weeks

1
0
0 0

[XS] Change in ...osmo-epdg[master]: gsup: Fix rx of AuthInfoReq without IP addr val

by lynxis lazus

Attention is currently required from: clufn, fixeria, laforge, pespin. lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40297?usp=email ) Change subject: gsup: Fix rx of AuthInfoReq without IP addr val ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40297?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Iaa4b45a00e472a324ad98f57a54db04454935130 Gerrit-Change-Number: 40297 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: clufn <callumfarrbennett(a)yahoo.com> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: clufn <callumfarrbennett(a)yahoo.com> Gerrit-Comment-Date: Thu, 15 May 2025 11:32:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: testenv: podman_install: show checked out commits

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40303?usp=email ) Change subject: testenv: podman_install: show checked out commits ...................................................................... testenv: podman_install: show checked out commits When running with --podman --binary-repo and a testsuite needs a component for which we don't have a binary package (such as sccp_demo_user), we need to clone the source and build it. Show the commit from which we are building / have already built the component. Suggested-by: Pau Espin Pedrol <pespin(a)sysmocom.de> Change-Id: I2837a41c919a9f7ef8c315ce5aa48fb4fe3f9a85 --- M _testenv/testenv/podman_install.py 1 file changed, 12 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/_testenv/testenv/podman_install.py b/_testenv/testenv/podman_install.py index 66777a6..a8293ef 100644 --- a/_testenv/testenv/podman_install.py +++ b/_testenv/testenv/podman_install.py @@ -96,9 +96,17 @@ testenv.cmd.run(["apt-get", "-q", "install", "-y", "--no-install-recommends"] + pkgs) +def show_commit(project, cwd): + cmd = ["git", "-P", "-C", cwd, "-c", "color.ui=always", "log", "-1", "--oneline"] + logging.info(f"{project}: showing current commit") + testenv.cmd.run(cmd, no_podman=True) + + def clone_project(project): - if os.path.exists(os.path.join(git_dir, project)): + git_dir_project = os.path.join(git_dir, project) + if os.path.exists(git_dir_project): logging.debug(f"{project}: already cloned") + show_commit(project, git_dir_project) return branch = "master" @@ -129,6 +137,7 @@ url, ] ) + show_commit(project, git_dir_project) def from_source_sccp_demo_user(): @@ -144,8 +153,8 @@ ] ) + clone_project("libosmo-sigtran") if not os.path.exists(sccp_demo_user_path): - clone_project("libosmo-sigtran") logging.info("Building sccp_demo_user") testenv.cmd.run(["autoreconf", "-fi"], cwd=sccp_dir) @@ -170,8 +179,8 @@ libosmocore_dir = os.path.join(git_dir, "libosmocore") osmo_ns_dummy_path = os.path.join(libosmocore_dir, "utils/osmo-ns-dummy") + clone_project("libosmocore") if not os.path.exists(osmo_ns_dummy_path): - clone_project("libosmocore") logging.info("Building osmo-ns-dummy") testenv.cmd.run(["autoreconf", "-fi"], cwd=libosmocore_dir) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40303?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2837a41c919a9f7ef8c315ce5aa48fb4fe3f9a85 Gerrit-Change-Number: 40303 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 month, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: podman_install: tweak git commands

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40304?usp=email ) Change subject: testenv: podman_install: tweak git commands ...................................................................... testenv: podman_install: tweak git commands * Do not run them in podman: git is required to run testenv, by not running it through podman the command in the log is shorter. * Set advice.detachedHead=false for the git clone to avoid printing the "You are in 'detached HEAD' state. You can look around ..." text block that isn't useful in this context. Change-Id: I2ee26764d1471e54eff748e11ec2cce6fb662667 --- M _testenv/testenv/podman_install.py 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/_testenv/testenv/podman_install.py b/_testenv/testenv/podman_install.py index a8293ef..130085c 100644 --- a/_testenv/testenv/podman_install.py +++ b/_testenv/testenv/podman_install.py @@ -112,7 +112,7 @@ branch = "master" url = f"https://gerrit.osmocom.org/{project}" if testenv.args.binary_repo.endswith(":latest"): - ls_remote = testenv.cmd.run(["git", "ls-remote", "--tags", url], capture_output=True, text=True) + ls_remote = testenv.cmd.run(["git", "ls-remote", "--tags", url], capture_output=True, text=True, no_podman=True) tags = [] pattern = re.compile("^\d+\.\d+\.\d+$") for line in ls_remote.stdout.split("\n"): @@ -127,6 +127,8 @@ testenv.cmd.run( [ "git", + "-c", + "advice.detachedHead=false", "-C", git_dir, "clone", @@ -135,7 +137,8 @@ "--branch", branch, url, - ] + ], + no_podman=True, ) show_commit(project, git_dir_project) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40304?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2ee26764d1471e54eff748e11ec2cce6fb662667 Gerrit-Change-Number: 40304 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 month, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log