- gerrit-log - lists.osmocom.org

[XL] Change in libosmocore[master]: Introduce tests/osmo-config-merge testsuite

by osmith

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/40295?usp=email ) Change subject: Introduce tests/osmo-config-merge testsuite ...................................................................... Patch Set 4: (1 comment) File tests/osmo-config-merge/Makefile.am: https://gerrit.osmocom.org/c/libosmocore/+/40295/comment/3e85ca25_c5f03680?… : PS4, Line 25: } >'$(srcdir)/package.m4' > No idea tbh, copied it from tests/Makefile.am. Let me know if you know better about this stuff. I'd try to remove it and see if it still works -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40295?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia172d4c280f4bae1b411ad805cca02355ca7fcc9 Gerrit-Change-Number: 40295 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 May 2025 14:28:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 month, 2 weeks

1
0
0 0

[XL] Change in libosmocore[master]: Introduce tests/osmo-config-merge testsuite

by pespin

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/40295?usp=email ) Change subject: Introduce tests/osmo-config-merge testsuite ...................................................................... Patch Set 4: (4 comments) File tests/osmo-config-merge/Makefile.am: https://gerrit.osmocom.org/c/libosmocore/+/40295/comment/0c9de919_e0d9af3e?… : PS4, Line 25: } >'$(srcdir)/package.m4' > What do we need package. […] No idea tbh, copied it from tests/Makefile.am. Let me know if you know better about this stuff. https://gerrit.osmocom.org/c/libosmocore/+/40295/comment/10887003_0c96aef4?… : PS4, Line 46: [ -e /proc/cpuinfo ] && cat /proc/cpuinfo > This is already done in tests/Makefile.am, so I would remove it here. Acknowledged https://gerrit.osmocom.org/c/libosmocore/+/40295/comment/41c61360_43496d27?… : PS4, Line 47: $(SHELL) '$(TESTSUITE)' $(TESTSUITEFLAGS) ENABLE_URING=$(ENABLE_URING) ENABLE_URING_TESTS=$(ENABLE_URING_TESTS) > ```suggestion […] Acknowledged https://gerrit.osmocom.org/c/libosmocore/+/40295/comment/c125038f_544e472b?… : PS4, Line 51: $(TESTSUITEFLAGS) ENABLE_URING=$(ENABLE_URING) ENABLE_URING_TESTS=$(ENABLE_URING_TESTS) > ```suggestion […] Acknowledged -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40295?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia172d4c280f4bae1b411ad805cca02355ca7fcc9 Gerrit-Change-Number: 40295 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 May 2025 14:27:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

1 month, 2 weeks

1
0
0 0

[XL] Change in libosmocore[master]: Introduce tests/osmo-config-merge testsuite

by osmith

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/40295?usp=email ) Change subject: Introduce tests/osmo-config-merge testsuite ...................................................................... Patch Set 4: (6 comments) File tests/osmo-config-merge/Makefile.am: https://gerrit.osmocom.org/c/libosmocore/+/40295/comment/6944e778_68ec345b?… : PS4, Line 25: } >'$(srcdir)/package.m4' What do we need package.m4 for? https://gerrit.osmocom.org/c/libosmocore/+/40295/comment/09c8c254_20aeb22f?… : PS4, Line 46: [ -e /proc/cpuinfo ] && cat /proc/cpuinfo This is already done in tests/Makefile.am, so I would remove it here. https://gerrit.osmocom.org/c/libosmocore/+/40295/comment/c5a9850a_f208585d?… : PS4, Line 47: $(SHELL) '$(TESTSUITE)' $(TESTSUITEFLAGS) ENABLE_URING=$(ENABLE_URING) ENABLE_URING_TESTS=$(ENABLE_URING_TESTS) ```suggestion $(SHELL) '$(TESTSUITE)' $(TESTSUITEFLAGS) ``` https://gerrit.osmocom.org/c/libosmocore/+/40295/comment/d1a71072_698b27d1?… : PS4, Line 51: $(TESTSUITEFLAGS) ENABLE_URING=$(ENABLE_URING) ENABLE_URING_TESTS=$(ENABLE_URING_TESTS) ```suggestion $(TESTSUITEFLAGS) ``` File tests/osmo-config-merge/atlocal.in: PS4: do we need this empty file? File tests/osmo-config-merge/testA.ok: https://gerrit.osmocom.org/c/libosmocore/+/40295/comment/f755bf44_dfefc29a?… : PS4, Line 74: power-ramp step-size 8000 mdB : power-ramp step-interval 1 : phy 0 instance 0 : power-ramp step-size 2000 mdB is this correct? I would have expected that the new power-ramp step-size overwrites the previous one -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40295?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia172d4c280f4bae1b411ad805cca02355ca7fcc9 Gerrit-Change-Number: 40295 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 May 2025 14:25:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 month, 2 weeks

1
0
0 0

[XS] Change in ...osmo-epdg[master]: s2b: add logline on terminating module

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37902?usp=email ) Change subject: s2b: add logline on terminating module ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37902?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I7a3665b0a77ac86bed448a18cf224e2f6954ba73 Gerrit-Change-Number: 37902 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 15 May 2025 13:43:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month, 2 weeks

1
0
0 0

[XS] Change in ...osmo-epdg[master]: s2b: when socket opening fails, stop the S2b module

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37901?usp=email ) Change subject: s2b: when socket opening fails, stop the S2b module ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37901?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I49a6a1ec0c938aa70444c19c0b7b644f2e42f1fd Gerrit-Change-Number: 37901 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 15 May 2025 13:42:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month, 2 weeks

1
0
0 0

[S] Change in ...osmo-epdg[master]: s2b: answer echo requests

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37900?usp=email ) Change subject: s2b: answer echo requests ...................................................................... Patch Set 1: Code-Review-1 (1 comment) File src/epdg_gtpc_s2b.erl: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37900/comment/0013e146_e225… : PS1, Line 520: IEs = [#v2_recovery{restart_counter = RCnt}], This looks wrong. The RestartCounter we send has nothing to do with the one we receive. Ideally we should read it at startup (or set to 0 if unable to read it), and increment and write it back after startup finishes. For now I guess it's good enough to send a "0" or to send a timestamp? -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37900?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I3c470bd89b9811ba269b53eb400ffc21db4fba3a Gerrit-Change-Number: 37900 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 15 May 2025 13:42:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 month, 2 weeks

1
0
0 0

[XS] Change in ...osmo-epdg[master]: s2b: set correct instance values for Bearers

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37899?usp=email ) Change subject: s2b: set correct instance values for Bearers ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37899?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Ibce4a2e44a3bb0d7e1d86953a94929242d45a3dd Gerrit-Change-Number: 37899 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 15 May 2025 13:40:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month, 2 weeks

1
0
0 0

[XS] Change in ...osmo-epdg[master]: gsup: Fix rx of AuthInfoReq without IP addr val

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40297?usp=email ) Change subject: gsup: Fix rx of AuthInfoReq without IP addr val ...................................................................... gsup: Fix rx of AuthInfoReq without IP addr val The var PdpAddress was being reassigned and erlang crashed when running ttcn3-epdg-test with: """ {{badmatch,#{ipv4 => <<0,0,0,0>>}},[{gsup_server,rx_gsup,3, [{file,"/tmp/osmo-epdg/src/gsup_server.erl"},{line,308}]}, {misc,'-spawn_wait_ret/2-fun-0-',2, [{file,"/tmp/osmo-epdg/src/misc.erl"},{line,43}]}]} """ Fixes: 2d2e43c061652ae6c9fd409e9badc33d5d66e068 Change-Id: Iaa4b45a00e472a324ad98f57a54db04454935130 --- M src/gsup_server.erl 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified lynxis lazus: Looks good to me, approved diff --git a/src/gsup_server.erl b/src/gsup_server.erl index c4c28cf..256522e 100644 --- a/src/gsup_server.erl +++ b/src/gsup_server.erl @@ -296,13 +296,14 @@ case maps:find(pdp_info_list, GsupMsgRx) of {ok, [PdpInfo]} -> #{pdp_context_id := _PDPCtxId, - pdp_address := #{address := PdpAddress, + pdp_address := #{address := PdpAddressRx, pdp_type_nr := PdpTypeNr, pdp_type_org := 241}, access_point_name := Apn } = PdpInfo, - case maps:is_key(ipv4,PdpAddress) or maps:is_key(ipv6,PdpAddress) of - true -> ok; %% Address received so do nothing + case maps:is_key(ipv4,PdpAddressRx) or maps:is_key(ipv6,PdpAddressRx) of + true -> %% Address received, use it + PdpAddress = PdpAddressRx; false -> %% No address received from strongswan, use a default value PdpTypeNr = ?GTP_PDP_ADDR_TYPE_NR_IPv4, PdpAddress = #{ipv4 => <<0,0,0,0>>} -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40297?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Iaa4b45a00e472a324ad98f57a54db04454935130 Gerrit-Change-Number: 40297 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: clufn <callumfarrbennett(a)yahoo.com> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 month, 2 weeks

1
0
0 0

[XS] Change in libosmo-sigtran[master]: sccp_demo_use: Log rx N-PCSTATE.ind

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40301?usp=email ) Change subject: sccp_demo_use: Log rx N-PCSTATE.ind ...................................................................... Patch Set 1: (1 comment) File examples/sccp_test_server.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/40301/comment/a3a7a3b3_78558… : PS1, Line 76: sp_status > same here, use osmo_ss7_pointcode_print or friends Acknowledged -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40301?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I19ff96c5892af412333ae413d95416c592e87f5c Gerrit-Change-Number: 40301 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 15 May 2025 12:48:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 month, 2 weeks

1
0
0 0

[XS] Change in libosmo-sigtran[master]: sccp: Log remote PC in LOGPSCC

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40299?usp=email ) Change subject: sccp: Log remote PC in LOGPSCC ...................................................................... Patch Set 1: (1 comment) File src/sccp_scoc.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/40299/comment/56ced574_1c206… : PS1, Line 131: _LOGPSCU((scc)->user, subsys, level, "CONN(%d,rpc=%u) " fmt, (conn)->conn_id, (conn)->remote_pc, ## args) > whenever we print point codes, we should use osmo_ss7_pointcode_print() or related. Acknowledged -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40299?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ifa3670f3f0894c3334299c6c9826a17bd63dd9ae Gerrit-Change-Number: 40299 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 15 May 2025 12:48:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 month, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log