Attention is currently required from: lynxis lazus, pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40305?usp=email )
Change subject: epdg: introduce testenv support
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
> Do you mind if I take this over? I've been working on adding a testenv config to epdg as well, as me […]
(open thread)
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40305?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5063e6ef55e8918653e9634237103790f47784a2
Gerrit-Change-Number: 40305
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Fri, 16 May 2025 05:49:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Attention is currently required from: lynxis lazus, pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40305?usp=email )
Change subject: epdg: introduce testenv support
......................................................................
Patch Set 3:
(1 comment)
File epdg/epdg.sh:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40305/comment/27a0e40e_88c0… :
PS3, Line 28: pipework --wait -i ${EPDG_TUN}
instead of vendoring the pipework script, we can just do a simple loop here:
```sh
FOUND=0
for i in $(seq 1 5); do
sleep 1
if ip link ls dev "$EPDG_TUN" >/dev/null; then
FOUND=1
break
fi
done
if [ "$FOUND" = 0 ]; then
echo
echo "ERROR: osmo-epdg did not create $EPDG_TUN!"
echo
exit 1
fi
```
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40305?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5063e6ef55e8918653e9634237103790f47784a2
Gerrit-Change-Number: 40305
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Fri, 16 May 2025 05:49:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: lynxis lazus, pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40305?usp=email )
Change subject: epdg: introduce testenv support
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
Do you mind if I take this over? I've been working on adding a testenv config to epdg as well, as mentioned in the last team meeting
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40305?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5063e6ef55e8918653e9634237103790f47784a2
Gerrit-Change-Number: 40305
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Fri, 16 May 2025 05:35:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40302?usp=email )
Change subject: sccp_scoc: Match local conn by src_ref, not dest_ref
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40302?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I0090f4088de407b476cfb0a6d652b384af714306
Gerrit-Change-Number: 40302
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 16 May 2025 05:30:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40306?usp=email )
Change subject: sccp: sccp_addr_to_str_buf(): Use osmo_ss7_pointcode_print_buf()
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40306?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ib54984e755dca16d5be4d3d5dac82faa38e83c79
Gerrit-Change-Number: 40306
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 16 May 2025 05:29:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes