Attention is currently required from: fixeria, lynxis lazus.

Hello Jenkins Builder, lynxis lazus,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-sgsn/+/43953?usp=email

to look at the new patch set (#2).

The following approvals got outdated and were removed: Verified+1 by Jenkins Builder

Change subject: gprs_sndcp_xid: fix length check in gprs_sndcp_compile_xid ......................................................................

gprs_sndcp_xid: fix length check in gprs_sndcp_compile_xid

The function gprs_sndcp_compile_xid gets an output buffer (dst) and a length (dst_maxlen), but unfortunately, the length is not checked before data is written to the output buffer (tlv_put).

The problem was reported by osmocom.org user tsato (see related ticket)

Related: OS#7095 Change-Id: I977946a036f96d4dee2656bef048e2618198db40 --- M src/sgsn/gprs_sndcp_xid.c M tests/sndcp_xid/sndcp_xid_test.c M tests/sndcp_xid/sndcp_xid_test.ok 3 files changed, 41 insertions(+), 2 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/53/43953/2