Attention is currently required from: fixeria, lynxis lazus.

dexter uploaded patch set #2 to this change.

View Change

The following approvals got outdated and were removed: Verified+1 by Jenkins Builder

gprs_sndcp_xid: fix length check in gprs_sndcp_compile_xid

The function gprs_sndcp_compile_xid gets an output buffer (dst) and
a length (dst_maxlen), but unfortunately, the length is not checked
before data is written to the output buffer (tlv_put).

The problem was reported by osmocom.org user tsato
(see related ticket)

Related: OS#7095
Change-Id: I977946a036f96d4dee2656bef048e2618198db40
---
M src/sgsn/gprs_sndcp_xid.c
M tests/sndcp_xid/sndcp_xid_test.c
M tests/sndcp_xid/sndcp_xid_test.ok
3 files changed, 41 insertions(+), 2 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/53/43953/2

To view, visit change 43953. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I977946a036f96d4dee2656bef048e2618198db40
Gerrit-Change-Number: 43953
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu>
Gerrit-CC: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis@fe80.eu>