Attention is currently required from: fixeria, laforge, pespin.
Hello Jenkins Builder, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-trx/+/43606?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by laforge, Code-Review+1 by pespin, Verified+1 by Jenkins Builder
Change subject: proxy: implement RF path simulation
......................................................................
proxy: implement RF path simulation
Compute real ToA/RSSI/CI values for forwarded bursts instead of the
fixed placeholder constants in burst_fwd.c. Each channel gets its own
struct path_sim_state, tracking Tx power/attenuation, Timing Advance,
reported ToA/RSSI/CI, and burst-dropping parameters. RSSI defaults to
a path-loss formula (Tx power - burst attenuation - fixed path loss)
unless overridden via FAKE_RSSI.
Add the CTRL commands needed to drive this: SETTA, SETPOWER,
NOMTXPOWER, RFMUTE, and the FAKE_TOA/FAKE_RSSI/FAKE_CI/FAKE_DROP
simulation helpers. RFMUTE and burst dropping (FAKE_DROP) turn a
forwarded burst into a NOPE.ind, matching the existing NOPE.req
handling path.
Change-Id: Iefa51d6b0e0bba1f12bdbcdf576528e7d3588b8f
Related: OS#6672
---
M proxy/Makefile.am
A proxy/include/osmocom/proxy/path_sim.h
M proxy/include/osmocom/proxy/trx.h
M proxy/src/Makefile.am
M proxy/src/burst_fwd.c
M proxy/src/ctrl_cmd.c
A proxy/src/path_sim.c
M proxy/src/trx.c
8 files changed, 368 insertions(+), 13 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/06/43606/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43606?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Iefa51d6b0e0bba1f12bdbcdf576528e7d3588b8f
Gerrit-Change-Number: 43606
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43112?usp=email )
Change subject: libosmo-trx/ep: flush pending TRXC messages on endpoint teardown
......................................................................
Patch Set 6:
(3 comments)
File libosmo-trx/src/trx_ep.c:
https://gerrit.osmocom.org/c/osmo-trx/+/43112/comment/4fbd68ea_20b15c1c?usp… :
PS6, Line 310: LOGEPCH(flush->ep, flush->chan_num, LOGL_DEBUG,
> This should be inside the if above, since no flush can complete if res <=0.
Done
https://gerrit.osmocom.org/c/osmo-trx/+/43112/comment/de008672_a5377814?usp… :
PS6, Line 348: flush = talloc(iofd, struct trx_ep_ctrl_flush);
> I really fail to see why do we need a separate object to handle the flushing, but ok...
Because the caller may call `osmo_trx_ep_free()` right after `osmo_trx_ep_close()`. I could do it the other way around: postpone free()ing the whole `struct osmo_trx_ep` until all of its CTRL iofds are done flushing - does this sound like a better approach?
https://gerrit.osmocom.org/c/osmo-trx/+/43112/comment/12d36029_16b6cf49?usp… :
PS6, Line 581: return !llist_empty(&ep->closing_flushes);
> I really wonder why do you need this list of closing flushes. […]
The list exists to let `osmo_trx_ep_free()` find outstanding flushes and sever their back-pointer, so that in `trx_ep_ctrl_flush_write_cb()` we don't access memory that was free()d.
P.S. I am really tired of re-working this patch over and over, and I really wish flushing was implemented in libosmocore. Having to implement this outside of libosmocore feels like a kludge.
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43112?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I69e6a3bcf49afc3cfca4a72afdf459625cb91e56
Gerrit-Change-Number: 43112
Gerrit-PatchSet: 6
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 13 Sep 2026 01:06:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43111?usp=email )
Change subject: libosmo-trx/ep: add TRX endpoint module
......................................................................
Patch Set 7:
(1 comment)
File libosmo-trx/src/trx_ep.c:
https://gerrit.osmocom.org/c/osmo-trx/+/43111/comment/4aef7c30_7d9b17b6?usp… :
PS6, Line 294: /* Open a channel's ctrl+data sockets. \returns 0 on success; -EIO on error */
> Not sure if these in the same line are on purpose.
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43111?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I767fa43a9ca88be40c385f6dcb9de22891a6afc3
Gerrit-Change-Number: 43111
Gerrit-PatchSet: 7
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 12 Sep 2026 06:48:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43110?usp=email )
Change subject: libosmo-trx/client: make public API operate on parsed messages
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43110?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Idf53513d06be2337383601494b225b5722c93129
Gerrit-Change-Number: 43110
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 12 Sep 2026 06:47:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43108?usp=email )
Change subject: libosmo-trx/client: add TRXC client (command queue) API
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
File libosmo-trx/src/trxc_client.c:
https://gerrit.osmocom.org/c/osmo-trx/+/43108/comment/0a010ac1_ce98d922?usp… :
PS3, Line 474: sf->cb(client, 0, sf->cb_data);
> Many things can go wrong if the callback free()s the client - this is currently not supported and ca […]
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43108?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I817e394f74a10e3adae4a0b58342c82acdf0794e
Gerrit-Change-Number: 43108
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 12 Sep 2026 06:47:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>