September 2026 - gerrit-log - lists.osmocom.org

[S] Change in osmo-msc[master]: SMS: fix bogus error for SMS over SG from MME
by laforge 11 Sep '26

11 Sep '26

Attention is currently required from: dexter, fixeria, osmith, pespin. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-msc/+/43625?usp=email ) Change subject: SMS: fix bogus error for SMS over SG from MME ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/43625?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Id3f9c6c20e6d4d4275ca16fb17b0822a7d70e0a0 Gerrit-Change-Number: 43625 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 11 Sep 2026 13:04:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-msc[master]: SMS: fix bogus error for SMS over SG from MME
by osmith 11 Sep '26

11 Sep '26

Attention is currently required from: dexter, fixeria, pespin. Hello Jenkins Builder, dexter, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/43625?usp=email to look at the new patch set (#2). Change subject: SMS: fix bogus error for SMS over SG from MME ...................................................................... SMS: fix bogus error for SMS over SG from MME OsmoMSC accepts SMS over the SG interface from the MME and can successfully send them. Fix that the following error gets logged along with every SMS from SG: MO SMS without prior CM Service Request (gsm_04_11.c:1127) Fixes: OS#6207 Change-Id: Id3f9c6c20e6d4d4275ca16fb17b0822a7d70e0a0 --- M src/libmsc/gsm_04_11.c 1 file changed, 8 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/25/43625/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/43625?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Id3f9c6c20e6d4d4275ca16fb17b0822a7d70e0a0 Gerrit-Change-Number: 43625 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in osmo-msc[master]: SMS: fix bogus error for SMS over SG from MME
by osmith 11 Sep '26

11 Sep '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/43625?usp=email ) Change subject: SMS: fix bogus error for SMS over SG from MME ...................................................................... SMS: fix bogus error for SMS over SG from MME OsmoMSC accepts SMS over the SG interface from the MME and can successfully send it. Fix that the following error gets logged along with every SMS from SG: MO SMS without prior CM Service Request (gsm_04_11.c:1127) Fixes: OS#6207 Change-Id: Id3f9c6c20e6d4d4275ca16fb17b0822a7d70e0a0 --- M src/libmsc/gsm_04_11.c 1 file changed, 8 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/25/43625/1 diff --git a/src/libmsc/gsm_04_11.c b/src/libmsc/gsm_04_11.c index 530ef17..fb04b45 100644 --- a/src/libmsc/gsm_04_11.c +++ b/src/libmsc/gsm_04_11.c @@ -1123,10 +1123,15 @@ osmo_fsm_inst_dispatch(msc_a->c.fi, MSC_A_EV_TRANSACTION_ACCEPTED, trans); if (mo) { - if (!osmo_use_count_by(&msc_a->use_count, MSC_A_USE_CM_SERVICE_SMS)) - LOG_TRANS(trans, LOGL_ERROR, "MO SMS without prior CM Service Request\n"); - else + if (!osmo_use_count_by(&msc_a->use_count, MSC_A_USE_CM_SERVICE_SMS)) { + if (vsub->attached_via_ran == OSMO_RAT_EUTRAN_SGS) { + /* SMS over the SG interface from MME (OS#6207) */ + } else { + LOG_TRANS(trans, LOGL_ERROR, "MO SMS without prior CM Service Request\n"); + } + } else { msc_a_put(msc_a, MSC_A_USE_CM_SERVICE_SMS); + } } /* If we're re-using the existing LU connection, drop the LU token. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/43625?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Id3f9c6c20e6d4d4275ca16fb17b0822a7d70e0a0 Gerrit-Change-Number: 43625 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in onomondo-ipa[master]: Prevent compiler warning after calling realloc()
by laforge 11 Sep '26

11 Sep '26

Attention is currently required from: dexter, jolly. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43624?usp=email ) Change subject: Prevent compiler warning after calling realloc() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43624?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I97360285ec5077d668dd23a158475496c9c47890 Gerrit-Change-Number: 43624 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 11 Sep 2026 11:04:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in onomondo-ipa[master]: Prevent compiler warning after calling realloc()
by jolly 11 Sep '26

11 Sep '26

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43624?usp=email ) Change subject: Prevent compiler warning after calling realloc() ...................................................................... Prevent compiler warning after calling realloc() After calling realloc(), the old pointer may get freed, so it must not be used afterwards. If memory leak debugging is enabled (see -DMEM_EMIT_DEBUG=ON), the old pointer value is printed but there is no access to any memory location. Prevent the compiler warning by making a copy of the old pointer and call realloc() with that copy. Print the value of the original pointer. Related: SYS#8199 Change-Id: I97360285ec5077d668dd23a158475496c9c47890 --- M include/onomondo/ipa/mem.h 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/24/43624/1 diff --git a/include/onomondo/ipa/mem.h b/include/onomondo/ipa/mem.h index 88349b1..cc9d43e 100644 --- a/include/onomondo/ipa/mem.h +++ b/include/onomondo/ipa/mem.h @@ -47,8 +47,9 @@ #ifdef MEM_EMIT_DEBUG #define IPA_REALLOC(obj, n) ({ \ void *___ptr; \ + void *___old_ptr = (obj); \ ___mem_counter -= malloc_usable_size(obj); \ - ___ptr = realloc(obj, n); \ + ___ptr = realloc(___old_ptr, n); \ ___mem_counter += malloc_usable_size(___ptr); \ if (___mem_counter > ___mem_peak) ___mem_peak = ___mem_counter; \ printf("====> %p=realloc(%p, %ld): %li bytes total, %li bytes peak\n", \ -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43624?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I97360285ec5077d668dd23a158475496c9c47890 Gerrit-Change-Number: 43624 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu>

1 0

[M] Change in pysim[master]: transport/smpp2sim: TERMINAL RESPONSE for proactive SEND SHORT MESSAGE
by dexter 11 Sep '26

11 Sep '26

Attention is currently required from: Hoernchen, daniel. dexter has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/43543?usp=email ) Change subject: transport/smpp2sim: TERMINAL RESPONSE for proactive SEND SHORT MESSAGE ...................................................................... Patch Set 2: (2 comments) File pySim/transport/__init__.py: https://gerrit.osmocom.org/c/pysim/+/43543/comment/d907b55f_b595a720?usp=em… : PS2, Line 72: def prepare_response(self, pcmd: ProactiveCommand, general_result: str = 'performed_successfully'): I think putting a spec ref (ETSI TS 102 223, section 6.8) would be very helpful here. File tests/unittests/test_transport.py: https://gerrit.osmocom.org/c/pysim/+/43543/comment/d316c275_9835b102?usp=em… : PS2, Line 44: self.assertEqual(b2h(til[1].to_tlv()), '82028381') correct me if I am wrong, but as far as I understand we should also see encoded strings for CommandDetails and Result here as well. If so, we should assert them like in test_on_decoded_command. (They are mandatory IEs, so they should be there, right?) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43543?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib96ce81c4ff093b8a6fc715f79617e95a2dd8433 Gerrit-Change-Number: 43543 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 11 Sep 2026 10:33:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in onomondo-eim[master]: SGP32Definitions: add JSON specific variant of SGP32-CancelSessionRes...
by jolly 11 Sep '26

11 Sep '26

Attention is currently required from: dexter. jolly has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43177?usp=email ) Change subject: SGP32Definitions: add JSON specific variant of SGP32-CancelSessionResponse ...................................................................... Patch Set 15: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43177?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: I566571778d2433bd87a46276e81d9d526ae97325 Gerrit-Change-Number: 43177 Gerrit-PatchSet: 15 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 11 Sep 2026 09:35:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in onomondo-eim[master]: SGP32Definitions: invert asn1ct tag workaround
by jolly 11 Sep '26

11 Sep '26

Attention is currently required from: dexter, laforge. jolly has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43176?usp=email ) Change subject: SGP32Definitions: invert asn1ct tag workaround ...................................................................... Patch Set 15: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43176?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: I43625be897f7a1cdbf0fa6b71ee651df993f8584 Gerrit-Change-Number: 43176 Gerrit-PatchSet: 15 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 11 Sep 2026 09:34:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in onomondo-eim[master]: SGP32Definitions: invert asn1ct tag workaround
by dexter 11 Sep '26

11 Sep '26

Attention is currently required from: jolly, laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43176?usp=email ) Change subject: SGP32Definitions: invert asn1ct tag workaround ...................................................................... Patch Set 15: (1 comment) Patchset: PS14: > Did you ever bring up this problem with the erlang developers, e.g. […] Not yet. I have created a ticket (SYS#8237) now so that we can go through this more systematically. I also think that there is more research required. -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43176?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: I43625be897f7a1cdbf0fa6b71ee651df993f8584 Gerrit-Change-Number: 43176 Gerrit-PatchSet: 15 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 11 Sep 2026 09:21:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in onomondo-eim[master]: SGP32Definitions: revert workaround for SGP32-RetrieveNotificationsLi...
by dexter 11 Sep '26

11 Sep '26

Attention is currently required from: dexter, jolly, laforge. Hello Jenkins Builder, jolly, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/onomondo-eim/+/43618?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by jolly, Code-Review+1 by laforge Change subject: SGP32Definitions: revert workaround for SGP32-RetrieveNotificationsListResponse ...................................................................... SGP32Definitions: revert workaround for SGP32-RetrieveNotificationsListResponse The SGP32-RetrieveNotificationsListResponse only plays a role on ES10b level (see also SGP.32, section 5.9.11). This means that this ASN.1 type is irrelevant on eIM level. Let's revert the workaround we did since it does not have any effect. Change-Id: I5a1d442acb972cce8fa5d09e84b5121d0a5124a6 Related: SYS#8100 --- M asn1/SGP32Definitions.asn1 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/18/43618/2 -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43618?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: I5a1d442acb972cce8fa5d09e84b5121d0a5124a6 Gerrit-Change-Number: 43618 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log September 2026