Jenkins Builder has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43652?usp=email )
Change subject: Add index to ipa_es10b_get_eim_cfg_data_filter ......................................................................
Patch Set 1:
(4 comments)
File src/ipa/libipa/es10b_get_eim_cfg_data.c:
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-ipa/+/43652/comment/a5428295_73ca952a?... : PS1, Line 301: return EINVAL; return of an errno should typically be negative (ie: return -EINVAL)
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-ipa/+/43652/comment/4912d5d1_3afe70c5?... : PS1, Line 306: return EINVAL; return of an errno should typically be negative (ie: return -EINVAL)
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-ipa/+/43652/comment/d91ec134_0328a276?... : PS1, Line 312: if (index >= res->res->eimConfigurationDataList.list.count) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-ipa/+/43652/comment/e7c0d4f4_c408849f?... : PS1, Line 329: return EINVAL; return of an errno should typically be negative (ie: return -EINVAL)
-
Jenkins Builder