Attention is currently required from: jolly.

dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43655?usp=email )

Change subject: IPAd: Make existing tests work with multi eIM support ......................................................................

Patch Set 1:

(3 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43655/comment/aa148ea2_62a73... : PS1, Line 9: The test cases terminate differently. At the end, the IPAd will request I have difficulties to understand what differently means here. To my understanding the behavior of the IPAd is changed consistently, meaning that it now always requests the eIM configuration.

Maybe write: "The behavior of the IPAd implementation has been changed." Now at the end of a poll cycle, the IPAd will ..."

File ipad/IPAd_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43655/comment/74983328_fa46e... : PS1, Line 804: var EsipaMessageFromEimToIpa esipa_res; I think it would be cleaner to remove those two unused variables in a separate patch.

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43655/comment/d1846522_3e613... : PS1, Line 462: private function f_terminate_poll_cycle() runs on IPAd_ConnHdlr { I wonder if we can optimize this a bit and remove some code dup. We may add a parameter "eimPackageError := 1" to the parameter list of this function.

Then we would use ts_getEimPackageResponse_eimPkgErr(eimPackageError) as template for f_esipa_transceive

This would not change the behavior of this function, but we then can call it from f_TC_get_eim_pkg_req_rej like so:

f_terminate_poll_cycle(eimPackageError := 127)

replacing the call to f_esipa_transceive and the call to f_vpcd_transceive which is introduced by this patch.