Attention is currently required from: jolly.

View Change

3 comments:

• Commit Message:

  • Patch Set #1, Line 9: The test cases terminate differently. At the end, the IPAd will request

    I have difficulties to understand what differently means here. To my understanding the behavior of the IPAd is changed consistently, meaning that it now always requests the eIM configuration.

    Maybe write: "The behavior of the IPAd implementation has been changed." Now at the end of a poll cycle, the IPAd will ..."

• File ipad/IPAd_Tests.ttcn:

  • Patch Set #1, Line 804: var EsipaMessageFromEimToIpa esipa_res;

    I think it would be cleaner to remove those two unused variables in a separate patch.

  • Patch Set #1, Line 462: private function f_terminate_poll_cycle() runs on IPAd_ConnHdlr {

    I wonder if we can optimize this a bit and remove some code dup. We may add a parameter "eimPackageError := 1" to the parameter list of this function.

    Then we would use ts_getEimPackageResponse_eimPkgErr(eimPackageError) as template for f_esipa_transceive

    This would not change the behavior of this function, but we then can call it from f_TC_get_eim_pkg_req_rej like so:

    f_terminate_poll_cycle(eimPackageError := 127)

    replacing the call to f_esipa_transceive and the call to f_vpcd_transceive which is introduced by this patch.

To view, visit change 43655. To unsubscribe, or for help writing mail filters, visit settings.